« Proposed change to add_linktree()
Users Online Today
Post moderation »

live627

  • Talking Head
  • Should five per cent appear too small / Be thankful I don't take it all / 'Cause I'm the taxman, yeah I'm the taxman
  • Posts: 1,412
Re: Users Online Today
« Reply #15 on June 15th, 2012, 07:10 PM »
Oh, and it doesn't show in Wine (hey, where's the quick edit button and the action menu? Now I can only quote myself, odd...)

Nao

  • With a Box
  • If you say so.....
  • Posts: 12,903
Re: Users Online Today
« Reply #16 on June 15th, 2012, 07:46 PM »
Quote from live627 on June 15th, 2012, 06:41 PM
Shows for me just fine, error notwithstanding. Mind if I attempt to commit my change?
Hey... I *was* working on that!! :lol:

Now I'll have to compare the changes... :^^;:
...« I say wedge wedge (in the butt) »
 « Everyone knows rock attained perfection in 1974. It's a scientific fact. » (Homer Simpson)

Arantor

  • With a Box
  • As long as the planets are turning, as long as the stars are burning, as long as your dreams are coming true...
  • Posts: 13,621
Re: Users Online Today
« Reply #17 on June 15th, 2012, 07:49 PM »
Oh crap something else I got wrong :lol:
  When we unite against a common enemy that attacks our ethos, it nurtures group solidarity. Trolls are sensational, yes, but we keep everyone honest.

Nao

  • With a Box
  • If you say so.....
  • Posts: 12,903
Re: Users Online Today
« Reply #18 on June 15th, 2012, 08:00 PM »
Well, up until today I'd never touched the plugin code anyway... ;)

I made a couple more fixes, but your JS code is complicated...
It's not like I can easily reuse weUrl() (which in addition doesn't support anchors...), and it doesn't support index.php-free URLs like here.

I also moved the code to the sidebar, isn't that what your description mentions...?
And added language files.
...« I say wedge wedge (in the butt) »
 « Everyone knows rock attained perfection in 1974. It's a scientific fact. » (Homer Simpson)

Arantor

  • With a Box
  • As long as the planets are turning, as long as the stars are burning, as long as your dreams are coming true...
  • Posts: 13,621
Re: Users Online Today
« Reply #19 on June 15th, 2012, 08:02 PM »
I honestly don't remember. It was made a long time ago and even though I gave everyone access I half thought no-one would ever look, heh.
  When we unite against a common enemy that attacks our ethos, it nurtures group solidarity. Trolls are sensational, yes, but we keep everyone honest.

Nao

  • With a Box
  • If you say so.....
  • Posts: 12,903
Re: Users Online Today
« Reply #20 on June 15th, 2012, 08:13 PM »
Well... I'm in :P
...« I say wedge wedge (in the butt) »
 « Everyone knows rock attained perfection in 1974. It's a scientific fact. » (Homer Simpson)

Nao

  • With a Box
  • If you say so.....
  • Posts: 12,903
Re: Users Online Today
« Reply #21 on June 15th, 2012, 08:16 PM »
rev 36
(3 files +2, 3kb)

! Fixed language files to say "including X hidden" instead of "plus X hidden", which was misleading... (OnlineToday.language.php)

! Fixed theme selector. Added language files. Yeah, I named them after skins... We're not going to call it a theme selector, are we...? (ThemeSelector.php, SkinSelector.language.php)
...« I say wedge wedge (in the butt) »
 « Everyone knows rock attained perfection in 1974. It's a scientific fact. » (Homer Simpson)

Arantor

  • With a Box
  • As long as the planets are turning, as long as the stars are burning, as long as your dreams are coming true...
  • Posts: 13,621
Re: Users Online Today
« Reply #22 on June 15th, 2012, 08:23 PM »
Quote
which was misleading...
Is it? I thought they were counted separately? They should have been...
Quote
We're not going to call it a theme selector, are we...?
Some of the code is derived from a theme selector I wrote for SMF, the name just sort of stuck really.
  When we unite against a common enemy that attacks our ethos, it nurtures group solidarity. Trolls are sensational, yes, but we keep everyone honest.

Nao

  • With a Box
  • If you say so.....
  • Posts: 12,903
Re: Users Online Today
« Reply #23 on June 15th, 2012, 08:34 PM »
Ah, yes, now we have a problem... It's "XX including X" for moderators, and "XX plus X" for visitors...
I think it'd be faster to just have a separate counter for all users, instead of a count().
...« I say wedge wedge (in the butt) »
 « Everyone knows rock attained perfection in 1974. It's a scientific fact. » (Homer Simpson)

Arantor

  • With a Box
  • As long as the planets are turning, as long as the stars are burning, as long as your dreams are coming true...
  • Posts: 13,621
Re: Users Online Today
« Reply #24 on June 15th, 2012, 08:40 PM »
I seem to recall that's why I kept it separate (that's certainly why SMF keeps it separate)
  When we unite against a common enemy that attacks our ethos, it nurtures group solidarity. Trolls are sensational, yes, but we keep everyone honest.

Nao

  • With a Box
  • If you say so.....
  • Posts: 12,903
Re: Users Online Today
« Reply #25 on June 15th, 2012, 09:41 PM »
Except it's not separate ;)
...« I say wedge wedge (in the butt) »
 « Everyone knows rock attained perfection in 1974. It's a scientific fact. » (Homer Simpson)

Arantor

  • With a Box
  • As long as the planets are turning, as long as the stars are burning, as long as your dreams are coming true...
  • Posts: 13,621
Re: Users Online Today
« Reply #26 on June 15th, 2012, 09:50 PM »
Is it not? It should be...

Oh, I don't remember, it was months ago :P
  When we unite against a common enemy that attacks our ethos, it nurtures group solidarity. Trolls are sensational, yes, but we keep everyone honest.

Nao

  • With a Box
  • If you say so.....
  • Posts: 12,903
Re: Users Online Today
« Reply #27 on June 15th, 2012, 10:11 PM »
You can fix it yourself if you want. I'm not on my computer for now ;)
...« I say wedge wedge (in the butt) »
 « Everyone knows rock attained perfection in 1974. It's a scientific fact. » (Homer Simpson)
« Proposed change to add_linktree()
Post moderation »