Aaron

  • Posts: 356
Re: Brave new world
« Reply #15, on March 16th, 2012, 01:33 PM »
Well, congratulations are in order, I guess! Well done on this milestone.

Were all thoughts imported, by the way? I'm seeing a lot less of them than yesterday.
"The entire British Empire was built on cups of tea … and if you think I'm going to war without one, mate, you're mistaken."

Hey Arnold!

  • Emperador del Universo
  • Wedge spanish, when? where?
  • Posts: 20
Re: Brave new world
« Reply #16, on March 16th, 2012, 01:36 PM »
Very nice, Wedge is a good boy :icon_mrgreen:

Congratulatons and great work, to keep having fun :icon_mrgreen:

Asgard

  • So Many Searches, Why Have So Many Searches, One Search Is Enough
  • Posts: 56
Re: Brave new world
« Reply #17, on March 16th, 2012, 01:42 PM »
This is looking great guys, so happy to see it up and running!

I love it and can't wait to be able to replace my own forum with it ^_^

Since you said we could post bugs here, I did notice something when I went to the link accidentally put on Facebook. This is a minor thing, but still stood out to me since it broke the flow. On that page someone had a url as their thought and since url's tend to be long and seen as unbroken text or just one word, it had actually broken out of the sidebar and was creeping into the post section of the board. I've attached a screenshot for your convenience and clarification. Browser was Safari 5.1.4 running on OSX 10.7

Not sure how I'd tackle fixing that, perhaps nothing at all but I can see how that could be purposely abused.

📎 Screen Shot 2012-03-16 at 8.42.56 AM.JPG - 12.85 kB, 242x57, viewed 926 times.


Aaron

  • Posts: 356
Re: Brave new world
« Reply #18, on March 16th, 2012, 01:50 PM »
By the way, is it just me, or is the initial wave of smileys on the post screen a bit excessive? :P The amount of smileys was much smaller before the conversion.

Pandos

  • Living on the edge of Wedge
  • Posts: 635
Re: Brave new world
« Reply #19, on March 16th, 2012, 01:52 PM »
Congratulations! Great Work!
Cant't wait to change from SMF to wedge.

By the way...
On my Netbook with a resolution of 1024x600 the sidebar disappears and it is not scrollable. It comes back by changing the resolution of my Browser to 90%.

Regards

Sven
# dpkg-reconfigure brain
error: brain is not installed or configured

Nao

  • Dadman with a boy
  • Posts: 16,082
Re: Brave new world
« Reply #20, on March 16th, 2012, 02:14 PM »
There are plenty of bugs that never showed up before and are apparent now. This is I why so adamant in using Wedge here. Some bugs are related to importer bugs. Others just show up in my log because of Google indexing pages I never visit. I will catch them all.

Interestingly, Pete's decision to open Quick reply by default brought me a couple of bugs. Including the fact that it's saving empty drafts without me doing anything. Fun one...

The smiley list is huge. I think the importer didn't care to record smiley positions - ie popup or not.

Re: Brave new world
« Reply #21, on March 16th, 2012, 02:23 PM »
Congratulations with this milestone.
It's looking good, fresh, yet familiar.


Hmm.
Post reply is terribly slow in response. Typing text , but also tooltips come on slowly (from transparent to visible in 3, 4 steps).
Even the animated smilies are slow.

Norodo

  • Oh you Baidu, so randumb. (60 sites being indexed at once? Jeez)
  • Posts: 469
Re: Brave new world
« Reply #22, on March 16th, 2012, 02:47 PM »
Looks great.

I second the thing about there being a wee bit too many smilies though.

 :stretcher: :ph34r: :vertag: :evil2: :shift: :rougit: :crash: :biggrin: :sweatdrop: :gathering: :crying: :mdr3: :___unsure:

Dr. Deejay

  • Happy new year all!
  • Posts: 118
Re: Brave new world
« Reply #23, on March 16th, 2012, 02:57 PM »
WOW! :D Wedge is really beautiful and it's great to see it in action :D Good job all :)

Nao

  • Dadman with a boy
  • Posts: 16,082
Re: Brave new world
« Reply #24, on March 16th, 2012, 03:02 PM »Last edited on March 21st, 2012, 02:34 PM
Okay, so...
Trying to enumate bugs for me and Pete to fix. (If any Consultant could chip in, too...)

- Post reply isn't slow for me, but I noticed on my iPhone that it doesn't even respond except when I tap 'Switch to full editor'. I'll have to try again... What browser/device are you using, Johnny?

- Full smiley set: this was definitely an importer bug. What I did to fix it was: copy the old table to a new name, rename the Wedge smiley table to a dummy name, and rename the new table to the Wedge smiley table. It started working again immediately. Eh. FIXED

- This one is for Pete... I'm getting tons of errors on $context['open_mod_reports']. Most notably, Googlebot goes through these. I added a safety precaution in Subs.php to get rid of the error, but it should be fixed. SEMI-FIXED

- Aeva Media data isn't imported, but its settings are (at least partly). I didn't consider that when running the import. As a quick fix, I disabled the media gallery (which isn't used a lot on Wedge.org anyway), and will restore it later (hopefully by next week.) All files and tables from the old version are still safe. (The old website, though, no longer works because much of its code assumed that it was at http://wedge.org, and I can't bother to fix it for now. Its only point as for now is comparing features with Wedge.)

- Apparently, not all thoughts are accessible to everyone. They are, to me, but I'm the admin so Wedge bypasses many privacy tests... Will need to fix personally.

- Long strings that break thoughts in userbox: just a question... How did the old Wedge.org deal with that? I don't seem to remember. Obviously it'll have to go through a preparsecode() call, which will allow us to break the URL, but OTOH it will add a link and I'm not sure I want that... Hmm, perhaps I should simply break down the URL without linking it. I have a function in Class-String that does that nicely in UTF8. FIXED

- ".errorbox ul" gets its bottom margin reset to 0, but the top margin is left as is. Should either fix that (at the risk of breaking some other layout), or better, use a p tag instead of ul whenever we can in error boxes. Well, at least if we know there's only one error to show...

:edit:

- Who's Online action is recorded as "Posting on (topic)" even when just viewing it. I'd recommend that Quick Reply doesn't mark this as Posting, except if a draft is saved. FIXED?

:edit:

- With PMs as Conversation, the first PMs are shown first. Is this a conscious choice from you, Pete? I can't remember...

:edit:

- postbg is a complicated beast... Some pages that display posts outside of topic pages will show them to overflow horizontally. This is because they're getting display:table treatment when the code doesn't consider them as tables. I'll try to fix this ASAP. SEMI-FIXED

Will edit as I find more bugs.

Powerbob

  • Posts: 151
Re: Brave new world
« Reply #25, on March 16th, 2012, 03:47 PM »
congratulations. Well done on this milestone. :eheh: :eheh: :cool: :cool:

Arantor

  • As powerful as possible, as complex as necessary.
  • Posts: 14,278
Re: Brave new world
« Reply #26, on March 16th, 2012, 06:42 PM »
Just quickly from me while I'm not on desktop...

* Oldest PM first is the default but I think newest first should be default.

* It works on iPad as expected however your signature appears misaligned, overflowing out of the container. iPad 1 does seem a touch sluggish though.

* Saving drafts automatically should trigger as "posting..." in Who's Online, however it should only be triggered when something is actually being typed. Needs more testing.
When we unite against a common enemy that attacks our ethos, it nurtures group solidarity. Trolls are sensational, yes, but we keep everyone honest. | Game Memorial

TE

  • Posts: 286
Re: Brave new world
« Reply #27, on March 16th, 2012, 07:18 PM »
Quote from Nao on March 16th, 2012, 02:14 PM
Some bugs are related to importer bugs.
grrr, the importer is alpha, too  and Wedge.org was a heavily modified SMF version... ;)

Congratualations, great to see Wedge in action :)
Thorsten "TE" Eurich - Former SMF Developer & Converters Guru

Nao

  • Dadman with a boy
  • Posts: 16,082
Re: Brave new world
« Reply #28, on March 16th, 2012, 07:19 PM »
Quote from Arantor on March 16th, 2012, 06:42 PM
Just quickly from me while I'm not on desktop...

* Oldest PM first is the default but I think newest first should be default.
Is this the default in SMF as well...?
I thought we'd changed the SMF default. But it's old. Something we did back in 2010...
Quote
* It works on iPad as expected however your signature appears misaligned, overflowing out of the container.
That's because I first right-align the frog, then I left align the rest. At low resolution, the frog will show up first, followed by the rest. Or am I mistaken about your description?
Quote
iPad 1 does seem a touch sluggish though.
What is it with the sluggishness? (Is that a real word?)
I mean, I did plenty of testing on my iPod and it always worked fine... Even posting stuff...
Heck, if anything, Wedge should be faster than SMF in all areas.

But there still are problems with quick reply.
- iPod 4.2: clicking inside the textarea to start replying -- the screen enlarges, keyboard shows up, and tapping the keys doesn't do anything... There's no blinking cursor, even. To show it, I have to click OK to dismiss the keyboard, then click the textarea again. Then it works. I never noticed that before... Dunno what causes it.
- Sometimes a draft will be saved even if you don't interact with the textarea as well. Reproduced twice in iPod (not always), didn't notice in Opera though.
- A bit annoying -- the Quote button when quick reply is on... It copies the post to the bottom. I'm not used to that. It'd be okay if the textarea expanded automatically to make space for long posts though...

Yeah I know, I can always set QR to Collapsed by default. I just like playing with the default values. Making sure they're the best overall choice.

Okay, I'm still having an issue with Googlebot being kicked out from the site... I think it's probably the more important bug we have. From the error log, it returns an error 403 with error message 'no_board' (Board doesn't exist) whatever page it visits. MessageIndex, Display, etc...
Thing is, it only does that for Googlebot, not Googlebot Mobile.
I STRONGLY suspect this is a problem with your Bad Behavio(u)r implementation. Can you remind me if we can disable it...? And if yes, where?
Re: Brave new world
« Reply #29, on March 16th, 2012, 07:34 PM »
Quote from TE on March 16th, 2012, 07:18 PM
grrr, the importer is alpha, too  and Wedge.org was a heavily modified SMF version... ;)
I'm just sayin'. Your importer is priceless (otherwise I'd have rewritten it heavily, considering I have SVN access :P), but it's definitely not ready for prime time. For instance, I experienced another 'duplicate key' problem with the member table at one point. It happened once, then the second time it worked. I had to restart the importing several times though. Once for the member table, and several times over another 'duplicate key' in the attachment table. I looked into the database and noticed that one of the only differences with other attachments, was that the message ID was relatively ancient compared to the other close attachment IDs. Which was surprising because it was posted at the same time as the original message... Anyway, I decided to simply remove the attachment (I edited the post to apologize for the issue, but it was not an important attachment anyway), and restarted the process. This time, it worked.

However, about 10 attachments (out of ~875) weren't imported. I'm talking about the database entries. Perhaps your importer tests against attachment errors and removes them in case there are any? Anyway, now here's how the attachment folder is structured: it's a serialized array with three folder names, attachments, and two sub-folders that are actually empty. I guess they'll be used once Wedge reaches a certain number of files in the folder? It already takes me over 2 minutes just to download the file index for that folder, very amusing... So, given that structure, I would have expected to see attachments moved over here. In fact, the only files that were in this folder were the avatars. Yay.
So here's what I did: I simply took the original attachment folder, renamed all files to give them the proper extension, and rewired the attachment folder to the DB setting. Then attachments started working again.

As for avatars, my issue was that they're of attachment_type = 1, meaning their filenames are in plain view. The importer didn't retrieve the attachment type, simply re-created the files in the attachment folder, and thus I was forced to reset the attachment_type flag in the database after I moved the folder to the root. Thankfully, it wasn't too complicated.

So, my main concerns for the future (and suggestions for improvement) would be:
- try and fix the duplicate key stuff...
- if avatars are static and in plain view (= EXCELLENT performance improvement even in SMF), do not import them as hidden files,
- offer users the ability to keep all of their data (gallery, attachments, avatars) in the same place as before (i.e. their old SMF install), and just update the Wedge settings to point to these folders. I think this would be really great, because it means not having to worry about moving files back into their original place when moving Wedge into the SMF folder.
Really, installing Wedge and importing SMF was the easiest part (except for the duplicate key problem). The hardest part was moving the folder. Considering that SMF users will install Wedge and use the importer *mainly* to test-drive it and decide whether they want to use it instead of SMF, it would be great to be able to keep all data in the SMF folder.
Quote
Congratualations, great to see Wedge in action :)
I'm still in awe. I wrote the skin, the theme, I did all of these little animations, I tested Wedge for a year and a half, and I still can't believe I'm freaking using it right now, on a public website. To me, Wedge was always my subject of study, the purpose of my work. Now, it is also a TOOL to help me do my job properly. I'm thankful to myself, to Pete and to everyone who helped build the project in the first place. :)