« Don't know if I shared it publicly or not
Thought system
Moderation filters UI »

Online Arantor

  • Wedgeward
  • Posts: 10,364
  • The Twelve Tasks of Asterix is awesome.
    • View profile
    • Innovate, not Imitate
Re: Thought system
« Reply #75 on November 16th, 2011, 11:19 PM »
I'll take a look in a bit; Safari was the one main system I hadn't tested it on.

I opined elsewhere that part of the problem with SMF's fixes to this problem is that they didn't have a battery of tests to work on, meaning that they were fumbling around in the dark trying to find directions. In the same discussion, I noted that the list of tests to be carried out is:

Quote
* A filename with no special characters or symbols other than file delimiter (file.txt)
* A filename with 7-bit symbols characters, but no spaces and no + (file_test.txt, file-test.txt)
* A filename with 7 bit characters, and a space (file test.txt)
* A filename with 7 bit characters, and a + (file+test.txt)
* A filename with 7 bit characters, and a space and a + (file test+results.txt)
* A filename with high bit characters (any ISO encoding, on ISO encoded forum) (file™.txt)
* A filename with high bit characters and a space (ISO encoding) (file name™.txt)
* A filename with high bit characters and + (ISO) (file+test™.txt)
* A filename with high bit characters and a space and + (ISO) (file test+results™.txt)

All of the high bit character tests will then need to be repeated on a UTF-8 forum with UTF-8 encoded filenames, and if any of the 7 bit tests fail, there is no point with the high bit tests until the 7 bit tests pass.
In fact I realise I missed single and double quotes off the list but " is not valid in most systems' filenames anyway. (And in the code I wrote, it would be safely rawurlencode'd anyway)
   computer-aided
   community building		             

Other stuff:

Online Nao

  • Wedgeward
  • Posts: 10,275
  • Reality check: I just discovered that Wedge already has a 'Mark unread' button for PMs, a feature in my to-do. Uh. It just isn't in the 'right' place...
    • View profile
    • Cynacittà @ noisen
Re: Thought system
« Reply #76 on December 12th, 2011, 06:03 PM »
Oh my... It would appear the little f*cker is dead.

I don't know why or how. It just doesn't register when I edit or type in a new thought.

Can anyone who tested the thought system (on a local copy) so far give me some feedback on this...? Did you ALWAYS see that issue? Send a thought -> the return copy is empty and nothing is entered into the DB. No errors either...
I really don't want to bother with Ajax debugging right now :(
Posted: December 12th, 2011, 06:01 PM

Oh, and I also messed up rev 1179... It was last month already -- and I committed a file that wasn't supposed to be (index.css), with selectbox styling for a feature that wasn't even in...

Pete or anyone, when you see that kind of file and it's NOT documented, can you report it please...? It usually means I forgot to uncheck a file that's not ready for consumption... (And yes I do have a fair share of files I have to uncheck every time. Pretty annoying really. But if I start putting them on Ignore, I'll just forget to deal with them in the future...)
  I say Wedge Wedge (in the butt)
« Everyone knows rock attained perfection in 1974. It's a scientific fact. » (Homer Simpson)

Online Arantor

  • Wedgeward
  • Posts: 10,364
  • The Twelve Tasks of Asterix is awesome.
    • View profile
    • Innovate, not Imitate
Re: Thought system
« Reply #77 on December 12th, 2011, 06:06 PM »
Quote
Oh my... It would appear the little f*cker is dead.

I don't know why or how. It just doesn't register when I edit or type in a new thought.
Hmm, I thought this was fixed? It's worked for me though I haven't tested it recently.

Quote
Pete or anyone, when you see that kind of file and it's NOT documented, can you report it please...?
See, I didn't realise it wasn't supposed to be in there, knowing that the selectbox was coming up...
   computer-aided
   community building		             

Other stuff:

Online Nao

  • Wedgeward
  • Posts: 10,275
  • Reality check: I just discovered that Wedge already has a 'Mark unread' button for PMs, a feature in my to-do. Uh. It just isn't in the 'right' place...
    • View profile
    • Cynacittà @ noisen
Re: Thought system
« Reply #78 on December 12th, 2011, 07:39 PM »
- It was fixed and working great, at least when I last dealt with it... i.e. it must have broken after that, while fixing something else in an unrelated place. Can you confirm and look into it?

- Just to be clear: if I ever commit "work in progress" code with shitty commented out stuff, it is NOT as planned, unless I'm clearly specifying it in the changelog (I usually apologize for this kind of thing.) I also found out that rev 1186 has my work-in-progress script.js committed... Just the same: it's shitty and not as planned. And again, it's not mentioned in the changelog.

Every time you commit something, I'll make sure to ensure you haven't committed any 'weird' stuff that's not in the changelog, and if there is, I'll ask you about it... I can do that kind of mistake, too, so I was kinda hoping someone was checking on my commits...
  I say Wedge Wedge (in the butt)
« Everyone knows rock attained perfection in 1974. It's a scientific fact. » (Homer Simpson)

Online Nao

  • Wedgeward
  • Posts: 10,275
  • Reality check: I just discovered that Wedge already has a 'Mark unread' button for PMs, a feature in my to-do. Uh. It just isn't in the 'right' place...
    • View profile
    • Cynacittà @ noisen
Re: Thought system
« Reply #79 on December 13th, 2011, 03:25 PM »
Found the culprit... In Ajax.php, rev 1184, I added a wedit::preparsecode($text) on the thought. Uh...

So... It doesn't generate an error in the database. Hard to trace. I simply removed the line from my current rev and it works. And it's not related to my fixNesting stuff because it wasn't already there in rev 1184... :-/
  I say Wedge Wedge (in the butt)
« Everyone knows rock attained perfection in 1974. It's a scientific fact. » (Homer Simpson)

Online Nao

  • Wedgeward
  • Posts: 10,275
  • Reality check: I just discovered that Wedge already has a 'Mark unread' button for PMs, a feature in my to-do. Uh. It just isn't in the 'right' place...
    • View profile
    • Cynacittà @ noisen
Re: Thought system
« Reply #80 on December 15th, 2011, 10:39 AM »
(Fixed.)
  I say Wedge Wedge (in the butt)
« Everyone knows rock attained perfection in 1974. It's a scientific fact. » (Homer Simpson)

Offline TE

  • Consultants
  • Posts: 240
    • View profile
    • eurich.de
Re: Thought system
« Reply #81 on February 15th, 08:31 AM »
question: is there an option to enable / disable the thoughts system inside the admin area? Maybe I'm blind but I can't fine one   :angel:
Thorsten "TE" Eurich - Former SMF Developer & Converters Guru
----------------------------------------------------------
SMF is dead, long live Wedge ;)

Online Nao

  • Wedgeward
  • Posts: 10,275
  • Reality check: I just discovered that Wedge already has a 'Mark unread' button for PMs, a feature in my to-do. Uh. It just isn't in the 'right' place...
    • View profile
    • Cynacittà @ noisen
Re: Thought system
« Reply #82 on February 16th, 03:49 PM »
Nope... It's obviously something I'll add later on. But it's not my priority, honestly. I want to give it a chance to get known... :P (Obviously, at the very least it'll be enabled by default...)
  I say Wedge Wedge (in the butt)
« Everyone knows rock attained perfection in 1974. It's a scientific fact. » (Homer Simpson)
« Don't know if I shared it publicly or not
Moderation filters UI »