New revs

Nao

  • Dadman with a boy
  • Posts: 16,079
Re: New revs
« Reply #2700, on September 27th, 2014, 12:50 PM »
[Commit revision bf985d8]
Author: Nao
Date: Sat, 27 Sep 2014 12:50:06 +0200
Stats: 1 file changed; +3 (insertions), -3 (deletions)

  • Shorten topic titles to 35 chars in stats. (Stats.php)
Re: New revs
« Reply #2701, on September 27th, 2014, 10:49 PM »
[Commit revision a0e044a]
Author: BurkeKnight
Date: Sat, 27 Sep 2014 22:21:25 +0200
Stats: 1 file changed; +1 (insertion), -1 (deletion)


[Commit revision e36c7d1]
Author: Nao
Date: Sat, 27 Sep 2014 22:49:19 +0200
Stats: 1 file changed; +1 (insertion), -1 (deletion)

  • Merge pull request #21 from BurkeKnight/master
  • Input #userspec -- quick tweak for some browser I have no idea about. Seriously. It worked fine everywhere I tested before... --Nao
Re: New revs
« Reply #2702, on September 29th, 2014, 09:57 PM »
[Commit revision a230857]
Author: Nao
Date: Mon, 29 Sep 2014 21:53:55 +0200
Stats: 1 file changed; +4 (insertions), -4 (deletions)

  • Not sure why I insisted on 'assuming' a scrollbar width in $(window).width(), when I could simply rely to $('body').width() to get a scrollbar-less width... Or is it some other thing that causes bugs elsewhere..? I'll find out soon enough. (sbox.js)

[Commit revision 95d35e4]
Author: Nao
Date: Mon, 29 Sep 2014 21:56:16 +0200
Stats: 2 files changed; +7 (insertions), -2 (deletions)

  • Now right-floating select box hints (i.e. <small> tags), which was my original plan. It caused a bug around which I worked by forcing a style temporarily... Weird bug, but whatever... Works in Chrome now. Haven't tested in other browsers, but as usual, if you're not getting paid for something, you'll have to rely on others to do some of the testing for you. (index.css, sbox.js)

[Commit revision 3022c8a]
Author: Nao
Date: Mon, 29 Sep 2014 21:57:22 +0200
Stats: 1 file changed; +1 (insertion), -1 (deletion)

Re: New revs
« Reply #2703, on October 1st, 2014, 03:55 PM »
[Commit revision dd42929]
Author: Nao
Date: Wed, 01 Oct 2014 15:54:52 +0200
Stats: 2 files changed; +4 (insertions), -2 (deletions)

  • Fixed search popup's widths altogether. (Search.template.php, sections.css)
Re: New revs
« Reply #2704, on October 2nd, 2014, 01:03 AM »
[Commit revision 49279a9]
Author: Nao
Date: Wed, 01 Oct 2014 20:30:19 +0200
Stats: 1 file changed; +0 (insertion), -1 (deletion)

  • Removing an older hack for mobile. (sections.css)

[Commit revision 3def5d7]
Author: Nao
Date: Thu, 02 Oct 2014 01:03:20 +0200
Stats: 3 files changed; +7 (insertions), -16 (deletions)

  • So... It turned out, my search popup code was a bit messed up because my browser always runs with a narrow width, so that responsive layouts are always enabled. And while it worked fine in responsive mode, I somehow managed to break it in desktop mode in the last few months. Fixing this by applying the responsive layout on desktop browsers, and we're done. (index.css, sections.css)
  • Tweaked JS so that search popups never overflow to the left of the screen if it's too narrow. (script.js)
Re: New revs
« Reply #2705, on October 6th, 2014, 12:41 AM »
[Commit revision 0303ffc]
Author: Nao
Date: Sun, 05 Oct 2014 16:08:56 +0200
Stats: 1 file changed; +1 (insertion), -1 (deletion)

  • Shortened strings returned by... shorten_subject(). (Subs.php)

[Commit revision 4bd583c]
Author: Nao
Date: Sun, 05 Oct 2014 16:09:42 +0200
Stats: 1 file changed; +2 (insertions), -2 (deletions)

  • Fixed minor glitch on skin selector in responsive mode. (Themes.php)

[Commit revision 261d5a3]
Author: Nao
Date: Sun, 05 Oct 2014 16:10:58 +0200
Stats: 1 file changed; +6 (insertions), -4 (deletions)

  • Commenazi, and spacinazi. (Subs-Media.php)

[Commit revision 9f4c805]
Author: Nao
Date: Mon, 06 Oct 2014 00:41:11 +0200
Stats: 2 files changed; +41 (insertions), -39 (deletions)

  • More fixes to the search popup. Should behave better in mobile mode *and* desktop mode, too... What an annoying piece of code, still. (script.js, sections.css)
Re: New revs
« Reply #2706, on October 18th, 2014, 08:27 PM »
[Commit revision c64ce87]
Author: Nao
Date: Sat, 18 Oct 2014 20:19:53 +0200
Stats: 1 file changed; +1 (insertion), -1 (deletion)

  • Add message ID to the post array, for plugins I guess. (PrintPage.php)

[Commit revision ae18f6c]
Author: Nao
Date: Sat, 18 Oct 2014 20:26:46 +0200
Stats: 1 file changed; +1 (insertion), -1 (deletion)

  • I broke custom fields in the member list back in March... (Memberlist.php)
Re: New revs
« Reply #2707, on October 22nd, 2014, 12:09 AM »
[Commit revision f7822f7]
Author: Nao
Date: Tue, 21 Oct 2014 20:37:21 +0200
Stats: 5 files changed; +9 (insertions), -9 (deletions)

  • I should probably update jQuery libraries, they've been up for months now... (Load.php, core/javascript/*)

[Commit revision 15bb50b]
Author: Nao
Date: Tue, 21 Oct 2014 23:32:13 +0200
Stats: 1 file changed; +3 (insertions), -0 (deletion)

  • This is a little feature of mine that I used to debug stuff months ago, and I figured it might be helpful to plugin authors as well, so let's do this... You can get a 'debug' view of hooks at templating time if you're an admin and you manually add ";viewhooks" to the URL (or "?viewhooks" if there's no question mark to begin with.) A red box means it's unused, and of course a green box means that at least one plugin is using that hook. Stick your mouse pointer over any box to get a tooltip indicating the hook's name. That's all, folks! (Subs.php)

[Commit revision 3f28ad0]
Author: Nao
Date: Wed, 22 Oct 2014 00:08:34 +0200
Stats: 1 file changed; +1 (insertion), -1 (deletion)

  • Missing id_msg, oops. (PrintPage.php)
Re: New revs
« Reply #2708, on October 22nd, 2014, 12:14 AM »
[Commit revision 4d3680a]
Author: Nao
Date: Wed, 22 Oct 2014 00:14:49 +0200
Stats: 1 file changed; +3 (insertions), -2 (deletions)

  • Search didn't set search_type to board if specific boards were set. (Based on fix by @CleptoMan, although totally not tested, as usual with me when it's past midnight.) (Search.template.php)
Re: New revs
« Reply #2709, on October 22nd, 2014, 11:10 PM »
[Commit revision 74ccafb]
Author: Nao
Date: Wed, 22 Oct 2014 22:17:35 +0200
Stats: 1 file changed; +3 (insertions), -5 (deletions)

  • Just a reminder: foreach() doesn't recalculate values on each iteration, so we don't need temp variables... (Like.php)

[Commit revision 9d716a9]
Author: Nao
Date: Wed, 22 Oct 2014 23:05:11 +0200
Stats: 1 file changed; +6 (insertions), -6 (deletions)

  • IP fields should be marked as unsigned, thus making twice as many IP entries available. Not a game changer, so I'm not going to update Upgrade.php just for that...
Re: New revs
« Reply #2710, on October 22nd, 2014, 11:10 PM »
[Commit revision 704756b]
Author: Nao
Date: Wed, 22 Oct 2014 22:30:02 +0200
Stats: 11 files changed; +112 (insertions), -74 (deletions)

  • Changed the Like feature to 'Reactions', which basically adds the ability to say something else than 'I like!' to a post, based on a selection of smileys. I wrote this a month ago, and was unable to make up my mind and commit it, so I'm doing it to a new branch, and forgetting the feature for now. Hopefully, someone else will be interested in helping out. (Display.php, Like.php, Merge.php, RemoveTopic.php, Stats.php, Subs-Members.php, Thoughts.php, Upgrade.php, Display.template.php, index.english.php, install.sql)
  • Things left to do:
  •  (1) Increment index.php's upgrade variable to allow for the upgrade script to pick up.
  •  (2) Update the upgrade script to have a better (shorter?) selection of default smileys.
  •  (3) Determine whether reaction icons should be based on smileys, or completely different pictures.
  •  (4) Add the actual UI for setting your reaction. I couldn't decide whether to use a select box or a mini-menu. Both have their pros and cons.
  •  (5) Add the actual admin UI for customizing what smileys can be used globally, and possibly some UI to allow posters to determine what reactions their message should allow.
Re: New revs
« Reply #2711, on October 28th, 2014, 09:10 PM »
[Commit revision 86a67d1]
Author: Nao
Date: Tue, 28 Oct 2014 20:20:37 +0100
Stats: 1 file changed; +1 (insertion), -0 (deletion)

  • Remove .first-post class from all items retrieved through infinite Ajax. You never know... (topic.js)

[Commit revision 0acaa37]
Author: Nao
Date: Tue, 28 Oct 2014 21:03:36 +0100
Stats: 1 file changed; +2 (insertions), -0 (deletion)

  • Also, probably useless, but in case an infinite page takes time to show, we might want to show an Ajax loader. I'm not sure it'll work though, with all of the DOM manipulations going around... But at least it doesn't break anything, so might as well do it. (topic.js)

[Commit revision 772cafd]
Author: Nao
Date: Tue, 28 Oct 2014 21:10:06 +0100
Stats: 2 files changed; +5 (insertions), -5 (deletions)

  • Fixed infinite pages showing a duplicate of the original post in blog mode. (Display.php)
  • Fixed infinite pages showing full userbox data in blog mode. (Display.template.php)
  • Also documented one of the lines a bit more... wetem::replace() can be complicated to grasp here. (Display.php)
  • These fixes took me hours to implement... I'm getting rusty! But this is as short and simple as I can do for them.
Re: New revs
« Reply #2712, on November 8th, 2014, 12:36 PM »
[Commit revision 8f85c88]
Author: Nao
Date: Sat, 08 Nov 2014 12:36:17 +0100
Stats: 1 file changed; +1 (insertion), -0 (deletion)

  • The colon separator for specifying number of items on homepage blocks didn't work properly. (Home.php)
Re: New revs
« Reply #2713, on November 12th, 2014, 11:19 PM »
[Commit revision 5ab1c8c]
Author: Nao
Date: Wed, 12 Nov 2014 23:17:53 +0100
Stats: 1 file changed; +13 (insertions), -1 (deletion)

  • Delete message link was broken on profile post lists for guests. (Profile.template.php)

[Commit revision d424bb0]
Author: Nao
Date: Wed, 12 Nov 2014 23:18:54 +0100
Stats: 1 file changed; +30 (insertions), -33 (deletions)

  • Action menu was disabled when viewing a guest post. I'm not sure why I did this at all, but let's say it was an oversight, and hope it doesn't break something else... Apparently it's working fine. (Display.php)
Re: New revs
« Reply #2714, on November 12th, 2014, 11:28 PM »
[Commit revision 1e70f28]
Author: Nao
Date: Wed, 12 Nov 2014 23:28:02 +0100
Stats: 1 file changed; +1 (insertion), -1 (deletion)

  • Screwed up operator precedence. I can only say this Your Honor: it's the first time I ever used a simplified ?: operator... (Home.template.php)