New revs

Nao

  • Dadman with a boy
  • Posts: 16,079
Re: New revs
« Reply #2655, on June 29th, 2014, 10:36 PM »
Note that I've decided to unlock this topic and allow comments related to new revisions. It's better than always having to dug up the New revs comment topic or create a new topic to comment, which rarely happens...
I'm also doing that because the github reposts have a clear look and you can choose to simply skip the posts that don't like them. Or follow new revs on github, whichever you prefer.

Please stay on topic. This isn't a support topic!
Re: New revs
« Reply #2656, on July 3rd, 2014, 12:25 AM »
[Commit revision b0ec67b]
Author: Nao
Date: Thu, 03 Jul 2014 00:24:47 +0200
Stats: 1 file changed; +1 (insertion), -1 (deletion)

  • Finally fixed a very resilient bug (which I never properly understood before), where guests couldn't select a skin through the skin selector. (Class-System.php)
Re: New revs
« Reply #2657, on July 5th, 2014, 11:16 PM »
[Commit revision 3e14729]
Author: Nao
Date: Fri, 04 Jul 2014 16:42:58 +0200
Stats: 8 files changed; +15 (insertions), -42 (deletions)

  • Removed jQuery UI, which saves 50KB off the zipped package. Wedge never actually used it -- it only used its sortable() method, which I moved into the sortable.min.js (thanks to jQuery UI's module builder). Also removed the add_jquery_ui function, if you really need it, you can always retrieve it from earlier commits (or this one.) (javascript/jquery-ui-1.10.0.min.js, javascript/sortable.min.js, ManageBoards.php, ManageMemberOptions.php, ManageMembergroups.php, ManageNews.php, Pin.php, Subs-Cache.php)

[Commit revision 73e2099]
Author: Nao
Date: Sat, 05 Jul 2014 23:12:07 +0200
Stats: 2 files changed; +18 (insertions), -0 (deletion)

  • The Modify button now uses the Quick Edit icon. It looks better. (index.css, sections.css)
  • Note: the Manage Boards page still uses the old modify button. For now...

[Commit revision 8f69758]
Author: Nao
Date: Sat, 05 Jul 2014 23:16:10 +0200
Stats: 1 file changed; +5 (insertions), -3 (deletions)

  • This is probably just transitory thing, but I'm adding back contact lists (except for restricted members) into the we::$user['buddies'] array. Not touching buddy_list for now, as it's something that needs... More work. (Class-System.php)
Re: New revs
« Reply #2658, on July 5th, 2014, 11:40 PM »
[Commit revision e17a1a1]
Author: Nao
Date: Sat, 05 Jul 2014 23:36:37 +0200
Stats: 7 files changed; +307 (insertions), -100 (deletions)

  • Tons of new features in the contact lists editor. And they're ALL AJAX POWERED! Yayz! No Save button! (Profile.php, Profile-Modify.php, Profile.template.php, pages.css)
  •  Reorder members in a list by grabbing their handles. What you do with them is none of my business.
  •  Rename any list.
  •  Remove any list.
  •  Change any list's type.
  •  Change any list's visibility. (Note, this isn't actually followed through, will come soon.)
  •  Permission to view this page is tied to profile_extra, which has _any and _own variants. Just what I needed.
  •  Contact list widget on people profile summaries are a bit more readable. Custom type is no longer the same as 'New list'.
  • Commented out most of the unused code in the new contact list system. Buh-bye buddies! Until I get some time to clean this up... (Profile-Modify.php)
  • I actually committed pages.css instead of index.css earlier, so I'm committing index.css now, and marking it as pages.css above, because it's funnier.

[Commit revision 9247a50]
Author: Nao
Date: Sat, 05 Jul 2014 23:39:48 +0200
Stats: 4 files changed; +18 (insertions), -15 (deletions)

  • Guests can no longer make the header disappear. I have a strong belief that this kind of trick will only be of interest to regular users of a forum, so... Why waste cookie bandwidth on this? (index.template.php, script.js)
  • Indenazi. (Boards.template.php, ManageMembergroups.template.php)
Re: New revs
« Reply #2659, on July 6th, 2014, 10:07 AM »
[Commit revision 4152e82]
Author: Nao
Date: Sun, 06 Jul 2014 10:07:19 +0200
Stats: 1 file changed; +13 (insertions), -2 (deletions)

  • Contact hiding was broken. For once, it wasn't a last-minute change, but instead a change followed by a couple of days of not testing the feature. (Profile-Modify.php)
Re: New revs
« Reply #2660, on July 6th, 2014, 01:36 PM »
[Commit revision 64aeb4c]
Author: Nao
Date: Sun, 06 Jul 2014 13:35:51 +0200
Stats: 1 file changed; +1 (insertion), -0 (deletion)

  • Recent Posts now honor privacy settings. (Recent.php)
  • There are still probably many places where I need to do this kind of thing. I never looked much into it because the rest of the privacy system wasn't really ready until recently anyway. Also, I still have about 400KB of Noisen.com patches that I need to go through. All of the original {query_see_topic}'s are in there, but I was so conservative that I added it in way too many places.
Re: New revs
« Reply #2661, on July 7th, 2014, 05:10 PM »
[Commit revision e5446bf]
Author: Nao
Date: Mon, 07 Jul 2014 17:10:09 +0200
Stats: 1 file changed; +1 (insertion), -1 (deletion)

  • wesql::fetch_rows was probably broken on newer MySQL servers. (Class-DB.php)
Re: New revs
« Reply #2662, on July 7th, 2014, 11:00 PM »
[Commit revision 5f4fe10]
Author: Nao
Date: Mon, 07 Jul 2014 23:00:43 +0200
Stats: 1 file changed; +11 (insertions), -26 (deletions)

  • Simplified the logic in rebuiltModCache(), along with a minor optimization suggested by John via Pandos. (Subs-Auth.php)
Re: New revs
« Reply #2663, on July 7th, 2014, 11:58 PM »
[Commit revision e2ee0d9]
Author: Nao
Date: Mon, 07 Jul 2014 23:58:26 +0200
Stats: 2 files changed; +17 (insertions), -14 (deletions)

  • Privacy icons are now called through a generic function, which lets us add a hover title indicating what type of privacy setting is being used. (Security.php)
  • Simplified thought template, and used the above function. Actually, it's the only place for now where I'm showing privacy icons at all... (Thoughts.template.php)
Re: New revs
« Reply #2664, on July 8th, 2014, 12:08 AM »
[Commit revision 54bcada]
Author: Nao
Date: Tue, 08 Jul 2014 00:08:47 +0200
Stats: 1 file changed; +30 (insertions), -3 (deletions)

  • So, I just found this situation where a private topic can be visible to guests. Yay, I win. The board list will show a link to it (although not actually browsable) if it's the last updated topic in the board. I've decided to 'fix' this by forcing a query_see_topic, and if the topic is private, do an extra query (which shouldn't be TOO slow, but I'm no specialist) that will return the proper last viewable post for you. This will only happen if the last post is private, so it shouldn't be too much of an issue. (Subs-BoardIndex.php)
  • Feedback is warmly welcomed!!
Re: New revs
« Reply #2665, on July 8th, 2014, 12:15 AM »
[Commit revision 41149a9]
Author: Nao
Date: Tue, 08 Jul 2014 00:12:29 +0200
Stats: 1 file changed; +4 (insertions), -4 (deletions)

  • While we're on the 'logic' side... Saving a single variable test, because I said so. (Subs-Post.php)

[Commit revision 8e03f6d]
Author: Nao
Date: Tue, 08 Jul 2014 00:15:34 +0200
Stats: 1 file changed; +1 (insertion), -1 (deletion)

  • Time for bed uh..? (Subs-Auth.php)
Re: New revs
« Reply #2666, on July 8th, 2014, 02:17 PM »
[Commit revision 2a97066]
Author: Nao
Date: Tue, 08 Jul 2014 14:17:33 +0200
Stats: 2 files changed; +5 (insertions), -1 (deletion)

  • Don't show the postlist_before block on blog posts with no comment, avoiding the awkward double line of page indexes. (Display.php, Display.template.php)
Re: New revs
« Reply #2667, on July 24th, 2014, 08:52 PM »
[Commit revision 96fe4a8]
Author: Nao
Date: Thu, 24 Jul 2014 20:51:58 +0200
Stats: 1 file changed; +8 (insertions), -3 (deletions)

  • Caching IP to host data for only 10 minutes isn't going to cut it. If your server is very slow, users will always get a long slowdown every 10 minutes, so I'm upping this to 24 hours, and hopefully it won't clutter the cache folder with IP data. Seriously, I had to go through a xdebug session just to get to the bottom of this and understand why my local server was so slow when accessed remotely, and so fast from my localhost (answer: 127.0.0.1 is easy to translate.) (Subs.php)
  • If the IP to host process is really slow and the admin never went to the admin page for this (which is unlikely, but on a first launch maybe...), disable hostname lookups by default. Once the setting is changed manually, it'll never be overridden again. BTW, totally untested... Don't complain too much, I'm doing this between two bottles for little Charlie. (Subs.php)
Re: New revs
« Reply #2668, on July 24th, 2014, 08:56 PM »
[Commit revision 00f721c]
Author: Nao
Date: Thu, 24 Jul 2014 20:53:29 +0200
Stats: 1 file changed; +1 (insertion), -1 (deletion)

  • Casenazi. (Subs-Post.php)

[Commit revision 9fe368e]
Author: Nao
Date: Thu, 24 Jul 2014 20:55:51 +0200
Stats: 1 file changed; +10 (insertions), -4 (deletions)

  • Sbox now allows select boxes to be opened programmatically, rather than through a click. This should help you hide the display area entirely and just show the drop down list. You'll see why it's interesting later. (sbox.js)
  • Casenazi. (sbox.js)
Re: New revs
« Reply #2669, on July 27th, 2014, 04:28 PM »
[Commit revision b74df21]
Author: Nao
Date: Sun, 27 Jul 2014 16:28:02 +0200
Stats: 2 files changed; +25 (insertions), -17 (deletions)

  • Wuthering is now even more Curvesque. (Wuthering/extra.css, Wuthering/skin.xml)
  • Those who want to smoothly transition from SMF 2.0 to Wedge will now be in known territory! The conversion isn't pixel-to-pixel, but it's not because I can't do it, it's simply because Curve is far from being perfect, and I'm not going to add even more CSS bytes just to make Wedge look worse... Anyway, improvements to this 'reproduction' are welcome, if you can get it to be on the shorter side.