New revs

Nao

  • Dadman with a boy
  • Posts: 16,082
Re: New revs
« Reply #1785, on December 2nd, 2012, 10:07 PM »
rev 1785
(52 files, 9kb)

! Fixed strict mode error. (Class-MoDe.php)

* Lots of minor changes to unify CSS style definitions in HTML code, and other similarly non-important things. (About 50 files)

* French translation. (ManageBoards, ManageMembers)

Arantor

  • As powerful as possible, as complex as necessary.
  • Posts: 14,278
Re: New revs
« Reply #1786, on December 8th, 2012, 01:13 AM »
(2 files, 4KB)

Revision: 1786
Author: arantor
Date: 08 December 2012 00:13:02
Message:
! Minor improvements to the manage moderation setup, should make it a little easier for typical plugins to extend it - at least the UI side of it. (ManageModeration.template.php)

! Likes are shown to guests, but the popup didn't work for guests. (Like.php)
----
Modified : /trunk/Sources/Like.php
Modified : /trunk/Themes/default/ManageModeration.template.php
Re: New revs
« Reply #1787, on December 9th, 2012, 05:51 PM »
(3 files, 1KB)

Revision: 1787
Author: arantor
Date: 09 December 2012 16:46:50
Message:
! Syntax error in post moderation. (PostModeration.php)

! Fix undefined errors and odd cases if a post was unliked but in the interim someone asked for the list of who viewed it. (Like.php)

! [SMF bug] queryPosts could be called with a variety of nasty consequences. (SSI.php)
----
Modified : /trunk/SSI.php
Modified : /trunk/Sources/Like.php
Modified : /trunk/Sources/PostModeration.php
Re: New revs
« Reply #1788, on December 9th, 2012, 06:06 PM »
(2 files, 9KB)

Revision: 1788
Author: arantor
Date: 09 December 2012 17:05:53
Message:
! Updated FTP class, features more debugging facilities, cleaner method for sending FTP messages over the primary channel (don't need to remember to follow each line with a newline, and the API handles debugging at the same time) plus the new GET and PUT methods over FTP, not fully battle tested. This is likely to expand in future, including multi-put and put from string, but not right now. (Class-FTP.php)

! weget should make use of FTP GET when downloading from FTP rather than getting it itself. (Class-WebGet.php)
----
Modified : /trunk/Sources/Class-FTP.php
Modified : /trunk/Sources/Class-WebGet.php
When we unite against a common enemy that attacks our ethos, it nurtures group solidarity. Trolls are sensational, yes, but we keep everyone honest. | Game Memorial

Nao

  • Dadman with a boy
  • Posts: 16,082
Re: New revs
« Reply #1789, on December 10th, 2012, 04:50 PM »
rev 1789 -- first time I'm letting an entire week pass between two commits... :(
(1 file, 1kb)

! Account for plugins passing a '.css' extension to add_plugin_css_file() when they shouldn't. (Subs-Cache.php)

! If a plugin's CSS file isn't found, we should gracefully fall back to a better solution. Or, at the very least, not crash everything. (Subs-Cache.php)

@ rev 1789 had to be given to the French guy... Even a bad flu won't prevent that!

Arantor

  • As powerful as possible, as complex as necessary.
  • Posts: 14,278
Re: New revs
« Reply #1790, on December 10th, 2012, 05:11 PM »
(13 files, 22KB)

Revision: 1790
Author: arantor
Date: 10 December 2012 16:10:24
Message:
! Remove one of the wedge.org specific hacks in index.template.php. Still one to go, though. (index.template.php)

! Add something a halfway decent meta description for topic pages. (Display.php, Subs-Template.php)

! Providing users the ability to specify messages when a moderation filter will trigger to prevent or moderate a message. Aside from the UI for it, this also required extending how messages are displayed when they are moderated, though this is not much more than a WIP at this time. (install.sql, ManageModeration.php, Subs-Moderation.php, Post2.php, Display.php, ManageModeration.template.php, Display.template.php, mana.css, sections.css, Errors and ManageSettings language files)
----
Modified : /trunk/Sources/Display.php
Modified : /trunk/Sources/ManageModeration.php
Modified : /trunk/Sources/Post2.php
Modified : /trunk/Sources/Subs-Moderation.php
Modified : /trunk/Sources/Subs-Template.php
Modified : /trunk/Themes/default/Display.template.php
Modified : /trunk/Themes/default/ManageModeration.template.php
Modified : /trunk/Themes/default/index.template.php
Modified : /trunk/Themes/default/languages/Errors.english.php
Modified : /trunk/Themes/default/languages/ManageSettings.english.php
Modified : /trunk/Themes/default/skins/mana.css
Modified : /trunk/Themes/default/skins/sections.css
Modified : /trunk/root/install.sql

@ The hack removed from index.template.php was ported to a plugin which is in the plugins repo.
Re: New revs
« Reply #1791, on December 14th, 2012, 01:36 AM »
(2 files, 1KB)

Revision: 1791
Author: arantor
Date: 14 December 2012 00:35:44
Message:
! When adding a new bbcode from a plugin, make sure to fill in the len cache. (ManagePlugins.php)

! Use the correct variable when passing the bbc buttons through the hook. (Class-Editor.php)

! When something that could be an image is passed as the 'image' parameter, treat it as a full URL. Detection is handled based on // rather than anything else because // is becoming a valid URL prefix to indicate schemeless requests (e.g. images requested with whatever the main page is using). (Class-Editor.php)
----
Modified : /trunk/Sources/Class-Editor.php
Modified : /trunk/Sources/ManagePlugins.php
Re: New revs
« Reply #1792, on December 15th, 2012, 12:49 AM »
(1 file, 1KB, one line!)

Revision: 1792
Author: arantor
Date: 14 December 2012 23:49:16
Message:
! modfilter_msg_popup was not properly used. This isn't pretty but it's OK for now, we can make it prettier later when people who aren't us use the feature. (ManageModeration.php)
----
Modified : /trunk/Sources/ManageModeration.php
Re: New revs
« Reply #1793, on December 15th, 2012, 10:01 PM »
(1 file, 1KB)

Revision: 1793
Author: arantor
Date: 15 December 2012 21:00:24
Message:
! Fixed generic list not being able to handle timeformat or comma format properly, though I did actually harmonise them entirely with the other types, and fixed the only instance I could actually find of using that. Suggested ages ago by Live but at the time I never understood the benefits or practicalities of it. (Groups.php, Subs-List.php)
----
Modified : /trunk/Sources/Groups.php
Re: New revs
« Reply #1794, on December 15th, 2012, 10:02 PM »
(1 file, 1KB)

Revision: 1794
Author: arantor
Date: 15 December 2012 21:02:02
Message:
! Bah, forgot this one last time. (Subs-List.php)
----
Modified : /trunk/Sources/Subs-List.php
Re: New revs
« Reply #1795, on December 16th, 2012, 06:02 AM »
(4 files, 9KB)

Revision: 1795
Author: arantor
Date: 16 December 2012 05:01:48
Message:
! Added new type for settings in the admin panel: percent. Using much the same code as the profile/issue warning template, it's now possible to add a shiny draggable selector for settings. Also added a note to the profile to say that if it is changed, the admin equivalent should possibly be touched too. I would note this isn't really finished, but I wanted to get a 'working' version committed. It isn't pretty at all at the code level, but it does support multiple selectors per page, too. I totally didn't need this for my new ban system or anything. (plugin-info.rng, ManageServer.php, ManageSettings.php, Admin.template.php)
----
Modified : /trunk/Sources/ManageServer.php
Modified : /trunk/Sources/ManageSettings.php
Modified : /trunk/Themes/default/Admin.template.php
Modified : /trunk/other/plugin-info.rng
Re: New revs
« Reply #1796, on December 16th, 2012, 06:16 AM »
(2 files, 2KB)

Revision: 1796
Author: arantor
Date: 16 December 2012 05:15:08
Message:
! Stupid typo. I shouldn't commit this late at night. (ManageSettings.php)
! Forgot to actually commit the profile template I added a comment to. (Profile.template.php)
! Converted some settings that actually made sense to the new percent type. (ManageSettings.php)
----
Modified : /trunk/Sources/ManageSettings.php
Modified : /trunk/Themes/default/Profile.template.php

Nao

  • Dadman with a boy
  • Posts: 16,082
Re: New revs
« Reply #1797, on December 16th, 2012, 02:21 PM »
rev 1797
(40 files, 7kb)

* Harmonized all index.php files that were only there to prevent manual folder exploration. All files now use the same contents -- a single-line redirect to the upper level. Simpler, better. Could be done with an .htaccess file, but I believe it's better to rely on PHP here. The only thing I'm not sure about is whether I should forcibly add index.php to the redirect or leave it this way... There's still time to adapt. (40 occurrences of */index.php)

Arantor

  • As powerful as possible, as complex as necessary.
  • Posts: 14,278
Re: New revs
« Reply #1798, on December 16th, 2012, 03:06 PM »
(2 modified, 1 new, 4KB)

Revision: 1798
Author: arantor
Date: 16 December 2012 14:05:23
Message:
! Bah, commit overlap. Moving all styling for the admin percent sliders to the management CSS which also has some stuff for the new ban page, which I might as well commit the styling for while I'm at it. This is all still not finished, mind. (Admin.template.php, mana.css, ban_items.png)
----
Modified : /trunk/Themes/default/Admin.template.php
Added : /trunk/Themes/default/images/admin/ban_items.png
Modified : /trunk/Themes/default/skins/mana.css

Nao

  • Dadman with a boy
  • Posts: 16,082
Re: New revs
« Reply #1799, on December 16th, 2012, 03:34 PM »
rev 1799 -- working on committing a larger rev right now.
(2 files, 3kb)

+ Saving a few bytes on CSS cached files where a path calculated through a global var like $here or $images could be longer than needed (like/this../../). (Subs-Cache.php)

! Take into account the user's OS when caching CSS files (re: an upcoming huge commit.) However, this is a bit buggy so I'm only committing this until I decide whether or not I should keep CSS file suffixes this way. Because of the difference in filename handling, it seems best to drop support for hasBrowser-based suffixes, and instead relying on @if/@is statements inside the files themselves. They're probably better off as tests inside the files only. (Subs-Cache.php)

* A quick note in BB rules for Pete to read mostly... Feel free to remove it if I'm mistaken. (Security.php)