New revs
Plugin revs »

Nao

  • Dadman with a boy
  • Posts: 16,082
Re: New revs
« Reply #1710, on September 24th, 2012, 10:05 AM »
rev 1710
(1 file, forgot to see the size)

* Reverted id_group database size to smallint(5) signed instead of mediumint(8) unsigned. This is mainly because I've decided to use contact lists for privacy, instead of custom membergroups, so in the end we should have no need for high IDs for membergroups. Probably to keep it in style with the SMF changelogs. (install.sql)

! Fixed member blurbs holding broken HTML by at least temporarily setting them to a size of 500 instead of 255. I know, it takes an extra byte in the database... But hey, I just saved one by reverting the id_group size, so don't complain too much! (install.sql)

* Renamed the (unused) thought_privacy table to privacy_thought, and added privacy_boards and privacy_topics tables as well. Their structure is only temporary -- privacy_id should probably be signed, and boards don't need a 'group' privacy type, but whatever... At least it's committed somewhere and it can be changed as long as it's not implemented, can't it..? (install.sql)

@ Starting from now, I'll be adding more whitespace to SVN logs, just like in the wedge.org topic... I'm not exactly sure why I kept it tight for so long.
Re: New revs
« Reply #1711, on September 24th, 2012, 10:12 AM »
rev 1711 -- because I really should be committing smaller updates instead of mindlessly packing everything together...
(2 files, 1kb)

* id_post_group is always going to be unsigned... Make it clear in the DB. (install.sql)

* Added a comment for help icons. Just saying how to replace them with a clean HTML entity... Not that I'm going to ship it by default. By I'll consider it for my own sites. (sections.css)

Arantor

  • As powerful as possible, as complex as necessary.
  • Posts: 14,278
Re: New revs
« Reply #1712, on September 24th, 2012, 01:21 PM »
(5 files, 3KB, just a quick one before other stuff happens that I need to go and do.)

Revision: 1712
Author: arantor
Date: 24 September 2012 12:20:43
Message:
! boardsAllowedTo wasn't returning arrays of things as expected. (Security.php)

! Disabled profile fields still visible in personal messages (thanks Emanuele) (PersonalMessage.php)

! Conversion of a few fopen/fwrite/fclose to file_put_contents. Smaller code, more readable, and doesn't necessarily have some of the nasty problems fwrite can have. (Class-GifAnimator.php, ManageRegistration.php, ManageServer.php)
----
Modified : /trunk/Sources/Class-GifAnimator.php
Modified : /trunk/Sources/ManageRegistration.php
Modified : /trunk/Sources/ManageServer.php
Modified : /trunk/Sources/PersonalMessage.php
Modified : /trunk/Sources/Security.php
When we unite against a common enemy that attacks our ethos, it nurtures group solidarity. Trolls are sensational, yes, but we keep everyone honest. | Game Memorial

Nao

  • Dadman with a boy
  • Posts: 16,082
Re: New revs
« Reply #1713, on September 24th, 2012, 06:23 PM »
rev 1713
(2 files, 1kb)

+ Added $head_font_style variable to enable skins to easily change the font style (or weight...) without changing anything else. Maybe I should do that everywhere uh...? (index.css)

* Minor improvements to Wuthering. (Wuthering/extra.css)
Re: New revs
« Reply #1714, on September 24th, 2012, 06:24 PM »
rev 1714
(2 files, 3kb)

+ Added support for @elseif in @if/@else/@endif statements in Wess. Basically, just like in any other high-level language, you can add any number of @elseif on the same tab level, but only one @else, and it has to be at the end (or not there at all). (Class-CSS.php)

! Because of the way 'content: "string"' was handled, having one inside an @if block could screw up the final outputted content. I'm afraid the fix is a bit slower than before, but I'd rather not take my chances. The same problem exists for protected comments, but there's absolutely no reason to have them inside @if blocks, so no time to waste on that. (Class-CSS.php)
Re: New revs
« Reply #1715, on September 25th, 2012, 10:27 AM »
rev 1715 -- variable tests!!
(5 files, 8kb)

+ Added support for variable tests. Surprisingly, I managed to implement variable tests into @is (inline ifs), in addition to my original target, @if. (Class-CSS.php, Subs-Cache.php)

@ Anyway -- this feature was a bit tricky to implement, and I'm not sure of its solidity although I spent many hours testing it. Don't try funny things with it, it just allows for basic boolean tests mostly for mixin use, so don't use quotes where not needed, and stick to ==, !=, <, >, and $var (true) and !$var (false) tests.

+ Allow for mixins to provide parameters without a default. It's the equivalent of setting it to '' (empty), really. (Class-CSS.php)

! Fixed multi-line mixins that were incorrectly indented when added through the 'mixes' keyword. (Class-CSS.php)

! Fixed passing parameters through the 'mixes' keyword, e.g. #id mixes mymixin ('hello, world!'). (Class-CSS.php)

* Updated the mixin sample to showcase the latest changes. (index.css)

* Minor CSS fixes/optimizations. (sections.css, Wuthering/extra.css)
Re: New revs
« Reply #1716, on September 25th, 2012, 10:46 AM »
rev 1716
(2 files, 2kb)

! Fixed Wess functions width() and height(), and dynamic admin menu icons, to all accept direct URLs. (Class-CSS.php, Subs-Cache.php)

@ Tested on the Topic Solved plugin only... Hopefully works everywhere. Hey Pete, did you empty the error log recently here..? I thought it had 17 errors last I'd seen...

Arantor

  • As powerful as possible, as complex as necessary.
  • Posts: 14,278
Re: New revs
« Reply #1717, on September 26th, 2012, 01:46 AM »
(1 file, 2KB)

Revision: 1717
Author: arantor
Date: 26 September 2012 00:44:35
Message:
! SMF bug: PayPal paid-subs module has HTTP/1.0 connection details if using fsockopen to handle the connection, but after Feb 1, 2013, PayPal will not accept them. I've taken the liberty of rewriting it using the WebGet class, too. However, I HAVE NOT TESTED IT. I see no reason why it shouldn't work, but treat it with the care it deserves. (Subscriptions-PayPal.php)
----
Modified : /trunk/Sources/Subscriptions-PayPal.php

@ The main reason I haven't tested it is because while I have an account that is PayPal capable, I can't pay for a subscription myself with my own account and I refuse to expect others to pay to test it on a site of mine, if that makes sense.
Re: New revs
« Reply #1718, on September 26th, 2012, 04:26 AM »
(3 files, 2KB)

Revision: 1718
Author: arantor
Date: 26 September 2012 03:25:18
Message:
! Bodged together the 'is this recurring' checkbox back on to the paid subs confirmation screen. It's about as inelegant as before but at least it works now. (Subscriptions-PayPal.php, Profile-Actions.php, ManagePaid.template.php)

! Amended the PayPal URL to be secure. No reason for it not to be. (Subscriptions-PayPal.php)
----
Modified : /trunk/Sources/Profile-Actions.php
Modified : /trunk/Sources/Subscriptions-PayPal.php
Modified : /trunk/Themes/default/ManagePaid.template.php

@ The changes to the subs modules today still mean it's broken for recurring. It's just slightly less broken in other ways now.

Nao

  • Dadman with a boy
  • Posts: 16,082
Re: New revs
« Reply #1719, on September 27th, 2012, 09:37 PM »
rev 1719
(2 files, 3kb)

! Fixed broken install process. (install.php)

! Fixed broken satellite CSS files -- they were compiled incorrectly because they no longer automatically include virtuals. (Class-CSS.php)
Re: New revs
« Reply #1720, on September 29th, 2012, 05:57 PM »
rev 1720 -- JS language strings! Thankfully there's a Revert button in case things go wrong... :P
(6 files, 7kb)

+ Added support for language caching inside JS files. Which, as you're going to see, can save a lot of bandwidth. Currently only applying it to the index template... (Subs-Cache.php, Load.php, index.template.php, script.js)

@ So, basically: just add a "@language index;" line somewhere in your JS file (if you need a language string in index.language.php), and then just use regular $txt['string'] right within your JS code. The string will always be escaped, so you don't need to surround it with quotes. If you need more language files, use "@language index, otherfile, ..." or use multiple @language keywords, your choice.

@ You can include plugin language files with "@language Author:Plugin:LanguageFile". The cache won't be flushed when they're modified, though, so you'll need to manually empty the JS cache folder. This is going to stay like that until Pete implements his planned 'language delta' feature.

! Fixed a minor error that is more a PHP bug than a Wedge bug to me... If you do strpos($string, $number), you'll apparently always get false even if $string does contain a string representation of $number. Anyway, that made cache flushing problematic in Wedge. (Subs-Cache.php)

* Casenazi. (PersonalMessage.language.php)
Re: New revs
« Reply #1721, on September 30th, 2012, 12:42 AM »
rev 1721
(2 files, 1kb)

* A bit of a risk I'm taking here, but I'm replacing the @media and @keyframes search code in Wess with a generic @[a-z]+ test, to support current and future @ blocks like the new @supports. Just making this part of a minor commit so I can easily revert if need be. (Class-CSS.php)

* Small tweak of the line-height in select boxes to ensure better vertical alignment in some browsers. (index.css)

Arantor

  • As powerful as possible, as complex as necessary.
  • Posts: 14,278
Re: New revs
« Reply #1722, on September 30th, 2012, 04:21 AM »
(11 files, 3KB)

Revision: 1722
Author: arantor
Date: 30 September 2012 03:19:31
Message:
! Stupid boardsAllowedTo bug. (Security.php)

! The this-user-is-being-ignored text should have the right cursor. (index.member.css)

! Crude hack for the installer to prevent it trying to cache during installation. (install.php, Subs.php)

! Remove base_theme support, as far as I know nothing is broken. (JSOption.php, Load.php, ManageServer.php, Profile-Modify.php, ScheduledTasks.php, Subs-Members.php, Themes.php)
----
Modified : /trunk/Sources/JSOption.php
Modified : /trunk/Sources/Load.php
Modified : /trunk/Sources/ManageServer.php
Modified : /trunk/Sources/Profile-Modify.php
Modified : /trunk/Sources/ScheduledTasks.php
Modified : /trunk/Sources/Security.php
Modified : /trunk/Sources/Subs-Members.php
Modified : /trunk/Sources/Subs.php
Modified : /trunk/Sources/Themes.php
Modified : /trunk/Themes/default/skins/index.member.css
Modified : /trunk/other/install.php

I'm open to suggestions about improving the installer hack stuff, by the way.

Nao

  • Dadman with a boy
  • Posts: 16,082
Re: New revs
« Reply #1723, on October 1st, 2012, 11:25 PM »
rev 1723 -- a bigger one is coming up.. :)
(1 file, 1kb)

* <we:block> blocks already imply rounded corners, no need to all .wrc to their class list. Really. (Who.template.php)

! Fixed credit list padding hack that wasn't properly triggered. (Who.template.php)
Re: New revs
« Reply #1724, on October 1st, 2012, 11:28 PM »
rev 1724
(4 files, 13kb)

* The homepage is now consistent between recent and random items. (Media.template.php, media.css)

* The homepage, album pages and item comments will now show sorting options in select boxes. It was a pain to rewrite, but hopefully it's worth it... -_- (Aeva-Gallery.php, Media.template.php)

* URLs should be better formed when sorting. (Aeva-Gallery.php, Subs-Media.php, Media.template.php)

* And more media tweaks I won't bother to list.
Plugin revs »