New revs

Arantor

  • As powerful as possible, as complex as necessary.
  • Posts: 14,278
Re: New revs
« Reply #1605, on June 3rd, 2012, 04:04 AM »
(3 files, 2KB)

Revision: 1605
Author: arantor
Date: 03 June 2012 03:03:54
Message:
! SMF bug: The anti-spam tests should be properly case-insensitive, not partially, i.e. should be UTF-8 aware when lower-casing. (Subs-Editor.php)
! Provide a more meaningful default for timezone than 'the first on the list' and if there's an error at registration actually remember the one the user picked when re-displaying the form. (Register.php, Register.template.php)
----
Modified : /trunk/Sources/Register.php
Modified : /trunk/Sources/Subs-Editor.php
Modified : /trunk/Themes/default/Register.template.php
When we unite against a common enemy that attacks our ethos, it nurtures group solidarity. Trolls are sensational, yes, but we keep everyone honest. | Game Memorial

Nao

  • Dadman with a boy
  • Posts: 16,082
Re: New revs
« Reply #1606, on June 3rd, 2012, 11:15 PM »
rev 1606
(12 files, 6kb)

* In the admin area, integer-type settings will now automatically have a 'min' value of 0 if nothing is set. (ManageAttachments.php, ManageNews.php, ManageSettings.php, Admin.template.php)

! scandir() could cause some errors when working with non-existent skins. It shouldn't happen, but in case someone bookmarked an old skin of yours that you deleted in the meantime, this could have been happening... (Subs-Cache.php)

! Fixed headers in help popups. (Errors.template.php, script.js)

! Fixed a mismatched anchor tag. Also translation. (Admin.language.php, ManageSettings.french.php)

* Code cleanup. (ManageMembers.php, Subs-Editor.php)
Re: New revs
« Reply #1607, on June 4th, 2012, 12:49 AM »
rev 1607
(3 files, 2kb)

! Fixed and harmonized thought sending's Ajax return HTML. (Ajax.php, Xml.template.php)

! Fixed target styling in thought threads. (sections.css)
Re: New revs
« Reply #1608, on June 5th, 2012, 09:41 AM »
rev 1608
(19 files, 2kb)

! SMF bug: a 'replace' DB query shouldn't use the 'order by null' optimization. Fixed by Pete! (Class-DB.php)

! IP logger should ignore duplicates on insertion (race condition). (QueryString.php)

* Harmonized wesql::insert('insert') to wesql::insert(''), like most calls. (install.php, Like.php, ManageMembergroups.php, ManagePaid.php, ManagePermissions.php, ManageSearchEngines.php, Poll.php, Post2.php, Profile-Modify.php, ScheduledTasks.php, Security.php, Subs-Boards.php, Subs-Members.php, Subs-Post.php, Subs-Scheduled.php, SSI.php)

Arantor

  • As powerful as possible, as complex as necessary.
  • Posts: 14,278
Re: New revs
« Reply #1609, on June 8th, 2012, 02:31 AM »
(3 files, 3KB)

Revision: 1609
Author: arantor
Date: 08 June 2012 01:31:22
Message:
! Anti spam Q&A should be bbc parsed. (Subs-Editor.php)

! The logic for highlighting rows should not be entirely down to the template, in case plugins want to override it. This way the list of classes is set in the core but the skin is free to decide how to show it. *shrug* I needed this for a plugin, shoot me. (MessageIndex.php, MessageIndex.template.php)
----
Modified : /trunk/Sources/MessageIndex.php
Modified : /trunk/Sources/Subs-Editor.php
Modified : /trunk/Themes/default/MessageIndex.template.php

Nao

  • Dadman with a boy
  • Posts: 16,082
Re: New revs
« Reply #1610, on June 8th, 2012, 02:32 PM »
rev 1610
(5 files, 4kb)

! A feed setting wasn't correctly set to integer. (ManageNews.php)

! References to deleted parent thoughts would link to a non-existent profile. (Thoughts.php)

! Fixed table width (which was incorrect when only short lines were found), in error log's source code popup. (Errors.template.php)

+ Implemented latest thoughts for all members (as opposed to the existing code for a specific member), and rewrote the homepage code to point to that instead. (Home.php, Thoughts.php, Thoughts.template.php)
Re: New revs
« Reply #1611, on June 10th, 2012, 12:39 PM »
rev 1611
(7 files, 4kb)

+ Added default Wireless support for Samsung and HTC devices that don't provide a generic mobile string. HTC is very unlikely to fail on fail, so it's probably overkill. (Class-MoDe.php)

+ Added a new easing type for jQuery animations, 'out', which is basically a size-optimized version of easeOutExpo from jQuery UI/jQuery Easing. I like my code short and easy to compress, thank you very much. (script.js)

+ Re-implemented my popup animation for help icons, using the out easing. Yeah, that's really the only thing that satisfies me when animating large areas. Overall code adds 60 bytes but it can and should be used in other areas as well. (script.js) :edit: just 55 bytes, actually...

* Don't bother showing a page index in the thought list if no thought is available. (Thoughts.template.php)

! Forgot to redirect the profile thoughts page to the renamed function. (Profile.php)

! If a menu was destroyed before showing it (there's only one reason it should happen: area not found in the profile section -- uh, like the bug I just mentioned), Wedge would cause an error later. (GenericMenu.template.php)

! Chrome sometimes seems to ignore linebreaks with a clear class. Odd. Replaced that specific occurrence with a div that does the same. (Credits.php)

! Fixed padding in quick reply boxes. (sections.css)
Re: New revs
« Reply #1612, on June 12th, 2012, 12:11 AM »
rev 1612
(3 files, 2kb)

! Fixed admin internal search when going through arrays (e.g. numbered strings). (Admin.php)

! Fixed some html_to_bbc calls that weren't using the wedit object. (Aeva-Gallery.php, Aeva-Gallery2.php)
Re: New revs
« Reply #1613, on June 12th, 2012, 02:39 PM »
rev 1613
(9 files +4-2, 5kb)

* Replaced the new animation easing function (out) with a simpler one (sqr) which is also more realistic, while still putting the emphasis on the latter end of the animation. Saves a dozen bytes. Also made a funny-looking optimization to weToggle that saves a whopping one byte. I spent at least 10 minutes on that, so let me commit it. (script.js)

! As threatened earlier, I split the split code in two. SplitTopics.php is now Split.php and Merge.php, and same for the template. (index.php, xml/detailed-version.php, QuickMod.php, SplitTopics.php, Subs-Post.php, SplitTopics.template.php)

! Some 'pas si formidables' French translations. (Admin.french.php, ManageSettings.french.php)

! SMF 'bug': useless code. Was changed from SMF 1.1 and never updated in SMF 2.0 Final. (Search2.php)

* Spacinazi. (ManageMembers.template.php)
Re: New revs
« Reply #1614, on June 13th, 2012, 11:58 AM »
rev 1614
(18 files, 33kb) (oddly, my last 'big' commit was exactly a month earlier, day to day.)

+ (Finally) added support for multiple group badges and ability for admins to determine (1) what group titles to show under user names (set it up in the Manage Membergroups area, Settings section), (2) what groups can show a badge and in what conditions (set it up in the individual membergroup settings pages, although as of now I have yet to write a proper UI for that one, but it works when done through the DB.) (install.sql, Display.php, Load.php, ManageMembergroups.php, PersonalMessage.php, Display.template.php, PersonalMessage.template.php, Help.language.php, ManageMembers.language.php, Themes.language.php)

+ Added permission for posting thoughts, and some related code. (install.sql, Load.php, ManagePermissions.php, index.template.php, ManagePermissions.language.php)

+ Added a 'userbox' custom loadMemberData set, used for topic pages. Also sorted the various sets to (more easily) spot the differences between them. Removed a few unused requests like group colors (done differently now.) (Display.php, Load.php)

+ Added hints for search engines in the language links (uses the country code and HTML5-sanctioned markup.) (Load.php, index.template.php)

* Don't bother saying "Hello, guest" when you don't even provide a login box in that section... (index.template.php)

* $context['first_new_message'] will now be used to link the anchor to the topic title if the topic is entirely unread, or the first unread post otherwise. (Display.php, Display.template.php)

! A missing function was causing AeMe to fail some maintenance tasks. (ManageMedia2.php)

* Commenazi. (Display.php)
Re: New revs
« Reply #1615, on June 13th, 2012, 12:30 PM »
rev 1615
(5 files, 5kb) (didn't do these on purpose...)

+ Added support for viewing all posts made by a single guest when clicking their name in topic pages. (Profile-View.php, Profile.php, Profile.template.php)

+ Adopting the sqr animation easing type by default. If you need to use swing, just specify 'swing2' as the easing. Tweaked menu animations to remain visible, as sqr is quite nice for 'big' animations but makes smaller animations barely visible. Finally, optimized more code. Saves another few bytes all in all. (script.js)

! The contextual tab menu code provided for custom URLs being used, but the original code didn't actually provide it with these URLs in the first place... (GenericMenu.template.php)
Re: New revs
« Reply #1616, on June 14th, 2012, 09:42 PM »
rev 1616
(6 files, 12kb)

* Some tweaks to the Wuthering layout and styling. Nothing biggy but... Oh, well, it's actually bigger than planned, with a few fixes along the way. (index.css, sections.css)

* Rewrote the WeCSS parser to accommodate for commas inside selectors, e.g. :not(.this, .or, .that) or input[title,lang]. Very happy with this much-needed rewrite... Yay, champagne. (Class-CSS.php)

! Fixed selector sorting as well. Now everything should be properly sorted. It's not going to save more than a couple of bytes in the final gzipped file, but at least it's cleaner. Also, this allowed me to finally get rid of duplicate selectors without the need to actually clean up CSS inheritance, e.g. having multiple inheritance from two classes that also inherit another common class won't duplicate your base class by as many classes as found. If you don't understand anything, it's all right, I'm just trying to sound smart. What did I say already? Oh, just look at .postbg2, I built my fix on that... (Class-CSS.php)

! Fixed @import grammar. As indicated in the comments, I still wouldn't recommend using these, as Wedge provides alternative solutions that don't force you to push your @import to the first file in the list. Maybe later I'll implement some mechanism to import local files directly inside a file, like Sass does. (Class-CSS.php)

! Fixed use of colons (:) inside url files, e.g. @import url(googlewebfontURL:400,700). Well, didn't I just say not to use @import?! Oh, me and my obsessions... (Class-CSS.php)

! Fixed undefined index error in profile thoughts. (Profile.php)

! Preventing the flow control 'replace' keyword from appearing in final CSS filenames. (Subs-Cache.php)

* Documented wedge_cache_css_files() params, and replaced the plugin-oriented param with a more generic variable array that can do the same and more. (Subs-Cache.php)

! Older Android webkit versions don't support box-sizing without a prefix. (Subs-Cache.php)

! The checkmark in the skin selector wouldn't always show up, so ensured it would always use a basic sans-serif font. This increases chances that it'll be available. (Themes.template.php)
Re: New revs
« Reply #1617, on June 15th, 2012, 01:44 PM »
rev 1617
(15 files, 7kb)

! Fixed thought permission to use the security functions to disable itself for muted members, instead of doing it through a hack... (Load.php, Security.php, index.template.php)

* Replaced all remaining italic tags with emphasis tags. I'm trying to keep the i tag to the smiley code, really. (other/ssi_examples.php, Aeva-Gallery2.php, Who.php, Help.language.php, ManageMedia.language.php, Media.language.php, Who.english.php)

+ Added a hackish representation of the $actions array for moderators in the Who's Online page. I'd rather print out the full URL as visited, but it's not possible with the current structure of the log table. Noisen.com has a special field which stores just that -- would it be worth doing the same? (Who.php)

* Who's Online page showed (to admins) hidden members with a 'hidden' class, which was never defined. Since the homepage shows them with a hardcoded em tag, doing the same here instead. (Who.template.php)

* Spellcheck translation was too long in French, making for ugly buttons... Settled for 'Orthographe', which is understandable enough for me. (index.french.php)
Re: New revs
« Reply #1618, on June 15th, 2012, 02:17 PM »
rev 1618
(3 files, 3kb)

+ Leave topic prefixes out of the links. Been in use for some time on wedge.org now, without any issues. I'm not convinced it's for the better (a page-wide preg_replace is not always very fast), but I'd rather have this out now, can be improved later. My uncommitted file list is getting too long. (Subs-Template.php)

! Don't show a user's current action in their profile if they're hidden... Admins will still see the action, but in italics to show that the user is hidden. (Profile-View.php)

! Moderators could get some errors in Who's Online when a user was getting an error in the media area. Instead of moving the error messages from the Media to Error language files, which is a long and annoying task, let's just ignore this... All right? Do you still like me? (Who.php)
Re: New revs
« Reply #1619, on June 15th, 2012, 02:58 PM »
rev 1619
(9 files, 3kb)

! Replaced a few complex regexes applied to htmlspecialchars, with a simple westr::htmlspecialchars, which as it happens, does exactly the same thing internally... Hopefully this won't break anything (I'm looking at the login form mostly!) (Display.php, Login2.php, ManageAttachments.php, SSI.php)

! Fixed some double backslashes in regexes here and there. Well, they didn't do anything unexpected, but it's cleaner to avoid escaping stuff that doesn't need it. (install.php, Register.php, Subs-Auth.php, Subs-Members.php)

! Search results would break when meeting an entity in the body. Basically, westr::entity_fix shouldn't be called through an eval but a callback instead, ensuring it sends an array. But anyway, I replaced that ugly call with a simple call to westr::entity_clean which does the same... (Search2.php)