New revs
Plugin revs »

Nao

  • Dadman with a boy
  • Posts: 16,082
Re: New revs
« Reply #1530, on March 31st, 2012, 07:11 PM »
rev 1530
(4 files, 1kb)

- Since we're not going to ship package support in Wedge, removed $context['uninstalling'] from related Aeva Media code. Also removed some duplicate code. (Aeva-Embed.php, Subs-BBC.php)

* Moved the footnote parser to its own function, it's cleaner that way and avoid creating a new lambda function for every call to parse_bbc(). (Subs-BBC.php)

- Forgot to commit the ;desc removal for error logs in a file. (Subs.php)

* French translation. (index.french.php)

@ One commit left to get our 300 for the quarter... :P I'm off for now.

Arantor

  • As powerful as possible, as complex as necessary.
  • Posts: 14,278
Re: New revs
« Reply #1531, on March 31st, 2012, 08:06 PM »
(2 files, 665 bytes, that's what it told me anyway)

Revision: 1531
Author: arantor
Date: 31 March 2012 19:03:12
Message:
! Sync internal BB implementation to BB 2.2.2's ruleset (the ones we're actually using, anyway) (Security.php)
! Fix, hopefully once and for all, CIDR matching system. (Subs.php)
----
Modified : /trunk/Sources/Security.php
Modified : /trunk/Sources/Subs.php

@This should fix latent issues we've had with MSN being blocked. Note that the code does accept IPv6 CIDR blocks, but won't accept subnets larger than 64 bits for matching purposes, which is how IPv6 is structured anyway, so something like ::ffff:0:0:0:0/96 won't work for matching (but it's not supposed to as far as I understand it, even though /128 is valid you'd never use it where CIDR matching occurs)
When we unite against a common enemy that attacks our ethos, it nurtures group solidarity. Trolls are sensational, yes, but we keep everyone honest. | Game Memorial

Nao

  • Dadman with a boy
  • Posts: 16,082
Re: New revs
« Reply #1532, on April 2nd, 2012, 05:13 PM »
rev 1532
(3 files, 4kb)

! The auto tag splitter was broken. Again, oops. (post.js)

! Fixed the indenazi generator. Although it's technically okay to do auto-indenting in most places, some tags will behave differently like 'pre' and 'textarea'. So I decided to go for a preg_replace instead of a str_replace (thankfully it's barely twice slower, which means it's still ultra-fast), and making sure that only lines starting with a tag are indented. It may not help with pre, but it'll help with textarea. (Subs-Template.php)

* Saved about 350 gzipped bytes for guest page loads by optimizing the sha1 file. It has an awful lot of code that never gets used anywhere, mostly the base64 and string encoding functions. Also optimized some of it, while I was at it... (sha1.js)
Re: New revs
« Reply #1533, on April 2nd, 2012, 09:18 PM »
rev 1533
(4 files, 3kb)

* There's probably a more efficient way to do it, but I rewrote the CSS variable parser to allow for the use of other variables in $alphamix, rather than a hardcoded color. It's also faster than the previous implementation, as it now does a single str_replace on the entire file, instead of at least two. (Class-CSS.php, index.css, Warm/index.css)

! The "View Results" button was still showing even if in viewresults mode (i.e. haven't voted yet, but clicked that button.) (Display.php)
Re: New revs
« Reply #1534, on April 3rd, 2012, 01:07 PM »
rev 1534
(3 files -2, 2kb)

* Replaced grad40.png with a proper CSS gradient, as it's easy to make it compatible with IE. (grad40.png, grad40i.png, Wine/index.css)

! Fixed a small issue with plainbox classes. (index.css)

! Fixed hardcoded RSS URL. (Home.template.php)
Re: New revs
« Reply #1535, on April 3rd, 2012, 02:53 PM »
rev 1535
(2 files, 1kb)

! Fixed new thoughts being created instead of old thoughts being edited when a moderator wanted to edit someone else's thoughts. (Ajax.php)

! Fixed current board not being shown disabled in Move Topic list (in fact, it wasn't shown at all). Note to SMF devs: there's a bug either way. The source file generates a list of boards without the current one, and the template file shows boards, including the current one in disabled state. I'd recommend doing it like I did -- it's best to have the current board in the list, in case the user wants to move the topic to a sub-board. (MoveTopic.php)
Re: New revs
« Reply #1536, on April 3rd, 2012, 10:45 PM »
rev 1536
(3 files, 1kb)

* Minor optimizations to timeformat(). Most notably, logic dictates that the setlocale code block should only be executed when lang_capitalize_dates is set, because otherwise the 'tokens' are converted in the final strftime() anyway. This seems to make my call to timeformat() about twice faster overall. My guess is that the SMF team didn't realize that because the English version always goes through the loop anyway. (Subs.php)

+ Added yet another exception to the 404 error list. Any files starting with /Themes/default/images/ are probably remainders of an SMF install called by Google Cache or equivalent, and should be ignored. (QueryString.php)

! If a button's class is set but empty, a useless space will be added at the end of the class list... (index.template.php)
Re: New revs
« Reply #1537, on April 4th, 2012, 05:58 PM »
rev 1537
(10 files -1, 5kb)

* Downloading or viewing files stored in Aeva Media would either be very quick (static thumbnails) or as slow as it could be (full site + media area loading). Ensured that Wedge/AeMe never load more than necessary, i.e. skip loading the menu items. (Aeva-Gallery.php)

+ Added a canonical URL to the main media areas: homepage, album page and item page. (Aeva-Gallery.php)

- Removed 'About' section from Aeva Media. The default landing page is now the settings page. (Admin.php, Aeva-Gallery.php, Aeva-ModCP.php, ManageMedia.php, about.png, Admin.language.php, ManageMedia.language.php, ManageMedia.template.php)

! Some media admin areas still used we:title instead of we:cat. (ManageMedia.template.php)

! Fixed an oversight that broke Today/Yesterday. (Subs.php)
Re: New revs
« Reply #1538, on April 5th, 2012, 12:32 PM »
rev 1538
(4 files, 5kb)

! If the user chose to view PMs as conversations, their outbox would keep showing conversations instead of filtering their sent messages. (PersonalMessage.php)

! Fixed an odd undefined index in PMs, although I don't really know what could have caused it... (PersonalMessage.php)

! Harmonized help popups when opened as actual windows -- they were unreadable at this point. (Help.template.php)

* Simplifying is not always for the best. (PersonalMessage.french.php)

- A lone windowbg declaration. (Profile.template.php)
Re: New revs
« Reply #1539, on April 5th, 2012, 06:08 PM »
rev 1539
(3 files, 33kb -- really not that much work.)

* Increased opening speed of action/user menus. They look good, sure, but that shouldn't be at the cost of usability. Found a better compromise. (topic.js)

* Considering how using prototypes isn't too great for optimizing bytesize, re-ordered the JS weEditor object to be a single function. I can't rename everything to local variables because plugins may want to use some functions, or access some properties. I'll try to keep optimizing, so this is a work in progress. About 200 gzipped bytes saved for now. (editor.js, Class-Editor.php)

Arantor

  • As powerful as possible, as complex as necessary.
  • Posts: 14,278
Re: New revs
« Reply #1540, on April 6th, 2012, 01:39 AM »
(2 files, 2KB)

Revision: 1540
Author: arantor
Date: 06 April 2012 00:38:49
Message:
! If the user's password is too short when changing it from the profile area, do actually insert the minimum number of characters into the error. (Profile-Modify.php)

! Various IPv6 related fixes in the IP tracking area of the user profile. (Profile-View.php)
----
Modified : /trunk/Sources/Profile-Modify.php
Modified : /trunk/Sources/Profile-View.php
Re: New revs
« Reply #1541, on April 6th, 2012, 03:49 PM »
(1 file, 4KB)

Revision: 1541
Author: arantor
Date: 06 April 2012 14:48:55
Message:
! Merging posts should also merge their likes. (SplitTopics.php)
----
Modified : /trunk/Sources/SplitTopics.php

Nao

  • Dadman with a boy
  • Posts: 16,082
Re: New revs
« Reply #1542, on April 6th, 2012, 04:06 PM »
rev 1542
(3 files, 8kb)

* Moved Spellcheck button before the Draft button. (Class-Editor.php)

* Optimized editor code even more. Removed the aEventWrappers array (the only thing it brings is 'this' harmonization. Just use 'that' in your events to target the JavaScript object, and 'this' to target the HTML object.) Turned a few public functions private (assuming that plugins won't want to use them), removed this.opt (it's not used outside of editor.js really), fixed a bug when RTF isn't possible, the usual stuff. Saved about 260 extra bytes... (editor.js)

! Fixed font size in WYSIWYG mode. (editor.css)
Re: New revs
« Reply #1543, on April 6th, 2012, 06:37 PM »
rev 1543
(4 files, 6kb)

! Fixed spellchecker. To do this, I moved the main JavaScript file list building to a function of its own, weInitJS (seriously, feel free to rename it to something that looks like a standard...) This is because this code is skipped when the index template isn't loaded, which shouldn't ALWAYS happen -- e.g. the spellchecker. (Load.php, Post.template.php)

! Also fixed the 'Play again' link in Captcha, while I was at it. (Register.template.php)

* More editor size optimizations. Saved about 30 bytes or so by moving onComplete calls to their matching sendXMLDocument. (editor.js)

Arantor

  • As powerful as possible, as complex as necessary.
  • Posts: 14,278
Re: New revs
« Reply #1544, on April 6th, 2012, 08:43 PM »
(1 file, 2KB)

Revision: 1544
Author: arantor
Date: 06 April 2012 19:42:53
Message:
! Log BB hits even for admins. Also make the POST logging slightly more sane in the process. (Security.php)
----
Modified : /trunk/Sources/Security.php
Plugin revs »