New revs

Nao

  • Dadman with a boy
  • Posts: 16,082
Re: New revs
« Reply #1515, on March 28th, 2012, 10:03 PM »
rev 1515
(6 files, 3kb)

+ Added a ssi_recentTopicTitles function that does what it does: ssi_recentTopics, but *without* any preview, thus saving the server from having to parse plenty of posts when you don't plan to show their previews. (SSI.php, Home.template.php)

! Fixed Preview button forcing a full page reload because of broken JavaScript. (Post.template.php)

! Permissions admin page would show permission inheritance select boxes over two different lines, instead of just one per option. (admin.css, sections.css)

! Fixed long topic titles breaking layout in post headers. (sections.css)

* Spacinazi. (ManageSmileys.english.php)
Re: New revs
« Reply #1516, on March 28th, 2012, 10:47 PM »
rev 1516
(2 files, 2kb)

! Fixed random tag closers being added at the end of a post by preparsecode() if a self-closed tag starting with the same characters was found in it. For instance, the  self-closed tag was thought of as a [me] tag by wedit::fixNesting(), and a closing [/me] was added. Fixed by adding a clear separator at the end of the list of tags to be tested. (Class-Editor.php)

! Fixed undefined variable errors in Who's Online page if someone was visiting a gallery item page. This is due to that particular case being accumulated into an array to be treated later, when $data[$k] should always be treated in the loop because of the final str_replace(). Fixed by setting up a blank $data[$k] to begin with, and forcing plugins and AeMe to simply use array_merge() instead of array concatenation... (Who.php)

Arantor

  • As powerful as possible, as complex as necessary.
  • Posts: 14,278
Re: New revs
« Reply #1517, on March 29th, 2012, 12:22 AM »
(3 files, 1KB)

Revision: 1517
Author: arantor
Date: 28 March 2012 23:21:26
Message:
! When storing the contents of the BB log, reparse X-Forwarded-For to use proper IP address. (Security.php)
! Take the server time offset into account for the purposes of setting auto detect time, which should hopefully fix the reported bug. (Profile-Modify.php, Register.php)
----
Modified : /trunk/Sources/Profile-Modify.php
Modified : /trunk/Sources/Register.php
Modified : /trunk/Sources/Security.php
Re: New revs
« Reply #1518, on March 29th, 2012, 01:04 AM »
(2 files, 1KB)

Revision: 1518
Author: arantor
Date: 29 March 2012 00:03:39
Message:
! $settings was not in appropriate scope. (Subs-Cache.php)
! Spacinazi. Fixes errant /me formatting too. (install.sql)
----
Modified : /trunk/Sources/Subs-Cache.php
Modified : /trunk/other/install.sql
Re: New revs
« Reply #1519, on March 29th, 2012, 01:59 AM »
(2 files, 1KB)

Revision: 1519
Author: arantor
Date: 29 March 2012 00:58:35
Message:
! Fix for the board ordering in the boards table. (install.sql)
! Thoughts were using the wrong permissions for 'any', no such permission as 'moderate', since there's either 'moderate_forum' or 'moderate_board', and nothing else magically defines 'moderate' on its own. (Ajax.php)
----
Modified : /trunk/Sources/Ajax.php
Modified : /trunk/other/install.sql
Re: New revs
« Reply #1520, on March 29th, 2012, 02:13 AM »
(1 file, 1KB)

Revision: 1520
Author: arantor
Date: 29 March 2012 01:11:12
Message:
! There are times when the cached count of errors is not always updated (e.g. error generated then there's an immediate die() afterwards). For these cases, when re-entering the error log, check the current displayed count against the number found by the error log and update that cache appropriately. (ManageErrors.php)
----
Modified : /trunk/Sources/ManageErrors.php
Re: New revs
« Reply #1521, on March 29th, 2012, 02:13 AM »
(1 file, 1KB)

Revision: 1521
Author: arantor
Date: 29 March 2012 01:13:04
Message:
! Stupid mistake from previous commit that inverted the logic. (ManageErrors.php)
----
Modified : /trunk/Sources/ManageErrors.php
When we unite against a common enemy that attacks our ethos, it nurtures group solidarity. Trolls are sensational, yes, but we keep everyone honest. | Game Memorial

Nao

  • Dadman with a boy
  • Posts: 16,082
Re: New revs
« Reply #1522, on March 29th, 2012, 03:16 PM »
rev 1522
(6 files, 3kb)

! There was a remaining allowedTo('moderate') test in the Ajax file. (Ajax.php)

! Was determining a default $data[$k] too early, which caused profile pages to report unknown actions for offline users. (Who.php)

! Membergroup edit page wouldn't show the allowed board list. (ManageMembergroups.template.php)

+ Added a small note in the membergroup edit page, regarding setting the number of rank images to 1 to use a badge instead of stars. (ManageMembergroups.template.php, ManageMembers.language.php)

* Language fixes. (ManagePermissions.french.php)
Re: New revs
« Reply #1523, on March 29th, 2012, 11:29 PM »
rev 1523
(4 files, 1kb)

+ Added nofollow parameter to main menu entries, used for Login and Register links when the page is visited by a possible robot. (Subs.php, index.template.php)

+ Added no_index flags to the same pages. (Login.php, Register.php)

- Removed target parameter from main menu entries. I double-checked, and it's never been used anywhere. Which is quite a waste of time when you're testing for it in all sub-menu entries down to the third level... (index.template.php)

Arantor

  • As powerful as possible, as complex as necessary.
  • Posts: 14,278
Re: New revs
« Reply #1524, on March 30th, 2012, 12:13 AM »
(5 modified, 6KB)

Revision: 1524
Author: arantor
Date: 29 March 2012 23:12:06
Message:
! Add extra key to categories table. (install.sql)

! date_offset_get() requires something to be passed to it. (Profile-Modify.php, Register.php)

! State the maximum sizes for avatars when uploading or using external avatars. (Profile.template.php, Profile language file)
----
Modified : /trunk/Sources/Profile-Modify.php
Modified : /trunk/Sources/Register.php
Modified : /trunk/Themes/default/Profile.template.php
Modified : /trunk/Themes/default/languages/Profile.english.php
Modified : /trunk/other/install.sql

Nao

  • Dadman with a boy
  • Posts: 16,082
Re: New revs
« Reply #1525, on March 30th, 2012, 11:39 AM »
rev 1525
(6 files, 5kb)

! Fixed (actually removed and simplified) a malformed rtrim call in pretty_generate_url() that would systematically return an empty string for board URLs. (Subs-PrettyUrls.php)

! Fixed Wedge breaking the entire forum (by redirecting it internally to an empty board) if said pretty_generate_url() returned an empty string, for instance by entering only dashes as the board name. Or something like that. Now it will correctly name it 'b123' where 123 is the board ID. You can always change the URL later... (Subs-Boards.php)

* Shortened posting icons code below board lists. (Boards.template.php, sections.css, index.rtl.css)

* Homepage blurb update. (As a reminder, that file won't be in Wedge, only a shortened version inspired by it. I'm only taking advantage of the SVN server here :P) (Home.template.php)

Arantor

  • As powerful as possible, as complex as necessary.
  • Posts: 14,278
Re: New revs
« Reply #1526, on March 30th, 2012, 01:56 PM »
(5 files, 6KB)

Revision: 1526
Author: arantor
Date: 30 March 2012 12:55:20
Message:
! The Routine Maintenance page can now have extra items added to it, and the tasks are actually searchable now too. (Admin.php, ManageMaintenance.php, ManagePlugins.php, ManageMaintenance.template.php, Admin language file)
----
Modified : /trunk/Sources/Admin.php
Modified : /trunk/Sources/ManageMaintenance.php
Modified : /trunk/Sources/ManagePlugins.php
Modified : /trunk/Themes/default/ManageMaintenance.template.php
Modified : /trunk/Themes/default/languages/Admin.english.php

Nao

  • Dadman with a boy
  • Posts: 16,082
Re: New revs
« Reply #1527, on March 30th, 2012, 03:01 PM »
rev 1527
(6 files, 7kb)

+ Added a new helper function, add_replacement($from, $to). This allows you to quickly add a replacement request for the output buffer processor. This is executed right after <URL> is transformed the second time. Probably should add more entry points for the replacement, but that's what I needed right now. I'm a selfish bastard. I'm French, very simply. (Subs-Template.php)

+ I was always bothered by the 'PM inbox' page title, which is shown even in convo mode. Using the new add_replacement function to replace the page title with the last non-empty subject in the conversation mode list. There are probably cleaner ways to do this, but I'm off to the theater premiere of Saint Seiya Omega episode 1, and no one, let me repeat, NO ONE, is gonna make me miss a SINGLE SECOND of that. Perhaps I'll regret it. Perhaps I won't. Perhaps I bet with a friend that I'd insert a reference to Saint Seiya in the Wedge changelog. Perhaps not. (PersonalMessage.php)

* Translation and tweaks. (Admin.french.php, PersonalMessage.language.php, Profile.french.php)

Arantor

  • As powerful as possible, as complex as necessary.
  • Posts: 14,278
Re: New revs
« Reply #1528, on March 30th, 2012, 03:11 PM »
(4 files, apparently only 1KB)

Revision: 1528
Author: arantor
Date: 30 March 2012 14:09:59
Message:
! Some debugging code that should have been removed. (Admin.php)

! Profile area should now be using the timezone selector to handle dates. The old time offset is still internally set up but this is the main thing about rolling the UI out to people. Sorry it isn't very pretty, but it's the best I can do with this particular problem for now. (Load.php, Profile-Modify.php, index language file)
----
Modified : /trunk/Sources/Admin.php
Modified : /trunk/Sources/Load.php
Modified : /trunk/Sources/Profile-Modify.php
Modified : /trunk/Themes/default/languages/index.english.php

Nao

  • Dadman with a boy
  • Posts: 16,082
Re: New revs
« Reply #1529, on March 31st, 2012, 07:08 PM »
rev 1529
(2 files, 2kb)

! Intrusion log was showing logs in chronological order by default. (ManageErrors.php)

* Rewrote error log to use descending order by default, so we could avoid adding ;desc everywhere when even the alternative (now ;asc) was never offered in the UI. And yes, it also saves 5 bytes per page for admins, considering it's also in the main menu. What? (Admin.php, ManageErrors.php)