New revs

Nao

  • Dadman with a boy
  • Posts: 16,082
Re: New revs
« Reply #1470, on March 15th, 2012, 11:15 PM »
rev 1470
(6 files +2 -2, 9kb)

! Fixed posts getting wrong padding in non-Weaving skins. Can't believe no one reported that one... ;) (Wine/sections.css)

* Tweaked post backgrounds in Warm. Hmm, it's still no good at all. Warm is a skin that has the potential to be fantastic, but is hurt by my current lack of inspiration regarding non-pastel color palettes. Whatever. Also fixed sidebar's top padding, which was definitely too small. (Warm/index.css)

+ Replaced existing footer logos with two new logos that seem to prove popular. Also simplified footer CSS and removed two other recent logos which are unlikely to be used again. (webelow.png, webelowine.png, wedgetop.png, wedgebot.png, index.css, Wine/index.css, Warm/index.css, Wuthering/index.css)

* Tweaked styling for category headers in Weaving. I guess you can say I chickened out and decided to go for a more 'classical' styling. It still looks great though... Also commenazi. (index.css, sections.css)
Re: New revs
« Reply #1471, on March 15th, 2012, 11:18 PM »
And the final batch...

rev 1471
(8 files, 7kb)

! The Like button was being shown both outside and inside the action menu at the same time. (Display.php, Display.template.php)

* Modified Primary Membergroups helper text to explain some peculiarities of the feature. (Profile.template.php, Help.language.php, Profile.language.php)

+ Added documentation for the <replace> command in skin files. Disabled current replacement examples, because, well, we don't need them, it's really for admins to use... (Warm/skin.xml)
Re: New revs
« Reply #1472, on March 15th, 2012, 11:52 PM »
rev 1472
(2 files, 1kb)

! Install process was broken by minor changes on my side. And yes, I'm installing the public version of Wedge... Exciting eh? (install.php, install.sql)
Re: New revs
« Reply #1473, on March 16th, 2012, 01:07 PM »
rev 1473
(2 files, 1kb)

! The Thoughts table wasn't using Wedge conventions (default values etc). (install.sql)

! Footer logo was cut off if page generation stats were disabled. (index.css)
Re: New revs
« Reply #1474, on March 16th, 2012, 01:17 PM »
rev 1474
(5 files +1, 4kb)

* Updated blog layout to catch up with the board layout additions, and forced blog posts to show a neutral background instead of something reflecting the current post state. Readability, man. Anyone willing to turn that lonely style into a class? (MessageIndex.template.php)

* Fixed Wireless skin on iPhones. Should look good enough, now, and more importantly... Usable! I'll be on my iPod in half an hour, and gosh I'll be glad I wrote all of that crap. (Wireless/sections.css, Wireless/sections.iphone.css)

! Ironically, .smalltext class is sometimes bigger than regular text on the iPhone. Quick hack on that one... Probably needs more work. (index.iphone.css)

! ssi_recentTopics() wasn't returning the most recent topics, because of a silly optimization I shouldn't have made. (SSI.php)

! WebGet was using CURLOPT_HTMLHEADER instead of HTTPHEADER... Honestly, I don't know a thing about the WebGet file but I'm fixin' errors from my log ;) (Class-WebGet.php)
Re: New revs
« Reply #1475, on March 16th, 2012, 06:06 PM »
rev 1475
(3 files, 1kb)

* Various minor improvements to Weaving, based on actual use at wedge.org. Yay. (index.css, sections.css)

+ Added another hardcoded element for wedge.org -- this time I'm adding a @worg prefix to indicate that this needs to be put into a plugin or something. This one adds the revision number in the footer, taken from a rev.txt file in the default theme root folder. Obviously, this requires manually updating the file so I won't commit it (consultants, don't forget to add an empty rev.txt file to your folder if you don't want to see any errors.) Oh, now I want to use $GlobalRev$... How do I do that, already..?! (index.template.php)
Re: New revs
« Reply #1476, on March 16th, 2012, 10:58 PM »
The GOOD thing with the Wedge.org upgrade, is that now you guys can all follow whatever additions I made to Wedge, because they'll usually be reflected on Wedge.org... ;) Just check the revision number in the webpage footer to be sure.

rev 1476
(18 files, 8kb)

! The double-post merge button didn't show up in some situations... Scratch that, in *most* situations really, because of an inverted default value. Also updated subtext to mention the delay should be indicated in seconds. Eh, it might have been minutes, all right? (Display.php, Admin.language.php)

! Applying John's suggested hack to allow HTML inside macro options (like the logo param in the header macro.) Untested, but should work. (Load.php, Subs-Template.php)

! ssi_recentTopics() was always pointing to the last post, instead of the last unread post for members. (SSI.php)

* Tweaked Track IP page to allow for language strings to show the IP anywhere inside the string, rather than at the end. (Profile-View.php, Profile.template.php, Profile.language.php)

* I'm sure there's a reason why I added a line-break after the quick reply textarea. There must be. For that reason, I'm removing it to fix the current layout, and eagerly waiting the day I'll go 'doh!' and unfix it. (Display.template.php)

! Wrong hardcoded membergroup ID in the thought system. (index.template.php)

* Modified French version to use 'cookie' instead of 'témoin' most everywhere. I just fired up IE9 and noticed how Microsoft is saying cookie in French. Cookies are yummy, whatever country you're from. (Admin.french.php, Errors.french.php, ManageSettings.french.php)

* Now using Help icon instead of '?' character to link to help popups in the membergroup permission manager. (ManagePermissions.template.php)

- We don't need the 'Switch to Full Editor' button to be animated on page load... It's just a waste of energy. (topic.js)

! Ah, the joys of CSS specificity... A table cell with a left class should be left-aligned, even if its parent row has a center class or whatever. (index.css)

! Public thoughts could overflow when shown in Display userboxes. (sections.css)
Re: New revs
« Reply #1477, on March 17th, 2012, 01:18 PM »
My! Forgot to post this one...

rev 1477
(6 files, 4kb)

! Add Media button was still showing up even with the Media gallery disabled. (Class-Editor.php)

! I don't know what this $firstIndex business was all about, but it didn't work on blogs. Rewrote it to simply use min($messages), which will retrieve the old message ID in the list. That's bound to be the first message to show up, innit...? (Display.php)

+ Added the proper board index to the homepage, below latest topics and latest thoughts. As I said - it's just ten lines of code and not template edits... Über-cool. (Home.php)

! Removing tapatalk from 404 error logs. Seriously, we don't need to see that. Also transforming ampersand entities to regular ampersands. Hopefully that'll be enough to make some referrers browsable without edits. (QueryString.php)

* Changed ssi_recentTopics() so that it uses the topic's title, rather than the last post's. Also removed a duplicate id_topic field retrieval. I don't even know how that never generated a MySQL error...! (SSI.php)

+ Adding a Save class to the Pretty URL admin page's submit button. (Admin.template.php)

Arantor

  • As powerful as possible, as complex as necessary.
  • Posts: 14,278
Re: New revs
« Reply #1478, on March 17th, 2012, 02:23 PM »
(1 file, 3KB)

Revision: 1478
Author: arantor
Date: 17 March 2012 13:22:54
Message:
! Rewrite the IPv6 matching code, it should now work properly on addresses (as it actually predates the IPv6 implementation, it didn't actually match netblocks properly against the internal IPv6 encoding used.) (Subs.php)
----
Modified : /trunk/Sources/Subs.php
Re: New revs
« Reply #1479, on March 17th, 2012, 06:36 PM »
(2 files, 1KB)

Revision: 1479
Author: arantor
Date: 17 March 2012 17:36:21
Message:
! If you select remove-draft, it should not be resaved automatically. If you want to save a draft after all, that's what the save draft button is for. (post.js)
! There should be a link tree displayed when you're inside a category at least... (Boards.php)
----
Modified : /trunk/Sources/Boards.php
Modified : /trunk/Themes/default/scripts/post.js
When we unite against a common enemy that attacks our ethos, it nurtures group solidarity. Trolls are sensational, yes, but we keep everyone honest. | Game Memorial

Nao

  • Dadman with a boy
  • Posts: 16,082
Re: New revs
« Reply #1480, on March 17th, 2012, 08:06 PM »
rev 1480
(10 files, 4kb)

+ Added a blog class to help style blog posts. Styling the original post is as easy as reaching ".blog .first-post"... So I did just that to remove the background color and increase the font size. (Display.template.php, InfoCenter.template.php, sections.css)

! Fixed a gradient function issue that caused some browsers to show the fallback background color in addition to the gradient itself. Hopefully this won't break anything else, seems unlikely at least. (Class-CSS.php)

* Committing my latest changes to the Wedge.org homepage, including removing the roundframe classes and quick board list, and moving the slogan section right before the main title, because in my case I'm floating both and need this to be done this way. That's what I like about skins. You can perfectly decide to change the order later because it's all in a macro. (Home.template.php, index.template.php)

- Wedge was always showing an 'Awaiting approval' message next to attachments in Post pages, because it couldn't find the approval field that was removed earlier. (Post.template.php)

! Fixed smart quote splitter. (editor.js, post.js)

! Fixed thought form margin when replying to a thought. (index.member.css)

! Quick hack to make #board_list and .board_list both stylable... (sections.css)

@ Taking a break, the missus being back from her ski holidays and everything... And she's not glad that I'm on my PC :whistle:
Re: New revs
« Reply #1481, on March 18th, 2012, 06:39 PM »
rev 1481
(6 files, 6kb)

+ Added "Top liked posts" statistics to the Stats page. Yay. Nothing is cached for now, it's not out of complexity but because I'm not sure it's worth it. (Stats.php, Stats.template.php, Stats.language.php)

* Tweaked CSS for quickbuttons so that they can be used outside of ul tags. (sections.css)

! Shortcut BBCode like
  • was generating warnings as well as incorrectly handling outside trimming. (Subs-BBC.php)
! Fixed a Feed bug on requesting a Topic feed. I'm not sure where that one came from... (Feed.php)

* Spacinazi. (Class-UnitTest.php, Class-SFTP.php, Like.php)

Arantor

  • As powerful as possible, as complex as necessary.
  • Posts: 14,278
Re: New revs
« Reply #1482, on March 18th, 2012, 07:02 PM »
(1 file, 1KB)

Revision: 1482
Author: arantor
Date: 18 March 2012 18:01:25
Message:
! PM drafts were not always handled correctly, where users had permission but permission was not checked properly and was kicking them back when it shouldn't have been. (Subs-Post.php)
----
Modified : /trunk/Sources/Subs-Post.php
Re: New revs
« Reply #1483, on March 19th, 2012, 10:10 AM »
(1 file, 1KB)

Revision: 1483
Author: arantor
Date: 19 March 2012 09:09:38
Message:
! Warning template was using old JavaScript code, with some incorrect styling to boot. (Profile.template.php)
----
Modified : /trunk/Themes/default/Profile.template.php
Re: New revs
« Reply #1484, on March 19th, 2012, 11:20 AM »
(1 file, apparently so small a change, TSVN reckoned it was 0KB)

Revision: 1484
Author: arantor
Date: 19 March 2012 10:19:44
Message:
! Replies/views count could get misformatted in the message index. (MessageIndex.php)
----
Modified : /trunk/Sources/MessageIndex.php