New revs
Plugin revs »

Arantor

  • As powerful as possible, as complex as necessary.
  • Posts: 14,278
Re: New revs
« Reply #1455, on March 13th, 2012, 01:07 AM »
(4 files, 1KB)

Revision: 1455
Author: arantor
Date: 13 March 2012 00:06:56
Message:
! Tweaked the board layout markup a bit, removing the forced separator row and converting that to CSS, as well as breaking the single massive table into one table per category, with a div container around everything. This allows for styling everything as a single unit as was previously performed, as well as attaching styling for individual category units like I wanted to do with my Core revamp, as well as making markup more semantic. I don't think anything's broken, I fixed the style issues I found, which weren't many, though it's probably possible to rework the style code better than I did (Boards.template.php, *.css)
----
Modified : /trunk/Themes/default/Boards.template.php
Modified : /trunk/Themes/default/skins/Wine/sections.css
Modified : /trunk/Themes/default/skins/index.iphone.css
Modified : /trunk/Themes/default/skins/sections.css

@Sorry for the huge commit note for such a small change, but it was one I flagged up as being quite important in my little world...
Re: New revs
« Reply #1456, on March 13th, 2012, 02:07 AM »
(1 file, 1KB)

Revision: 1456
Author: arantor
Date: 13 March 2012 01:06:37
Message:
! Add support for subtexts in the settings-page integration, if you define a given 'item' as a setting, $txt['item'] will still be its main wording, but now $txt['item_subtext'] will be checked for, and if found will be used as a description under the main wording. (ManageSettings.php)
----
Modified : /trunk/Sources/ManageSettings.php
Re: New revs
« Reply #1457, on March 13th, 2012, 11:32 AM »
(13 files, 22KB)

Revision: 1457
Author: arantor
Date: 13 March 2012 10:31:19
Message:
! None of the settings should contain their footnotes as part of the main language strings now, where a subtext is defined it should be its own language string (so if we change markup from dfn in the future, we do it a fraction of the times we did before), which also means we get to remove a legacy piece of code while we're at it. (ManageAttachments.php, ManageMemberOptions.php, ManageNews.php, ManagePosts.php, ManageSearchEngines.php, ManageServer.php, ManageSettings.php, Admin+ManageSettings+Search language files)
----
Modified : /trunk/Sources/ManageAttachments.php
Modified : /trunk/Sources/ManageMemberOptions.php
Modified : /trunk/Sources/ManageNews.php
Modified : /trunk/Sources/ManagePosts.php
Modified : /trunk/Sources/ManageSearchEngines.php
Modified : /trunk/Sources/ManageServer.php
Modified : /trunk/Sources/ManageSettings.php
Modified : /trunk/Themes/default/languages/Admin.english.php
Modified : /trunk/Themes/default/languages/Admin.french.php
Modified : /trunk/Themes/default/languages/ManageSettings.english.php
Modified : /trunk/Themes/default/languages/ManageSettings.french.php
Modified : /trunk/Themes/default/languages/Search.english.php
Modified : /trunk/Themes/default/languages/Search.french.php
When we unite against a common enemy that attacks our ethos, it nurtures group solidarity. Trolls are sensational, yes, but we keep everyone honest. | Game Memorial

Nao

  • Dadman with a boy
  • Posts: 16,082
Re: New revs
« Reply #1458, on March 13th, 2012, 06:59 PM »
rev 1458
(12 files, 5kb)

+ Added support for skin options. This is, basically, what the <sidebar> option was about: a setting that's only used at templating time, so it should naturally belong in a wider structure, which is now $context['skin_options']... You can add any options you like, as long as you test for them in your templates. Remember that you'll have to test for empty() as well, because Wedge won't fill in the option for you if it isn't set. (Load.php, Aeva-Gallery.php, Subs-Cache.php, Display.template.php, Wine/skin.xml, Wine/Warm/skin.xml)

* Note: I also documented the upcoming <mobile> option. (Wine/Warm/skin.xml)

* Spacinazi (leftover tabs.) (Class-Editor.php, Class-WebGet.php, ManageModeration.php, ManageServer.php, ManageBoards.template.php, ManagePaid.template.php)

Arantor

  • As powerful as possible, as complex as necessary.
  • Posts: 14,278
Re: New revs
« Reply #1459, on March 13th, 2012, 11:06 PM »
(8 modified, 1 new, 21KB)

Revision: 1459
Author: arantor
Date: 13 March 2012 22:05:16
Message:
! Initial support for Liking posts, amongst other things. It's still woefully lacking, mind, but the very basic functionality (non AJAX like of posts) does work. (index.php, install.sql, Display.php, Like.php, Display.template.php, sections.css, index language file, *.png)
----
Modified : /trunk/Sources/Display.php
Added : /trunk/Sources/Like.php
Modified : /trunk/Themes/default/Display.template.php
Modified : /trunk/Themes/default/images/theme/quickbuttons.png
Modified : /trunk/Themes/default/languages/index.english.php
Modified : /trunk/Themes/default/skins/sections.css
Modified : /trunk/index.php
Modified : /trunk/other/images/quickbuttons-32bit.png
Modified : /trunk/other/install.sql

@ I added the images to the 32-bit version first, then indexed it and saved it over the standard one to get it smaller again, but it's not as efficient as it could be, I think >_>

Nao

  • Dadman with a boy
  • Posts: 16,082
Re: New revs
« Reply #1460, on March 14th, 2012, 12:41 AM »
rev 1460
(4 files, 12kb)

* Re-optimized quickbuttons.png, saved about 200 bytes. Increased gamma correction on like/unlike because the contrast was too high on bright backgrounds. (images/theme/quickbuttons.png, other/images/quickbuttons-32bit.png)

! Fixed skin option retrieval code, that's what happens to you when you focus on documenting a feature instead of testing it thoroughly... ;) (Subs-Cache.php)

! The theme selector is too restrictive when searching for skins. It should allow for skins that don't have an index.css file to begin with. (Themes.php)
Re: New revs
« Reply #1461, on March 14th, 2012, 12:52 AM »
rev 1461
(7 files +3, 14kb)

+ Added <mobile> option for skins. What it does right now is modify the post layout to show the userbox above the post, rather than next to it. Also, the userbox in mobile mode is simplified to: avatar, user name, user rank, post date, and action buttons. More importantly, the Quote and Modify buttons get moved to the Action menu to save some space. (Display.php, and most of the other files.)

+ Added support for 'like', 'unlike', 'quote' and 'modify' to the Action menu. (Display.php, index.language.php)

+ Added a new skin, Wireless (see the pattern in official Wedge skin names, eh?), which simply enables mobile mode and provides userbox styling, so that we don't have to style it in Weaving under a specificity of '.mobile'... Yeah, whatever. (skins/Wireless/*)

! In some rare situations, Wedge would not close the opening UL tag for action buttons. Not that it would break anything else than validation, though... (Display.template.php)

! Post classes would break in all situations (except for topic messages), because of a padding reset. I'm pretty sure I reset it for a reason, so it's likely that something else will break... If it does, well, I'll fix it again. Differently. (sections.css)

- Replaced $txt['reply_quote'] with just $txt['quote']. We're adding so many new strings to the index language files, might as well remove anything that doesn't really serve a point... (PersonalMessage.template.php, Profile.template.php, index.language.php)

Arantor

  • As powerful as possible, as complex as necessary.
  • Posts: 14,278
Re: New revs
« Reply #1462, on March 14th, 2012, 02:03 PM »
(7 modified, 4KB)

Revision: 1462
Author: arantor
Date: 14 March 2012 13:01:57
Message:
! OK, so my original plan of killing off Features and Options has been rethought to form General Options. The site's title is there now along with the site link (and a new magical option). (ManageServer.php, ManageSettings.php, index.english.php, Admin+index+ManageSettings language files)
----
Modified : /trunk/Sources/ManageServer.php
Modified : /trunk/Sources/ManageSettings.php
Modified : /trunk/Themes/default/index.template.php
Modified : /trunk/Themes/default/languages/Admin.english.php
Modified : /trunk/Themes/default/languages/Admin.french.php
Modified : /trunk/Themes/default/languages/ManageSettings.english.php
Modified : /trunk/Themes/default/languages/index.english.php

@ The 'magical' option isn't anything exciting, it just means that the forum title can now also be linked to the site URL given, should you want to do so. Another very common request foiled by 5 minutes of work in the core.

Nao

  • Dadman with a boy
  • Posts: 16,082
Re: New revs
« Reply #1463, on March 14th, 2012, 04:10 PM »
rev 1463
(6 files, 3kb)

* Replaced the Help icon with a white logo from our usual 'provider', Yûsuke Kamiyamane (bless you). Better contrast makes the ? sign more readable, and the color palette is closer to what we'd expect from Weaving. Opinions may vary regarding Wine, but we can always reupload an alternative version for it. Cherry on top: filesize is twice smaller... (images/helptopics.gif, admin.css, sections.css)

* French translation and fixes. (Help.french.php, index.french.php, ManageSettings.french.php)

@ Hopefully you'll like the new help icon :)

Arantor

  • As powerful as possible, as complex as necessary.
  • Posts: 14,278
Re: New revs
« Reply #1464, on March 14th, 2012, 04:52 PM »
(17 files, 3KB)

Revision: 1464
Author: arantor
Date: 14 March 2012 15:52:13
Message:
! Removed "Show open report count in forum header" from moderation center preferences, seeing how we don't use it and it's driven by the menu instead. Important: if you previously had moderation settings set, it's going to be broken, so make sure to either clean out mod_prefs in the members table, or at least strip the leading value from something like 1|npgrw|1 to npgrw|1. (ModerationCenter.php, Profile-Modify.php, Report.php, ScheduledTasks.php, Subs.php, ModerationCenter.template.php, ModerationCenter language file)

! Removed some duplicate settings pertaining to drafts and added a note to another area to indicate that there were related settings available. (ManagePosts.php, ManageSettings.php, ManageSettings language file)

! Language string clean up (ManagePosts.php, ManageSettings.php, ManageSmileys.php, Admin+ManageSettings+ManageSmileys language files)
----
Modified : /trunk/Sources/ManagePosts.php
Modified : /trunk/Sources/ManageSettings.php
Modified : /trunk/Sources/ManageSmileys.php
Modified : /trunk/Sources/ModerationCenter.php
Modified : /trunk/Sources/Profile-Modify.php
Modified : /trunk/Sources/Report.php
Modified : /trunk/Sources/ScheduledTasks.php
Modified : /trunk/Sources/Subs.php
Modified : /trunk/Themes/default/ModerationCenter.template.php
Modified : /trunk/Themes/default/languages/Admin.english.php
Modified : /trunk/Themes/default/languages/Admin.french.php
Modified : /trunk/Themes/default/languages/ManageSettings.english.php
Modified : /trunk/Themes/default/languages/ManageSettings.french.php
Modified : /trunk/Themes/default/languages/ManageSmileys.english.php
Modified : /trunk/Themes/default/languages/ManageSmileys.french.php
Modified : /trunk/Themes/default/languages/ModerationCenter.english.php
Modified : /trunk/Themes/default/languages/ModerationCenter.french.php

Nao

  • Dadman with a boy
  • Posts: 16,082
Re: New revs
« Reply #1465, on March 14th, 2012, 07:49 PM »
rev 1465
(4 files +1, 4kb)

! Inline events contained inside a link referring to <URL> were not being postponed. Also slightly optimized a preg_quote call. (Subs-Template.php)

* Updated Help icon again, this time in a reddish color that should work better across Weaving and Wine. (other/images/helptopics.png, images/helptopics.gif, Wine/sections.css)

* Translation. (ManageSettings.french.php)
Re: New revs
« Reply #1466, on March 14th, 2012, 08:08 PM »
rev 1466
(2 files, 1kb) -- not much, sorry! I just thought this needed committing...

! A few links to category IDs were pointing to somewhere else, thus not triggering the actual act of showing the category's board list... (Load.php, Subs-BoardIndex.php)

@ Made a mention that we need to fix the header logo bug... Anyone up for it? :P (Load.php)

Arantor

  • As powerful as possible, as complex as necessary.
  • Posts: 14,278
Re: New revs
« Reply #1467, on March 15th, 2012, 12:41 AM »
(1 modified, 1KB)

Revision: 1467
Author: arantor
Date: 14 March 2012 23:41:25
Message:
! Sorry Nao, I don't think you'll like this regex change much. But we need to make sure that canonical URLs do not get passed through the PHPSESSID injector, since prior to this, they were - which means PHPSESSIDs galore throughout the web, even with canonical URLs. Yes, SMF has this bug but too many people keep denying its existence without actually bothering to check. (Subs-Template.php)
----
Modified : /trunk/Sources/Subs-Template.php

Nao

  • Dadman with a boy
  • Posts: 16,082
Re: New revs
« Reply #1468, on March 15th, 2012, 08:45 AM »
rev 1468
(2 files, 10kb)

* Sorry Pete, I don't think you'll like this commit much. Replaced the Like and Unlike icons with Fugue versions, which are much better looking. Also fixed a few twisted pixels in the original and optimized quickbuttons sprite. New version is a few dozen bytes bigger, but it arguably looks better. (other/images/quickbuttons-32bit.png, images/theme/quickbuttons.png)
Re: New revs
« Reply #1469, on March 15th, 2012, 11:13 PM »
Note: I have 26 files to commit right now. I did my best to split them into several thematic commits.

rev 1469
(6 files +2, 30kb) (sic)

! Changed the current thought privacy system to use membergroups instead of random numbers. Later updates should restore fine-tuning on member level. (install.sql, Ajax.php, Profile-View.php, index.template.php, Home.php)

! The thought list in profile pages wasn't being parsed for inline BBC. (Profile-View.php)

! Hopefully temporary hack to fix thought privacy dropdown showing items in a random order in Opera and Chrome. Also added temporary code for use on Wedge.org. (index.template.php, script.js)

+ Added a new virtual membergroup, 'Everyone', to everyone's list of groups. Should make it easier to target everyone including primary membergroups. (Load.php)

+ Added Home.php and Home template, these are *temporary* files for use on Wedge.org only. The code will be moved to the Welcome.php file once it's stable enough and cleaned up (proper MVC model and so on). (Home.php, Home.template.php)
Plugin revs »