New revs
Plugin revs »

Nao

  • Dadman with a boy
  • Posts: 16,082
Re: New revs
« Reply #1305, on February 9th, 2012, 04:55 PM »
rev 1305
(207 files, 231kb)

* The musical chairs commit. $theme (a local variable) becomes $th, while $settings becomes $theme and $modSettings is renamed to $settings. This is because $modSettings never made sense, as it didn't represent "modification settings", but instead Wedge/SMF's general settings. (207 files, not gonna list any. Pretty much all PHP files in Wedge.)

- Removed unused oNewsFader declaration. (Boards.template.php)
Re: New revs
« Reply #1306, on February 9th, 2012, 05:53 PM »
rev 1306
(6 files, 4kb)

! Select box width and scrollbar position were incorrectly set on complex boxes. I have no idea why, but it was fixed 'simply' by moving the .width() outside of the command chain and into the following line, at a cost of zero byte. I suspect it's an issue with the wrapAll method. (sbox.js)

+ Added a data-self parameter to the thought list, allowing to determine whether Edit/Delete buttons should be shown next to a particular thought. Takes 12 more bytes but I saved another 5 by removing the whitespace on the thought HTML. It's not like I'm going to change it a lot anyway... (script.js)

* Moved the Aeva (auto-embedding) section just below the Smiley and Attachment/Avatar sections, because they're all about 'visual'. (Admin.php)

* Details. (media.css, Worg/index.member.css, Worg/sections.css)

Arantor

  • As powerful as possible, as complex as necessary.
  • Posts: 14,278
Re: New revs
« Reply #1307, on February 9th, 2012, 07:27 PM »
(3 added, 5 deleted, 15 modified, 48KB)

Revision: 1307
Author: arantor
Date: 09 February 2012 18:26:21
Message:
! First draft of the moderation filters code. The UI is hardly done (the show page works, as does the actual rules engine, but that's it). There is - very temporarily, I'll note - a big scary text box without a label in Security and Moderation - Anti Spam. This textbox is simply a textbox pointing at $settings['postmod_rules'] where the actual rules are stored, just so that I have somewhere to view and edit them (and that doesn't involve phpMyAdmin and forcing a cache flush), and once the UI is working, I'll remove this textbox. This change also removes the core features page, the post moderation secondary page and most of the code relating to post moderation configuration, with the exception of the permissions, and anything related to attachment approvals. Mostly this commit is just so that I have it in SVN and can work on the rest reasonably incrementally. (All files in this commit are directly related to these things.)
----
Modified : /trunk/Sources/Admin.php
Modified : /trunk/Sources/Load.php
Added : /trunk/Sources/ManageModeration.php
Modified : /trunk/Sources/ManagePermissions.php
Modified : /trunk/Sources/ManageSettings.php
Modified : /trunk/Sources/Post2.php
Modified : /trunk/Sources/PostModeration.php
Added : /trunk/Sources/Subs-Moderation.php
Modified : /trunk/Themes/default/Admin.template.php
Added : /trunk/Themes/default/ManageModeration.template.php
Modified : /trunk/Themes/default/ManagePermissions.template.php
Deleted : /trunk/Themes/default/images/admin/corefeatures.gif
Deleted : /trunk/Themes/default/images/admin/feature_pm.png
Deleted : /trunk/Themes/default/images/admin/post_moderation_allow.gif
Deleted : /trunk/Themes/default/images/admin/post_moderation_deny.gif
Deleted : /trunk/Themes/default/images/admin/post_moderation_moderate.gif
Modified : /trunk/Themes/default/languages/Admin.english.php
Modified : /trunk/Themes/default/languages/Admin.french.php
Modified : /trunk/Themes/default/languages/Errors.english.php
Modified : /trunk/Themes/default/languages/ManagePermissions.english.php
Modified : /trunk/Themes/default/languages/ManagePermissions.french.php
Modified : /trunk/Themes/default/languages/ManageSettings.english.php
Modified : /trunk/other/install.sql


(Yes, Core Features is NOW GONE FROM SVN :D And note that this is still a WIP so things can and will change.)
When we unite against a common enemy that attacks our ethos, it nurtures group solidarity. Trolls are sensational, yes, but we keep everyone honest. | Game Memorial

Nao

  • Dadman with a boy
  • Posts: 16,082
Re: New revs
« Reply #1308, on February 9th, 2012, 08:00 PM »
rev 1308
(13 files, 8kb)

* Translators are gonna hate me... While I was in the process of renaming all of  these variables, I decided I wanted to fix Aeva Media as well. Subtext entries were using different suffixes, such as _info, _sub, _subtxt, _subtext and _desc. Renamed them all to _desc, except for _info which isn't always for a subtext anyway. Also replaced all mg_subtext entries with the commonly used (in Wedge) dfn tag. It's important that the admin area looks the same everywhere. Now I just need to remove the alternating color stripes... Arg. Also, various tweaks here and there, nothing worthy of an individual mention though. (Aeva-Foxy.php, Aeva-Gallery.php, Aeva-Gallery2.php, ManageMedia.php, ManageMedia2.php, ManageMedia3.php, ManageMedia.template.php, Media.template.php, Media.language.php, ManageMedia.language.php, media.css)

Arantor

  • As powerful as possible, as complex as necessary.
  • Posts: 14,278
Re: New revs
« Reply #1309, on February 9th, 2012, 11:19 PM »
(5 modified, 2KB)

Revision: 1309
Author: arantor
Date: 09 February 2012 22:19:29
Message:
! Stupid bug from a missed $modSettings change. (Post2.php)
+ Regexp match on body/subject filter is more capable now, instead of just blindly searching for regexp matches, it's possible to separate out (for UI purposes, mostly) whether to match based on start/end/contained-by/full-match, and do that in a case sensitive or insensitive fashion. But full regexp is still available for complex cases. (ManageModeration.php, Subs-Moderation.php, ManageModeration.template.php, ManageSettings language file)
----
Modified : /trunk/Sources/ManageModeration.php
Modified : /trunk/Sources/Post2.php
Modified : /trunk/Sources/Subs-Moderation.php
Modified : /trunk/Themes/default/ManageModeration.template.php
Modified : /trunk/Themes/default/languages/ManageSettings.english.php

Nao

  • Dadman with a boy
  • Posts: 16,082
Re: New revs
« Reply #1310, on February 9th, 2012, 11:59 PM »
rev 1310
(9 files, 7kb)

+ Added the two new hooks to the known hooks list, and removed the old core features hook from it. I wasn't sure about the sections to file them in, so I did my best to make a guess. (ManagePlugins.php)
- Removed a few language entries that were left in. (Admin.language.php, ManageSettings.language.php)
+ French translation. The large block in ManageSettings is totally untested, hopefully I won't forget to actually test the feature, eh? (Admin.french.php, Errors.french.php, ManageSettings.french.php)
* Minor spacinazi and indenazi. (ManageModeration.php, ManagePlugins.php, Subs-Moderation.php, Who.php)

:edit: ManageSettings is missing more French entries, I did the work before rev 1309 was committed, so I guess I'll do it tomorrow, too tired now.
Posted: February 9th, 2012, 11:54 PM

:edit: 2 -- Subs-Membergroups.php:655 has a $GLOBALS on modSettings... Little bugger ;) I'll finish converting the rest of modSettings tomorrow.
Re: New revs
« Reply #1311, on February 10th, 2012, 12:01 PM »
rev 1311
(1 file +1 -1, 3kb)

! Finally, finally fixed the Opera issues with select box animations. Well, I couldn't let it slip, it's still my favorite browser after all. After hours of debugging, I noticed that all bugs would go away if moving the inline-block declaration from .sbox to .display, which is what I just did. Because I seem to remember having had bugs in other browsers when doing that, I won't tempt the devil, and instead add an index.opera.css file that does the job in two lines. Right? The other good news is that this allows me to remove an Opera hack in sbox.js and save another 5 gzipped bytes. (sbox.js, Worg/index.opera.css)

- Also removed a custom.css file that wasn't supposed to be there. Harmless, but it defeated the whole point of custom.css -- being able to upload yours without fear of a Wedge upgrade replacing it. Please hit me if I forget to remove it again when Worg becomes the top-level skin... Okay? (Worg/custom.css)
Re: New revs
« Reply #1312, on February 10th, 2012, 03:51 PM »
rev 1312
(3 files +1, 2kb)

+ Restored corefeatures.gif file, under the name settings.gif, because it was used by a couple other menu entries. (Admin.php, admin/settings.gif)

- Removed a couple of remaining CoreFeatures references. (Admin.php, ManageSettings.php)

* French translation. (ManageSettings.french.php)

Arantor

  • As powerful as possible, as complex as necessary.
  • Posts: 14,278
Re: New revs
« Reply #1313, on February 10th, 2012, 05:12 PM »
(41 files, 5KB)

Revision: 1313
Author: arantor
Date: 10 February 2012 16:12:13
Message:
! Minor typo in the moderation rules for 'matches' type matches. (Subs-Moderation.php)
! Attachments are no longer moderated on their own, but inherit the approval of the post they're attached to. As Nao says, if you want to have attachment approval, use the gallery. I *think* I got everything relating to attachment approvals and everything seems to work as expected at this point in time. (All the rest of the files in this commit.)
----
Modified : /trunk/SSI.php
Modified : /trunk/Sources/Display.php
Modified : /trunk/Sources/Dlattach.php
Modified : /trunk/Sources/ManageAttachments.php
Modified : /trunk/Sources/ManageModeration.php
Modified : /trunk/Sources/ManagePermissions.php
Modified : /trunk/Sources/ModerationCenter.php
Modified : /trunk/Sources/MoveTopic.php
Modified : /trunk/Sources/Post.php
Modified : /trunk/Sources/Post2.php
Modified : /trunk/Sources/PostModeration.php
Modified : /trunk/Sources/Profile-View.php
Modified : /trunk/Sources/RemoveTopic.php
Modified : /trunk/Sources/ScheduledTasks.php
Modified : /trunk/Sources/Security.php
Modified : /trunk/Sources/Subs-Moderation.php
Modified : /trunk/Sources/Subs-Post.php
Modified : /trunk/Sources/Subs.php
Modified : /trunk/Themes/default/Display.template.php
Modified : /trunk/Themes/default/ModerationCenter.template.php
Modified : /trunk/Themes/default/Post.template.php
Modified : /trunk/Themes/default/Profile.template.php
Modified : /trunk/Themes/default/languages/EmailTemplates.english.php
Modified : /trunk/Themes/default/languages/EmailTemplates.french.php
Modified : /trunk/Themes/default/languages/Errors.english.php
Modified : /trunk/Themes/default/languages/Errors.french.php
Modified : /trunk/Themes/default/languages/ManagePermissions.english.php
Modified : /trunk/Themes/default/languages/ManagePermissions.french.php
Modified : /trunk/Themes/default/languages/ModerationCenter.english.php
Modified : /trunk/Themes/default/languages/ModerationCenter.french.php
Modified : /trunk/Themes/default/languages/Post.english.php
Modified : /trunk/Themes/default/languages/Post.french.php
Modified : /trunk/Themes/default/languages/Reports.english.php
Modified : /trunk/Themes/default/languages/Reports.french.php
Modified : /trunk/Themes/default/languages/Who.english.php
Modified : /trunk/Themes/default/languages/Who.french.php
Modified : /trunk/Themes/default/languages/index.english.php
Modified : /trunk/Themes/default/languages/index.french.php
Modified : /trunk/index.php
Modified : /trunk/other/install.sql
Modified : /trunk/other/unittest/tests/Class-UnitTest_tidyhtml.php

Nao

  • Dadman with a boy
  • Posts: 16,082
Re: New revs
« Reply #1314, on February 10th, 2012, 05:57 PM »
rev 1314
(1 file, 4kb)

* Rewrote CSS cache handler to fill an array of elements for the filename, instead of building a string directly. I don't know why I did it that way, what with the regex hacks I had to go through... Hopefully, this should also fix a few bugs. (Subs-Cache.php)
Re: New revs
« Reply #1315, on February 10th, 2012, 10:13 PM »
rev 1315
(2 files, 1kb)

! A couple of last-minute changes to Subs-Cache actually broke it. That's what you get when you commit right before you have to leave... (Subs-Cache.php)

- Removed the final (hopefully?) remaining $modSettings, which was hidden because it's accessed through $GLOBALS. (Subs-Membergroups.php)
Re: New revs
« Reply #1316, on February 11th, 2012, 10:36 AM »
rev 1316
(18 files, 8kb)

* Replaced the new_icon class (language-specific new.gif) with a 'note' class that will do the same as in main menu notifications. Renamed $txt['menu_new'] to $txt['new_short'] (better contextual name), it may even go away entirely later. (media/Subs-Media.php, Profile-Modify.php, Subs.php, SSI.php, TEMPLATES: Boards, Display, GenericMenu, index, MessageIndex, PersonalMessage, Post, Recent, LANGUAGES: index, SKINS: Worg/index.css, Worg/index.ie9.css, Worg/sections.css)

- Removed remaining calendar references from a file that's likely to never be used at all. That's me. (upgrade.sql)

- Removed remaining attachment approval references. (index.language.php)

+ Added add_thought and edit_thought language strings, because the thought editor is on every single page, and I'd rather have semantically 'correct' entries for it. (index.template.php, index.language.php)

- Removed preview_new language string -- a single 'new' string does the job just as well. (Post.template.php, index.language.php)
Re: New revs
« Reply #1317, on February 11th, 2012, 10:55 AM »
rev 1317
(-2 folders, 1kb)

- Removed the english and french image folders. Since they're no longer used for now... Doing it as a separate commit to make it easier to revert later. (images/english, images/french)
Re: New revs
« Reply #1318, on February 11th, 2012, 11:45 AM »
rev 1318
(2 files, 2kb)

* Rewrote CSS prefix handler to be a bit more specific on each rule. Most notably, the previous version didn't correctly set up box shadows on IE9, it should at least fix that. (Subs-Cache.php)

* Detail. (Worg/index.css)


(And yes, it means I gave up on my nicely done little function to interact with every single browser version number. Although I could always publish it in the attic...)
Re: New revs
« Reply #1319, on February 11th, 2012, 04:06 PM »
rev 1319
(12 files, 3kb)

* Renamed modSettings cache key to settings, $txt['modSettings_title'] and $txt['modSettings_desc'] to 'settings_*', to avoid any possible confusion with the modsettings page (which will eventually go, since it's package-related.) Also removed the 'modSettings_info' text string, which AFAIK is not used anywhere, probably including SMF in. (upgrade.php, Admin.php, Load.php, ManageServer.php, ManageSettings.php, Subs.php, LANGUAGES: Admin, index, ManageSettings)
Plugin revs »