New revs

Nao

  • Dadman with a boy
  • Posts: 16,082
Re: New revs
« Reply #1035, on September 28th, 2011, 02:20 PM »
rev 1035
(7 files +2, 11kb)

+ Added a 'data' subfolder to the cache folder, to differentiate between data we might end up adding to the HTML (cached JS or CSS), from data that is solely for internal use (PHP cache). Also added an index.php handler, even if not needed, because we're never far away from a security issue. (cache/data/*)

+ Added a couple of media table keys that weren't correctly imported from the AeMe installer. (install.sql)

* Tweaked media CSS to allow for the item information column to be moved to the bottom if we don't have enough space on the right. (media.css)

! Fixed a few typos in the language files, and removed some outdated strings. (ManageAddons.language.php, ManageMedia.french.php, Media.language.php)
Re: New revs
« Reply #1036, on September 28th, 2011, 02:22 PM »
rev 1036
(11 files, 21kb)

+ Added an add_css() function to make it easier to add inline CSS at the very end of the headers. (Aeva-Embed.php, Aeva-Foxy.php, Subs-Media.php, Subs-Cache.php, Register.template.php)

* Cache manager will now use the data subfolder, and when asked, will touch the (less likely to be opened) Collapse.php file instead of Load.php. Because if you're developing Wedge and testing it on a local install, believe me, it's annoying as hell to see Notepad2 complain just because you left Load.php opened and it noticed its file date changed. What do you mean, you don't care? Did your mom tell you how rude you can be sometimes? Do you really deserve Wedge? Well... We'll see about it after you apologize. (Subs-Cache.php)

* Removed 'last_minute_header' hack, and instead rewrote everything to use $context['header'] and show it at the last minute, instead of via the index template. Also made the dynamic replacement ten times faster by using substr_replace instead of a regex. (Class-Editor.php, Aeva-Embed.php, Aeva-Gallery.php, Aeva-ModCP.php, Subs-Media.php, Subs-BBC.php, Subs-Cache.php, Subs-Template.php, index.template.php)
Re: New revs
« Reply #1037, on September 28th, 2011, 06:03 PM »
rev 1037
(3 files, 9kb)

+ Will now add the action list and 'do' to the forbidden board names when generating pretty URLs. (Subs-PrettyUrls.php)

! Reverted part of rev 362, where a bug in the auto-suggest code was fixed by introducing another one. Now, pressing Tab with no suggestion highlighted will still take the first valid match into account. I tried hard, but I wasn't able to reproduce the bug mentioned in rev 362, so... fingers crossed. (suggest.js)

! Fixed auto-suggest position after submitting an item (assuming we're going to submit more, obviously.) (suggest.js)

* Converted Foxy code to jQuery. (Aeva-Foxy.php)
Re: New revs
« Reply #1038, on September 28th, 2011, 11:41 PM »
rev 1038
(39 files, 27kb)

! get_boardindex hook didn't work as expected when not in include_categories mode. (Subs-BoardIndex.php)

* For consistency reasons, now using the official PHP syntax for variable referencing, i.e. "=&" instead of "= &". (38 files... Not listing them all. Not committing getid3 because it's version 1.7.9 and I need to update it to 1.9.1...)

* Commenazi. (Class-DBPackages.php)
Re: New revs
« Reply #1039, on September 29th, 2011, 01:27 PM »
rev 1039
(12 files, 18kb)

* Now caching the cache type for the lifetime of the PHP page. It also has the benefit of not doing strange things when a cache getter is enabled but a cache setter is disabled through php.ini, or things like that. Also optimized various areas of the cache. (Subs-Cache.php)

! This has got to be one of my best bugs in a long time. Last time I optimized the file cache code, I actually inverted a test, meaning that the caching logic was completely screwed up. Lulz!!1 (Load.php, Subs-Cache.php)

* Optimized getLanguages() to be a bit faster using glob() instead of scandir(), things like that. (Load.php)

* Always running getLanguages() for now. It takes a millisecond or so. Probably could use some optimization, but I'm going to be cool with that for now. Also centralized the test for isset($context['languages']) at the beginning of getLanguages(). (Load.php, ManageAddons.php, ManageBoards.php, ManageServer.php, Register.php)

- Removed $context['languages'][...]['selected'], as it's never used anywhere. (Load.php)

- Got rid of pointless features aeva_get_size() and max_dir_size. (Aeva-Subs-Vital.php, ManageMedia.php, Subs-Media.php, ManageMedia.language.php)

* aeva_get_num_files() actually did a recursive search when it only needed to get the current folder's number of files. Optimized 18 lines into 2. (Aeva-Subs-Vital.php)

* Upped maximum number of files in an album folder to 1500, once again. The common FTP limit for viewable files is 2000, and 1500 should allow for at least 500 items per folder, for a minimum of 250k avatars and attachments in the future system. Until we get to add an extra level of depth to the folder structure, of course. (install.sql)
Re: New revs
« Reply #1040, on September 29th, 2011, 09:18 PM »
rev 1040
(3 files, 6kb -- small one, but IE was its usual bitch with me.)

* Cache manager doesn't need to unset $val when it's not set in the first place... (Subs-Cache.php)

! Fixed mini-menus in both IE6 and IE7. IE6 requires hardcoding the width, so I chose 120px. Tough life. (index.ie6.css, index.ie7.css)
Re: New revs
« Reply #1041, on September 30th, 2011, 07:15 AM »
rev 1041
(39 files +5-5, 107kb)

* Renamed add-ons to plugins, as per the latest discussion on the matter.

/trunk/Addons
/trunk/Plugins
/trunk/Plugins/.htaccess
/trunk/Plugins/index.php
/trunk/Sources/Admin.php
/trunk/Sources/Class-DBPackages.php
/trunk/Sources/Credits.php
/trunk/Sources/Errors.php
/trunk/Sources/Load.php
/trunk/Sources/ManageAddons.php
/trunk/Sources/ManagePlugins.php
/trunk/Sources/ManageServer.php
/trunk/Sources/ManageSettings.php
/trunk/Sources/PackageGet.php
/trunk/Sources/Packages.php
/trunk/Sources/Profile.php
/trunk/Sources/ScheduledTasks.php
/trunk/Sources/Subs-Cache.php
/trunk/Sources/Subs-Package.php
/trunk/Sources/Subs-Post.php
/trunk/Sources/Subs-Template.php
/trunk/Sources/Subs.php
/trunk/Themes/default/ManageAddons.template.php
/trunk/Themes/default/PersonalMessage.template.php
/trunk/Themes/default/images/admin/addon_manager.png
/trunk/Themes/default/images/admin/addon_remove.png
/trunk/Themes/default/images/admin/addon_settings.png
/trunk/Themes/default/images/admin/plugin_manager.png
/trunk/Themes/default/images/admin/plugin_remove.png
/trunk/Themes/default/images/admin/plugin_settings.png
/trunk/Themes/default/languages/Admin.english.php
/trunk/Themes/default/languages/Admin.french.php
/trunk/Themes/default/languages/Errors.english.php
/trunk/Themes/default/languages/Errors.french.php
/trunk/Themes/default/languages/Help.english.php
/trunk/Themes/default/languages/ManageAddons.english.php
/trunk/Themes/default/languages/ManageAddons.french.php
/trunk/Themes/default/languages/ManagePermissions.english.php
/trunk/Themes/default/languages/ManageSettings.english.php
/trunk/Themes/default/languages/Media.french.php
/trunk/Themes/default/languages/Modlog.english.php
/trunk/Themes/default/languages/Packages.english.php
/trunk/Themes/default/languages/Who.english.php
/trunk/Themes/default/languages/index.english.php
/trunk/Themes/default/languages/index.french.php
/trunk/index.php
/trunk/other/Settings.php
/trunk/other/Settings_bak.php
/trunk/other/install.php
Re: New revs
« Reply #1042, on September 30th, 2011, 08:07 AM »
rev 1042
(10 files -5, 387kb)

* Updated getid3 from v1.7.9 to v1.9.1. Given the increase in size, compensated a bit by removing files that aren't playable from within browsers (FLAC, Wv, APE) because I doubt they'd be uploaded 'as is' instead of zipped up or something. Also removed ID tag files because we're not actually using any of this data in the media area... For now at least. (Source/media/getid3/*)
Re: New revs
« Reply #1043, on September 30th, 2011, 08:35 PM »
rev 1043
(6 files +1, 129kb)

+ Forgot to add the Matroska parser for mkv and webm support in the media area. (module.audio-video.matroska.php)

! Turned language flag URLs into relative URLs, fixing a wrong attempt by Wedge to re-prettify pretty URLs with both 'action' and 'board' variables in them. Eh, also makes the URLs shorter... (index.template.php)

+ Added support for 'rem' unit size in WeCSS's math function. (Class-CSS.php)

+ Forgot to translate an old item. Hmm. (index.french.php)

* Commenazi. (Load.php, getid3/*)
Re: New revs
« Reply #1044, on September 30th, 2011, 11:25 PM »
rev 1044
(7 files, 11kb)

+ At last, started implementing id_parent in messages for the future threaded view (whether as a plugin or in core). Currently works on Reply, Quote and new posts. Doesn't work on Quick Reply for now. (Post.php, Post2.php, Subs-Post.php, Post.template.php)

! Fixed and tweaked PM post layout -- straightened up the padding and margin, used on_timeformat() where it applies, made Delete button visible, etc. And my apologies for the minor hack in the PM layer's above(). (PersonalMessage.php, PersonalMessage.template.php, index.member.css)
Re: New revs
« Reply #1045, on October 1st, 2011, 12:29 PM »
rev 1045
(8 files, 9kb)

- clean_cache('member_data') doesn't do anything. It didn't back in SMG days, it still doesn't. Might as well remove it... (Subs-Media.php)

! Default clean_cache type should be empty, and redirect to the data sub-folder. The type is only overridden for the smiley cache anyway. (Subs-Cache.php)

! Fixed padding for the quick reply textarea. (Class-Editor.php, editor.css, sections.css)

* Moved 'mark unread' link next to 'report to moderator' in PM template. (PersonalMessage.template.php)

* Quick reply opening speed was fast, but not fast enough for a 'quick' reply. Increased speed by 25%. (topic.js)

- Moderation notes? Thank you, Captain Obvious! (admin.css)
Re: New revs
« Reply #1046, on October 1st, 2011, 06:08 PM »
rev 1046
(13 files +5-5, 45kb)

* clean_cache filter can now be a string anywhere inside the filename. (Subs-Cache.php)

+ Added a 'dynamic' plugin for WeCSS, where one may define a dynamic_function() anywhere (whatever the name), and then call it from within a CSS file via {%dynamic_function:params%}. Will have to look into potential security issues, though... (Class-CSS.php, Subs-Cache.php)

+ Added a dynamic function to cache language flags into index.css... Yay. This gets me one more percent on Google PageSpeed. (Subs-Cache.php, index.css, index.template.php)

! Forgot to update a few files with the Plugin rename. (other/*, ManagePlugins.language.php, ManagePlugins.template.php, admin.css)

! Fixed margin glitch when showing a .wrc div that only contains a single p (paragraph). (index.css)

! Fixed bug with is_replied_to in PM searches. (PersonalMessage.php)

- Saving one line of code. Beautiful. (Display.template.php)
Re: New revs
« Reply #1047, on October 1st, 2011, 07:40 PM »
rev 1047
(4 files, 7kb)

* Swapped parameter order for clean_cache() to put the emphasis on the most used param. Also cleaned up related data. (ManageServer.php, ManageSmileys.php, Subs-Boards.php, Subs-Cache.php)

* Delete CSS cache when language files are modified. (Subs-Cache.php)

Arantor

  • As powerful as possible, as complex as necessary.
  • Posts: 14,278
Re: New revs
« Reply #1048, on October 2nd, 2011, 05:16 PM »
Revision: 1048
Author: arantor
Date: 16:15:47, 02 October 2011
Message:
! Fix to installer failing to create correct key in database tables. (install.sql)
----
Modified : /trunk/other/install.sql
When we unite against a common enemy that attacks our ethos, it nurtures group solidarity. Trolls are sensational, yes, but we keep everyone honest. | Game Memorial

Nao

  • Dadman with a boy
  • Posts: 16,082
Re: New revs
« Reply #1049, on October 2nd, 2011, 06:09 PM »
rev 1049
(16 files +6, 33kb -- too tired to take time splitting into smaller commits.)

+ Because I was bothered by a lousy Google PageSpeed rating on admin menus, due to menu icons, I gathered them together and multiplied said rating by two. Known issue: if you modify the admin menu, you'll need to manually remove the cache file, or run clean_cache('css', 'admenu') through a hook or something. Needs discussing. (Admin.php, Subs-Cache.php, Subs-Menu.php, admenu.css)

+ Added cache control htaccess files to avatar and smiley folders. Smileys don't need this, unless they're too big to be cached by WeCSS. Also note that $admin_areas is now a global, so the admin menu hook doesn't need to specify it as a param. (avatars/.htaccess, Smileys/.htaccess)

+ Added three icons to the topic moderation menu. Only visible to members with the correct permissions. Asking for feedback on whether I should remove them or add icons to the rest. (index.member.css, sections.css)

* Modified CSS dynamic plugin to force requiring a dynamic_ prefix on the function name. Should make it safer to use. (Class-CSS.php, index.css)

* Got real when it comes to clean_cache(), and made it simpler to remove CSS and JS files with it. You just need to specify 'css' now, and Wedge will extend it to all extensions used for CSS files. (ManageServer.php, ManageSmileys.php, Subs-Cache.php)

! Error URLs were recently broken if using Pretty URLs. (Errors.php)

! Package functions don't need to declare admin.css, since it's already declared by that time. (PackageGet.php, Packages.php)

! jQuery was being used in an inline function. (Subscriptions-PayPal.php)

* Super-minor fixes. (avatars/xkcd/index.php, Load.php, ManageErrors.php)

NB: would appreciate feedback on this commit, thanks...