New revs
Plugin revs »

Arantor

  • As powerful as possible, as complex as necessary.
  • Posts: 14,278
Re: New revs
« Reply #1020, on September 21st, 2011, 02:43 PM »
2 files, 5KB

Revision: 1020
Author: arantor
Date: 13:42:43, 21 September 2011
Message:
! Items in the generic show_settings template should have ids on their spans, in case we want to restyle them dynamically (e.g. if something is disabled and we can re-enable it by selecting a different setting/choice), and also convert the inline style for disabled items to a class style. (Admin.template.php, admin.css)
----
Modified : /trunk/Themes/default/Admin.template.php
Modified : /trunk/Themes/default/skins/admin.css
When we unite against a common enemy that attacks our ethos, it nurtures group solidarity. Trolls are sensational, yes, but we keep everyone honest. | Game Memorial

Nao

  • Dadman with a boy
  • Posts: 16,082
Re: New revs
« Reply #1021, on September 21st, 2011, 09:32 PM »
rev 1021
(10 files, 19kb)

- Removed layer hints. They would probably have been a bit confusing to part-time themers and modders. Here's hoping themers will make sure their skeletons have all of the regular layers in them. (Aeva-Gallery.php, Profile.php, Subs-Menu.php, index.template.php, Warm/skin.xml)

! Fixed some logic errors when providing wrong values to the skeleton. (Subs-Template.php)

+ Added a skeleton_find_parent() function to get the parent layer's name for a given block or layer. (Subs-Template.php)

* Shortened a few JS functions. I'm particularly proud I managed to shorten my menu code by a few more lines. Nerd alert. (ManageMaintenance.template.php, mediadmin.js, post.js, script.js)
Re: New revs
« Reply #1022, on September 22nd, 2011, 06:47 PM »
rev 1022
(7 files, 12kb)

+ Added ability to remove index.php from the URL in the Pretty URLs area. You no longer have to enable Pretty URLs just to remove index.php, for those who don't like them. (ManageSettings.php, QueryString.php, Admin.template.php, Admin.language.php)

- Don't repeat comments twice in the htaccess file. Don't repeat comments twice in the htaccess file. (other/.htaccess)

- Shortened the debug HTML code. (Subs-Template.php)
Re: New revs
« Reply #1023, on September 22nd, 2011, 09:54 PM »
rev 1023
(8 files, 13kb)

- Removed compactTopicPagesEnable setting. I've never seen a single SMF forum disable it anyway. (install.sql, Display.php, ManageSettings.php, Subs.php, Help.language.php, ManageSettings.language.php)

@ Note to SMF: if you keep the option, I'd just like you to know the help popup for it is completely screwed up... It looks like it's the help for compactTopicPagesContiguous, in fact (which is repeated below). Plus, the help never mentions it's for the page index.
Re: New revs
« Reply #1024, on September 23rd, 2011, 12:34 AM »
rev 1024
(7 files +1, 23kb)

+ Re-introducing the top menu arrow. Holy cow, did I miss that one. Used a clever CSS trick to add it through JavaScript without even breaking validation. (menurow.gif, script.js, index.css, Warm/index.css)

+ Added support for average() color function. It returns a color that is the average of two colors passed to it. Note that this is the HSLA average, not RGBA, so it's more accurate. Also used the function on menu background for IE9, as an example. (Class-CSS.php, index.css)

* Updated minilogos to PT Sans. Hmm, I think Helvetica looks best at that size though... (minilogo.png, minilogow.png)

! Error when errors occur. But only if no add-ons are installed, if I'm not in error. (Errors.php)

! Fixed minor glitch on menu corners. (index.css)
Re: New revs
« Reply #1025, on September 23rd, 2011, 11:36 AM »
rev 1025
(3 files, 7kb)

- Reverting a useless fix which was due to my setup not being up to date. (Errors.php)

! More menu CSS fixes for IE8 and IE9. Microsoft, please kill IE. Now. (index.ie*.css)

Arantor

  • As powerful as possible, as complex as necessary.
  • Posts: 14,278
Re: New revs
« Reply #1026, on September 23rd, 2011, 06:07 PM »
Revision: 1026
Author: arantor
Date: 17:02:55, 23 September 2011
Message:
! (SMF bug, thanks Dragooon) When registering users through instant activation, make sure the right variable is passed to the activate hook. (Register.php)
----
Modified : /trunk/Sources/Register.php


@ I did a quick look back through the code history in SMF. It looks like prior to RC4, a different integration hook was called entirely (and arguably that's also broken), but that in RC4 it changed and the way it changed made it break.

Nao

  • Dadman with a boy
  • Posts: 16,082
Re: New revs
« Reply #1027, on September 23rd, 2011, 07:31 PM »
rev 1027
(23 files -1 -1 folder, 31kb)

* Updated loadBlock() to set the default 'where' param to 'add' for non-default layers (still defaults to 'replace' in default.) You may also just use an empty string instead of specifying 'default' in loadBlock() and loadLayer(). Whatever makes you feel more comfortable. (index.php, Boards.php, Calendar.php, Display.php, Homepage.php, Aeva-Gallery.php, MessageIndex.php, Profile.php, Subs-Menu.php, Subs-Template.php, Unread.php, UnreadReplies.php, Warm/skin.xml)

* Moved constructPageIndex() to the index template, to make it easier to style for themers. (Subs.php, index.template.php)

* Turned the stat center into a proper layer. (Boards.php, Homepage.php, InfoCenter.template.php)

! Fixed menus and menu notices in plenty of browsers. IE9, I hate you with a passion now. It's the only browser that doesn't play nicely with floats... IE10 works, and even IE6 works here. Eh. (GenericMenu.template.php, script.js, index.css, index.ie6.css, index.ie7.css)

- Forgot to remove layer hint and extra CSS definitions. Also removed the hs folder, as we're no longer using Highslide. (Load.php, Subs-Cache.php, aeva/hs, smf2.css)

Arantor

  • As powerful as possible, as complex as necessary.
  • Posts: 14,278
Re: New revs
« Reply #1028, on September 24th, 2011, 02:13 PM »
Revision: 1028
Author: arantor
Date: 13:13:12, 24 September 2011
Message:
! If the board or message index has a custom class/title specified for the left icon, make use of that. (Probably only of use to add-ons.) (Boards.template.php, MessageIndex.template.php)

! Limited ability to perform removal of add-ons and associated clean-up. It gets upset if it can't remove the files, though, because it doesn't have any ability to let you log in via FTP to fix them at present. (ManageAddons.php, ManageAddons.template.php, ManageAddons.english.php, addon_remove.png)

! Fix for undefined variable in addon-loader as reported by live627. (Load.php)
----
Modified : /trunk/Sources/Load.php
Modified : /trunk/Sources/ManageAddons.php
Modified : /trunk/Themes/default/Boards.template.php
Modified : /trunk/Themes/default/ManageAddons.template.php
Modified : /trunk/Themes/default/MessageIndex.template.php
Added : /trunk/Themes/default/images/admin/addon_remove.png
Modified : /trunk/Themes/default/languages/ManageAddons.english.php
Re: New revs
« Reply #1029, on September 24th, 2011, 02:58 PM »
Revision: 1029
Author: arantor
Date: 13:57:42, 24 September 2011
Message:
! Hopeful fix for the SET/ENUM issue and having the wrong default; if no default is set, don't create a phantom one in its place. (ManageAddons.php)
----
Modified : /trunk/Sources/ManageAddons.php
Re: New revs
« Reply #1030, on September 24th, 2011, 03:18 PM »
Revision: 1030
Author: arantor
Date: 14:17:56, 24 September 2011
Message:
! Make sure all the displayed strings are actually pushed through htmlspecialchars, simply because it's not good mojo if you provide XSS facilities in an add-on. (ManageAddons.php)
----
Modified : /trunk/Sources/ManageAddons.php

Nao

  • Dadman with a boy
  • Posts: 16,082
Re: New revs
« Reply #1031, on September 25th, 2011, 02:09 AM »
rev 1031
(7 files, 12kb)

* Split the header contents into several blocks[1] (logo_toggler, search_box, language_selector and random_news), allowing to move individual components into other places like the sidebar, as demonstrated in Warm. (And yes, it will break indentation if you check the HTML code. I'm not going to fix it, it's too resource-intensive.) Also, removing logo_toggler will now cancel the oMainHeaderToggler object setup. (index.template.php, Warm/skin.xml)

! Fixed various glitches in Warm and Wuthering, and harmonized their main font: Warm is a PT Sans beast with Segoe UI and Trebuchet MS fallbacks, and Wuthering is a Segoe UI with an Arial fallback. (Warm/index.css, Wuthering/index.css)

- Don't bother setting we_iso_case_folding if it's never going to be used (i.e. set to false, or simply sha1.js is not loaded.) (ssi_examples.php, index.template.php, sha1.js)

* Forgot to remove an 'add' from a loadBlock. (Admin.php)
 1. One question... Is it TOO much? I'm assuming it's okay because these are important components, but I'll refrain from doing it everywhere...

Arantor

  • As powerful as possible, as complex as necessary.
  • Posts: 14,278
Re: New revs
« Reply #1032, on September 25th, 2011, 02:25 AM »
Revision: 1032
Author: arantor
Date: 01:25:10, 25 September 2011
Message:
! Added code contributed by Dragooon for add-ons being able to detect their own hooks (i.e. providing a hook and simultaneously registering something against it), plus a fix to one of my bugs, plus what I suspect may be a bugfix to Dragooon's (but I might be wrong), plus a little tweak elsewhere to prevent phantom hooks being registered. (ManageAddons.php, Load.php)
----
Modified : /trunk/Sources/Load.php
Modified : /trunk/Sources/ManageAddons.php

Nao

  • Dadman with a boy
  • Posts: 16,082
Re: New revs
« Reply #1033, on September 26th, 2011, 11:43 PM »
rev 1033
(14 files, 23kb)

+ Introducing pretty URL prefixes for actions and profiles. Basically, when enabling pretty actions or pretty profiles, you also get to choose between various URL styles for them. Supporting "/" and "/do/" for actions, and "/~" and "/profile/" for profiles. Defaults to the long versions. Need to add some documentation about this, and some code at board creation time to prevent them from having a name in the protected action list...[1] (install.sql, ManageSettings.php, PrettyUrls-Filters.php, QueryString.php, Admin.template.php, Admin.language.php, admin.css)

* Updated credits page to merge library copyrights with other copyrights. (Credits.php, Who.template.php, Who.language.php)

* Added Pretty URLs admin page to the internal admin search engine. Heck, we need to add many more sub-actions to that array... I'll let Pete handle this after he finishes reworking the admin area. (Admin.php)

* Spacinazi. (Subs-Cache.php)
 1. Feel free to add it to your to-do list, Pete... I'm so horribly busy these days. :(
Re: New revs
« Reply #1034, on September 27th, 2011, 06:09 PM »
rev 1034
(8 files +3 -2, 39kb)

* Upped the maximum file count in media folders to 500 (from 150). (install.sql)

* Renamed Homepage custom page to Welcome, so that you can create your own Homepage. (Homepage.php, Homepage.template.php)

* Spacinazi, parenthenazi, typo and code cleanup. (ManageAddons.php, Subs-Media.php, Subs-Boards.php, Subs-Cache.php, Admin.template.php, ManageAddons.english.php)

* French translation. (Admin.french.php, ManageAddons.french.php)
Plugin revs »