New revs
Plugin revs »

Nao

  • Dadman with a boy
  • Posts: 16,082
Re: New revs
« Reply #960, on August 21st, 2011, 12:09 AM »
rev 959
(4 files, 8kb)

* Tweaked theme selector to be a bit more user-friendly. The currently selected theme is now indicated as such ('Current theme'). The currently selected skin also gets its own class (should probably use a caption like for the theme), and doesn't show the Pick links. Child skins also get more left padding, to emphasize their nature as a child, and their thumbnails are resized to ensure they don't use up too much vertical space. (Themes.template.php, index.css)

* Commenazi. (latest-themes.php, Themes.php)
Re: New revs
« Reply #961, on August 21st, 2011, 04:51 PM »
rev 960
(7 files, 10kb)

* Changed some of the skin values to be set to an empty string by default, meaning it should use the theme's default skin, rather than always the theme's root skin. It's too hot in here to overthink it. (install.sql, Themes.php)

* Micro-optimization and translation tweak. (Admin.php, Themes.french.php)

! When picking a default theme for guests with the theme picker, the pick page was set as being from the profile area, rather than admin area. (Subs.php)

! Background issues on Warm menu in sucky browsers, including Safari Mobile. (Warm/index.css)

* Tweaked font size in main menu to help usability on iOS. (index.iphone.css)

Arantor

  • As powerful as possible, as complex as necessary.
  • Posts: 14,278
Re: New revs
« Reply #962, on August 22nd, 2011, 01:35 PM »
Revision: 961
Author: arantor
Date: 12:35:04, 22 August 2011
Message:
! If there's no menu item explicitly selected but we're in a place where we probably should have one because we subsections and we should highlight the first subsection, select it. (Subs-Menu.php)
----
Modified : /trunk/Sources/Subs-Menu.php
When we unite against a common enemy that attacks our ethos, it nurtures group solidarity. Trolls are sensational, yes, but we keep everyone honest. | Game Memorial

Nao

  • Dadman with a boy
  • Posts: 16,082
Re: New revs
« Reply #963, on August 24th, 2011, 08:00 PM »
rev 962 --- multipart commit.
(5 files, 12kb)

* Rewrote constructPageIndex() to be tighter -- smaller and better HTML, CSS and JavaScript. As a bonus, pretty URLs are also correctly rewritten in the process, hopefully without exceptions. (Subs.php, script.js, index.css)

* Started work on simplifying theme/skin combinations. id_theme=0 should have skin='' (meaning it's taken from theme_skin_guests), and skin='' on other id_themes means the root (skins folder). (Load.php)

* Although it technically works, it doesn't make sense to set the cursor type on 'a:hover', it should instead be directly on 'a'. (index.css)

! SMF bug: session errors when using new PHP5 feature that allows to set more hash bits for the valid session characters. Thanks live627 for the report and rawlogic for the ready-made fix! (wedge_api.php, Load.php)
Re: New revs
« Reply #964, on August 24th, 2011, 08:07 PM »
rev 963 --- the last part of the commit will take more time...
(13 files, 12kb)

* Tweaked member list to be more welcoming (more padding) and use less HTML (bandwidth nazi.) (Memberlist.template.php)

! Setting css('display', '') on an item doesn't work when its display is hidden through a class (like the hide class). I knew that, but I'd forgotten to fix that in a couple of instances. Modders, use toggle() instead, it's cooler anyway. (editor.js, topic.js)

! Help entry typo for pretty URLs. (Admin.language.php)

* Some breathing space for the main menu in iOS. (index.iphone.css)

* The usual code cleanup. (upgrade.php, ManageBoards.php, ManagePermissions.php, Subs-List.php, index.template.php, Login.template.php)

- We don't really need that 'skins' variable in the themes table... Also tweaked another 'skins' entry. (install.sql, ManageBoards.php)
Re: New revs
« Reply #965, on August 24th, 2011, 10:50 PM »
rev 964
(2 files, 6kb)

! Allow URLs with $ and % in them to be turned into pretty URLs, e.g. page index templates using a flexible start shortcut (board=1.0). (PrettyUrls-Filters.php)

* More 'skins' fixes. (Themes.php)
Re: New revs
« Reply #966, on August 25th, 2011, 12:58 AM »
rev 965
(1 file, 6kb)

- Cleaned up the pretty topic creation code, removing all code pertaining to finding duplicates in the database. Since Wedge only bothers with the topic ID, duplicate topic titles aren't a problem. (PrettyUrls-Filters.php)

* Did some performance tests on PURL transforms, and figured out that word boundaries don't impact it, unlike what I thought. So I'm now using them to ensure strange URLs like "action=mymod;deleteboard=1" won't get prettified by mistake. (PrettyUrls-Filters.php)

! Hopefully, fixed the last issue with PURLs in page index code. (PrettyUrls-Filters.php, again.)
Re: New revs
« Reply #967, on August 25th, 2011, 07:44 PM »
rev 966
(7 files, 18kb)

* Another Credit page overhaul. It's a work in progress, so it'll be finished later.

+ Added a 'website credits' section to list Administrators and Global Moderators, so that the page can actually live up to its 'Website credits' status. (Credits.php, Who.language.php, Who.template.php)

- Removed a few things, such as unused credit areas and the 'general' thank you message to beta testers and translators... Okay, if they're doing a priceless job, then they need to be thanked by name, don't they? Plus, translators get to credit themselves anyway... (Credits.php, Who.language.php, Who.template.php)

+ Added credits for FamFamFam Silk icons and Diagona, and removed them from the AeMe area. Other AeMe items will come later. (Credits.php, ManageMedia.php)

! Added special authorization for img tags to hold action=media items. Unsure whether I should specify the sub-actions that actually perform the downloading or showing of an item... (Subs-BBC.php)

* Tweaked credit page visuals. (sections.css, Who.template.php)

@ Pete, I made a dirty query to get the website team list, but maybe it's stored somewhere in a special variable or something...? Or maybe there's a faster way of retrieving these?
Re: New revs
« Reply #968, on August 26th, 2011, 12:20 AM »
rev 967
(8 files, 13kb)

* More credit page fine-tuning. Still upset that the extra white space in the English version. Added a couple of special thanks. Added link to our online license. Removed unused text strings. Replaced we:titles with we:blocks. Also added Ante's real name in the credits. It's credited in plain view at http://www.lewisonline.ca/?p=426 after all... (Credits.php, Who.english.php)

* Removed third-party tool credits from AeMe and moved them to the main credit page. (Credits.php, ManageMedia.php, ManageMedia.language.php, Who.language.php, ManageMedia.template.php, Who.template.php)
Re: New revs
« Reply #969, on August 26th, 2011, 04:45 PM »
rev 968
(5 files, 7kb)

* Hopefully finished implementing the 'theme_skin_guests' rewrite. Why do these things always have to be complicated...? Will require some thorough testing of the admin settings with a default install and an imported SMF install set with a default guest skin different from the root skin. (Subs-Boards.php, Subs-Cache.php, ManageBoards.template.php)

* The 'replace' type in the skins.xml file can be uppercase if you want. It's not going to kill performance anyway... (Subs-Cache.php)

* Fixed a couple of rtl.css occurrences to index.rtl.css. Hmm, what exactly does that copy function in Themes.php do...? Does it mean we have to copy all of the index.*.css files? I smell trouble! :P (Class-CSS.php, Themes.php)
Re: New revs
« Reply #970, on August 28th, 2011, 11:47 PM »
rev 969
(8 files, 11kb)

* Simplified copyright text and handling. (smfinfo.php, Credits.php, Subs.php, index.template.php, index.language.php, Printpage.template.php, Reports.template.php)

Arantor

  • As powerful as possible, as complex as necessary.
  • Posts: 14,278
Re: New revs
« Reply #971, on August 30th, 2011, 12:03 AM »
Revision: 970
Author: arantor
Date: 23:02:38, 29 August 2011
Message:
! theme_skin_guests will not probably be not defined during the installer, so instead of relying on $modSettings having the value, use the default value as a fallback. (Subs-Cache.php)

! Credits page should use the correct language string for its title. (Credits.php)
----
Modified : /trunk/Sources/Credits.php
Modified : /trunk/Sources/Subs-Cache.php

@ I like the way copyright is now implemented. :)
Re: New revs
« Reply #972, on August 30th, 2011, 12:14 AM »
Revision: 971
Author: arantor
Date: 23:13:47, 29 August 2011
Message:
! Removal of the 'number of people in memberlist' option. I've never seen anyone change the default, but if someone really wants to, it's still in the database as a setting so it can be tweaked with a mod if necessary. (In theory it could be removed from the DB, simply because it is pre-initialised to default otherwise) (ManageSettings.php, ManageSettings language file)
----
Modified : /trunk/Sources/ManageSettings.php
Modified : /trunk/Themes/default/languages/ManageSettings.english.php
Modified : /trunk/Themes/default/languages/ManageSettings.french.php
Re: New revs
« Reply #973, on August 30th, 2011, 12:40 AM »
Revision: 972
Author: arantor
Date: 23:39:55, 29 August 2011
Message:
! Removed the 'disable administration security' user interface option. The internal setting has been preserved so it's not like it can't be set relatively easily with phpMyAdmin if needed. While this may be a slight inconvenience to long-experienced users who create test sites, for the majority of users it's one thing they can't accidentally shoot themselves in the foot with. (ManageSettings.php, Login.template.php, Help and ManageSettings language files)
----
Modified : /trunk/Sources/ManageSettings.php
Modified : /trunk/Themes/default/Login.template.php
Modified : /trunk/Themes/default/languages/Help.english.php
Modified : /trunk/Themes/default/languages/Help.french.php
Modified : /trunk/Themes/default/languages/ManageSettings.english.php
Modified : /trunk/Themes/default/languages/ManageSettings.french.php

Nao

  • Dadman with a boy
  • Posts: 16,082
Re: New revs
« Reply #974, on August 30th, 2011, 09:45 PM »
rev 973 (everything I did while playing Xenoblade this week :P)
(12 files +1, 21kb)

! The smiley cache was always regenerated on each call, because of a last-minute change in parameter order. (Subs-BBC.php, Subs-Cache.php)

* Reprocessed copyright comments in JavaScript files to only cache the bare minimum, i.e. @copyright stuff, and avoid showing the version number and issue date. (Subs-Cache.php)

* The cache folder's htaccess should specify a Vary-Encoding header to make Page Speed happy and help with proxy caching or whatever. (cache/.htaccess)

* Shaved a few extra bytes off the main script file's cached version. I also sacrificed my plain view credit for the menu code for the good cause. It's still in the uncached version though, it's my thing, took me years to finetune it, nearly drove me crazy, I want the whole world to know that stupid script is mine. And that includes you, reading the changelog. (script.js, theme.js)

! Reverted rev 972's removal of the securityDisable_why text string, as it's unrelated to the availability of securityDisable itself. (Login.template.php, Help.language.php)

! Syntax error in PM template. Not sure where this one came from... (PersonalMessage.template.php)

* Tweaked current date's margin and we:block styling. (index.template.php, index.css)

* Spacinazi. (ManageBoards.php)
Plugin revs »