New revs
Plugin revs »

Nao

  • Dadman with a boy
  • Posts: 16,082
Re: New revs
« Reply #945, on August 17th, 2011, 04:34 PM »
rev 943 -- OMG, it's like we're racing to the top! Love that!
(5 files, 10kb)

* French translation - new items and fixes. (ManageSettings.french.php, Help.french.php, Admin.french.php)

! $txt['allow_hideOnline'] makes an odd reference (in both languages) to 'non-administrators'. It should be 'allow to hide from non-admins', not 'allow non-admins to hide'. Removed non-admins altogether because it's pretty obvious that admins have all rights over their server. (ManageSettings.language.php)

* Converted the custom profile JavaScript to jQuery (looks like I forgot to complete that one long ago!) (Admin.template.php)

! If #mask was hidden in the custom profile field form, a linebreak would be shown in its place. (Admin.template.php)

@ Pete> I'm not sure it's semantically all right to use a theme menu string in a member menu... ^^; I won't fix it because I'm against giving too many strings to translate to users, but I doubt both menu entries would translate identically in all languages... Also, duly noted for the changelog typo. It's not like I'm never doing that myself :lol:

Arantor

  • As powerful as possible, as complex as necessary.
  • Posts: 14,278
Re: New revs
« Reply #946, on August 17th, 2011, 05:44 PM »
Revision: 944
Author: arantor
Date: 16:43:53, 17 August 2011
Message:
! Wedge now requires MySQL 5.1.0 (install.php, tools/*, upgrade.php)
! Juggle some language strings around for later, as we prepare to phase others. (Admin.php, Admin and ManageSettings language files)
----
Modified : /trunk/Sources/Admin.php
Modified : /trunk/Themes/default/languages/Admin.english.php
Modified : /trunk/Themes/default/languages/Admin.french.php
Modified : /trunk/Themes/default/languages/ManageSettings.english.php
Modified : /trunk/Themes/default/languages/ManageSettings.french.php
Modified : /trunk/other/install.php
Modified : /trunk/other/tools/create_backup.php
Modified : /trunk/other/tools/webinstall.php
Modified : /trunk/other/upgrade.php
Re: New revs
« Reply #947, on August 17th, 2011, 07:14 PM »
Revision: 945
Author: arantor
Date: 18:12:54, 17 August 2011
Message:
! Remove the moderator/admin entry from Core Features, instead the logs are now controlled from the main Log Settings page (Admin :: Server & Maintenance :: Logs :: Log Settings, trust me it is easier to find than you might think!), and are controlled individually rather than collectively. (Admin.php, ManageMembers.php, ManageSettings.php, ModerationCenter.php, Profile-Modify.php, Profile-View.php, Profile.php, Subs-Membergroups.php, Subs-Members.php, Subs.php, Help and ManageSettings language files)

! Make only moderate and admin log enabled by default, don't really need profile edits log by default, at least while it only logs 60% or so of the fields that can be changed. (install.sql)
----
Modified : /trunk/Sources/Admin.php
Modified : /trunk/Sources/ManageMembers.php
Modified : /trunk/Sources/ManageSettings.php
Modified : /trunk/Sources/ModerationCenter.php
Modified : /trunk/Sources/Profile-Modify.php
Modified : /trunk/Sources/Profile-View.php
Modified : /trunk/Sources/Profile.php
Modified : /trunk/Sources/Subs-Membergroups.php
Modified : /trunk/Sources/Subs-Members.php
Modified : /trunk/Sources/Subs.php
Modified : /trunk/Themes/default/languages/Help.english.php
Modified : /trunk/Themes/default/languages/Help.french.php
Modified : /trunk/Themes/default/languages/ManageSettings.english.php
Modified : /trunk/Themes/default/languages/ManageSettings.french.php
Modified : /trunk/other/install.sql


Also note that the logAction function is now a bit faster if the relevant log is disabled, since the is-enabled check now happens before any other checks occur.
When we unite against a common enemy that attacks our ethos, it nurtures group solidarity. Trolls are sensational, yes, but we keep everyone honest. | Game Memorial

Nao

  • Dadman with a boy
  • Posts: 16,082
Re: New revs
« Reply #948, on August 17th, 2011, 08:02 PM »
rev 946
(9 files, 11kb)

* Simplified upgrade script DB version check. Why are we updating the upgrader already...? Fixed what's likely to be a SMF bug ($db['version'] being considered in command-line as the current version instead of target version). Also, shouldn't that extra version check codeblock be removed? (upgrade.php)

* Simplified install script. By two lines. We don't need to eval the thing, as we'll run it every time... (install.php)

! Version number fixes. (install.sql, readme_*.html)

- $database_version is no longer used. (create_backup.php)

* French translation. (ManageSettings.french.php)

Arantor

  • As powerful as possible, as complex as necessary.
  • Posts: 14,278
Re: New revs
« Reply #949, on August 18th, 2011, 11:36 AM »
Revision: 947
Author: arantor
Date: 10:35:52, 18 August 2011
Message:
! Removing one of the fixes I supplied for SMF 2: the load balancing dialog warning when on Windows. Instead, I just removed the entire page because if it's on Windows, it's absolutely useless and might as well not bother being shown. (Admin.php, ManageServer.php, ManageSettings language file)
----
Modified : /trunk/Sources/Admin.php
Modified : /trunk/Sources/ManageServer.php
Modified : /trunk/Themes/default/languages/ManageSettings.english.php
Modified : /trunk/Themes/default/languages/ManageSettings.french.php
Re: New revs
« Reply #950, on August 18th, 2011, 11:53 AM »
Revision: 948
Author: arantor
Date: 10:53:20, 18 August 2011
Message:
! New area under Server Settings: Debugging. Moved all the debugging stuff out of Server Settings/General into it, plus hoovered up another option from elsewhere in the admin panel that even had the comment "This is sort of like debugging", especially as it isn't really a layout option! (Admin.php, ManageServer.php, ManageSettings.php, Admin language file)
----
Modified : /trunk/Sources/Admin.php
Modified : /trunk/Sources/ManageServer.php
Modified : /trunk/Sources/ManageSettings.php
Modified : /trunk/Themes/default/languages/Admin.english.php

Nao

  • Dadman with a boy
  • Posts: 16,082
Re: New revs
« Reply #951, on August 18th, 2011, 03:07 PM »
rev 949
(67 files, 57kb)

* More smf/simplemachines/etc. conversions... Did a lot of cleaning work, too, such as fixing the DTD headers, removing AeMe version checks and removing a couple of eggs I found while doing the changes. The end is in sight. NOT TOO SOON!! (about 64 files...)

* Nearly done with integrating the AeMe installer into Wedge's. (db_aeva.php, install.sql)

* Added a couple more allowed keywords to the spell-checker. 'Wedge' is proper English, but it's a multilingual checker. (Spellcheck.php)

Arantor

  • As powerful as possible, as complex as necessary.
  • Posts: 14,278
Re: New revs
« Reply #952, on August 18th, 2011, 03:10 PM »
Revision: 950
Author: arantor
Date: 14:07:48, 18 August 2011
Message:
! Reporting PMs to admins is now enabled permanently. (ManageSettings.php, PersonalMessage.php, PersonalMessage.template.php, Help and ManageSettings language files)
! Online/offline icon is no longer optional. Note that it's still hidden if you can't send the person concerned a PM, maybe we should fix that so it isn't simultaneously a link to PM that person. (ManageSettings.php, PersonalMessage.template.php, Display.template.php, Help and ManageSettings language files)
----
Modified : /trunk/Sources/ManageSettings.php
Modified : /trunk/Sources/PersonalMessage.php
Modified : /trunk/Themes/default/Display.template.php
Modified : /trunk/Themes/default/PersonalMessage.template.php
Modified : /trunk/Themes/default/languages/Help.english.php
Modified : /trunk/Themes/default/languages/Help.french.php
Modified : /trunk/Themes/default/languages/ManageSettings.english.php
Modified : /trunk/Themes/default/languages/ManageSettings.french.php

Posted: August 18th, 2011, 03:08 PM

Revision: 951
Author: arantor
Date: 14:10:02, 18 August 2011
Message:
! And, slightly ridiculously, the online enable option is actually specified in the installer as off, not sure why that's entirely necessary, but there you go. (install.sql)
----
Modified : /trunk/other/install.sql

Nao

  • Dadman with a boy
  • Posts: 16,082
Re: New revs
« Reply #953, on August 18th, 2011, 03:21 PM »
Wow, we committed in the same minute! Did you get a conflict? :P

rev 952
(3 files -1, 7kb)

* Finished AeMe install integration. :) (db_aeva.php, install.php, install.sql)

* Translation. (Admin.french.php)

Arantor

  • As powerful as possible, as complex as necessary.
  • Posts: 14,278
Re: New revs
« Reply #954, on August 19th, 2011, 10:59 PM »
Revision: 953
Author: arantor
Date: 13:18:52, 19 August 2011
Message:
! Fixed installer doing very strange things like never actually getting past the DB settings stuff. (install.php)
----
Modified : /trunk/other/install.php


(Bah, meant to post this earlier.)

Nao

  • Dadman with a boy
  • Posts: 16,082
Re: New revs
« Reply #955, on August 20th, 2011, 12:09 AM »
rev 954
(26 files +1, 35kb)

+ Add a copy of the SMF2 license file to the root folder. (license_smf.txt)

* As far I know, the name conversions are now FINISHED... Oh my. Except for the smfinfo.php file, but I don't even think we'll be distributed that one. (other/*)

* Just tweaking install to my liking... No surprise to anyone. (install.php)

* Renamed some sm* vars to we*. (JSEditor.php, QuoteFast.php, editor.js)

! Fixed menu backgrounds not showing up in IE. (index.css)

! Fixed screwed up quick buttons in IE8. (index.ie8.css)
Re: New revs
« Reply #956, on August 20th, 2011, 12:30 AM »
rev 955
(7 files, 12kb)

* Replaced $amSettings['disable_feed'] with its opposite, $modSettings['xmlnews_enabled']. While it's nice to know you can remove feed links from your media pages and still have them work, I doubt there's any good reason for doing so... (install.sql, ManageMedia.php, ManageMedia.language.php, Media.template.php)

* Spacinazi and version numbers change. (SSI.php, ssi_examples.php)
Re: New revs
« Reply #957, on August 20th, 2011, 09:50 AM »
rev 956
(1 file, 3kb)

! Typo in one of the disable_feed replacements. Note for later: have someone actually actively look for issues in our commits, especially late at night, so that we don't have to do it in the morning :P (Media.template.php)
Re: New revs
« Reply #958, on August 20th, 2011, 02:08 PM »Last edited on August 20th, 2011, 02:28 PM by Voldefork
rev 957
(1 file, 5kb)

! Although newer Firefox versions seem to force resizing handles on smileys in Wysiwyg mode, we can *at least* convert these back to real smileys when saving, regardless of whatever dimensions are forced in. (Class-Editor.php)

@ Note: this doesn't seem to happen in SMF, so it was a bug in my earlier smiley rewrite.
Re: New revs
« Reply #959, on August 20th, 2011, 05:53 PM »
rev 958
(7 files, 12kb)

* Painstakingly rewrote the skin list function (in the Profile area) to fix a logic flaw. Add-type skins are now listed relative to their parent skin, and replace-type skins are listed on the top level, just like the root skin. (Themes.php, Themes.template.php)

* Tweaked language files to make a clearer statement about choosing the default skin when you choose a theme rather than a specific skin. (Themes.language.php)

- The skin list function was still avoiding the 'cache' folder, which was a remnant from the original skin system implementation... (Themes.php)

* Moved the menu toggler to the left of the menu -- where it makes a lot more sense having... (index.css, index.rtl.css)

* Number of theme users now uses number_context. (Themes.template.php, Themes.language.php)

* May not be necessary at all, but I ensured eAccelerator and other cache systems aren't detected if their 'put' function is detected but not callable. Consider it an extra safety. (ManageServer.php)

@ Minor issue with skins (as seen above): if the admin sets the guest skin (i.e. the default) to something else than the root skin, the thumbnail will still show the root skin. May have to change that, but there is only one default skin per website and there may be multiple themes... Dunno what's best. Any ideas...?
Plugin revs »