New revs
Plugin revs »

Nao

  • Dadman with a boy
  • Posts: 16,082
Re: New revs
« Reply #930, on August 13th, 2011, 07:42 PM »Last edited on August 13th, 2011, 10:28 PM by Nao/Gilles
rev 925 (and there it is... now we're talking.)
(11 files, 47kb)

* Rewrote the smiley handling system. Parsed smileys now use a div enclosing the actual smiley code. Benefit #1: copying and pasting text will retain smileys as text code in all browsers (SMF limits it to Firefox). Benefit #2: the most used smileys can now be encoded into the CSS, resulting in very fast loading times. As a note, the WYSIWYG editor will still use image tags to show smileys, otherwise navigating smileys through keyboards wouldn't work as well. (Class-Editor.php, ManageSmileys.php, Subs-BBC.php, editor.js, post.js)

+ Added aforementioned cache for BBC tag images. Should work across different smiley sets and browsers, using the same settings as the regular CSS cache. (Subs-BBC.php, Subs-Cache.php)

* Micro-optimized the editor JS code to take less space in the page (replacing objects with arrays, etc.) Because the editor code is unlikely to be changed (much) by mods, and because we now tend to add it even in topic pages, it makes sense to compact it, especially for uncompressed HTML pages where we save over 3 kilobytes. The js files also saved a kilobyte, and about 200 bytes once gzipped. (Class-Editor.php, editor.js, post.js)

- Removed smf_smileys_url (no longer used.) (Class-Editor.php)

- Removed some code that assumed $modSettings['smileys_dir'] and smileys_url weren't set... Probably some SMF1 compatibility code, because it's always set in Wedge. (ManageSmileys.php)

* Removed $txt['icon_laugh'] as it's not a 'default' smiley per the editor code. Added $txt['icon_edit'] because it is. (Subs-BBC.php, Class-Editor.php, index.language.php)

* Rewrote clean_cache to accept any kinds of extensions, instead of their 3 last characters. (Subs-Cache.php)

! clean_cache was broken when specifying extensions, as it used the wrong variable name. (Subs-Cache.php)

* Harmonized JS code for "Object.prototype.function = function ()". Oops, I mean 'spacinazi'. (editor.js, pm.js, post.js, suggest.js, topic.js)

* Moved the Delete button in File attachments to the left, for feng-shui reasons. Also fixed bevel in the button, although I have a feeling it'll break in Safari again... Also, did anyone notice that the input form button is never disabled, even when kindly asked to do so..? (post.js)

@ Note to Pete: maybe the file input should be hidden, as opposed to disabled....?

:edit: I updated Safari to v5.1, and the bug I mentioned is finally gone. So it's all good now... Only problem is, smileys don't show up in the editor :lol: Another bug I'll have to fix...

:edit: 2 - Postbox smileys are buggy in IE (all versions including 9), and Safari. They work well in Chrome, Firefox and Opera, the 'good guys'.
Re: New revs
« Reply #931, on August 14th, 2011, 06:26 PM »
rev 926
(26 files -1, 36kb) (........yet another big commit.)

* The 'more' button in smiley rows should now be on the right, and clicking it will show the new smileys through a slide animation. (Class-Editor.php)

* Now generating the smiley cache for each different different, allowing for IE6 to skip base64-encoded smileys. Also skipping the bigger smileys (>4KB), because we're only here to save bandwidth, not play with base64. (Subs-BBC.php, Subs-Cache.php)

! SMF bug (with no impact on code logic though): $smileyPregSearch is a string, not an array! (Subs-BBC.php)

* Renamed 'smiley_*' to 'smiley *' and thus moved smiley CSS logic to the main CSS file, in order to save some data (approx. 200 bytes after compression, by default.) (Class-Editor.php, Subs-BBC.php, Subs-Cache.php)

* Reintroduced code to disable smiley resizing in Firefox... Unfortunately, it doesn't work. Tried TinyMCE, CKEditor and a few others -- same issue, so I guess Firefox is to blame. Bad Firefox, baaad! (Class-Editor.php)

! Fixed a last-minute bug that prevented Wysiwyg smileys from being converted correctly. (Class-Editor.php)

! Fixed editor to still load the CSS for smileys, even if parsesmileys() is never called on the page. What a load of code just for that... (Class-Editor.php)

* More silly JS code simplification. What can I do, I'm a sucker for micro-optimizations... (Class-Editor.php)

* Commented out a function that isn't used for now in the Zoomedia code. Will need to convert it, really... (Aeva-Subs-Vital.php)

* Renamed smfRegister to weRegister. (Profile.template.php, Register.template.php, Reminder.template.php, register.js)

- Removed profile.js, as it was a bit too short to be justified at this point. (Profile.template.php, Register.template.php, profile.js)

+ Added proper Wedge headers to all JS files that didn't have it. (admin.js, captcha.js, editor.js, fader.js, pm.js, post.js, register.js, spellcheck.js, stats.js, suggest.js, theme.js, topic.js, zoomedia.js)

! Fixed smiley padding in Wysiwyg editor. (editor.css)

* Generic buttons should have a more generic background color, if you ask me. (index.css)

! More robust image replacement technique for smileys. (sections.css, index.ie6.css, index.ie7.css)

! Fixed bug with code tag fixer in Firefox. (theme.js)

* Spacinazi. (ManageMedia.template.php)
Re: New revs
« Reply #932, on August 15th, 2011, 01:07 AM »
rev 927
(6 files, 15kb)

+ All of the default smileys are now accessible in the post editor by default. Heck, aren't they worth it? No? (Class-Editor.php)

! In some situations, the smileys wouldn't show up in the post editor smiley box, because of an incorrect link tag. (Class-Editor.php)

! Some css cache filenames were incomplete because I forgot to update an integer after renaming the css folder. (Subs-Cache.php)

! Validation error. Since when can't inputs be put inside paragraph tags, already...? (Post.template.php)

* Updated file list, for whatever it's worth. We won't be using that file anyway. (xml/detailed-version.php)

! Did some tweaking on Warm and Wuthering skins to give them more personality, notably by changing the font. (Warm/index.css, Wuthering/index.css)
Re: New revs
« Reply #933, on August 15th, 2011, 10:09 PM »Last edited on August 15th, 2011, 10:24 PM by Nao/Gilles
rev 928 (this one was committed by Pete, who forgot to post it here........ :whistle:)
(7 files, ??kb)

! Move some of the member specific stuff (general options, plus signatures and profile fields) into their own entry in Members area, instead of under Features and Options. I gave the new settings their own file because ManageSettings is enormous - even now it's still 800 lines, as opposed to 2000. (Admin.php, Admin.template.php, Admin.english.php, ManageMemberOptions.php, ManageSettings.php, ManageSettings.english.php, ManageSettings.french.php)

rev 929 (this one is mine...)
(8 files, ??kb)

! Fixed Warm: background color for hidden sidebar and user menu, removed bullets, right-floated the avatar, and removed a couple of extra empty lines from the main menu. (Warm/index.css)

! Don't bother to base64-encode smileys if gzip is not supported by the browser, as it'll take too much space. (Subs-Cache.php)

! Ensure the Actions pretty URL filter doesn't cannibalize the Profiles filter by being run before it. (ManageSettings.php)

* Unencoded smiley URLs should be relative, not absolute. (Subs-Cache.php)

* Nanosecond optimization. (PrettyUrls-Filters.php, Subs-PrettyUrls.php)

* Terminology (temp?) fix. (Admin.language.php)

* Commenazi. (Post2.php)

rev 930
(2 files, 6kb)

* Translation. (Admin.french.php, ManageSettings.french.php)
Re: New revs
« Reply #934, on August 16th, 2011, 04:08 PM »
rev 931
(32 files, 35kb) (most of it automated really. With a double-check.)

! Fixed right alignment of sidebar feed links in Warm. (Warm/index.css)

* Preventing horizontal overflow for code boxes. Need to find something better... (index.css)

* Renamed smc_* to we_* (or we* depending on the object), project-wide. You should now use weEditor, weAutoSuggest, weSaveEntities, weButtonBox, etc. (30 files, not listing them all.)
Re: New revs
« Reply #935, on August 16th, 2011, 11:55 PM »
rev 932
(39 files, 32kb -- did all of these manually... ouch >_<)

* Got rid of most display:none's and replaced them with the 'hide' class. (install.sql, Class-Editor.php, Aeva-Foxy.php, Subs.php, TEMPLATES: Admin, BoardIndexInfoCenter, Calendar, index, ManageMaintenance/Media/Membergroups/ ManageNews/Paid/Permissions/Smileys, Media, ModerationCenter, MoveTopic, Packages, PersonalMessage, Post, Profile, Recent, Register, Reminder, Search, SplitTopics, Themes)

* Started converting smf_ to wedge_ or we_, or at least preparing the code for the change. Renamed smfSelectText to weSelectText. (install.sql, readme_convert.html, ssi-examples.php, upgrade.php, latest-news.php, Credits.php, ManageMedia.language.php, Who.language.php, ManageMedia.template.php, script.js)

- detailed-version.js was attempting to be included twice. Wedge didn't let that happen, but might as well not try in the first place, right...? (Admin.template.php)

- Removed smf_session_id fallback -- it's a leftover from SMF 1.0 (emphasis on the zero.) (sha1.js)

+ Although it's a hidden setting, disable_smf_js should be used consistently, including in the moderation center. I'm still leaving it out of the detailed version page, though... It would make sense not to use it there. (ModerationCenter.template.php)

@ Tomorrow: the smf_ automated update :P (Checked them all, the 700+ occurrences, should be good... Except for variables that will get reset.)
Re: New revs
« Reply #936, on August 17th, 2011, 10:38 AM »
rev 933
(18 files, 18kb)

* More manual name conversions, this time from _smf to _wedge and smf_ to wedge_. (readme_convert.html, smfinfo.php, latest-packages.php, Admin.php, ManageServer.php, THEMES: Admin, ManageSmileys, ModerationCenter, Packages, Themes, LANGUAGES: Admin, ManageSettings)

- Removed utf8 parameter from the language file manager, considering all language files are now UTF8... (ManageServer.php, Admin.template.php, ManageSettings.language.php)

- SMF bug: removed unused string $txt['identification_by_smf']. (Login.language.php)
Re: New revs
« Reply #937, on August 17th, 2011, 11:01 AM »
rev 934
(166 files, 100kb)

* Changed the SMF constant to WEDGE, in pretty much all files outside of the theme (automatic replacements, manually checked.) Also started converting regular SMF string to Wedge or whatever the context requires. (index.php, readm... hey, I said pretty much ALL the files, do you honestly think I'm going to list them all?!)

Arantor

  • As powerful as possible, as complex as necessary.
  • Posts: 14,278
Re: New revs
« Reply #938, on August 17th, 2011, 12:08 PM »
Revision: 935
Author: arantor
Date: 11:04:44, 17 August 2011
Message:
! Don't allow edits of posts to have drafts; if you're editing a post, you can just resave it in situ instead, no need to keep saving drafts of it. (Post.php, Subs-Post.php)
----
Modified : /trunk/Sources/Post.php
Modified : /trunk/Sources/Subs-Post.php
When we unite against a common enemy that attacks our ethos, it nurtures group solidarity. Trolls are sensational, yes, but we keep everyone honest. | Game Memorial

Nao

  • Dadman with a boy
  • Posts: 16,082
Re: New revs
« Reply #939, on August 17th, 2011, 12:51 PM »
rev 936
(68 files +1-3, 91kb)

! Forgot to convert a smf_sess. Also removed the last remaining smf_session_id, and removed a useless test. (Load.php, script.js)

- Removed a couple of outdated files and renamed smf_api to wedge_api (although I doubt we'll ever use it, just like most of the tools.) (wedge_api.php, add_settings-1x.php, boardmod.mod)

* Removed the 'Demo' version type (I don't think we're ever going to release a 'demo'?), renamed CVS version type to SVN, and removed a few CVS filename handling tests (who uses that nowadays?). (current-version.php, Class-DB.php, Subs-Package.php, Themes.php)

* Renamed smfLanguage* and smfUpdate* variables to we*. (tools, admin.js)

* Renamed smf_editorArray to weEditors. (script.js, etc.)

* Renamed smf_oCurrentResizeEditor to weCurrentResizeEditor, and smf_execCommand to we*. (editor.js)

* Renamed smf_openid_* and smf_openID_* to we_openID_*. (index.php, Login2.php, Profile.php, Profile-Modify.php, Register.php, ScheduledTasks.php, Security.php, Subs-OpenID.php)

* Changed Aeva's lookup user agent to something more browsery and with a proper URL for server admins to check. (Aeva-Embed.php)

* And finally, renamed SMF (uppercase) to Wedge wherever it was used to qualify the current software (i.e. not older versions, or proper credit.) (Dozens of files...)
Re: New revs
« Reply #940, on August 17th, 2011, 01:25 PM »
rev 937
(31 files, 30kb)

* Renamed every single remaining smf_ reference to either we_ or we. Too. Tired. Won't. List. Files. (About 30)

- Removed unused $txt['cannot_connect_doc_site'] variable. (Errors.language.php)

Arantor

  • As powerful as possible, as complex as necessary.
  • Posts: 14,278
Re: New revs
« Reply #941, on August 17th, 2011, 02:28 PM »
More admin panel stuff. Yes, the typo is there in the original log entry too :P


Revision: 938
Author: arantor
Date: 13:26:47, 17 August 2011
Message:
! Convert the 'Log Pruning' page into a more general 'Log Settings' page, and move a couple of items to it, for controlling the error log. (Admin.php, ManageSearchEngines.php, ManageSettings.php, Admin and ManageSettinsg language files, old unit test)

! Template eval is now disabled by default. (install.sql)

! Default password strength is medium, not low, by default. Means 8 character password, no reusing username, instead of 4 character minimum. (install.sql)

! Made 'Registration' into 'Registration and Login' since some of the settings apply to both login and registration instead of some random area of the admin panel, and moved a couple of settings into it. (ManageRegistration.php, ManageSettings.php)
----
Modified : /trunk/Sources/Admin.php
Modified : /trunk/Sources/ManageRegistration.php
Modified : /trunk/Sources/ManageSearchEngines.php
Modified : /trunk/Sources/ManageSettings.php
Modified : /trunk/Themes/default/languages/Admin.english.php
Modified : /trunk/Themes/default/languages/Admin.french.php
Modified : /trunk/Themes/default/languages/ManageSettings.english.php
Modified : /trunk/other/install.sql
Modified : /trunk/other/unittest/tests/Class-UnitTest_tidyhtml.php
Re: New revs
« Reply #942, on August 17th, 2011, 03:29 PM »
Revision: 939
Author: arantor
Date: 14:25:54, 17 August 2011
Message:
! Removal of the last vestiges of 'do not show contact details to guests, they're just not shown to guests now. (ManageSettings.php, Security.php, SendTopic.php, Help and ManageSettings language files)

! Custom fields now have an option for visible to guests (only when the field would otherwise be available to regular users), which means the profile fields that are used for things like AIM can be hidden from guests, which was the remaining thing controlled by the above setting. (install.sql, Load.php, ManageMemberOptions.php, Admin.template.php, ManageSettings language file)
----
Modified : /trunk/Sources/Load.php
Modified : /trunk/Sources/ManageMemberOptions.php
Modified : /trunk/Sources/ManageSettings.php
Modified : /trunk/Sources/Security.php
Modified : /trunk/Sources/SendTopic.php
Modified : /trunk/Themes/default/Admin.template.php
Modified : /trunk/Themes/default/languages/Help.english.php
Modified : /trunk/Themes/default/languages/Help.french.php
Modified : /trunk/Themes/default/languages/ManageSettings.english.php
Modified : /trunk/Themes/default/languages/ManageSettings.french.php
Modified : /trunk/other/install.sql

Posted: August 17th, 2011, 03:26 PM

Revision: 940
Author: arantor
Date: 14:29:30, 17 August 2011
Message:
! Admin / Members / Member Options had the wrong default function, should have used the first tab not the last. (ManageMemberOptions.php)
----
Modified : /trunk/Sources/ManageMemberOptions.php

Nao

  • Dadman with a boy
  • Posts: 16,082
Re: New revs
« Reply #943, on August 17th, 2011, 03:38 PM »
rev 941
(12 files, 12kb)

- The Settings files shouldn't have a version number in them, as they're not intended to be upgraded later. (Settings.php, Settings_bak.php)

* A few more contextual changes from Simple Machines to Wedge. (*/readme.html, ManageServer.php, ModerationCenter.php, Themes.php, Admin.language.php)

* French translation. (Admin.french.php, ManageSettings.french.php)

! Warm's windowbg classes shouldn't really use alpha transparency, as the class is used in so many different places. Maybe I should introduce a postbg and postbg2 or something to account for topics, and have them based automatically on windowbg...? (Warm/index.css)

@ Pete: what was the typo you mentioned in 938...?

Arantor

  • As powerful as possible, as complex as necessary.
  • Posts: 14,278
Re: New revs
« Reply #944, on August 17th, 2011, 03:39 PM »
Revision: 942
Author: arantor
Date: 14:37:15, 17 August 2011
Message:
! Oops, forgot to ensure that guest access to fields was applied in profiles as well. (Profile.php)
----
Modified : /trunk/Sources/Profile.php



@Nao, the typo in r938 is in the changelog itself:
Quote
(Admin.php, ManageSearchEngines.php, ManageSettings.php, Admin and ManageSettinsg language files, old unit test)
Plugin revs »