New revs

Nao

  • Dadman with a boy
  • Posts: 16,082
Re: New revs
« Reply #915, on August 6th, 2011, 11:35 AM »
rev 908
(9 files, 12kb)

- Removed site list's ability to self-update, as I don't see myself updating it outside of the main software's updates themselves. You can update manually from further Wedge updates, obviously. Also removed some outdated code that checked for new Aeva Media versions. (Aeva-Embed.php, ManageMedia.php, ManageMedia3.php, Subs-Media.php, ManageMedia.language.php, Media.language.php)

* Casenazi. (PersonalMessage.php)
Re: New revs
« Reply #916, on August 7th, 2011, 09:54 AM »
rev 909
(29 files +5-5, 104kb)

* Replaced $forum_version with WEDGE_VERSION constant. It was already defined, just not used. This eliminates the need to globalize $forum_version each time you need it. Version number also gets rid of the 'Wedge' element. We only want a number! (index.php, install.php, smfinfo.php, upgrade.php, current-version.php, detailed-version.php, Calendar.php, Class-DB.php, Credits.php + Who template collateral, Feed.php, ManageMaintenance.php, ManageMedia.php, ManageServer.php, PackageGet.php, ScheduledTasks.php, Subs-Package.php, Subs.php, index.language.php, Packages.template.php)

* More renaming of SMF to Wedge in versioning and things like that, like fixing and optimizing the JS for the detailed version page. It was all very messy to begin with and it's done across this commit and the next anyway. (Install.language.php, admin.js...)

* Renamed Findmember to FindMember, Jseditor to JSEditor, Jsoption to JSOption, Printpage to PrintPage and Unreadreplies to UnreadReplies. Both for function names and file names. The next commit will fix the filenames (due to a SVN limitation.) (index.php, temp.*.php)

* Simplified admin JS object, by shortening some ridiculously long variable names and hardcoding version compare DOM IDs. Who would change them anyway?! SMF2 has a tendency to encourage the multiplication of settings when it should instead be deciding whether or not something is likely to be changed in the future. (Admin.php, admin.js)

* list (), not list()... (upgrade.sql, current-version.php, latest-packages.php, latest-themes.php)
Re: New revs
« Reply #917, on August 7th, 2011, 09:59 AM »
rev 910
(10 files, 12kb)

! Fixed Safari 2.x not using readOnly on form submit (heck, I'm not even sure if this bug was valid to begin with?), and optimized invertAll. (script.js)

! Helper functions should use camelCase, thanks John. (PersonalMessage.php)

* Finished version renaming stuff. (Admin.template.php)

! What was 'Wedge (originally SMF) Add-on' language string supposed to mean in the Admin area's detailed version page? It's only giving us the main version... And if it's supposed to be the version of the package that made the upgrade... Isn't it supposed to be the same? (Admin.language.php)

- Removed more of the auto-update code for AeMe. (ManageMedia.template.php, Media.template.php)

* Updated some outdated file headers. (Subs-Aeva-Sites.php, Media.language.php)
Posted: August 7th, 2011, 09:57 AM

rev 911
(0 files +5-5)

! Grmpf... Was in a hurry to grab something to eat, and forgot to rename the files like I was supposed to in rev 910. (temp.*.php)
Re: New revs
« Reply #918, on August 7th, 2011, 12:49 PM »
rev 912
(27 files, 26kb)

* Renamed smfVersion to weVersion and smfVersions to weVersions (also changes the smfVersion setting name in the DB, FYI). Also renamed a few rarely used global JS variables in a similar fashion. (install.php, install.sql, smfinfo.php, upgrade.php, upgrade.sql, current-version.php, detailed-version.php, latest-*.php, mirrors.xml, Class-DB.php, Themes.php, admin.js, TEMPLATES: Admin, ManageSmileys, Packages, Themes)

* Renamed remaining typeof()s to just typeof. (smfinfo.php, latest-themes.php, Aeva-Foxy.php, MessageIndex.template.php, Packages.template.php, Profile.template.php, Themes.template.php, spellcheck.js)

* Normalized all remaining keyCode calls to $.which. (MessageIndex.template.php, zoomedia.js)

- There was no reason to call smf_codeFix since it's always called as needed in the default theme anyway... (Post.template.php)

* One more variable name optimization. (script.js)

@ Note: I'm not 100% sure about documenting all of the files where typeof was changed. Who cares...
Re: New revs
« Reply #919, on August 7th, 2011, 01:35 PM »
rev 913
(3 files, 19kb)

* Moved media table creation from db_aeva to the regular Wedge installer. db_aeva still needs to be run at this point, but it'll soon be a thing of the past. (db_aeva.php, install.sql)

* Forgot to save the editor, where I had another keyCode to which conversion. (editor.js)

Arantor

  • As powerful as possible, as complex as necessary.
  • Posts: 14,278
Re: New revs
« Reply #920, on August 8th, 2011, 10:34 AM »
Revision: 914
Author: arantor
Date: 09:33:24, 08 August 2011
Message:
! Remove the 'make emails visible' option, it's just not needed to present emails as-is for all members (even just to other members) as an option. (All files mentioned here are related to this change, namely cleaning out the old 'yes' branch)
----
Modified : /trunk/Sources/Feed.php
Modified : /trunk/Sources/ManageSettings.php
Modified : /trunk/Sources/Security.php
Modified : /trunk/Sources/SendTopic.php
Modified : /trunk/Sources/Subs-Auth.php
Modified : /trunk/Themes/default/Display.template.php
Modified : /trunk/Themes/default/ManageMembergroups.template.php
Modified : /trunk/Themes/default/PersonalMessage.template.php
Modified : /trunk/Themes/default/Profile.template.php
Modified : /trunk/Themes/default/languages/Help.english.php
Modified : /trunk/Themes/default/languages/Help.french.php
Modified : /trunk/Themes/default/languages/ManageSettings.english.php
Modified : /trunk/Themes/default/languages/ManageSettings.french.php
Re: New revs
« Reply #921, on August 8th, 2011, 10:52 AM »
Revision: 915
Author: arantor
Date: 09:48:56, 08 August 2011
Message:
! Made the warning system permanently on, seeing how we're going to be making more use of it. Most of this is simply removing two sets of is-enabled checks. (install.sql, Admin.php, Display.php, ManagePermissions.php, ModerationCenter.php, PersonalMessage.php, Profile-Actions.php, Profile-View.php, Profile.php, ScheduledTasks.php, ManageSettings.language.php)
----
Modified : /trunk/Sources/Admin.php
Modified : /trunk/Sources/Display.php
Modified : /trunk/Sources/ManagePermissions.php
Modified : /trunk/Sources/ManageSettings.php
Modified : /trunk/Sources/ModerationCenter.php
Modified : /trunk/Sources/PersonalMessage.php
Modified : /trunk/Sources/Profile-Actions.php
Modified : /trunk/Sources/Profile-View.php
Modified : /trunk/Sources/Profile.php
Modified : /trunk/Sources/ScheduledTasks.php
Modified : /trunk/Themes/default/languages/ManageSettings.english.php
Modified : /trunk/Themes/default/languages/ManageSettings.french.php
Modified : /trunk/other/install.sql

Posted: August 8th, 2011, 10:49 AM

Revision: 916
Author: arantor
Date: 09:52:00, 08 August 2011
Message:
! Oops, forgot to remove the warning_enabled default setting from the installer. (install.sql)
----
Modified : /trunk/other/install.sql
When we unite against a common enemy that attacks our ethos, it nurtures group solidarity. Trolls are sensational, yes, but we keep everyone honest. | Game Memorial

Nao

  • Dadman with a boy
  • Posts: 16,082
Re: New revs
« Reply #922, on August 8th, 2011, 11:48 AM »
rev 917
(8 files, 12kb)

* Renamed $txt['board_topics_*'] to $txt['topics_*'] to harmonize with posts and redirects, grouped them together, and fixed the few occurrences of $txt['board_topics'] that weren't converted yet. Also removed the ucfirst on processed Posts, Topics and Redirects, since they're guaranteed to have a number before them. (SSI.php, BoardIndex.template.php, MessageIndex.template.php, index.language.php)

! add_js() was using a wrong restarter CDATA, oops. (Subs-Cache.php)

* Some tweaks to the user box. (sections.css)

* First topic post now sports a slightly larger font to differentiate it from the rest. Best used in blog posts. (sections.css)

* Testing other fonts for topic posts. Readability is vital here, and Arial 14px, as cool as it is in the UI, may not be the most suitable for posts. (index.css)
Re: New revs
« Reply #923, on August 8th, 2011, 06:37 PM »
rev 918
(13 files, 16kb)

! Aeva auto-embedding should now be applied only to popular sites by default (until you fine-tune the admin settings). This saves about 0.1s per call to parse_bbc(). (Aeva-Embed.php, ManageMedia3.php)

! self:: doesn't seem to work on public static functions. Using the object name instead. (Class-String.php)

* Removed these websites from the Popular embed list (not actually that popular these days): Bebo, Imeem, Truveo. (Subs-Aeva-Sites.php)

* Moved these websites to the Popular embed list (according to Alexa ranks): Break, Hulu, Last.fm (Audio). (Subs-Aeva-Sites.php)

* Spacinazi. Ternary operators are always processed after == :) (Feed.php, Subs-Auth.php)

* Moved a long comment out of a function. (Security.php)

* Okay, I give up for now... Back to Verdana for posts for now. In terms of readability, it's hard to do better on an imported SMF forum, otherwise it's too much of a change. For now. (index.css, sections.css)

* Now calling number_context in board index and in-topic stats, for the number of replies and views. (Display.template.php, MessageIndex.template.php, index.language.php)

- Had a remaining board_topics call. (MessageIndex.template.php)

@ Note: I would really appreciate if someone could take some time and look into video site popularities. Or even test the current state of Aeva embedding -- do all sites work as expected, etc. I wonder if I really should have sites like MySpace Videos or video.msn.com in the popular list... Do people embed these often?
Re: New revs
« Reply #924, on August 8th, 2011, 07:39 PM »
rev 919
(3 files, 5kb)

! Error when no news lines were filled in. (Subs.php, index.template.php)

* Spacinazi. (Subs-BoardIndex.php)
Re: New revs
« Reply #925, on August 9th, 2011, 04:16 PM »
rev 920
(32 files, 45kb)

* Updated 'div ul.buttonlist' to 'ul.buttonlist'. Saves some space. (index.template.php, index.css, sections.css, topic.js, Media.template.php)

* Updated the button strip visuals to something a tad less gloomy. (sections.css, index.rtl.css, media.css)
* Harmonized and simplified approvebg, stickybg, lockedbg. Also cleaned up half a dozen unused classes. (index.css, sections.css, index.rtl.css, media.css, Wuthering/sections.css, Display.template.php, MessageIndex.template.php, Recent.template.php)

* Harmonized pagesection divs, and turned pagelinks into .pagesection nav. (Aeva-Foxy.php, Aeva-Gallery2.php, Media.language.php, TEMPLATES: Display, GenericList, ManageMedia, ManageMembergroups, Media, Memberlist, MessageIndex, ModerationCenter, PersonalMessage, Profile, Recent, Reminder, Search, SplitTopics, Who)

! Undefined $merge_safe variable in some situations. (Display.php)

! Fixed text colors in viewquery mode. (ViewQuery.php)

- Removed the default 'right' parameter from button strips when still used. (TEMPLATES: BoardIndex, Calendar, PersonalMessage, Recent, Reports)

- References to .align_* classes were left in. (Reminder.template.php)

! SMF bugs: if a topic is stickied and locked, the Search template won't generate the correct class. Also, the template never actually uses it... (Search.template.php)

* Spacinazi. (Profile.template.php, Xml.template.php)
Re: New revs
« Reply #926, on August 10th, 2011, 06:15 PM »
rev 921
(3 files, 6kb, not a very interesting commit I know...)

* Renamed cache keys to use Wedge instead of SMF. There are going to be a lot of minor renames like this overall... (Subs-Cache.php)

! Category headers could be pushed to the right (e.g. by the menu) when reducing the window width. (index.css)

* Approve button was a bit off, too. (sections.css)

Arantor

  • As powerful as possible, as complex as necessary.
  • Posts: 14,278
Re: New revs
« Reply #927, on August 11th, 2011, 01:59 PM »
Revision: 922
Author: arantor
Date: 12:58:49, 11 August 2011
Message:
! Mismatched tags in the who's viewing sidebar template in message index. (MessageIndex.template.php)

! Time to be controversial; removing meta keywords. Most forums have them turned off, the ones that don't have global keywords that don't help, and major search engines don't use them anyway, so it's actually work that isn't needed. (Subs.php, ManageSettings.php, index.template.php, ManageSettings and Help language files)

! Added general facility for meta description support, now to be used in the message index and more places in future. (index.template.php, MessageIndex.php)
----
Modified : /trunk/Sources/ManageSettings.php
Modified : /trunk/Sources/MessageIndex.php
Modified : /trunk/Sources/Subs.php
Modified : /trunk/Themes/default/MessageIndex.template.php
Modified : /trunk/Themes/default/index.template.php
Modified : /trunk/Themes/default/languages/Help.english.php
Modified : /trunk/Themes/default/languages/Help.french.php
Modified : /trunk/Themes/default/languages/ManageSettings.english.php
Modified : /trunk/Themes/default/languages/ManageSettings.french.php

Nao

  • Dadman with a boy
  • Posts: 16,082
Re: New revs
« Reply #928, on August 11th, 2011, 05:14 PM »
rev 923
(5 files, 7kb)

+ Added ability to load a CSS file in the header even after that header has been filled, e.g. from within parse_bbc(). (Subs-Cache.php, Subs.php, index.template.php)

* Minor tweaks to the post button bar. (sections.css)

* Harmonized text color on button strips. (sections.css)

! Mismatched curly brace. (GenericList.template.php)
Re: New revs
« Reply #929, on August 13th, 2011, 04:36 PM »
rev 924 (and that's not even the big commit... :whistle:)
(15 files +1, 20kb)

- Replacing seldom used we_images_url JavaScript variable with we_theme_url + '/images'. (index.template.php, ManageMembergroups.template.php, Themes.template.php, suggest.js, register.js)

* Minor fixed to post page button layout. (sections.css)

* Spacinazi. Please note that 'input_attr' now expects an extra space. I'm not wasting CPU cycles on just two specific form entries. (Register.template.php, Profile.template.php, Profile-Modify.php)

! Harmonized descriptions for smileys and smiley-based topic icons. Also fixed bad French translations for these. (index.language.php, Install.language.php)

+ Added the Edit smiley to the Aaron smiley set. (edit.gif)

* Smileys that are not installed by default in the visible postbox area should be in the popup, rather than hidden. (install.sql)