New revs

Nao

  • Dadman with a boy
  • Posts: 16,082
Re: New revs
« Reply #870, on July 13th, 2011, 07:20 PM »
rev 862
(6 files, 9kb)

* Minor details and fixes for the separator code. (Admin.php, GenericMenu.template.php)

- Why are we adding a class for something that's not even useful? (Admin.template.php, admin.css)

! Just because I spent months on that silly translation already, doesn't mean I don't have to keep improving it. (Help.french.php, Profile.french.php)
Re: New revs
« Reply #871, on July 14th, 2011, 12:57 AM »
rev 863
(5 files, 11kb)

* Rewrote uuid code in Atom feeds to instead use a tag URI (RFC 4151), in the form "tag:domain.com,2011-07-01:msg-7". It may not be the definitive code, but it's better than a UUID. Also removed the last compatibility code block. Really no need for that... (Feed.php, QueryString.php)

! Typo. (Help.french.php)

* In a world where war rages on every day, I believe it's important to say 'Hello' rather than 'Hi'. Who is Wedge to say you want to say Hi when you may not even know who you're talking to? (ManageSettings.language.php)


@ Note: totally unrelated... It appears that not many people tested the automatic quote splitter :P It fails badly when pressing Enter after a self-closed tag such as more, media etc. Also fails horribly when splitting URL tags. Okay, is anyone ever testing my crappy code? :P
Re: New revs
« Reply #872, on July 14th, 2011, 06:40 PM »
rev 864 (another big one!)
(36 files, 37kb)

* Rewrote the post layout for topic views. Ohhhh yeah. Now using display: table and sporting more freedom. Will fix IE6 and IE7 later. If they're nice enough. Also, section.css could probably use some cleaning up. (Display.template.php, sections.css)

* Rewrote JavaScriptEscape() to avoid escaping tabs and newlines. Also gave up on escaping tag closers, as I couldn't find any single reason for doing so. And using shorter hacks for script, href and scripturl situations. (Subs.php)

* Renamed global smf_* Js variables to we_*, and smf_scripturl to we_script, as it's used more often, so might as well have it shorter. (various other/* files, editor.js, mediadmin.js, register.js, script.js, stats.js, suggest.js, topic.js, up.js, Admin.php, TEMPLATES: index, ManageMembergroups, Packages, Post, SplitTopics, Themes)

* Moved registration center next to the member list in the admin menu, as semantically it's closer to that, than to the permission/ban stuff. (Admin.php)

! Avoid duplicates in closed tag list when doing the split quote thing. Needs a rewrite though. (Class-Editor.php)

* Indenazi, Pretty URL replace buffer cleanup and other useless changes. (Subs.php, ManageMedia.english.php, post.js, index.css)

! Event delayer was systematically doing a failed bind() for each and every event in the page. Oops, my bad. (Subs.php)

- sScriptUrl and sImagesUrl are never used (or never useful) in a couple of JS objects. (Display.template.php, Media.template.php, topic.js)

* Renamed admin menu entry 'Reports' to 'Detailed Reports'. I think it should help differentiate it from moderator reports. I always get confused by this. (Admin.language.php)

* Updated French translation. (Admin.french.php, ManageMedia.french.php)

! It's Rank images, not Stars. (ManageMembers.language.php, Reports.language.php)

! Fixed toggler in the email settings page. Note: we need to turn this into a PROPER Wedge toggler... (ManageNews.template.php)

* Various script.js changes that may or may not be reverted later: a semi-fix for reqWin title retrieval (doesn't actually work on text nodes, uh...), and a hack to prevent Firefox from fixing the reqWin event. (script.js)

! Apparently, Firefox 5 (and earlier?) doesn't like when jQuery creates a hidden input and adds a name param separately. Fixed by putting the name into the tag string itself. (suggest.js, topic.js)
Posted: July 14th, 2011, 05:09 PM

rev 865

! Typo crash. (Admin.php)
Re: New revs
« Reply #873, on July 14th, 2011, 09:28 PM »
rev 866 (another big commit... U mad bro?)
(16 files, 27kb)

* Moved user box template to its own function. (Display.template.php)

* Subtle changes to the post box to please Pete, err, to make it less crowded. (sections.css)

* Boldly attempting to remove the border around fieldsets in the admin homepage. Only there, eh. Makes the page less... crowded, you got it. (index.css)

! Media embedder still had a deprecated table align. Ouch. (Subs-Media.php)

! In some situations (namely Wedge rewriting the tab_data stuff with its own data to finetune tab positions), Wedge would fail noticing that it shouldn't be trying to show a context menu item. (GenericMenu.template.php)

- As far as I know, $txt['attachment_log'] is not used anywhere. (Admin.language.php)

* Ugly warning in Attachment/Avatar admin area. (ManageAttachments.php, Admin.language.php)

* Log pruning area has long descriptions in French, so I added bold tags around the actual names of the logs. (ManageSettings.french.php)

* Indenazi. (Subs-Menu.php)

* Large cleanup in the Log admin area. spider logs lost their plural, all log menu entries are now repeated (once for their in-context menu entry, once for the Log menu area, enabling to drop the 'log' part of the name and keep the context menu on a single line in French and other long languages), renamed pruning_title to log_pruning, etc. (Admin.php, ManageSearchEngines.php, ManageSettings.php, Admin.language.php, Search.language.php, ManageSearch.template.php)
Re: New revs
« Reply #874, on July 14th, 2011, 11:45 PM »
rev 867
(6 files +1, 11kb)

* More changes to the topic view. Both Report to Moderator links are now in the user box, with the main one getting its own (temp) icon. And it no longer shows on user's own posts (which always baffled me because sometimes they'd use this as a way to draw attention on their own posts.) Also reworded 'Report to moderator' to 'Report this message to a moderator', because hover titles can be longer, right? (Display.template.php, report.gif, index.language.php, sections.css)

* Nothing interesting. (PersonalMessage.english.php, ManageNews.template.php)

Arantor

  • As powerful as possible, as complex as necessary.
  • Posts: 14,278
Re: New revs
« Reply #875, on July 15th, 2011, 08:48 AM »
Revision: 868
Author: arantor
Date: 07:48:22, 15 July 2011
Message:
! Some more icons for the admin panel. (Admin.php, *.png)
! Minor tag mismatch in the credits page. (Credits.php)
+ Added ability for icon copyrights to be displayed in the credits too. Feel free to edit or mash up if you don't like it, but we should be attributing where appropriate. (Credits.php, Who.english.php, Who.template.php)
----
Modified : /trunk/Sources/Admin.php
Modified : /trunk/Sources/Credits.php
Modified : /trunk/Themes/default/Who.template.php
Added : /trunk/Themes/default/images/admin/about.png
Added : /trunk/Themes/default/images/admin/addon_manager.png
Added : /trunk/Themes/default/images/admin/addon_settings.png
Added : /trunk/Themes/default/images/admin/current_theme.png
Added : /trunk/Themes/default/images/admin/custom_fields.png
Added : /trunk/Themes/default/images/admin/media_maintenance.png
Added : /trunk/Themes/default/images/admin/mediasettings.png
Added : /trunk/Themes/default/images/admin/news_and_newsletters.png
Added : /trunk/Themes/default/images/admin/search_engines.png
Added : /trunk/Themes/default/images/admin/serversettings.png
Added : /trunk/Themes/default/images/admin/smileys.png
Modified : /trunk/Themes/default/images/admin/themes_and_layout.png
Modified : /trunk/Themes/default/languages/Who.english.php
When we unite against a common enemy that attacks our ethos, it nurtures group solidarity. Trolls are sensational, yes, but we keep everyone honest. | Game Memorial

Nao

  • Dadman with a boy
  • Posts: 16,082
Re: New revs
« Reply #876, on July 15th, 2011, 09:31 AM »
rev 869
(8 files +3-3, 18kb)

! Never noticed that before, but the main content was misaligned in floating sidebar mode. (index.css)

* Don't show « » in Last edit, and show it in italics only through CSS. (Display.template.php, sections.css)

* Say "Last edited" instead of "Last edit", since it's followed with "today", "yesterday" or "on Date". (index.english.php)

* Renamed some bigicons to keep underscore consistency. (ban_list.png, media_settings.png, server_settings.png, Admin.php)

* The admin area's placeholder icon should be at the same size as the rest... (Admin.template.php)

* Translation, or lack thereof. (Who.french.php)

Arantor

  • As powerful as possible, as complex as necessary.
  • Posts: 14,278
Re: New revs
« Reply #877, on July 15th, 2011, 10:41 AM »
Revision: 870
Author: arantor
Date: 09:41:22, 15 July 2011
Message:
! Added an alternative hostname resolver that should be faster on most systems with no noticeable change in quality of result (and won't hit timeouts the same way gethostbyaddr does if the address is non-existent) (Subs.php)
----
Modified : /trunk/Sources/Subs.php

Nao

  • Dadman with a boy
  • Posts: 16,082
Re: New revs
« Reply #878, on July 15th, 2011, 05:01 PM »
rev 871
(6 files, 14kb)

+ Added ability to position message user boxes to the right of the post, instead of the left. Defaults to the right for now (opposite the sidebar.) (Display.php, Display.template.php, sections.css)

* Improved AeMe image embedding styling. (media.css)

* Repositioned down arrows in the main menu a pixel further down, because it felt a bit misaligned. Only a bit really. Also saved a few bytes by not re-including menu.gif, which was already included for h4 tags. (index.css)

* Some profile options had finishing periods, when surrounding options didn't. (Profile.english.php)
Re: New revs
« Reply #879, on July 15th, 2011, 11:39 PM »
rev 872
(7 files, 32kb)

- AeMe code was still using reqWin(this.href). Although technically still all right, we don't need to specify the ".href" anymore... (Aeva-Gallery2.php, ManageMedia2.php, Media.template.php)

! Applied youtu.be fix to thumbnail retrieval. (Aeva-Embed.php)

* Rewrote title retrieval code for help popups. Now works on all of the help links I could think of. I'm not going to test them all, eh... Hopefully we'll rewrite this mess of an admin area later. (script.js)

* Serious update to the help popup language files. Hardcoded titles were removed. Quote entities changed to double quotes. Double spaces made single again. Updated SMF and simplemachines to Wedge where expected. Rewrote time_format and custom_mask help popups to be actually usable, and to fix many inconsistencies in the descriptions. Fixed some "users" to users' or user's. (Someone was having problems with their English grammar.) (Help.english.php, Help.french.php)
Re: New revs
« Reply #880, on July 16th, 2011, 12:10 PM »
rev 873
(8 files, 10kb)

* Turned media banning's findmember into an auto-suggest. More to come. (ManageMedia2.php)

! Media banning language string fixes. (Admin.language.php, ManageMedia.language.php, ManageMedia.template.php)

! Javascript trimmer was being incorrectly implemented, should have been $.trim($()), not $().trim(). Hey, what did you expect. (script.js)

* Moved .windowbg/2/3 background colors to $winddow_bg/2/3 variables. (index.css)
Re: New revs
« Reply #881, on July 16th, 2011, 10:46 PM »
rev 874
(31 files, 37kb)

* Renamed smf_prepareScriptUrl to we_prepareScriptUrl, and removed the parameter. It was systematically we_script anyway... BTW, I think I spotted a SMF bug in the multilingual readme selector for packages. (index.template.php, Packages.template.php, Post.template.php, SplitTopics.template.php, Themes.template.php, editor.js, mediadmin.js, register.js, script.js, stats.js, suggest.js, topic.js, up.js)

* Rewrote Jump To box to use pretty URLs when they're enabled. (Ajax.php, Xml.template.php, script.js)

- Simplified Jump To parameters and removed lots of static vars. (Display.php, MessageIndex.php, Display.template.php, MessageIndex.template.php, script.js)

- Removed Jump To from the Search area. Did anyone actually notice there was one in there...? Yup, just what I thought. (Search2.php, Search.template.php)

* Renamed Jump To to Quick Access. UI stuff, you know. I'm not paid a million bucks a month for nothing. BTW, I'm still waiting for my first check. (index.english.php, index.french.php)

* Rewrote Jump To/Quick Access (okay, it's the last time I'm talking about this) to get rid of the "Go" button. To ensure one can still access the current board (which can be done through the linktree next to it anyway), Wedge no longer fills in the current board name separately. Instead, it emphasizes it with a different background color. The rewrite also allowed me to save nearly 300 bytes off the gzipped size of the script file. Yay for me. And I removed the IE hack because, well, it didn't work. Who cares about IE glitches. (script.js)

* Moved Legend icons to the sidebar in Unread Replies and Unread Topics. (Unread.php, Unreadreplies.php, Recent.template.php)

- Class quickbuttons already implied reset and smalltext. (PersonalMessage.template.php, Post.template.php, Profile.template.php, Recent.template.php, Search.template.php)

! Class quickbuttons (again) should only be a table cell in topic view, otherwise it doesn't render well in Recent Posts. (sections.css)

* Slightly modified design for the post title and jump to boxes in topic view. (sections.css)

! In the search box's ignored board list, if you didn't have many boards the layout was odd. (Search.template.php)

- Removed #topic_icons definitions, no longer used. (index.ie6.css, index.ie7.css, sections.css)
Re: New revs
« Reply #882, on July 17th, 2011, 08:09 PM »
rev 875
(7 files, 12kb)

* Instead of 'My Community', Wedge will now set a default non-generic name for your board at install time, based on the URL. For instance, installing it "http://wedge.org/forum/" will automatically name it "Wedge Forum". (install.php, Install.language.php)

! e.keyCode is not standard. jQuery has e.which. (MessageIndex.template.php)

! Found a more 'semantic' workaround for the reqWin event fixer. I still don't want to force recording the current event in delayed events. (script.js)

! Wrong variable name (event should be e). (topic.js)

* Changed menu background again to add the gradient effect back into it. This is now officially the most crowded design I've ever seen for a menu. I'll be right back after my seppuku. (index.css)
Re: New revs
« Reply #883, on July 18th, 2011, 03:54 PM »
rev 876
(12 files, 29kb)

+ Added support for separators in the main menu. (Subs.php, index.template.php)

* Merged the Admin and Moderate menus. Now admins will no longer have to deal with that silly Moderate button, everything is added to the admin menu below a separator. (Subs.php, sprite-menu-32bit.png, sprite.png, index.css)

* Shortened 'Unapproved posts and topics' to just 'Unapproved posts'. Really, it's the same... (index.language.php)

* Made the main menu background a bit more uniform. (index.css)

* Forgot to rename wedge_news in a few places. Also gave the 'we' prefix to admin objects. Also fixed JS errors in the moderation center. (latest-news.php, Admin.php, Admin.template.php, ModerationCenter.template.php, admin.js)
Re: New revs
« Reply #884, on July 19th, 2011, 08:19 PM »
rev 877
(7 files, 23kb)

+ Added an 'action menu' that is for individual posts what the user menu is for post authors. Moved 'report to moderator' to that menu. Work in progress (although it works fine as it is.) (Display.php, Display.template.php, index.language.php, topic.js, sections.css)

! Undefined $php_errormsg. (Load.php)

@ Sorry for the slightly hackish solutions in sections.css, Display.php and topic.js... These were the simplest ones I could devise. Also should point out that for design consistency, I reused the quickbuttons styling on the user menu -- i.e. it now uses uppercase Trebuchet MS instead of normal Verdana. Still unhappy with text alignments, but it's hard to do something 'clean' when you have to use background-image to add icons... :-/