New revs
Plugin revs »

Nao

  • Dadman with a boy
  • Posts: 16,082
Re: New revs
« Reply #855, on July 9th, 2011, 04:36 PM »
rev 846
(3 files, 8kb)

- From last rev (forgot to document it): Removed 'Last post' mention from Recent posts. (Recent.template.php)

* Renamed custom CSS "gradient-background:" to just "gradient:", as it's unlikely to be mixed up with Safari's old "gradient()" function. And honestly, I was lost myself as to what the exact name of the rule was. (Class-CSS.php, index.css, media.css)

* If showing a top-down gradient through the gradient rule, don't bother printing 'top', as it's not required. (Class-CSS.php)

* Some slight changes to the quote box styling. Trying Lucida Sans as quote headers. (Class-CSS.php)

@ Note: I'm working on removing the SMF type of feed data. Also, looking into a workaround for the <author> tag in the RSS specification... Didn't even know they made it mandatory to use an e-mail address in these. A godsend for spammers ;)
Re: New revs
« Reply #856, on July 10th, 2011, 08:22 PM »
rev 847
(3 files, ??kb)

+ Added a $modSettings['feed_root'] variable, automatically set to $scripturl on the first use of a feed, which should serve as a 'permanent' root for Atom feed IDs even after a domain move. (Feed.php)

! Pretty URLs weren't used at all in feeds. Although <guid> would best be left alone, the old PURLs mod from SMF converted them, so for now we'll convert them as well... (Feed.php)

! Indenazi in the original dumpTags call and a comment. (Feed.php, Subs-Boards.php)

- Removed some extra code for the deprecated SMF feed type. A few lines left to delete. (Feed.php)

! Although this warrants further research regarding the usefulness of parsing an entity-encoded item, I cdata-parsed a few things that needed some harmonizing there. (Board names, author names, etc.) (Feed.php)

* Trebuchet MS is an acceptable fallback for quote box headers. (index.css)


rev 848
(1 file, 6kb)

! Fixed the category bug in feeds. Also made schemes non-required (and prettified if present), because it's hardly semantic in our case. (Feed.php)

* Don't bother cdata-parsing a string if it has no objectionable content. (Feed.php)

! category labels shouldn't be cdata-parsed, and instead protected against double quotes. (Feed.php)
Re: New revs
« Reply #857, on July 11th, 2011, 12:15 AM »
rev 849
(1 file, 6kb)

* Atom's id field now uses a UUID for id entries, calculated from the original URL of the item. It's actually a single md5 call so it's really a UUID, but FWIW feed readers won't notice the trick. (Feed.php)

- Deleted a few unused variables from the feed code: num_replies, id_first_member, first_subject, first_poster_name. (Feed.php)

- Removed even more SMF feed code. Put inside parenthesis the rest of the code to be removed. (Feed.php)

@ Pete, feel free to remove the remainder of the commented out code. The only reason I didn't finish this is because I'm falling asleep right now. I don't believe there's anything we need to keep -- or, on the contrary, we could concatenate all of the extra profile info into the description field in Atom and RSS feeds. Whatever you like best...

Arantor

  • As powerful as possible, as complex as necessary.
  • Posts: 14,278
Re: New revs
« Reply #858, on July 11th, 2011, 12:58 PM »
Revision: 850
Author: arantor
Date: 11:58:15, 11 July 2011
Message:
! Move the IM fields into custom field templates. While there are slight changes to formatting, it *should* work out OK; I tested using the newer links and still got the information I should have had... (ManageSettings.php, ManageSettings.english.php, Admin.template.php, facebook.png, steam.png, twitter.png)

@todo: Add a couple more fields (PSN, XBox Live), remove the existing fields.
----
Modified : /trunk/Sources/ManageSettings.php
Modified : /trunk/Themes/default/Admin.template.php
Added : /trunk/Themes/default/images/facebook.png
Added : /trunk/Themes/default/images/steam.png
Added : /trunk/Themes/default/images/twitter.png
Modified : /trunk/Themes/default/languages/ManageSettings.english.php
Re: New revs
« Reply #859, on July 12th, 2011, 09:56 AM »
Revision: 851
Author: arantor
Date: 08:56:12, 12 July 2011
Message:
! Add a time gate to registration. First visit to the registration screen should force a limit of 10 seconds on filling the main form out, if you have any errors, that limit should be reduced to 5 seconds on returning the form. There is, presently, no limit on accepting the registration agreement (should there be one?) (Register.php, Errors.english.php)
----
Modified : /trunk/Sources/Register.php
Modified : /trunk/Themes/default/languages/Errors.english.php
When we unite against a common enemy that attacks our ethos, it nurtures group solidarity. Trolls are sensational, yes, but we keep everyone honest. | Game Memorial

Nao

  • Dadman with a boy
  • Posts: 16,082
Re: New revs
« Reply #860, on July 12th, 2011, 11:29 AM »
rev 852
(3 files, ??kb)

- Right now, I don't believe custom CSS browser prefixes are disabled once the proper rule is implemented[1], so why not save a few bytes off the final files and prevent browsers from giving CSS errors? (Subs-Cache.php)

! Slightly incorrect way of handling $data in getXmlProfile(). (Feed.php)

! Code tags would get incorrect header styling when used within quote tags. Reordered styles to avoid that. (index.css)

* Changed code tag background to adapt itself to any windowbg colors, while retaining the blueish color. (index.css)

* Changed h6 tag (used notably as mini-headers in the credits page) to use the Corbel font on Windows 7 systems. Also increased letter spacing to, hmm... Give peace a chance. Probably gonna change my mind later. Seriously though, Corbel and Calibri are nice fonts, and they have a larger install base than PT Sans, so I should do something with them. (index.css)
 1. I actually spent some time trying to find details about that but found nothing online about it, so I guess they keep compatibility options on.

Arantor

  • As powerful as possible, as complex as necessary.
  • Posts: 14,278
Re: New revs
« Reply #861, on July 12th, 2011, 11:35 AM »
Revision: 853
Author: arantor
Date: 10:34:48, 12 July 2011
Message:
! All instances of setcookie should now be indicating to use httponly. (Since we're using PHP 5.2, there's not even the effort required to make a compatibility function.) (smf_api.php, Poll.php, Security.php, Subs-Auth.php, SSI.php)
----
Modified : /trunk/SSI.php
Modified : /trunk/Sources/Poll.php
Modified : /trunk/Sources/Security.php
Modified : /trunk/Sources/Subs-Auth.php
Modified : /trunk/other/tools/smf_api.php

Nao

  • Dadman with a boy
  • Posts: 16,082
Re: New revs
« Reply #862, on July 12th, 2011, 02:33 PM »
rev 854
(8 files, 13kb)

! Regexp error in the Facebook custom field array. (ManageSettings.php)

! Admin settings use windowbg2 as the default background. (Admin.template.php)

* Validation & indentation nazi. (Admin.template.php)

* Made it a bit clearer (uh, in my fashion...) that the registration error is due to you being a spambot. And also something that bothered me with the Facebook string (again.) (Errors.english.php, ManageSettings.english.php)

* French translation. (Errors.french.php, ManageSettings.french.php)

* Something I'm not sure about, waiting for feedback... Help popups will automatically attempt to retrieve the string they're about, and will reproduce it at the top of the popup. (script.js)

- Removing border color on fieldset legends with windowbg. Maybe it was a tad too much... Adding a border to help popups though. (index.css)

- Back to square one for the h6 tag. Worked well in the credits page, but not anywhere else. (index.css)
Re: New revs
« Reply #863, on July 12th, 2011, 06:58 PM »
rev 855
(4 files, 8kb)

* Moved the admin search box outside of the header, and re-introduced an admin welcome message next to it, this time focusing exclusively on navigational help, or whatever. (Admin.template.php, Admin.language.php, admin.css)

(Just a small feature, I'm adding it separately in case you want to revert it, Pete. Although I'm positive it makes the homepage look less busy.)

Arantor

  • As powerful as possible, as complex as necessary.
  • Posts: 14,278
Re: New revs
« Reply #864, on July 12th, 2011, 11:59 PM »
Revision: 856
Author: arantor
Date: 22:53:38, 12 July 2011
Message:
! Removed the ICQ/AIM/Y!IM/MSN fields from the core; they're now only available as custom profile fields. Really no big loss.

Did also rearrange the last of the strings and tied one up. Hopefully I got the French version right too.

Note that I've left the icons in because they're still usable for now but I'm going to clean them up too shortly. (install.php, install.sql, smf_api.php, Feed.php, Load.php, ManageMembers.php, ManageSettings.php, Memberlist.php, Profile-Modify.php, Register.php, Subs-Members.php, Display.template.php, Admin.english.php, Admin.french.php, Help.english.php, Help.french.php, index.english.php, index.french.php, ManageSettings.english.php, ManageSettings.french.php, Profile.english.php, Profile.french.php, ManageMembers.template.php, Memberlist.template.php, PersonalMessage.template.php, Profile.template.php, Who.template.php)
----
Modified : /trunk/Sources/Feed.php
Modified : /trunk/Sources/Load.php
Modified : /trunk/Sources/ManageMembers.php
Modified : /trunk/Sources/ManageSettings.php
Modified : /trunk/Sources/Memberlist.php
Modified : /trunk/Sources/Profile-Modify.php
Modified : /trunk/Sources/Register.php
Modified : /trunk/Sources/Subs-Members.php
Modified : /trunk/Themes/default/Display.template.php
Modified : /trunk/Themes/default/ManageMembers.template.php
Modified : /trunk/Themes/default/Memberlist.template.php
Modified : /trunk/Themes/default/PersonalMessage.template.php
Modified : /trunk/Themes/default/Profile.template.php
Modified : /trunk/Themes/default/Who.template.php
Modified : /trunk/Themes/default/languages/Admin.english.php
Modified : /trunk/Themes/default/languages/Admin.french.php
Modified : /trunk/Themes/default/languages/Help.english.php
Modified : /trunk/Themes/default/languages/Help.french.php
Modified : /trunk/Themes/default/languages/ManageSettings.english.php
Modified : /trunk/Themes/default/languages/ManageSettings.french.php
Modified : /trunk/Themes/default/languages/Profile.english.php
Modified : /trunk/Themes/default/languages/Profile.french.php
Modified : /trunk/Themes/default/languages/index.english.php
Modified : /trunk/Themes/default/languages/index.french.php
Modified : /trunk/other/install.php
Modified : /trunk/other/install.sql
Modified : /trunk/other/tools/smf_api.php
Re: New revs
« Reply #865, on July 13th, 2011, 02:13 AM »
Revision: 857
Author: arantor
Date: 01:13:03, 13 July 2011
Message:
! Remove custom fields from being in core features, and have it just behave naturally as part of the system. Interestingly there is absolutely no performance change involved. (install.sql, Admin.php, ManageSettings.php, ManageSettings.english.php, ManageSettings.french.php, feature_cp.png)

! Random legacy $smcFunc call we missed (Search2.php)
----
Modified : /trunk/Sources/Admin.php
Modified : /trunk/Sources/ManageSettings.php
Modified : /trunk/Sources/Search2.php
Deleted : /trunk/Themes/default/images/admin/feature_cp.png
Modified : /trunk/Themes/default/languages/ManageSettings.english.php
Modified : /trunk/Themes/default/languages/ManageSettings.french.php
Modified : /trunk/other/install.sql
Re: New revs
« Reply #866, on July 13th, 2011, 09:33 AM »
Revision: 858
Author: arantor
Date: 08:32:41, 13 July 2011
Message:
! Move all the field icons into their own little folder. (ManageSettings.php, fields/*)
----
Modified : /trunk/Sources/ManageSettings.php
Deleted : /trunk/Themes/default/images/aim.gif
Deleted : /trunk/Themes/default/images/facebook.png
Added : /trunk/Themes/default/images/fields
Added : /trunk/Themes/default/images/fields/aim.gif
Added : /trunk/Themes/default/images/fields/facebook.png
Added : /trunk/Themes/default/images/fields/msntalk.gif
Added : /trunk/Themes/default/images/fields/steam.png
Added : /trunk/Themes/default/images/fields/twitter.png
Deleted : /trunk/Themes/default/images/msntalk.gif
Deleted : /trunk/Themes/default/images/steam.png
Deleted : /trunk/Themes/default/images/twitter.png

Nao

  • Dadman with a boy
  • Posts: 16,082
Re: New revs
« Reply #867, on July 13th, 2011, 12:01 PM »
rev 859
(19 files +4-4, 42kb)

* Renamed Stylings to Skins. Renamed Styles folders to Skins. Renamed settings.xml to skin.xml. (install.sql, Load.php, ManageBoards.php, Subs-Boards.php, Subs-Cache.php, Themes.php, TEMPLATES: index, ManageBoards, Themes, LANGUAGES: ManageBoards, Themes, SKINS: index.css)

* Moved moderatorbar inside the post area, to facilitate its styling. Err... Yes, what? I'm currently working on it. (Display.template.php)

! Who crapped into our source code? Fixed a weird bug in the version retrieval code. (Themes.php)

@ To svn readers: rename 'styling' to 'skin' in the member and board tables, go to the admin area > Themes and Layout > Manage and Install, and hit Save.

Arantor

  • As powerful as possible, as complex as necessary.
  • Posts: 14,278
Re: New revs
« Reply #868, on July 13th, 2011, 01:38 PM »
Revision: 860
Author: arantor
Date: 12:38:19, 13 July 2011
Message:
! More admin panel reorganisation: Maintenance is now Server & Maintenance, and Server Settings and Mail live in there (reducing their prominence as they're less commonly used settings), auto embedding is now under Forum, and Media's Maintenance is now also under the Server & Maint. area. Also, auto embedding is no longer in Core Features, but controlled by its own page (in line with the other stuff), which means pretty much going back to AeMe's own code in that respect. (Admin.php, Admin.template.php, Admin.english.php, ManageMedia.english.php, ManageSettings.english.php, ManageSettings.french.php, feature_e.png)
----
Modified : /trunk/Sources/Admin.php
Modified : /trunk/Sources/ManageSettings.php
Modified : /trunk/Sources/media/ManageMedia3.php
Modified : /trunk/Themes/default/Admin.template.php
Deleted : /trunk/Themes/default/images/admin/feature_e.png
Modified : /trunk/Themes/default/languages/Admin.english.php
Modified : /trunk/Themes/default/languages/ManageMedia.english.php
Modified : /trunk/Themes/default/languages/ManageSettings.english.php
Modified : /trunk/Themes/default/languages/ManageSettings.french.php

Nao

  • Dadman with a boy
  • Posts: 16,082
Re: New revs
« Reply #869, on July 13th, 2011, 06:14 PM »
rev 861
(8 files, 20kb)

+ Added separators to submenu items, slightly reordered a few entries, and fixed a logic issue in the menu cleanup code. (Admin.php, Subs-Menu.php, GenericMenu.template.php)

! Information box was too small. (ManagePaid.php)

* Added rounded corners to the admin homepage fieldsets, but it doesn't work well in Opera... Ah well, if it's an Opera bug, I'm not gonna prevent other browsers from showing these. (Admin.template.php)

* Refined Pretty URLs admin area. Made it clearer what the cache option is for (until now, it wasn't even obvious that disabling it would still keep PURLs enabled.) (Admin.template.php, Admin.language.php, admin.css)

* French translation fixes in the admin area. It had a tendency to use words like 'Réglages' a bit too much where 'Paramètres' made more sense. Also, the 'Forum' menu area is called 'layout' internally, so the French translation had 'Apparence'. Since Pete moved the Theme options to another menu area, it was time to reflect the change in the French version as well... (Admin.french.php)
Plugin revs »