New revs
Plugin revs »

Nao

  • Dadman with a boy
  • Posts: 16,082
Re: New revs
« Reply #825, on June 21st, 2011, 07:50 PM »
rev 812
(32 files +2-2, 46kb)

- Removed support for rel="index" meta tags, as it's no longer part of the HTML5 standard. Also moved meta tags below all link tags, to ensure any external files are loaded as soon as possible. (index.template.php)

- Trimmed down external latest news. (other/xml/latest-news.php)

* Changed button strips to use a 'class' element rather than an 'active' boolean, avoiding validation errors when trying to add custom CSS classes. (Aeva-Gallery.php, Aeva-ModCP.php, MessageIndex.php, TEMPLATES: index, Display, Media, Memberlist, PersonalMessage, Recent, Reports)

* Some of my uncommitted layout changes are starting to make their way into the code... Without the stylesheets. Meh. Coming soon! (BoardIndexInfoCenter.template.php, Display.template.php)

* I just don't like seeing 5 lines of code that could look cool and fit on a single line... (Subs-Login.php)

* The default feed format is now Atom rather than RSS 1, and support for SMF (custom) and Webslice feeds has been removed because they've never been commonly used anyway. Media feeds remain in RSS 2 format for now. (Feed.php, BoardIndexInfoCenter.template.php, index.template.php, index.language.php)

* Renamed 'RSS' to 'Atom' or 'feeds'. (index.php, db_aeva.php, rss.png, Feed.php, Load.php, Aeva-Foxy.php, Aeva-Gallery.php, ManageMedia.php, Subs-Media.php, media.css, TEMPLATES: BoardIndex, BoardIndexInfoCenter, index, Media, LANGUAGES: Admin, Help, index, ManageMedia, Post, Stats, Who)

@ Note: I removed the mention about feeds in the Help file, because we're going to move it somewhere else... Let's just not forget to document it when it's done. ;)
Re: New revs
« Reply #826, on June 22nd, 2011, 04:15 PM »
rev 813
(13 files +1, 14kb)

* Bumped minimum PHP version from 5.1.2 to 5.2. Also removed a couple of replacements for PHP 5.2+ specific functions. (install.php, readme_*.html, webinstall.php, Load.php, ManageSettings.php, ManageMedia3.php, Subs-Cache.php)

! A language string wasn't properly updated in feeds. (Feed.php)

! IE9 doesn't support text-shadow. All other browsers have supported it for the last 125 years. Get real, IE. (index.ie9.css)

- Leftover from an early AeMe feature. (Aeva-Sites-Custom-Example.php)
Re: New revs
« Reply #827, on June 24th, 2011, 07:43 PM »
rev 814
(12 files, 16kb)

* Moved the pretty URL initialization code to the installer, removing the need to do it from the admin area. Also greatly simplified the code internally. (install.php, install.sql, ManageSettings.php, PrettyUrls-Filters.php, Subs-PrettyUrls.php, Subs.php, Admin.template.php, Admin.language.php)

* Saved a few bytes from CDATA parsing in feeds. Well, only in case a ]]> sign is used in posts. Which probably never happens. (Feed.php)

* Just changing text-align to right for the sidebar in Warm. Looks a bit better... Unsure though. (Warm/index.css)

! Fixed mismatched closing tag in Warm definition. (Warm/settings.xml)
Re: New revs
« Reply #828, on June 24th, 2011, 11:37 PM »
rev 815
(12 files, 13kb)

* Simplified pretty_filters setting a lot. Removed 'requires' and 'id' (never used), as well as 'priority' (real men use array_splice). The array is unserialized at startup. Specific hacks no longer test for the global pretty URL setting, and instead test for the filter type they're related to. Finally, pretty_enable_filters will only be set if at least one of the filters is enabled. (install.php, Display.php, Load.php, ManageBoards.php, ManageSettings.php, Aeva-Foxy.php, QueryString.php, Subs-PrettyUrls.php, Subs.php, ManageBoards.template.php)

- Leftover. (Admin.french.php)

NOTE: this release is totally, completely untested... I was trying to get confused by my own code changes so I decided to give myself a break :P Obviously if bugs are found, I'll fix them. But normally it should be more 'logical' than the previous incarnation of Pretty URLs.
Also, we definitely need to add a few hook points for PURLs. The determine_location hook is certainly not enough.
Re: New revs
« Reply #829, on June 26th, 2011, 05:55 PM »
rev 816
(8 files, 18kb)

! Given that IE9 still doesn't support CSS gradients, rewrote gradient_background() to add proper support for it, and redirect to the rgba version in case of a solid color. (Class-CSS.php, Subs-Cache.php)

* Moved 'column' div to the sidebar block definition (should help with hooking), and reworked sidebar indentation to match this and save a few bytes. (index.template.php, BoardIndexInfoCenter.template.php, Calendar.template.php, GenericMenu.template.php)

- Removed some hardcoded Pretty URL code that wasn't actually needed. Documented a function. (Subs-Boards.php, Subs-PrettyUrls.php)
Re: New revs
« Reply #830, on June 26th, 2011, 08:20 PM »
rev 817
(5 files +1, 9kb)

+ Added support for IE 10 in the PHP code, and used it to provide real gradients for it. (Class-CSS.php, Load.php, index.ie10.css)

! Pretty URLs were broken. Again. (ManageSettings.php, Subs.php, Admin.template.php)
Re: New revs
« Reply #831, on June 28th, 2011, 11:58 AM »
rev 818
(10 files, 14kb)

* Replaced zoomedia's "rel" hack with actual class names[1]. Still not used for now, but it'll be better in the long run anyway. (Aeva-Embed.php, Aeva-Gallery.php, Aeva-Subs-Vital.php, Subs-Media.php) Media.template.php)

* Moved media details to the sidebar in case the browser is Safari Mobile. It can't cope with the width anyway. (Aeva-Gallery.php)

* Moved some media action bools to proper context variables. Added bonus: action bar won't show up at all if you can't do anything. (Aeva-Gallery.php, Media.template.php)

! Search was broken. (Search2.php)

! Hardcoded language string. (zoomedia.js)

* Some layout improvements in media homepage and media item pages. (Media.template.php)

- Removed shortcut keys from media strings, as they're no longer valid. (Media.language.php)

* Improved vertical alignment in error log. (Errors.template.php)

- No need for an id in auto-generated shims. (zoomedia.js)
 1. That's because they don't validate in the new html5 validator...
Re: New revs
« Reply #832, on June 30th, 2011, 09:39 AM »
rev 819
(5 files, 7kb)

! The WYSIWYG editor had a reverse color palette. Not exactly sure why... (editor.css)

! Guests could be attributed illogical (and illegal) permissions in the gallery, such as moderating it. (ManagePermissions.php)

* Modified the order of some media permissions to separate moderation-type permissions from regular ones. (ManagePermissions.php)

* Made it clearer that the 'Auto-approve albums' permission allows regular users creating their own albums. (ManagePermissions.language.php)

* Small code logic clarification. (Aeva-Gallery2.php)

Arantor

  • As powerful as possible, as complex as necessary.
  • Posts: 14,278
Re: New revs
« Reply #833, on July 1st, 2011, 12:27 PM »
Revision: 820
Author: arantor
Date: 11:22:11, 01 July 2011
Message:
! The IP address displayed in the reminder emails was not properly formatted.
----
Modified : /trunk/Sources/Reminder.php

Posted: July 1st, 2011, 12:22 PM

Revision: 821
Author: arantor
Date: 11:27:21, 01 July 2011
Message:
! Add the ability to specify a separate email address for 'from' in emails. I don't think I explained it that well, but basically this means you can trivially set a different outgoing address, preventing people who are too dumb to read properly from sending you emails when they should be using the forum instead.
----
Modified : /trunk/Sources/ManageServer.php
Modified : /trunk/Themes/default/languages/Admin.english.php
Modified : /trunk/Themes/default/languages/Help.english.php
When we unite against a common enemy that attacks our ethos, it nurtures group solidarity. Trolls are sensational, yes, but we keep everyone honest. | Game Memorial

Nao

  • Dadman with a boy
  • Posts: 16,082
Re: New revs
« Reply #834, on July 2nd, 2011, 01:00 AM »
rev 822
(24 files, 26kb)

* Rewrote the 'More smileys' feature to show new smileys below the default smiley list, instead of opening an ugly popup. Also simplifies the JS code a lot. (Class-Editor.php, Post.language.php, post.js)

* Moved the 'Customize Smileys' option to the top of the smiley admin page, mostly to make it stand out, and clarified what it's for in the language strings. (ManageSmileys.php, ManageSmileys.language.php)

! The Re: prefix was broken in the French version. Somehow, somewhere, the nbsp entity is now converted to an ASCII character, so it wouldn't recognize prefixes in existing posts. Rather than fix the bug, I decided to simply use a breakable space. Older posts might need to be converted... (index.french.php)

+ Adding [Unknown] to the Consultant list in the credits area. (Credits.php)

* Updated header comments for all gallery-related files to match the new PHPDoc style and add credits to Dragooon where credit is due. (Sources/media/*.php, Media.template.php, ManageMedia.template.php, mediadmin.js, up.js)

- Media popups really didn't need the extra classes. I'd say. (Aeva-Gallery.php, Media.template.php)

@ Note: other JS files probably need their headers to be updated as well...
Re: New revs
« Reply #835, on July 2nd, 2011, 01:12 PM »
rev 823
(6 files, 13kb)

! The mail sending code uses $modSettings['mail_from'] while our admin code was $modSettings['from_email']. (ManageServer.php)

! Fixed Packer to allow for structures such as "for (var something in { object: true })", and added a comment with a link to my bug report and original fix. (Class-Packer.php)

* Rewrote the help text for mail_from. It may have been a bit unclear. At least to me. (Help.english.php)

* Translated new strings to French. (Admin.french.php, Help.french.php)

- Stray comment. (Subs-Post.php)

Arantor

  • As powerful as possible, as complex as necessary.
  • Posts: 14,278
Re: New revs
« Reply #836, on July 3rd, 2011, 12:56 AM »
Revision: 824
Author: arantor
Date: 23:56:29, 02 July 2011
Message:
! Remove 'Reports Generation' from Core Features. I mean, it was enabled already and all the Core Feature option does is show/hide the area, it's not like it actually prevents any ongoing performance problems, so there really wasn't much point actually making it optional in the first place. (install.sql, Admin.php, ManageSettings.php, ManageSettings.english.php, ManageSettings.french.php)
----
Modified : /trunk/Sources/Admin.php
Modified : /trunk/Sources/ManageSettings.php
Modified : /trunk/Themes/default/languages/ManageSettings.english.php
Modified : /trunk/Themes/default/languages/ManageSettings.french.php
Modified : /trunk/other/install.sql
Re: New revs
« Reply #837, on July 3rd, 2011, 01:44 AM »
Revision: 825
Author: arantor
Date: 00:44:09, 03 July 2011
Message:
! Moved the news and version info into the sidebar (and if the menu is in sidebar, it'll be under the menu though that's not going to be an issue for long), plus fixed the styling and language strings to match (Admin.php, Admin.template.php, Admin.english.php, admin.css, index.rtl.css)
! Removed the AdminSearchOM function. Not only do we not use it (because we don't have an online manual to search), the chances are if and when we do, we won't use the same method they had anyway, meaning that we don't really want it around. (Admin.php, Admin.template.php, Admin.english.php, Admin.french.php)
----
Modified : /trunk/Sources/Admin.php
Modified : /trunk/Themes/default/Admin.template.php
Modified : /trunk/Themes/default/languages/Admin.english.php
Modified : /trunk/Themes/default/languages/Admin.french.php
Modified : /trunk/Themes/default/styles/admin.css
Modified : /trunk/Themes/default/styles/index.rtl.css
Re: New revs
« Reply #838, on July 3rd, 2011, 02:16 AM »
Revision: 826
Author: arantor
Date: 01:14:40, 03 July 2011
Message:
! The sidebar has more dependencies than I thought it did, need to make sure the list of admins is obtained and that the JavaScript is included where necessary. (Admin.php, Admin.template.php)
----
Modified : /trunk/Sources/Admin.php
Modified : /trunk/Themes/default/Admin.template.php

Posted: July 3rd, 2011, 02:14 AM

Revision: 827
Author: arantor
Date: 01:16:14, 03 July 2011
Message:
! And oops, a missing global variable or two... (Admin.php)
----
Modified : /trunk/Sources/Admin.php
Re: New revs
« Reply #839, on July 3rd, 2011, 02:31 AM »
Revision: 828
Author: arantor
Date: 01:30:53, 03 July 2011
Message:
! Fixed some more oddities with the subtemplate not being called right. Also, split up AdminHome into two functions - there is no need for the admin front page to actually do everything needed for the credits as well, and vice versa. (Admin.php)
----
Modified : /trunk/Sources/Admin.php
Plugin revs »