New revs
Plugin revs »

Nao

  • Dadman with a boy
  • Posts: 16,082
Re: New revs
« Reply #780, on May 10th, 2011, 12:38 PM »
rev 765
(7 files, 27kb)

* Massive rewrite for Zoomedia. (zoomedia.js, zoom.css)
  * Starting position for zoom animation now matches exactly the origin thumbnail.
  * Slightly reduced border size, as it was a bit too much for my taste.
  * Descriptions no longer show up as overlays on the image. They also enlarge the zoomedia box if it's too narrow to hold the description.
  + Double-click the original thumbnail, or the opened preview, to enlarge it into the fullsize version. Includes annoying fix for IE 6/7/8.
  ! IE6 always showed the Loading label, even if the image was cached.
  ! Outside closing clicks were tested even with no zoomedia box opened. Ooops.
+ Added menu animation for low-level menu entries as well. (script.js)
- Removed useless 'added' parameter from sitelist. (ManageMedia3.php, Subs-Aeva-Sites.php)
- Removed hss() as full zoom handler. This is now done entirely by Zoomedia. (Aeva-Subs-Vital.php, Subs-Media.php)

Zoomedia tested under IE6, IE7, IE8 and Opera 11.50... Haven't tested in Chrome for a few days but it should work.
Re: New revs
« Reply #781, on May 11th, 2011, 11:59 AM »
rev 766
(13 files, 12kb)

! base64-encoding bypass technique failed when base64 encoding wasn't supported. (Class-CSS.php, Subs-Cache.php)
! The More tag could cause errors when parsed outside of a topic. (Subs-BBC.php)
! Some headers still had an icon next to the header text without any whitespace. (TEMPLATES: Login, Memberlist, Notify, PersonalMessage, Recent, Themes)
* Don't need strong tags in a header... Chances are it's already in bold. (Aeva-Foxy.php, ManagePermissions.template.php)
* $()[0].checked is faster than $().is(':checked'), so use that in loops. (ManagePermissions.template.php)
* Minor typos and such. (BoardIndex.php, Packages.template.php)
Re: New revs
« Reply #782, on May 12th, 2011, 01:06 AM »
rev 767
(16 files +1, 24kb)

+ Officially added outline types 'drop-shadow', 'white' and 'black', replacing the Highslide equivalents and adding black to the lot. (Aeva-Gallery.php, Aeva-Gallery2.php, Aeva-Subs-Vital.php, Media.language.php, zoomedia.js)
* Replaced table-based layout with inline-blocks for media item lists. This allows for simpler handling of list layout, especially with different screen sizes. Opera, oddly, needed a trick to avoid generating scrollbars on hover. Took me hours to figure one out. (Subs-Media.php, media.css, media.ie6.css, media.ie7.css, media.opera.css)
- Removed num_items_per_line options, as they're a moot point with the new item lists. (db_aeva.php, ManageMedia.php, Subs-Media.php, ManageMedia.language.php, Media.template.php)
- AFAIK, media item hover boxes don't need to bother with a 'faux' trick... (Subs-Media.php, media.css)
- And jQuery can do without a 'px' mention when animating or setting CSS. (zoomedia.js)

@ Known issue: the zoomedia close button doesn't show consistently across all browsers, especially when resizing to full size. (zoomedia.js)
Re: New revs
« Reply #783, on May 12th, 2011, 06:52 PM »
rev 768
(7 files, 12kb)

! Guests could generate an internal error when updating the topic view count. (Display.php)
+ Added $new_topic to the list of params that can be read and rewritten in createPost. (Subs-Post.php)
! Unseen media area was using the wrong language strings and had misplaced buttons. (Media.template.php)
! Some of the media permissions still had the 'aeva_' name in them. Hopefully I've updated everything that needed it. (ManageMedia.php, ManageMedia.language.php, ManageMedia.template.php)

(Can't believe some of these bugs I never noticed until now... :P)
Posted: May 12th, 2011, 06:50 PM

(And yes, that's probably the reason why single-upload didn't work on the demo site...)
Re: New revs
« Reply #784, on May 13th, 2011, 10:03 AM »
rev 769
(8 files +1-1, 23kb)

* Renamed media-admin.js to mediadmin.js, to avoid possible confusion in filenames. There was no harm done, but as a general rule of thumb, we should avoid hyphens in JS/CSS filenames when one of the filename's elements is a common one, like... media, or admin. (Aeva-Gallery2.php, Aeva-ModCP.php, ManageMedia.php)
! Fixed a language string possibly not being loaded in the album manager. (Aeva-Gallery2.php)
! One of the PNG8 files didn't correctly set the alpha bit. (arrow_inout.png)
! admin_toggle() was broken due to the use of .has() instead of .is() (mediadmin.js)
! admin_toggle() only takes one parameter. (ManageMedia.template.php, Media.template.php, mediadmin.js)
! Media pruning area was broken. (ManageMedia2.php)
* Moved admin_prune_toggle() to the actual media pruning admin page -- it's only used there, and it's short. (ManageMedia.template.php)
* admin_toggle() will now open its flower only after its related icon has finished loading. Maybe better, maybe worse. (mediadmin.js)
* Alignazi. (Media.template.php, media.css)
Re: New revs
« Reply #785, on May 13th, 2011, 08:15 PM »
rev 770
(10 files -1, 11kb)

* Parenazi. (Security.php)
* Bad whitespace! (Errors.template.php)
* Apparently, .attr('value') is frowned upon. (script.js, suggest.js, topic.js)
* Removed that silly white-space 'fix' devised by the SMF devs for linktrees, and replaced it with what I call a fix. (index.css, index.ie6.css, index.ie7.css)
! admin_toggle() shouldn't use expand/collapse icons, they're no longer provided. (mediadmin.js)
- Removing unneeded placeholder code in linktrees. (index.template.php)
- Removing jQuery 1.6, it sucked. (jquery-1.6.js)
Re: New revs
« Reply #786, on May 13th, 2011, 08:28 PM »
rev 771
(9 files, 18kb)

! Reverted allowedTo('media') to aeva_allowedTo(), because it's not the same. Really. And it fucked up permission profiles. Can I say 'fuck' in the changelog? No? Oops. (Aeva-Foxy.php, Aeva-Gallery.php, Aeva-Gallery2.php, Aeva-Subs-Vital.php, Subs-Media.php, Media templates)
! More expand/collapse fixes. (ManageMedia.template.php, Media.template.php)
* Cleaned up some variables, to be set in the Sources folder now, rather than in the Media template. (Aeva-Gallery.php, Media.template.php)
* Cleaned up table names. (ManageMedia.language.php)
Re: New revs
« Reply #787, on May 15th, 2011, 04:06 PM »
rev 772
(9 files, 13kb)

+ If Today/Yesterday date transformations are enabled, check for the year and remove it if it's the current one. (Subs.php)
! If pretty URLs were enabled, the jump box would redirect to the homepage because 'board' wasn't treated in the URL. (QueryString.php)
* Removed a few 'px' suffixes whenever jQuery could handle them by itself. (editor.js, script.js, suggest.js,
! Style fixes. (index.css, media.css)
* Indenazi. (Media.template.php)

@ The date thing was an idea I had and executed in a few minutes time only. I'm not SURE it's for the best, but I like it for now. The reason why it's in Today/Yesterday is to avoid an extra getdate() call, as well as avoid transforming whenever we want the full date (e.g. "Hello user, today is...")
Re: New revs
« Reply #788, on May 17th, 2011, 10:18 AM »
rev 773
(7 files, 12kb)

! Zoom outline options weren't passed to album pages. (Needs a fix in zoomedia.js as well, but I'm in the middle of rewriting it.) (Subs-Media.php)
* A few language strings were using longform XHTML tags. (ManageMedia.language.php, Media.language.php)
! French version recommended 6-char passwords or more, even when security settings force it to be at least 8 chars. (Profile.french.php)
* Spacinazi. (ManageMedia.template.php)
Re: New revs
« Reply #789, on May 18th, 2011, 04:02 PM »
rev 774
(13 files, 17kb)

! SMF bug: crash when providing several negative search terms (i.e. excluded terms) in a search. This was due to the inner_join array containing multiple occurrences of the same JOIN. (Search2.php)
* Renamed <strong class="highlight> to the more semantic and shorter <mark>, and renamed the highlight2 class to highlight, since it's no longer in use. (ManageServer.php, PersonalMessage.php, Search2.php, Profile.template.php, spellcheck.js, index.css, sections.css)
! Since we don't exactly know what HTML flavor SSI.php is being run with, make sure to use alt params in img tags. (SSI.php)
* Moved title from link to image in selectable language flags. And yes, I know, img title support in screen readers is pretty poor. Maybe we should add an alt for these. Uh. (index.template.php)
* Added <meta name="generator" content="Wedge">, both as a signature, and to stop HTML validation from pestering us with yet another change in the mandatory use of alt params in img tags. (index.template.php)
* Hopefully finished converting the admin area's media template to HTML5. (ManageMedia.template.php)
* Signatures shouldn't have the same color as post bodies. Chose a slightly less contrasted version. (sections.css)
* Shaving a few bytes off script.js. You know me... I can't stop myself. (script.js)
+ Added very preliminary support for paragraph headers inside blocks. (index.css)
* Too much vertical space wasted between thumbnails in album pages. (media.css)

@ Note: this changelog needs being discussed, I *think*...
Re: New revs
« Reply #790, on May 19th, 2011, 11:00 AM »
Okay, well, apparently rev 774 didn't need discussin'? :P
This new one is short but still required hours of testing. >_<

rev 775
(2 files, 7kb)

+ User menus will now extend to the width of the user name, even if it's very long. Well, probably not in IE6 but who cares. (topic.js)
+ Added some extra code to ensure the user name is still visible uncropped when hovering over the menu rather than the user name itself. (topic.js, sections.css)
Re: New revs
« Reply #791, on May 19th, 2011, 03:00 PM »
rev 776
(2 files, 6kb)

! The 'code' tag security check at registration time should be case-insensitive. I think. (Register.php)
* Modified user menu again to close it even when the mouse isn't moving. We just need to store all mouse events during the animation... (topic.js)
Re: New revs
« Reply #792, on May 21st, 2011, 03:23 PM »
rev 777
(8 files, 23kb)

* Rewrote most of Zoomedia to make it more solid across all browsers, especially when it comes to the double click behavior, and making sure any CSS changes to zoom box padding won't affect the JS code. (zoomedia.js, media.css, media.opera.css, zoom.css)
* CSS details. (other/wip/text-overflow.js, post.js, script.js)
* Saving a few bytes at compression time. (topic.js)

@ Left to fix: zoom box descriptions in small viewports. I don't really know how to fix... I was thinking of 'simply' resizing the box to make it fit *and* keep the description height the same (otherwise it will overflow), but come to think of it, it'd probably be smarter to actually hide the description because we could use that size, and simply show a "Details" link along with some indication that it has a description.

What do you think?

Arantor

  • As powerful as possible, as complex as necessary.
  • Posts: 14,278
Re: New revs
« Reply #793, on May 21st, 2011, 07:17 PM »
Revision: 778
Author: arantor
Date: 18:16:47, 21 May 2011
Message:
! Sync to SMF
 ! r10504 Validation error with collapsed boards. (And I got the indentation right.) (BoardIndex.template.php)
 ! r10505 Making a board child of itself crashed the forum. (Subs-Boards.php, Errors.english.php) [Bug 4710]
 ! r10506 Theme option changes was not loaded after profile changes in some cases. (This fix is slightly more thorough than the one posted before, it actually checks the input is an array before trying to use it as such, but otherwise it's the same fix.) (Profile-Modify.php) [Bug 4675]
 ! r10510 Member language selection was not reset upon a language deletion. (ManageServer.php) [Bug 4641] (And I fixed the comments, which they didn't.)
 * r10511 JavaScript quick topic modify did not work when quick moderation mode was 'icons'. (MessageIndex.template.php) [Bug 4715]
 ! r10512 It was possible to create permission profiles without names. (ManagePermissions.php) [Bug 4709]
 ! r10513 Additional group changes were not tracked properly. (Profile-Modify.php) [Bug 4718]
 ! r10514 Ignore boards options were ignored in MessageIndex. (Subs-BoardIndex.php) [Bug 4719]
 ! r10515-6 Remove Inactive Members maintenance removed members it should not. (ManageMaintenance.php) [Bug 4716]
 ! r10517-8, 10520 Reserved member name check failed with HTML entities. (Subs-Members.php) [Bug 4717]
 ! r10522 Minor break in PM replies fixed. (PersonalMessage.template.php) [Bug 4713] (Couldn't seem to replicate this in SMF, let alone Wedge, so have included it for now anyway)
 ! r10523 Fixed incorrect class on checkbox. Changed default removal selection to safest option.(ManageMaintenance.template.php) (The class was already gone, so that wasn't an issue, but I agreed with the change about the topic maintenance, instead of the default of 'any' being default under the purge-old area, the default is now 'moved notices')
 ! r10527 Installing, upgrading and uninstalling packages were not logged in admin log. (Packages.php, Modlog.english.php) [Bug 4469] (I actually made this one last spring as a mod, and handed it to the team on a plate to implement. They finally did!)
 * r10528 It was not possible to remove avatar when selecting avatar from gallery was disabled. (Profile-Modify.php, Profile template) [Bug 4636]
 ! r10529 Automated conversion of URLs to hyperlinks failed with URLs containing exclamation mark. (Subs-BBC.php) [Bug 4624]
 * r10530 Topic moderation using checkboxes did not function correctly for non-moderators. (topic.js) [Bug 4706] (This got jQuery-ified in the process. Hopefully this isn't too ugly now.)
 ! r10532 Profile updates did not load all previously saved data. (Profile.php, Profile-Modify.php) [Bug 4635]
 ! r10533 Login session data was cleared when it shouldn't have. [Bug 4644] And while we're at it, login by $_GET is not needed. (Login2.php, Subs-Login.php)
 ! r10537 Incorrect custom menu URL for unapproved posts moderation area. (ModerationCenter.php) [Bug 4728]
 ! r10538-9 Languages which doesn't support 12 hour time format had their 'am/pm's stripped. (Subs.php, index.english.php) [Bug 4720] (I've implemented this as is, but we may want to revert this in the time to come; there is likely a better way of doing it.)
 ! r10540 Incorrect error message when attempting to remove a non-existing post. (RemoveTopic.php) [Bug 4705]
 * Tabs and line endings within code tags were not parsed correctly for some browsers. (Packages.php, Packages.template.php) [Bug 4578] (I already attacked most of this previously, as it happens, only the package manager stuff wasn't done, and done differently - and likely better.)

! Not sync'd
 ! r10507 Bringing back the good, old welcome guest note along with activation link. [Bug 4703] (Apart from actually not doing what the changelog describes (it actually turns the 'Please login or register' into 'Welcome, Guest, please login or register')... that particular change is already better reflected in the sidebar.
 ! r10508 Upgrader fixes for MySQL 5.5 for upgrading from 1.0 and 1.1 [Bug 4698]
 ! r10509 Supposedly makes sure the MIME type gets fixed when upgrading from before 2.0, but I don't see how checking that smfVersion is identical to '2.0 a' is a viable trigger here... [Bug 4700]
 ! r10519 Replicating the change from 10517-8 into 1.1 branch
 ! r10521 More MySQL 5.5 fixes, this time for 1.0
 ! r10524 Fixed Webkit/Presto bug with sidebar menus enabled. Deleted superfluous code from webkit.css and rtl.css (index.css, rtl.css, webkit.css) (The main change in index.css isn't relevant to us anyway, the RTL changes ditto... and the Webkit changes, well, I think they should probably have left the clear:right in, the others don't apply...)
 ! r10526 Categories which could not be collapsed were still given collapse links. (Subs-BoardIndex.php) [Bug 4639] (We didn't give them collapse links directly like SMF do anyway, this was never an issue for us.)
 ! r10531 Sidebar fixes - Fixing class 'clear clear' from r10525, making #avatar_upload be overflow:auto (though I have no idea what's prompted that) and giving #creator dd the same overflow, again no idea why it's necessary... so I didn't include them. Oh, and resizing an input type=file...
 ! r10534-6 Converters stuff
 ! r10542 Like 10509, this adds a test for version being '2.0 a' into the theme upgrader code.

! Special stuff
 ! r10525 Lots of weird little layout 'fixes' "mostly for IE6". The individual changes are not documented in the changelog, nor anywhere else I can find.
  - Subs-BoardIndex.php, breaking the category links up so instead of a single a tag being the anchor for categories and the link for collapsing it, they separated it. We were already separate anyway after the last time they messed with this. (NOT ADDED)
  - Admin template, instances of hr tags all getting .clear added to them, not entirely sure why. Including one instance of hr that needed it so badly, it became class="hrcolor clear clear". Not entirely sure why they did this. (NOT ADDED)
  - admin.css, removing a resizing of dt and dd relative to each other inside the admin area (for narrower screens with sidebar). Code doesn't apply to us. (NOT ADDED)
  - ie6.css, they adjusted a height for the 'admin panel' from 655px to 100%, but the code doesn't apply to us. (NOT ADDED)
  - index.css: removing the weird -99em left margin for no-collapse titles (which we already noted was ridiculous at the time Ant added it, also removed from rtl.css), made the dd bigger in dl.settings (now occupies 56% instead of 48%) and also make it overflow auto to cope with smaller resolutions, they also adjusted #creator dd to float right, which is the right panel in the profile area... for no reason I can see. (ADDED, except the #creator change)
  - BoardIndex template, rejigging how the category title was output with the surrounding markup. Incidentally, it's now virtually what we already had, with the actual name being output last, relative to the collapse and unread links. (NOT ADDED)
  - ManageBans template, making one text field bigger than the DB field that holds it, plus resizing the different text boxes to line up; we're going to be ripping this out anyway. (NOT ADDED)
  - ManageBoards template, adding style="float:left; width:100%;" to the ul that forms the category contents of the main manage-boards screen, really no idea why. (NOT ADDED)
  - ManageMembers template, making some catbgs rounded when they weren't before. (ADDED)
  - ManagePermissions template, making one area handle oversize content better. (ADDED)
  - ManageSearch template, moving the save-search-weights button into the curved area and to the right, to be more consistent with everything else, and moving the save-search-method button to the right, again for consistency. (ADDED)
  - Packages template, making the textboxes all the same size. (ADDED)
  - Profile template, the instances of hr tags all got .clear added to them, like Admin template. (NOT ADDED)
----
Modified : /trunk/Sources/Login2.php
Modified : /trunk/Sources/ManageMaintenance.php
Modified : /trunk/Sources/ManagePermissions.php
Modified : /trunk/Sources/ManageServer.php
Modified : /trunk/Sources/ModerationCenter.php
Modified : /trunk/Sources/Packages.php
Modified : /trunk/Sources/Profile-Modify.php
Modified : /trunk/Sources/Profile.php
Modified : /trunk/Sources/RemoveTopic.php
Modified : /trunk/Sources/Subs-BBC.php
Modified : /trunk/Sources/Subs-BoardIndex.php
Modified : /trunk/Sources/Subs-Boards.php
Modified : /trunk/Sources/Subs-Login.php
Modified : /trunk/Sources/Subs-Members.php
Modified : /trunk/Sources/Subs.php
Modified : /trunk/Themes/default/BoardIndex.template.php
Modified : /trunk/Themes/default/ManageMaintenance.template.php
Modified : /trunk/Themes/default/ManageMembers.template.php
Modified : /trunk/Themes/default/ManagePermissions.template.php
Modified : /trunk/Themes/default/ManageSearch.template.php
Modified : /trunk/Themes/default/MessageIndex.template.php
Modified : /trunk/Themes/default/Packages.template.php
Modified : /trunk/Themes/default/PersonalMessage.template.php
Modified : /trunk/Themes/default/Profile.template.php
Modified : /trunk/Themes/default/languages/Errors.english.php
Modified : /trunk/Themes/default/languages/Modlog.english.php
Modified : /trunk/Themes/default/languages/Profile.english.php
Modified : /trunk/Themes/default/languages/index.english.php
Modified : /trunk/Themes/default/scripts/topic.js
Modified : /trunk/Themes/default/styles/index.css
When we unite against a common enemy that attacks our ethos, it nurtures group solidarity. Trolls are sensational, yes, but we keep everyone honest. | Game Memorial

Nao

  • Dadman with a boy
  • Posts: 16,082
Re: New revs
« Reply #794, on May 22nd, 2011, 12:18 AM »
rev 779
(17 files, 26kb)

! rev 778 didn't use westr::htmlspecialchars where needed. (Packages.php, Subs-Members.php)
! A $_POST was being tested after checking whether the corresponding $_REQUEST was set. (Subs-Login.php)
* French translation. (Errors.french.php, index.french.php, Modlog.french.php, Profile.french.php)
* I thought I'd optimized all of the labels... Apparently not. I'm just doing this one okay? (Profile.template.php)
! $.length() doesn't work. It's $.length, not a function. Also optimized code for compressed size. (topic.js)
! Button strips don't have child divs, they use unordered lists. Also, the default class for them is floatleft, not floatbottom. (topic.js)
! User box user names were being shown on top of zoom boxes. (sections.css, zoom.css)
! Removed useless right padding from stat months/days. Way better in small resolutions. (sections.css)
! It's add-on, not package. I think. (Modlog.english.php)
* Spacinazi. (ManageServer.php, Aeva-Gallery.php, Profile-Modify.php, index.language.php)
* Ugly CSS. (ManagePermissions.template.php)

Please read the changelog above and review the code fixes!
Plugin revs »