New revs

Nao

  • Dadman with a boy
  • Posts: 16,082
Re: New revs
« Reply #720, on April 12th, 2011, 08:04 PM »
rev 704
(4 files, 8kb)

! Fixed item commenting. (Aeva-Gallery.php, Media.template.php)
* Styling details. (up.js, media.css)
Re: New revs
« Reply #721, on April 13th, 2011, 12:22 AM »
rev 705
(8 files, 12kb)

! Fixed hover popups in album pages. The IE hack makes use of the selector precedence algorithm. I think it's the first time I actually devised this, instead of doing it by chance. (media.css, ie6.css, ie7.css)
! clear_thumbnames should be set by default, because we want the best possible performance for avatars. (db_aeva.php)
! Media Maintenance tasks were broken. (ManageMedia2.php)
* Don't turn -moz-border-radius into -moz-webkit-border-radius, things like that. Remember, friends: just use border-radius. Wedge will do the rest. (Subs-Cache.php)
* Fixed uploader script and converted the rest to jQuery. (up.js)
* Minor details. (Load.php)

@Note: Highslide is broken (again). I don't know what exactly caused this, since it worked up until the previous rev, if I'm not mistaken. :-/
Re: New revs
« Reply #722, on April 13th, 2011, 10:39 AM »
rev 706
(1 file)

! Fixed Highslide by replacing it with an older, more solid version... Until I get to replace it with another library, really. (highslide.js)
Re: New revs
« Reply #723, on April 13th, 2011, 08:11 PM »
rev 707
(6 files +1, 86kb -- mostly the addition of highslide-full.js)

* Fixed Highslide full version, moved JavaScript calls to the JS footer, and rewrote code to use rel tags instead of events. (Aeva-Embed.php, Aeva-Subs-Vital.php, Subs-Media.php, ManageMedia.template.php, Media.template.php, highslide-full.js)
! Media tag helper popup needed a scrollbar. (Media.template.php)
! Fixed JavaScript error when manually removing a file that was rejected by the script for being too large. (up.js)
Re: New revs
« Reply #724, on April 15th, 2011, 09:52 AM »
rev 708
(7 files +17-15, 82kb)

* Swapped SMF and Wedge names in the footer, so that we can use Wedge on live websites without breaking the mandatory SMF copyright mention. (index.php)
* Updated variable names in AeMe installer, although it's only useful for tester upgrades, not for new installs. (db_aeva.php)
- cal_enabled was defined twice in the installer. (install.sql)
* Partly rewrote the CSS caching system to allow for more flexibility (at the cost of more file_exists tests, which shouldn't be a problem with OS caching.) css_generic_files is split into another array, css_main_files, which contains the actual main CSS files, while css_generic_files now only contains overriding stylesheets, and is also loaded by stand-alone stylesheets, making it easy to override any stylesheet with stylesheet_name.override_name.css (Load.php, Subs-Cache.php)
* Renamed all override-type files to index.original_name.css, and moved Media-specific hacks to media.original_name.css. (*.css)
- Hide the 'webkit' keyword in CSS URLs if we have a more specific browser recognized by Wedge. (Subs-Cache.php)
! CSS caching didn't work at install time because of the missing $context['user'] variable. (Subs-Cache.php)
+ Added a .hide class that simply does display:none... It's cleaner this way, although it requires loading the CSS to apply it. Could turn out to be useful, though. (index.css)
* Made a comment a bit clearer. (Subs.php)

@ Note: should rewrite wedge_cache_css to merge it with add_css_file. Both do pretty much the same thing, with a few tweaks for main CSS files. (Subs-Cache.php)

@ Note: should really, really test the CSS caching system with new themes... Have never done so. It probably doesn't even work properly. (Subs-Cache.php)
Re: New revs
« Reply #725, on April 15th, 2011, 11:18 AM »
rev 709
(4 files, 6kb)

! webkit keyword wasn't removed from filename if at the beginning or the end[1]. (Subs-Cache.php)
! Made DragSlide a bit more open to non-reqWin popups. (script.js)
* Details. (Aeva-Gallery.php, media.js)
 1. Tested in Safari...

Arantor

  • As powerful as possible, as complex as necessary.
  • Posts: 14,278
Re: New revs
« Reply #726, on April 16th, 2011, 10:38 AM »
Revision: 710
Author: arantor
Date: 09:37:11, 16 April 2011
Message:
! Make sure user-agent is actually defined for the purposes of BB checking. (Security.php)
----
Modified : /trunk/Sources/Security.php
When we unite against a common enemy that attacks our ethos, it nurtures group solidarity. Trolls are sensational, yes, but we keep everyone honest. | Game Memorial

Nao

  • Dadman with a boy
  • Posts: 16,082
Re: New revs
« Reply #727, on April 16th, 2011, 09:06 PM »
rev 711, aka "My revisions are badass!"
(13 files +5, 44kb)

* Replaced Highslide with a WIP lightbox called zoomedia. Excuse the pun. It isn't feature complete, and tends to fail on .scrollTop() requests, but it can be fixed, hopefully, and it's a pretty tight library. (close.png, close-32bit.png, Aeva-Subs-Vital.php (temp code!), hs.css (WIP), zoomedia.js)
+ Added a micro-optimization to Javascript cache code, allowing for slightly smaller files. (Subs-Cache.php)
! Fixed a bug that caused earlier versions of cached files not to be deleted as thought of. (Subs-Cache.php)
! Apparently, the File API specification was modified since the Aeva Media days, which triggered an error in Opera 11.10. (Aeva-Gallery.php)
* Clean-up job. Nothing worthy of documenting, but somehow important to me. (Class-Packer.php, Errors.template.php, Media.english.php, Media.french.php, editor.js, script.js, admin.css, index.css, sections.css, aeva/change_menu*.png (temp fix for silent errors))

Arantor

  • As powerful as possible, as complex as necessary.
  • Posts: 14,278
Re: New revs
« Reply #728, on April 16th, 2011, 11:46 PM »
Revision: 712
Author: arantor
Date: 22:45:36, 16 April 2011
Message:
! PHP is not as smart as humans at dealing with one line branches, so better be clearer for PHP's benefit. (Security.php)
----
Modified : /trunk/Sources/Security.php


While the fix technically made sense, PHP could have been ambiguous in its handling of the branch else because it wasn't clear whether it applied to the nested if or the parent one, so I gave it braces.

Nao

  • Dadman with a boy
  • Posts: 16,082
Re: New revs
« Reply #729, on April 17th, 2011, 12:13 AM »
rev 713, aka "It's a 2-line commit, too. Nah, just kidding, just got more work for you guys."
(9 files, 34kb)

* Updated the mass upload area. Updated YUI Uploader to v2.8.x, moved their Uploader JS to local so as to fix a bug in SWFObject + Opera (maybe other browsers). Reworked layout for cooler file lists. (Aeva-Gallery2.php, uploader.swf, up.js, up.css)
! Fixed regression where sub-files added to the main CSS file list weren't correctly cached. (Subs-Cache.php)
* Done some extra work to make the Media template a bit more validator-friendly. (Media.template.php)
* Pathetic urge to save even more bytes in zoomedia... Now 658 bytes after compression. (zoomedia.js)
* Error log was ugly. Me no like ugly things. Me like beer and women. In that order. (admin.css)
! Context menus could be followed up by a misaligned element. (index.css)
Re: New revs
« Reply #730, on April 17th, 2011, 02:38 AM »
rev 714
(5 files, 9kb)

! Late night woopsies.

Too tired to document. View the diff patch ;)

Arantor

  • As powerful as possible, as complex as necessary.
  • Posts: 14,278
Re: New revs
« Reply #731, on April 17th, 2011, 02:52 AM »
Revision: 715
Author: arantor
Date: 01:52:23, 17 April 2011
Message:
! Some fixes for undefined character set (legacy stuff) (Aeva-Foxy.php, Aeva-Gallery.php, ManageMedia.php, Media.template.php)
----
Modified : /trunk/Sources/media/Aeva-Foxy.php
Modified : /trunk/Sources/media/Aeva-Gallery.php
Modified : /trunk/Sources/media/ManageMedia.php
Modified : /trunk/Themes/default/Media.template.php
Re: New revs
« Reply #732, on April 17th, 2011, 03:35 AM »
Revision: 716
Author: arantor
Date: 02:34:44, 17 April 2011
Message:
! Fix missing dependencies for the mass uploader (Aeva-Gallery2.php)
----
Modified : /trunk/Sources/media/Aeva-Gallery2.php
Re: New revs
« Reply #733, on April 17th, 2011, 03:47 AM »
Revision: 717
Author: arantor
Date: 02:46:59, 17 April 2011
Message:
! Aeva DB changes should not require default values on text columns (db_aeva.php)
! Harmonising media permissions fully (Admin.php, ManagePermissions.php, ManagePermissions.english.php, ManagePermissions.french.php, ManageMedia.php, Aeva-Subs-Vital.php, Subs-Media.php, Profile.php, Subs.php, Errors.english.php, Errors.french.php)
----
Modified : /trunk/Sources/Admin.php
Modified : /trunk/Sources/ManagePermissions.php
Modified : /trunk/Sources/Profile.php
Modified : /trunk/Sources/Subs.php
Modified : /trunk/Sources/media/Aeva-Subs-Vital.php
Modified : /trunk/Sources/media/ManageMedia.php
Modified : /trunk/Sources/media/Subs-Media.php
Modified : /trunk/Themes/default/languages/Errors.english.php
Modified : /trunk/Themes/default/languages/Errors.french.php
Modified : /trunk/Themes/default/languages/ManagePermissions.english.php
Modified : /trunk/Themes/default/languages/ManagePermissions.french.php
Modified : /trunk/other/db_aeva.php
Re: New revs
« Reply #734, on April 17th, 2011, 03:54 AM »
Revision: 718
Author: arantor
Date: 02:54:32, 17 April 2011
Message:
! Oops, forgot to update the permissions/group associations. (ManagePermissions.php)
----
Modified : /trunk/Sources/ManagePermissions.php