New revs
Plugin revs »

Nao

  • Dadman with a boy
  • Posts: 16,082
Re: New revs
« Reply #615, on February 13th, 2011, 05:32 PM »
rev 587
(3 files + 2 added, 157kb) (nothing changed really... Only renamed "permute()" to "bbc_permute()" to avoid potential conflicts in function names.)

+ Added Subs-Cache file, that includes all of the code for caching regular data, CSS and JS, thus off-loading Subs.php, Load.php and QueryString.php. (Load.php, QueryString.php, Subs-Cache.php, Subs.php)
+ Added Subs-BBC file, that includes all of the code for parsing BBCode, thus off-loading Subs.php, and... that's all. It's already a lot. (Subs-BBC.php, Subs.php)
* Moved match_cidr() to the IP function area. (Subs.php)

Arantor

  • As powerful as possible, as complex as necessary.
  • Posts: 14,278
Re: New revs
« Reply #616, on February 13th, 2011, 07:36 PM »
Revision: 588
Author: arantor
Date: 18:35:49, 13 February 2011
Message:
! Preliminary IPv6 support (lots of files)
! Minor tweaks to installer to prevent throwing of errors over SMF constant. This needs cleanup though. (install.php)

@todo:
 Profile IP tracking stuff is still broken
 Bans also broken (which likely means non admin users are also broken for now)
 match_cidr() needs updating
 host_from_ip() needs testing for IPv6
 Proxy code needs rewriting, it's just commented out for now but it was actually broken before

When I say it's preliminary support, I mean just that - it doesn't immediately fall over, but it's going to be fragile for now. There's also likely stuff I've forgotten for now, but I think I got the major stuff either resolved or at least 'known'. (And some would love to add IPv6 support as a mod...? Sigh.)
----
Modified : /trunk/Sources/Display.php
Modified : /trunk/Sources/Errors.php
Modified : /trunk/Sources/Load.php
Modified : /trunk/Sources/ManageBans.php
Modified : /trunk/Sources/ManageErrors.php
Modified : /trunk/Sources/ManageMembers.php
Modified : /trunk/Sources/ModerationCenter.php
Modified : /trunk/Sources/Modlog.php
Modified : /trunk/Sources/Profile-Modify.php
Modified : /trunk/Sources/Profile-View.php
Modified : /trunk/Sources/Profile.php
Modified : /trunk/Sources/QueryString.php
Modified : /trunk/Sources/Reporttm.php
Modified : /trunk/Sources/Security.php
Modified : /trunk/Sources/Subs-Membergroups.php
Modified : /trunk/Sources/Subs-Members.php
Modified : /trunk/Sources/Subs-Post.php
Modified : /trunk/Sources/Subs.php
Modified : /trunk/Sources/Who.php
Modified : /trunk/Themes/default/Errors.template.php
Modified : /trunk/other/install.php
Modified : /trunk/other/install.sql
When we unite against a common enemy that attacks our ethos, it nurtures group solidarity. Trolls are sensational, yes, but we keep everyone honest. | Game Memorial

Nao

  • Dadman with a boy
  • Posts: 16,082
Re: New revs
« Reply #617, on February 14th, 2011, 05:37 PM »
I think it's the first time I see you commit commented out code... Hang in there!

rev 589
(5 files, 13kb)

! Fixed CSS not showing up in the installer if the forum is installed in a sub-folder. Hopefully. (install.php)
* Moved censorText() to a more logical place. Again -- hopefully. (Load.php, Subs-BBC.php)
+ Added separators to the internal PM menu. (PersonalMessage.php)
! Fixed various obvious bad translations in the installer. Okay, what did I do during these two months I spent on fixing these files? Did someone throw them away or was I just that careless? (Install.french.php)

PS: Another commit coming up... Just sorting out the files for now. Also, I'm not too sure about that code I added in install.php... I think I should instead change Subs-Cache.php to return "cache/" instead of $boardurl . "/" when $boardurl is empty... That'd probably make more sense. The only reason I didn't do it is that it's unlikely $boardurl isn't set when the forum is installed. Meaning it just wastes a CPU cycle for nothing...
Re: New revs
« Reply #618, on February 14th, 2011, 11:31 PM »
rev 590
(8 files, 12kb)

* Changed the dynamic sidebar removal to instead move it to the far left, and restore it (with an animation) when hovering it. Only tested in Opera for now. Also adds a box-shadow in this mode, to make it clear that it's no longer in the regular flow. (index.css, Warm/index.css, index.template.php)
* If the linktree only has one item, it has to be the home page, hasn't it? Let's not waste time showing it then... But keep the linktree div in it, since we might have some padding applied to it. (index.template.php)
! The special popup at runtime wasn't using the new system. (install.php, Install.english.php, Install.french.php)
! Fixed a horizontal scrollbar at board creation time. (ManageBoards.template.php)
! Fixed a warning when caching the Pastel styling -- had forgotten a bracket. Next step: drop stupid CSS and use the new syntax everywhere. (sections.css)

@ Note: should we care about the legacy code for older PHP versions in the installer...? Lines 102-117. (install.php)
@ Note2: cool changes innit? :P As indicated, it's only tested in Opera for the sidebar stuff (should work everywhere but IE won't get the animation obviously), and the linktree area -- I'm not sure the homepage is the only place that has only one item. If it's not the case then we should change the other areas to have at least two items, /mesays.
@ Comments welcome.

Arantor

  • As powerful as possible, as complex as necessary.
  • Posts: 14,278
Re: New revs
« Reply #619, on February 15th, 2011, 02:48 AM »
Revision: 591
Author: arantor
Date: 01:47:47, 15 February 2011
Message:
! Kill 'enable sticky option', they're now wired on. (Surprisingly many files.)
----
Modified : /trunk/Sources/Display.php
Modified : /trunk/Sources/JSModify.php
Modified : /trunk/Sources/ManagePosts.php
Modified : /trunk/Sources/MessageIndex.php
Modified : /trunk/Sources/Post.php
Modified : /trunk/Sources/Post2.php
Modified : /trunk/Sources/QuickMod.php
Modified : /trunk/Sources/Search2.php
Modified : /trunk/Sources/SplitTopics.php
Modified : /trunk/Sources/Sticky.php
Modified : /trunk/Sources/Unread.php
Modified : /trunk/Sources/Unreadreplies.php
Modified : /trunk/Themes/default/ManageMaintenance.template.php
Modified : /trunk/Themes/default/MessageIndex.template.php
Modified : /trunk/Themes/default/Recent.template.php
Modified : /trunk/Themes/default/languages/Admin.english.php
Modified : /trunk/Themes/default/languages/Admin.french.php
Modified : /trunk/Themes/default/languages/Help.english.php
Modified : /trunk/Themes/default/languages/Help.french.php
Modified : /trunk/other/install.sql

Nao

  • Dadman with a boy
  • Posts: 16,082
Re: New revs
« Reply #620, on February 15th, 2011, 09:40 AM »
rev 592
(5 files, 8kb)

! Fixed and optimized math function in the CSS parser. I was pretty sure I'd tested it thoroughly, eh... (Class-CSS.php)
+ Added support for some basic PHP functions in math(), in case you need them: round, ceil, floor, abs and fmod. (Class-CSS.php)
* Moved gz Mime type overrides to the cache folder. (other/.htaccess, cache/.htaccess)
* Ensure WAP2 mode never uses more than .5em of whitespace between lines. (wireless.css)
* Made a code block more compact, because I've learned to hate it, and I don't want to see it anymore. (script.js)
Re: New revs
« Reply #621, on February 15th, 2011, 01:32 PM »
rev 593
(22 files, 23kb)

* Modified add_css_file() to use less parameters, allow for extension-less filenames and get files from the current styling, or their closest parent if unavailable. (install.php, Subs-Cache.php, Packages.template.php, Reports.template.php, Wireless.template.php, Xml.template.php)
* Renamed 'css' folder to 'styles', and updated related code. Haven't done it on the SVN yet to make it easier to spot changes, the actual renaming will be in the next commit. (install.sql, Load.php, ManageBoards.php, Subs-Boards.php, Subs-Cache.php, Themes.php, ManageBoards.template.php, Themes.template.php, */settings.xml, */index.css)
! The Bad Behavior code was using $context['html_headers'] at some point, instead of $context['http_headers']. (Security.php)
Posted: February 15th, 2011, 11:13 AM

rev 594
(n/a)

* Renamed css folder to styles.
Posted: February 15th, 2011, 11:27 AM

rev 595
(n/a)

+ Added .htaccess files to styling folders, preventing reading the CSS files for regular users. I may be paranoid, but no an android.

(Currently fighting with a tree conflict... Did 'rename' on my css folder, then committed and forgot to update it BEFORE committing, which is never mentioning anywhere... Because of that, I can't even touch my work folder anymore, I have to work from a clean folder. Grrr...)
Posted: February 15th, 2011, 11:36 AM

rev 596
(n/a)

+ Cleaning up my SVN... Committing two files that I thought I'd committed before: the actual button bevel (3D effect), and the script folder protection. (images/theme/bevel.png, scripts/.htaccess)

(Okay, I think my SVN is good now... Phew. I had to manually edit my SVN files, ah ah.)
Posted: February 15th, 2011, 12:10 PM

rev 597
(2 files, 4kb)

- Removed legacy PHP code. (install.php)
! Fixed wrong param number in preg_match_all. (Security.php)
Re: New revs
« Reply #622, on February 16th, 2011, 12:18 AM »
rev 598
(3 files, 11kb)

! Added a child div in the sidebar to account for a Chrome bug in "display: table-cell" blocks... Yay... (index.template.php, Warm/index.css)
! Fixed outdated JS code for the auto-resizer. Now it should correctly hide the sidebar before it starts doing crazy things. (index.template.php)
* Minor padding/margin/width tweaking in the sidebar. (index.css, Warm/index.css)

Arantor

  • As powerful as possible, as complex as necessary.
  • Posts: 14,278
Re: New revs
« Reply #623, on February 16th, 2011, 12:58 AM »
Revision: 599
Author: arantor
Date: 23:58:25, 15 February 2011
Message:
! Installer fixes: $to_header no longer defined for add_css_file, Subs-Cache would infinite loop due to missing $context['styles'], not to mention never actually finding the files it wanted. (install.php, Subs-Cache.php)
! Rewire board access to be based on a separate table, rather than the FIND_IN_SET against a text field. (install.sql, Load.php)

@todo
 Refit admin panel
 Provide facility for board/topic privacy to be configured since currently it is reusing the membergroups field to set $board_info['privacy'], though that doesn't appear to be used by anything right now.
----
Modified : /trunk/Sources/Load.php
Modified : /trunk/Sources/Subs-Cache.php
Modified : /trunk/other/install.php
Modified : /trunk/other/install.sql
Re: New revs
« Reply #624, on February 17th, 2011, 03:33 AM »
Revision: 600
Author: arantor
Date: 02:33:06, 17 February 2011
Message:
! Reinstate proxy handling for IPv6. Still needs more testing and match_cidr to be rewritten for IPv6 though. (QueryString.php)
----
Modified : /trunk/Sources/QueryString.php

Nao

  • Dadman with a boy
  • Posts: 16,082
Re: New revs
« Reply #625, on February 17th, 2011, 11:48 AM »
rev 601
(3 files + 6 added, 22kb)

+ Added WarmWine (temp name of course), a child styling for Warm that basically reproduces the original Wine. There are a few differences but mainly in padding and stuff. (Warm/Wine/*)
! is_ipv4() wasn't using the given parameter. (QueryString.php)
! A better fix for the infinite loop in add_css_file(). (Subs-Cache.php, install.php)
Re: New revs
« Reply #626, on February 18th, 2011, 04:46 PM »
rev 602
(23 files, 167kb, plenty of search & replace but also plenty of manual fixing :P)

* Converted all remaining stylings to the new simplified CSS syntax. (styles/*)
! The clean_cache() function systematically deleted all files from the cache. As it is called by a scheduled task, added a parameter to prevent deleting CSS and JS files when they don't need it. They're still purged when going to the admin area and changing a file compression/obfuscation setting. (Subs-Cache.php)
! Typo in Pastel. (mad-width, ahah, that one should be standard.) (styles/index.css)
@ Moved Green stylings by mistake. Will move them back later... Don't want to screw up my svn copy again.
Re: New revs
« Reply #627, on February 18th, 2011, 06:57 PM »
rev 603
(11 files, 20kb)

+ If user doesn't have permission to view own or any profile, strip links leading to them. (QueryString.php)
* Minor tweaks to Pastel and Warm. (*.css)

Arantor

  • As powerful as possible, as complex as necessary.
  • Posts: 14,278
Re: New revs
« Reply #628, on February 19th, 2011, 12:55 PM »
Revision: 604
Author: arantor
Date: 11:54:58, 19 February 2011
Message:
! Sync to Bad Behavior 2.1.11
 ! Remove test for Google Wireless in anti-Google spoof as it is a special proxy not a search engine. (Security.php)
! Sync to SMF 10465
 ! (r10449) Cache bug in upgrader (upgrade.php)
 ! (r10466) Typo in forum profile loader, makes custom fields more internally consistent (Profile-Modify.php)
 ! (r10467) 64-bit created zip file decompression fix (Subs-Package.php)

Not implemented from SMF
 * r10447 Tweak of censored words UI (going to be rewritten anyway)
 * r10448 Shuffling of setlocale and time format in 2.1 branch, not convinced it is beneficial yet, and not convinced it doesn't have issues (it certianly has some issues in the hacky changes to Load.php if mb_* functions aren't available... like fatal errors)
 * r10450,10457-10459 Tagging 1.0.21, 1.1.13, 2.0 RC5, branching in 2.1/other
 * r10451 Pedantry and minor typo fix in converter (not applicable to us because the importer needs to be written from scratch anyway)
 * r10452 Conversions of substr($x, $y, 1) to $x[$y]... it makes it harder to follow and the speed factor is not hugely significant even if it is inside parse_bbc (it's *where* it's inside parse_bbc, in validate functions mostly)
 * r10453 Pedantry: removal of @ in front of ini_get/ini_set and ob_start calls
 * r10454 Many tiny changes of == to === and rewrites of substr($x, $y, 1) to $x[$y] as well as substr($x, 0 $y) == $z becoming strpos($z, $x) === 0 - doesn't help readability and mostly it's run in places that don't impact performance too much (and is 2.1)
 * r10455 Removal of @ in front of set memory limit calls in converters
 * r10456 More == to === conversions
 * r10460 Yet more == to === in Post.php for 'testing commits'
 * r10461-3 Converting TYPE to ENGINE in upgrader scripts, then reverting it
 * r10464 Many tiny changes of == to === and rewrites of substr($x, $y, 1) to $x[$y] as well as substr($x, 0 $y) == $z becoming strpos($z, $x) === 0 - doesn't help readability and mostly it's run in places that don't impact performance too much (and is 2.1)
 * r10465 Changing the 'clean attachment' to 'clear attachment' - we already revised the UI entirely
 * r10468 PostgreSQL specific fix in upgrader.
 * r10469 [2.1] "Replaced some strtr with str_replace and some strpos(strtolower()) with stripos() and some strtolower() == strtolower() with strcasecmp(). Just pedantic stuff."
----
Modified : /trunk/Sources/Profile-Modify.php
Modified : /trunk/Sources/Security.php
Modified : /trunk/Sources/Subs-Package.php
Modified : /trunk/other/upgrade.php

Nao

  • Dadman with a boy
  • Posts: 16,082
Re: New revs
« Reply #629, on February 20th, 2011, 11:56 PM »
rev 605

* Upgrading Warm to default styling, and moving Pastel to its own folder. Doing it in two phases to avoid SVN conflicts.
Posted: February 20th, 2011, 11:48 PM

rev 606/607

* Moved Green and Green again to Pastel (will have to delete Green again, we got the point), cleaned up Pastel (will have to test tomorrow), and deleted the Warm subfolder. Hopefully it's all done now.
Plugin revs »