New revs
Plugin revs »

Nao

  • Dadman with a boy
  • Posts: 16,082
Re: New revs
« Reply #510, on January 12th, 2011, 10:21 PM »
rev 466

* Renamed linktree classes to IDs and rewrote template to avoid using non-semantic code to show the arrows. (index.template.php, index.css, rtl.css, Nix/index.css)
* French translation. (ModerationCenter.french.php)
Re: New revs
« Reply #511, on January 13th, 2011, 05:54 PM »
This is to celebrate your return! :niark:

rev 467

* Cleaned up Pretty URLs. Removed some code that prevented using an URL twice (never happens because we're always specifying the topic ID), used variable references in foreach (we're in PHP5, let's use that), removed or commented out some Noisen-specific code, removed url_id from the URL table (this was never used), micro-optimized preg_match'es by doing strpos tests beforehand (should be twice faster if the test fail, and 30% slower if it passes. May need further testing.) (PrettyUrls-Filters.php, QueryString.php)
+ Added proper support for actions in Pretty URLs. Using format /do/action, waiting for the Actions rewrite to be completed before we move it to just /action or whatever. (PrettyUrls-Filters.php, QueryString.php)
+ Added proper support for profiles in Pretty URLs. Still a bit buggy, I believe. u= needs to be set right after the profile action. (PrettyUrls-Filters.php, QueryString.php)
- Removed debug code that didn't have the corresponding helper function (obsafe_print_r) anyway. (QueryString.php)
! The determine_location hook wasn't triggered if not inside a board. (QueryString.php)
* Replaced sesc= and sc= replacements with the proper session_var. If any sesc/sc is still in the code, it should be removed. I think. (QueryString.php)
! Fixed Pretty URLs not showing its load times, and moved that to the very bottom, to include other dynamic buffer replacements. (QueryString.php)
* Added some comments about various bugs or potential issues in Pretty URLs. (QueryString.php)
Re: New revs
« Reply #512, on January 13th, 2011, 08:02 PM »
rev 468

! Fixed ob_sessrewrite getting called twice. Against all odds, the ob_get_contents()/ob_clean() pair does trigger the current output buffer handler, even if it doesn't destroy it later. I'd be tempted to call that a PHP bug, but anyway, maybe I'm just too dumb to understand that logic. Worked around it by putting all of the debug info into a variable, and showing it at ob_sessrewrite time, rather than getting the existing buffer. (QueryString.php, Subs.php)
- Removed an unused url_id from redirectexit(). (Subs.php)

Arantor

  • As powerful as possible, as complex as necessary.
  • Posts: 14,278
Re: New revs
« Reply #513, on January 14th, 2011, 10:15 AM »
Revision: 469
Author: arantor
Date: 09:11:32, 14 January 2011
Message:
+ New CAPTCHA: ledicons-animated (captcha-ledicons.php, captcha-ledicons_anim.php)
----
Modified : /trunk/Sources/captcha/captcha-ledicons.php
Added : /trunk/Sources/captcha/captcha-ledicons_anim.php

Posted: January 14th, 2011, 10:11 AM

Revision: 470
Author: arantor
Date: 09:15:29, 14 January 2011
Message:
+ Optionally display flags on board indexes for board-specific languages (install.sql, BoardIndex.php, BoardIndex.template.php, MessageIndex.php, MessageIndex.template.php, Subs-BoardIndex.php, ManageBoards.php, ManageBoards.english.php, Help.english.php)
----
Modified : /trunk/Sources/BoardIndex.php
Modified : /trunk/Sources/ManageBoards.php
Modified : /trunk/Sources/MessageIndex.php
Modified : /trunk/Sources/Subs-BoardIndex.php
Modified : /trunk/Themes/default/BoardIndex.template.php
Modified : /trunk/Themes/default/MessageIndex.template.php
Modified : /trunk/Themes/default/languages/Help.english.php
Modified : /trunk/Themes/default/languages/ManageBoards.english.php
Modified : /trunk/other/install.sql
Re: New revs
« Reply #514, on January 14th, 2011, 10:30 AM »
Revision: 471
Author: arantor
Date: 09:30:03, 14 January 2011
Message:
! Enforced 'allow guests to browse the forum' being disabled - guests have no access when that's off, so no permissions, no access to anything other than logging in.
 ! Enforce it for permissions, board access in SSI context and all SSI functions (SSI.php, Security.php)
 ! Hide guests group from all reports when access disabled (Reports.php)
 ! Hide guests option from board access (ManageBoards.php)
 ! Hide guests option from all permissions UIs (ManagePermissions.php)
----
Modified : /trunk/SSI.php
Modified : /trunk/Sources/ManageBoards.php
Modified : /trunk/Sources/ManagePermissions.php
Modified : /trunk/Sources/Reports.php
Modified : /trunk/Sources/Security.php
Re: New revs
« Reply #515, on January 14th, 2011, 11:02 AM »
Revision: 472
Author: arantor
Date: 10:01:48, 14 January 2011
Message:
! Fixing an undefined index in $context (Unreadreplies.php)
----
Modified : /trunk/Sources/Unreadreplies.php
When we unite against a common enemy that attacks our ethos, it nurtures group solidarity. Trolls are sensational, yes, but we keep everyone honest. | Game Memorial

Nao

  • Dadman with a boy
  • Posts: 16,082
Re: New revs
« Reply #516, on January 14th, 2011, 01:08 PM »
I tried to separate this commit in two, to make it possibly easier to review.... But it's definitely not possible to make them even. The big new features really span too many different files.

rev 473

! Fixed /~/ URLs to redirect to current user's profile. Yeah, I know... I should use /profile/ instead. (QueryString.php)
! Fixed pretty profile URLs as shown inside subdomains. (PrettyUrls-Filters.php)
* Rewrote guest reattribution area text to make it easier to understand. At least for me... (ManageMaintenance language files)
+ French translation. (Help.french.php, ManageBoard.french.php)

rev 474

+ Added a sidebar area. Only tested under the currently uncommitted styling. (BoardIndex.php, Subs.php, index.template.php, index.css)
* Rewrote the sub-template system to allow for mini-layers. (BoardIndex.php, Load.php, Subs.php, index.template.php)
* Reordered profile URLs to always show the 'u' component in second position. (Display.php, ModerationCenter.php, Profile-Modify.php, Profile-View.php, Profile.php, ScheduledTasks.php, Subs-Menu.php, TEMPLATES: Display, PersonalMessage, Profile, Who)
- Removed leftover code: main_below test in loadSubTemplate(), function description in Subs-Members, and outdated documentation in the index template. (Load.php, Subs-Members.php, index.template.php)
- Removed all *_my classes and instead used an additional 'my' class. This won't work in IE6, but my doctor said I shouldn't care. (Green/index.css, index.css, Nix/index.css, sections.css, MessageIndex.template.php, Recent.template.php)
! Renamed linktree ID to a class, to avoid validation issues. Thanks Pete for the reminder. (index.css, Nix/index.css, rtl.css, index.template.php)
Re: New revs
« Reply #517, on January 14th, 2011, 05:15 PM »
Again, splitting a commit in two for easier reference.

rev 475

* Renamed some $VARIABLES to $variables. (install.php, upgrade.php, Memberlist.php, PersonalMessage.php, Profile-Actions.php, Reports.php, ScheduledTasks.php, Stats.php)

rev 476

! Sidebar was going crazy in the default styling. (index.css)
! Fixed display pages not playing along with the sidebar. Will probably have to remove all of the clear states from the code. Yikes. (sections.css)
* Turned search field into type="search" and gravatar field into type="email"... Not that it's needed, but supposedly the fallback for non-supporting browsers is type="text", so it's the call of the future. Will need to change more input fields this way, obviously. Consider this a personal note. (index.template.php, Profile.template.php)
! Fixed ignored boards indentation (whatever) in Search, and applied fixes to Profile as well (forgot that one). (Profile.template.php, Search.template.php)
Re: New revs
« Reply #518, on January 14th, 2011, 09:22 PM »
rev 477

! Fixed menus showing stray or duplicate separators in some cases. (Subs-Menu.php)
* Added a minor optimization to CSS if an empty rule is found. Useful if we want to offer empty placeholders. (Subs.php)
! Fixed auto-suggest on pages where only one entry is requested. (suggest.js)
Re: New revs
« Reply #519, on January 15th, 2011, 01:26 PM »
rev 478

! Fixed htaccess to make it work with Pretty URLs when installed in a sub-folder. (other/.htaccess)
! Fixed undefined index if query string wasn't set. (Errors.php)
! Fixed clear issues in MessageIndex. (sections.css)

Arantor

  • As powerful as possible, as complex as necessary.
  • Posts: 14,278
Re: New revs
« Reply #520, on January 16th, 2011, 05:28 PM »
Revision: 479
Author: arantor
Date: 16:28:17, 16 January 2011
Message:
! If possible, save a query for getting last post's time for a thread (for whether it's old enough there should be a warning to user) (Display.php, Display.template.php)
----
Modified : /trunk/Sources/Display.php
Modified : /trunk/Themes/default/Display.template.php
Re: New revs
« Reply #521, on January 16th, 2011, 05:38 PM »
Revision: 480
Author: arantor
Date: 16:37:30, 16 January 2011
Message:
! Stray poll action cleaned up (index.php, Poll.php)
+ Imperative scheduled tasks now exist though UNTESTED (index.php, Load.php, Subs-Scheduled.php)
----
Modified : /trunk/Sources/Load.php
Modified : /trunk/Sources/Poll.php
Added : /trunk/Sources/Subs-Scheduled.php
Modified : /trunk/index.php
Modified : /trunk/other/install.sql


Of course, imperative scheduled tasks has a new table.
Re: New revs
« Reply #522, on January 16th, 2011, 06:46 PM »
Revision: 481
Author: arantor
Date: 17:46:04, 16 January 2011
Message:
+ Provide option whether moved topics can only be moved into areas the user could theoretically create a new topic in, or any board they can see. (ManagePosts.php, MoveTopic.php, Admin.english.php, Help.english.php)
----
Modified : /trunk/Sources/ManagePosts.php
Modified : /trunk/Sources/MoveTopic.php
Modified : /trunk/Themes/default/languages/Admin.english.php
Modified : /trunk/Themes/default/languages/Help.english.php
Re: New revs
« Reply #523, on January 17th, 2011, 08:16 AM »
Revision: 482
Author: arantor
Date: 07:15:57, 17 January 2011
Message:
! Remove unread since last visit, so unread just triggers all unread now. (index.english.php, index.template.php, Unread.php, Unreadreplies.php, Recent.template.php)
----
Modified : /trunk/Sources/Unread.php
Modified : /trunk/Sources/Unreadreplies.php
Modified : /trunk/Themes/default/Recent.template.php
Modified : /trunk/Themes/default/index.template.php
Modified : /trunk/Themes/default/languages/index.english.php
Re: New revs
« Reply #524, on January 17th, 2011, 08:34 AM »
Revision: 483
Author: arantor
Date: 07:33:54, 17 January 2011
Message:
! Recent posts was broken, oops (Recent.php)
----
Modified : /trunk/Sources/Recent.php
Plugin revs »