New revs
Plugin revs »

Nao

  • Dadman with a boy
  • Posts: 16,082
Re: New revs
« Reply #450, on December 18th, 2010, 10:51 PM »
rev 386

* Modified the license agreement to rename WedgeBox to Wedgeward (don't bother, I'll probably get around to changing it again before you know it), and add the "vbgamer45 clause". Or at least a placeholder... (license.txt)
* Renamed WedgeBox to Wedgeward everywhere else. (install.php, ssi_examples.shtml, upgrade.php, Credits.php, index.template.php, LANGUAGES: index, Install)

Arantor

  • As powerful as possible, as complex as necessary.
  • Posts: 14,278
Re: New revs
« Reply #451, on December 20th, 2010, 04:48 PM »
Revision: 387
Author: arantor
Date: 15:47:43, 20 December 2010
Message:
+ First part of the drafts system
 + Added ability to save drafts (lots of files)
 + Editor gained ability to specify buttons programmatically without editing the editor code (Class-Editor.php)
 ! Area to display drafts (Profile-View.php, Profile.php, Profile.english.php, Profile.template.php)
 ! Better display of saved drafts than original mod (MessageIndex.php, MessageIndex.template.php, Display.php, Display.template.php)
 ! Permissions (ManagePermissions.english.php, ManagePermissions.php)
 ! Admin on/off switches (ManagePosts.php, Admin.english.php)
 ! If the topic is no longer available when trying to handle a draft, display a warning to the user and handle the draft as if trying to create a new topic (Profile-View.php, Profile.template.php)

@todo in rough priority: Saving of personal messages, display of PM saved drafts, auto saving, fix what to do if a board isn't available (give the user another board to pick instead)
----
Modified : /trunk/Sources/Class-Editor.php
Modified : /trunk/Sources/Display.php
Modified : /trunk/Sources/ManagePermissions.php
Modified : /trunk/Sources/ManagePosts.php
Modified : /trunk/Sources/MessageIndex.php
Modified : /trunk/Sources/PersonalMessage.php
Modified : /trunk/Sources/Post.php
Modified : /trunk/Sources/Post2.php
Modified : /trunk/Sources/Profile-View.php
Modified : /trunk/Sources/Profile.php
Modified : /trunk/Sources/Subs-Members.php
Modified : /trunk/Sources/Subs-Post.php
Modified : /trunk/Themes/default/Display.template.php
Modified : /trunk/Themes/default/MessageIndex.template.php
Modified : /trunk/Themes/default/Profile.template.php
Modified : /trunk/Themes/default/languages/Admin.english.php
Modified : /trunk/Themes/default/languages/ManagePermissions.english.php
Modified : /trunk/Themes/default/languages/Profile.english.php
Modified : /trunk/Themes/default/languages/index.english.php
Modified : /trunk/other/install.sql
When we unite against a common enemy that attacks our ethos, it nurtures group solidarity. Trolls are sensational, yes, but we keep everyone honest. | Game Memorial

Nao

  • Dadman with a boy
  • Posts: 16,082
Re: New revs
« Reply #452, on December 21st, 2010, 12:49 AM »
rev 388

* Spacinazi. (Post.php, Post2.php, Profile.php, Subs-Post.php, Profile.template.php, index.english.php)
! As a reminder, the align attribute doesn't validate in HTML5. (Profile.template.php)
* French translation for drafts. WIP. (LANGUAGES: Admin, index, ManagePermissions, Profile)
Re: New revs
« Reply #453, on December 21st, 2010, 06:23 PM »
rev 389

! Fixed inline topic title modification, which was awfully broken since the switch to jQuery. (MessageIndex.template.php, topic.js)
! Fixed help popup for IE. Also made sure to close the popup if user clicks anywhere outside of it. (script.js)
* wesql::insert can't accept a "default" value for its first parameter, since its remaining parameters are mandatory... (Class-DB.php)
* Added a quick hack for lazy DB insertion. This is temporary (for AeMe integration), and should probably be removed later, unless proved solid. (Class-DB.php)
* Spacinazi: replaced NULL with null, just for consistency. (Class-Editor.php, Load.php, ManageSearchEngines.php, SplitTopics.php)
! CSS minification didn't optimize "element > element". (Subs.php)
+ Added some code to prevent Packer from removing /*! comments (copyright stuff) from the compressed files. Doesn't work when the file is compressed with Packer, though (as opposed to just minified.) (Subs.php, script.js)
* Moved add_linktree() from AeMe to Wedge. (Subs.php)
* Menu tweaks. (index.css, Green/index.css, Nix/index.css, ie6.css, ie7.css, rtl.css)
* Help popup should properly underline links. (index.css)
* Adjusted voice popup to use jQuery to close its own div. (Register.template.php)
* Optimized for size reduction and taking advantage of Packer variable minification. (spellcheck.js, topic.js, script.js)
* The menu system was rewritten so thoroughly... I looked into it, and it no longer uses any of the original code, only the original idea. (script.js)
* Stopped using smf_itemPos() at all. Should we remove it? (suggest.js, script.js, topic.js)
* More jQuery optimization. (script.js)
Re: New revs
« Reply #454, on December 22nd, 2010, 08:44 PM »
rev 390

* Rewrote some of the menu code to make it even tighter. A bit slower maybe, but only by milliseconds. (script.js, index.css)
- Removed setOuterHTML function and replaced it with native jQuery calls. Also various minor jQuery conversions. (upgrade.php, script.js, topic.js, TEMPLATES: Admin, ManageNews, PersonalMessage, Poll, Post)
- Don't attempt to use Base62 encoding with Packer. It seems to be broken in v3.1 anyway. (Subs.php)
- Cancelling underscores in variable names to make sure they don't collide with other scripts. (topic.js)
+ A French file in SMF/Wedge wasn't completely translated. Ha! (ManageSettings.french.php)
Re: New revs
« Reply #455, on December 23rd, 2010, 12:55 PM »
rev 391

+ Err... I think no one bothers to test minification because I forgot to delete Class-Minify and commit the Packer class instead, ah ah. Okay, that's not funny. (Class-Packer.php)
! Duplicate filenames should be removed earlier in the caching process. (QueryString.php, Subs.php)
* Simplified Packer constructor, because basically this is a custom object and I'd rather hack into it from its class file rather than anything else. (Subs.php)
- Commented out the semicolon addition hack for Packer. This is because all of Wedge's files are fixed by now, and only those who use badly coded JS files should worry about using that code block. (Subs.php)
* Some edit_poll style optimization. At this point it's quite clear that no real thought has been put into SMF's CSS. It needs some severe reworking to make it much shorter. 59KB is a joke. (index.css)
! sha1.js being a base JS file, it shouldn't be included through add_js_file(). (Login.template.php)
! Code typo. (Post.template.php)
* Moved hashLogin/AdminPassword functions to sha1.js because they require hex_sha1() and thus shouldn't be in the main script file. (script.js, sha1.js)
* More script.js optimizations. isEmptyText() is reduced to one line because jQuery has $.trim(), same for in_array/$.inArray(), setTimeout functions don't need the 'window' prefix, used temp variables to hold long object names, etc. (script.js)
@ Note: $('<option />').appendTo(SomeDocumentFragment) doesn't seem to work. Doing it with appendChild fixes it. (script.js)
Re: New revs
« Reply #456, on December 23rd, 2010, 06:25 PM »
rev 392

- Got rid of those annoying eval's. (Class-Editor.php, editor.js, pm.js)
- Got rid of those annoying init's. (admin.js, pm.js, stats.js)
! Fixed BCC help popup not showing up. Complicated hack for a link no one ever clicks, uh... (script.js)
* More JS optimization. (pm.js, script.js, suggest.js)

Note for Pete: Add BCC is still slightly broken... The auto-suggest pops up where the text input was in the first place, rather than its current position. Haven't found out why. Also, I can enter my name as many times as I want, it adds it repeatedly. I seemed to remember that SMF had a mechanism to prevent duplicates. Did I break something or was I dreaming?
Re: New revs
« Reply #457, on December 24th, 2010, 10:11 PM »
rev 393

* Moved JS/CSS cache folder to the root cache. (cache/.htaccess, ManageServer.php, QueryString.php, Subs.php)

(I'm committing in two chunks -- this one is the quicker one as it's only one feature change, tested to work. I'll do the rest of my commits when I'm more available.)
Re: New revs
« Reply #458, on December 25th, 2010, 12:02 AM »
rev 394, aka the Santa Caummit. Ho ho hoooo! (Midnight, French time.)

* Made the auto-suggest popup colors a little less depressing. (index.css)
* Turned the quick edit button into a div and made it always show immediately. A big mistake from SMF, fixed at last... (index.css, Display.template.php, topic.js)
- Removed a few evil eval's. (ManageBans.template.php)
* There's no point in creating a Loading indicator if we want to remove it in the first place. (script.js)
! The Add BCC link would forget to return false as expected. (pm.js)
* More JS optimizations. (captcha.js, sha1.js, stats.js, theme.js, topic.js)
* Note to self: .first() is more logical and faster than :first if we really only want the first item in the list. (script.js)

Pete --- I really didn't have time to test all of these. Please, please make sure to check the JS files here. Most notably sha1.js (hopefully nothing broken), stats.js, theme.js and basically the other JS files (although less important.) I'm surprised I got to squeeze even more bytes out of the original files. Some of these are way shorter now... (theme.js isn't very big in the first place, but I've shaved another 30% off it I believe.)
Bed time! Merry Christmas to all.

Arantor

  • As powerful as possible, as complex as necessary.
  • Posts: 14,278
Re: New revs
« Reply #459, on December 25th, 2010, 03:54 AM »
Revision: 395
Author: arantor
Date: 01:01:38, 25 December 2010
Message:
+ Added ability to remove all drafts at once (Profile-View.php, Profile.english.php, Profile.template.php)
+ Added ability to automatically prune posts, as well as advising the user of the time drafts live for. (install.sql, ManagePosts.php, ScheduledTasks.php, Help.english.php, Profile-View.php, Profile.english.php, Profile.template.php)
----
Modified : /trunk/Sources/ManagePosts.php
Modified : /trunk/Sources/Profile-View.php
Modified : /trunk/Sources/ScheduledTasks.php
Modified : /trunk/Themes/default/Profile.template.php
Modified : /trunk/Themes/default/languages/Admin.english.php
Modified : /trunk/Themes/default/languages/Help.english.php
Modified : /trunk/Themes/default/languages/Profile.english.php
Modified : /trunk/other/install.sql

Posted: December 25th, 2010, 02:02 AM

Revision: 396
Author: arantor
Date: 01:37:18, 25 December 2010
Message:
! Cleaned up how 'topic-no-longer-exists' is determined ready for later (Profile-View.php, Profile.template.php)
! Bug fixes in resaving drafts (Subs-Post.php)
----
Modified : /trunk/Sources/Profile-View.php
Modified : /trunk/Sources/Subs-Post.php
Modified : /trunk/Themes/default/Profile.template.php

Posted: December 25th, 2010, 02:38 AM

Revision: 397
Author: arantor
Date: 01:41:11, 25 December 2010
Message:
! Move the call to load the error language file into determineActions since this can be called from the profile area too, rather than only Who(). (Who.php)
----
Modified : /trunk/Sources/Who.php

Posted: December 25th, 2010, 02:41 AM

Revision: 398
Author: arantor
Date: 02:54:14, 25 December 2010
Message:
! Fix the installer dumping updateStats cache files in the wrong place because $cachedir wasn't brought into scope properly. (install.php)
----
Modified : /trunk/other/install.php
Re: New revs
« Reply #460, on December 26th, 2010, 02:51 AM »
Revision: 399
Author: arantor
Date: 01:51:09, 26 December 2010
Message:
+ If a topic is locked, and the user does not have moderation powers, the message for drafts is handled appropriately as well as offering to make it a new topic. (Profile-View.php, Profile.english.php, Profile.template.php)
----
Modified : /trunk/Sources/Profile-View.php
Modified : /trunk/Themes/default/Profile.template.php
Modified : /trunk/Themes/default/languages/Profile.english.php
Re: New revs
« Reply #461, on December 26th, 2010, 05:29 AM »
Revision: 400
Author: arantor
Date: 04:28:59, 26 December 2010
Message:
! Bug fix for missing legend text in admin panel (Admin.english.php)
+ Main menu items for drafts, both in posts (under profile) and PMs (under messages) (Subs.php, index.english.php)
+ Saving PM drafts (Class-Editor.php, Display.php, PersonalMessage.php, Post.php, Subs-Post.php)
----
Modified : /trunk/Sources/Class-Editor.php
Modified : /trunk/Sources/Display.php
Modified : /trunk/Sources/PersonalMessage.php
Modified : /trunk/Sources/Post.php
Modified : /trunk/Sources/Subs-Post.php
Modified : /trunk/Sources/Subs.php
Modified : /trunk/Themes/default/languages/Admin.english.php
Modified : /trunk/Themes/default/languages/index.english.php

Nao

  • Dadman with a boy
  • Posts: 16,082
Re: New revs
« Reply #462, on December 26th, 2010, 10:15 AM »
Waking up... Trying to get back to work and checking your stuff...

rev 401

* Use $cachedir instead of $boarddir . '/cache'... (ManageServer.php, QueryString.php, Subs.php)
! A variable was global'ed twice. We should double-check for these... (QueryString.php)
Re: New revs
« Reply #463, on December 26th, 2010, 02:16 PM »
rev 402

* Renamed more window.setTimeout/clearTimeout to just the function names. (upgrade.php, Load.php, fader.js, topic.js, Themes.template.php)
* More JS optimizations. Most notably, topic.js turns a 11-line code block into a single-line jQuery call, although it has yet to be tested. (fader.js, register.js, suggest.js, topic.js)
* Spacinazi/typonazi. (Class-Editor.php, Profile.english.php, Profile.template.php, captcha.js)
* Less pinkish colors for the auto-suggest popup. (index.css)
+ French translation of new draft features. (LANGUAGES: Admin, Help, index, Profile)
* Made a help text more specific about something. (Help.english.php)
* Fixed uglyish PM post box layout. (PersonalMessage.template.php, index.css)

Arantor

  • As powerful as possible, as complex as necessary.
  • Posts: 14,278
Re: New revs
« Reply #464, on December 26th, 2010, 05:05 PM »
Revision: 403
Author: arantor
Date: 16:04:47, 26 December 2010
Message:
+ Added ability to view saved PM drafts (including fix to menu) (PersonalMessage.php, PersonalMessage.template.php, PersonalMessage.english.php, Subs.php, index.english.php)
----
Modified : /trunk/Sources/PersonalMessage.php
Modified : /trunk/Sources/Subs.php
Modified : /trunk/Themes/default/PersonalMessage.template.php
Modified : /trunk/Themes/default/languages/PersonalMessage.english.php
Modified : /trunk/Themes/default/languages/index.english.php
Plugin revs »