New revs
Plugin revs »

Nao

  • Dadman with a boy
  • Posts: 16,082
Re: New revs
« Reply #420, on December 6th, 2010, 10:48 AM »
rev 351

* Renamed wedb class to wesql, for consistency with both the westr class, and the original mysql_* functions. Whatever, eh? (SSI.php, subscriptions.php, other/install.php, Sources/*.php)

(Put into its own separate commit, so that you can cancel it if you end up not liking it.)
(Also, I haven't renamed wedbPackages and wedbExtra yet. I don't really know what to do about them... Maybe weDbPackages and weDbExtra? Or weDBPackages and weDBExtra, like their Class-*.php filenames?)
Re: New revs
« Reply #421, on December 6th, 2010, 11:49 AM »
rev 352

* Slightly optimized parse_bbc() by removing its two easter eggs (chrissy and kissy), avoiding copying $master_codes to $codes, and referencing $master_codes when filling the BBCode array, instead of copying it. (Subs.php)
* User menus are no longer triggered when clicking a username, rather they'll pop up when hovering the username, and close automatically when moving the mouse somewhere else. Oddly, this makes the code a bit simpler, as body click events and double-click cancellations (via onmousedown) are no longer necessary. (Display.template.php, topic.js)
+ Added French image folder. Just so we don't forget providing it later... (images/french/*)

(Have yet to commit my partial editor.js conversion to jQuery. I wouldn't even know where to begin with testing, ah ah...)
Re: New revs
« Reply #422, on December 6th, 2010, 04:23 PM »
rev 353

! Error when renaming the wedb class. (Class-DB.php)
* hover() is shorter than a double bind. (Display.template.php)
* Moved avatar management code in profile to the footer area. (Profile.template.php)

(Sorry for the crash bug. I'm busy debugging the main menu in IE (it's currently broken) and I didn't test everything.)
Re: New revs
« Reply #423, on December 6th, 2010, 11:49 PM »
rev 354

! Fixed a few functions that were broken during the conversion to jQuery. (script.js)
Posted: December 6th, 2010, 10:26 PM

rev 355

* Improved menu performance in Internet Explorer by a factor of 42. I'm so proud. (script.js)
! Fixed iframe shim for IE. Should be working well in IE6 now. (script.js)
* More jQuery goodness. Can be improved, as usual... (script.js)
@ todo: fix editor in IE6... Doesn't seem to accept Wysiwyg, and icons don't show. (Already fixed that once last month... Uh. IE.)
Re: New revs
« Reply #424, on December 7th, 2010, 06:39 PM »
Ah... Finally done with that commit... -_-

rev 356

* Too bad jQuery doesn't support the pageshow event... Still, moving that to the footer. (Post.template.php)
- Replaced event listeners with jQuery's implementation. (register.js, topic.js)
* Replaced XMLHttpRequest tests with a can_ajax variable, and removed all tmpMethod hacks. The Themes template still has a different hack that needs to go. (upgrade.php, TEMPLATES: Display, MessageIndex, Packages, Search, SplitTopics, Themes, register.js, stats.js, suggest.js, topic.js)
* Style file inputs to get a default width of 300px. (index.css, Packages.template.php)
* Replaced Comic Sans MS with Segoe UI. Yeah, Comic is a popular font, but it doesn't make me laugh. That would actually be the opposite... Also replaced the ugly Courier with Courier New, and deleted an extra, unused copy of the font list from the script file. (Class-Editor.php, editor.js)
* Made main menu code faster, and saved an awful lot of code, too. (script.js)
* Been slightly more aggressive when minifying CSS... Saves a few bytes per file. (Subs.php)
* Renamed is_ie9 JS var to is_ie9up, as it's really what it does now... (script.js)
- getMousePosition() was no longer needed, as its task is already fulfilled by jQuery. (editor.js)
* The 'more' bbcode tag was hardcoded. I know it's not finished yet (add button, etc..?), but it still needed to get its own class and translations. (Subs.php, index.css, index.english.php, index.french.php)
@ Discuss: Shouldn't parse_bbc use UTF8-safe strlen/substr functions everywhere..?
@ Note for later: IE6 doesn't like $('<input>', { object }). Whatever they say on the web... It doesn't. It has to be fully formed in the HTML portion.
Re: New revs
« Reply #425, on December 7th, 2010, 09:04 PM »
rev 357

+ The smc_Toggle class was screaming to be upgraded to use jQuery's animations! Looks great and saves 5 lines of code, ah ah! (script.js)
Re: New revs
« Reply #426, on December 9th, 2010, 06:30 PM »
rev 358

* Modified the menu system to turn it into a pure CSS menu when Javascript is not available. Oh yes. (index.css, script.js, GenericMenu.template.php, index.template.php)
* Changed toggle class animation to make it slide up and down, instead of shrink and fade. This should be a bit better for performance, and accomodate for weirder layouts, if ever needed. (script.js)
! Fixed remaining chars counter in the 'more' tag, to take multi-byte chars into account. Also, don't bother showing anything if the tag was put at the end of the message. (Subs.php)
! Fixed many CSS bugs in the main menu implementation for IE6 and IE7. (ie6.css, ie7.css)
* Couple of translation tweaks. (Admin.french.php)
* More jQuery conversion work... Errr... Just turned a 5-line loop into a 2-line parentsUntil() chain. So what. It's a cool geeky instruction. (script.js)
- Removed a 'move' bbcode leftover. Thanks Pete! (Post.template.php)

MultiformeIngegno

  • Posts: 1,337
Re: New revs
« Reply #427, on December 9th, 2010, 08:02 PM »
Great! :cool:

Nao

  • Dadman with a boy
  • Posts: 16,082
Re: New revs
« Reply #428, on December 9th, 2010, 08:06 PM »
Thanks ;)
Please post your comments in the appropriate topic though... We're trying to make this one has only the changelogs, to make it easier to go through ;)

rev 359

- Hack for ob_sessrewrite was no longer needed, as Wedge doesn't use ob_end_clean() anywhere. (QueryString.php)
Re: New revs
« Reply #429, on December 10th, 2010, 12:50 AM »
rev 360

* More jQuery optimization. Simplified help frame to avoid storing a variable in memory just for that. (script.js, Help.template.php, Register.template.php)
* Made submitThisOnce() work on Safari 3.0+, because the comment indicates the hack is for v1.3 beta... Logic dictates that recent builds should work fine. (script.js)
* Moved array_search() to editor.js, as it was only used over there. (editor.js, script.js)
* Spacinazi. (Subs.php, script.js)
Re: New revs
« Reply #430, on December 10th, 2010, 10:00 AM »
rev 361

* Converted smf_avatarResize() to jQuery, and removed some leftover code. (script.js)

I think 99% of the jQuery conversion is done in script.js... I mean, I don't really see anything else to do. I'll probably be able to save at most 10 more lines by doing micro-changes here and there... Nothing more.
Still, all in all I've managed to shave nearly 7 kilobytes off the size of script.js -- that is, about 18%, or twice more than the best I thought I could have achieved.

I have a feeling that editor.js can get a similar treatment, but I don't know if it's worth thinking about it, because of the talk on including CKEditor. I figure it means editor.js will go at some point...? Or at least most of it?

Arantor

  • As powerful as possible, as complex as necessary.
  • Posts: 14,278
Re: New revs
« Reply #431, on December 10th, 2010, 11:50 AM »
Quote
I have a feeling that editor.js can get a similar treatment, but I don't know if it's worth thinking about it, because of the talk on including CKEditor. I figure it means editor.js will go at some point...? Or at least most of it?
At least most of it.
When we unite against a common enemy that attacks our ethos, it nurtures group solidarity. Trolls are sensational, yes, but we keep everyone honest. | Game Memorial

Nao

  • Dadman with a boy
  • Posts: 16,082
Re: New revs
« Reply #432, on December 10th, 2010, 03:12 PM »
So I'm working on suggest.js instead. :P
Re: New revs
« Reply #433, on December 10th, 2010, 07:26 PM »
rev 362

! Fixed a SMF bug in the auto-suggest control, where the popup would reappear after selecting an entry if the typed text was the same as the suggested (and selected) text, only with different letter case. (suggest.js)
- Removed handleSubmit() function, which was really pointless, and oRealTextHandle object, which... you get the idea. (suggest.js)
+ Added subtle animation effect to auto-suggest popups. (suggest.js)
* Overall, converted auto-suggest to jQuery. (suggest.js)

Arantor

  • As powerful as possible, as complex as necessary.
  • Posts: 14,278
Re: New revs
« Reply #434, on December 11th, 2010, 12:52 AM »
Revision: 363
Author: arantor
Date: 23:37:37, 10 December 2010
Message:
! Performance enhancement to SSI's ssi_recentTopics function (thanks to live627)
----
Modified : /trunk/SSI.php

Posted: December 11th, 2010, 12:38 AM

Revision: 364
Author: arantor
Date: 23:52:11, 10 December 2010
Message:
! Fixed installer not logging in user on new install (install.php)
----
Modified : /trunk/other/install.php
Plugin revs »