New revs
Plugin revs »

Nao

  • Dadman with a boy
  • Posts: 16,082
Re: New revs
« Reply #405, on December 2nd, 2010, 12:11 PM »
rev 330

* Now that we're using PHP 5.1.2 as minimum version, date_default_timezone_set() is always available, so don't bother looking for it. Also made a couple of related time function fixes. (install.php, upgrade.sql, Calendar.php, Load.php, ManageSettings.php)
- Deleted a few unused globals. There's probably room for more to be removed here. (install.php)
- Delete clickMagic(), as it will now be done inline. (script.js)
! Fatal error pages could break the header layout. (css/index.css)
! CRLF fix. (Nix/ie6.css)

(I forgot to document the script.js change in the changelog -- actually I was planning to commit it in the next batch rather than now, oops...)
Pete, can you look into these useless globals in install.php? I don't see why there were so many declared in the first place...
Re: New revs
« Reply #406, on December 2nd, 2010, 02:15 PM »
rev 331

@ First official use of jQuery in Wedge![1] (QueryString.php, topic.js)
* Finalized inline JS code. Now, all events are automatically moved to the end of the page, with all duplicates merged, and executed after jQuery is loaded. (QueryString.php, index.template.php)
* Modified Quick Reply, Quick Modify and User Menu objects to allow for better duplicate management. Deleted xDeprecated argument from QuickReply.quote(). (Display.template.php, topic.js)
- Deleted data- prefixes from events in Display template. Other files will be done next. (Display.template.php)
* User menu is now a bit more user-friendly... User can click anywhere in the page to cancel an opened menu, and clicking on another user name will also close previously opened menus. (topic.js)
Posted: December 2nd, 2010, 02:00 PM

rev 332

- Reverted all 60+ existing data-on* events to happily use the new system. (Class-Editor.php, Groups.php, Manage*.php, Modlog.php, Profile-Modify.php, Subs-Package.php, Subs.php, TEMPLATES: Admin, Calendar, ManageMaintenance, MessageIndex, ModerationCenter, Poll, Post, Profile, Register, Stats)
 1. As far as I know... :mdr:
Re: New revs
« Reply #407, on December 2nd, 2010, 02:30 PM »
rev 333

* Renamed weDB, weDBExtra, weDBPackages and weDBSearch classes to wedb, wedbExtra, wedbPackages and wedbSearch. This took a minute to do. Can be reverted if someone's unhappy. Just wanted to see how it looked and felt ;) (Plenty of files, obviously.)

To Pete: I didn't wait for your feedback to do this... I'm well aware that you might not like this, so I made sure it's done in a separate commit. If you don't like it, either manually do a search & replace on wedb to weDB (or "wdb"?), or just revert rev 333! This is NOT a hostile fork commit... :^^;:

Also, obviously, if you're going to analyze revs 330-332, please update to rev 332, not 333 ;)
Re: New revs
« Reply #408, on December 2nd, 2010, 07:49 PM »
rev 334

* ssi_examples fix. Plenty of things were broken in the first place. (other/ssi_examples.*)
* Converted more templates to HTML5. Some of these files in other/* are a real mess... Might as well throw them away at some point. (news_readme.html, readme_*.html, sphinx_config.php, ssi_examples.*, package/*.html, package/test_modification.php, repair_settings.php, webinstall.php, SSI.php)
- Did you know that link rel="stylesheet" tags could also do without the type="text/css" attribute? Yes? Well, I didn't. I tried, and it validates. Away they go. (install.php, Class-Editor.php, ViewQuery.php, and most of the files above. TEMPLATES: Errors, Help, index, ModerationCenter, Packages, Post, Register, Reports)
- Forgot to update the documentation when I removed specific browser version sniffing in rev 93. (Load.php)
Posted: December 2nd, 2010, 07:07 PM

rev 335

- Deleted empty alt's from img tags, as they're not required by the HTML5 specs. (ssi_examples.php, Display.php, Load.php, Subs-Menu.php, Subs.php, editor.js, TEMPLATES: Admin, BoardIndex, Display, Errors, GenericList, GenericMenu, Login, ManageMembergroups, ManageSmileys, Memberlist, MessageIndex, ModerationCenter, Notify, Packages, PersonalMessage, Post, Profile, Recent, Search, SendTopic, Stats, Themes, Who)
* Fixed posting_icons alignment. (index.css)
Re: New revs
« Reply #409, on December 3rd, 2010, 08:59 AM »
rev 336

! Events could be postponed even when inserted in the footer area. (QueryString.php, index.template.php)

Arantor

  • As powerful as possible, as complex as necessary.
  • Posts: 14,278
Re: New revs
« Reply #410, on December 3rd, 2010, 02:45 PM »
Revision: 337
Author: arantor
Date: 12:40:36, 03 December 2010
Message:
! Don't show the login screen for someone who is already logged (Login.php)
----
Modified : /trunk/Sources/Login.php

Posted: December 3rd, 2010, 01:41 PM

Revision: 338
Author: arantor
Date: 13:44:42, 03 December 2010
Message:
! Make bbcode be loaded from a table rather than stored hardcoded in the parser (Subs.php, install.sql)
----
Modified : /trunk/Sources/Subs.php
Modified : /trunk/other/install.sql
Re: New revs
« Reply #411, on December 3rd, 2010, 05:50 PM »
Revision: 339
Author: arantor
Date: 16:49:46, 03 December 2010
Message:
+ westring class (Class-String.php)
! Die, $smcFunc, die. (MANY files, many changes pretty automated which is why some of the other/ files are done)
! Stripping out a few more of the db_* functions that should have gone yesterday (RepairBoards.php and a couple of others)
----
Modified : /trunk/SSI.php
Modified : /trunk/Sources/Activate.php
Modified : /trunk/Sources/Admin.php
Modified : /trunk/Sources/Announce.php
Modified : /trunk/Sources/Calendar.php
Modified : /trunk/Sources/Class-Editor.php
Added : /trunk/Sources/Class-String.php
Modified : /trunk/Sources/CoppaForm.php
Modified : /trunk/Sources/Display.php
Modified : /trunk/Sources/Dlattach.php
Modified : /trunk/Sources/DumpDatabase.php
Modified : /trunk/Sources/Errors.php
Modified : /trunk/Sources/Feed.php
Modified : /trunk/Sources/Findmember.php
Modified : /trunk/Sources/Groups.php
Modified : /trunk/Sources/JSModify.php
Modified : /trunk/Sources/Jseditor.php
Modified : /trunk/Sources/Jsoption.php
Modified : /trunk/Sources/Load.php
Modified : /trunk/Sources/Lock.php
Modified : /trunk/Sources/Login2.php
Modified : /trunk/Sources/Logout.php
Modified : /trunk/Sources/ManageAttachments.php
Modified : /trunk/Sources/ManageBans.php
Modified : /trunk/Sources/ManageBoards.php
Modified : /trunk/Sources/ManageCalendar.php
Modified : /trunk/Sources/ManageErrors.php
Modified : /trunk/Sources/ManageMail.php
Modified : /trunk/Sources/ManageMaintenance.php
Modified : /trunk/Sources/ManageMembergroups.php
Modified : /trunk/Sources/ManageMembers.php
Modified : /trunk/Sources/ManageNews.php
Modified : /trunk/Sources/ManagePaid.php
Modified : /trunk/Sources/ManagePermissions.php
Modified : /trunk/Sources/ManagePosts.php
Modified : /trunk/Sources/ManageRegistration.php
Modified : /trunk/Sources/ManageScheduledTasks.php
Modified : /trunk/Sources/ManageSearch.php
Modified : /trunk/Sources/ManageSearchEngines.php
Modified : /trunk/Sources/ManageServer.php
Modified : /trunk/Sources/ManageSettings.php
Modified : /trunk/Sources/ManageSmileys.php
Modified : /trunk/Sources/Memberlist.php
Modified : /trunk/Sources/MessageIndex.php
Modified : /trunk/Sources/ModerationCenter.php
Modified : /trunk/Sources/Modlog.php
Modified : /trunk/Sources/MoveTopic.php
Modified : /trunk/Sources/Notify.php
Modified : /trunk/Sources/PackageGet.php
Modified : /trunk/Sources/Packages.php
Modified : /trunk/Sources/PersonalMessage.php
Modified : /trunk/Sources/Poll.php
Modified : /trunk/Sources/Post.php
Modified : /trunk/Sources/Post2.php
Modified : /trunk/Sources/PostModeration.php
Modified : /trunk/Sources/PrettyUrls-Filters.php
Modified : /trunk/Sources/Printpage.php
Modified : /trunk/Sources/Profile-Actions.php
Modified : /trunk/Sources/Profile-Modify.php
Modified : /trunk/Sources/Profile-View.php
Modified : /trunk/Sources/Profile.php
Modified : /trunk/Sources/QueryString.php
Modified : /trunk/Sources/QuickMod.php
Modified : /trunk/Sources/QuoteFast.php
Modified : /trunk/Sources/Recent.php
Modified : /trunk/Sources/Register.php
Modified : /trunk/Sources/Reminder.php
Modified : /trunk/Sources/RemoveTopic.php
Modified : /trunk/Sources/RepairBoards.php
Modified : /trunk/Sources/Reports.php
Modified : /trunk/Sources/ScheduledTasks.php
Modified : /trunk/Sources/Search.php
Modified : /trunk/Sources/Search2.php
Modified : /trunk/Sources/SearchAPI-Custom.php
Modified : /trunk/Sources/SearchAPI-Fulltext.php
Modified : /trunk/Sources/Security.php
Modified : /trunk/Sources/SendTopic.php
Modified : /trunk/Sources/Spellcheck.php
Modified : /trunk/Sources/SplitTopics.php
Modified : /trunk/Sources/Stats.php
Modified : /trunk/Sources/Sticky.php
Modified : /trunk/Sources/Subs-Admin.php
Modified : /trunk/Sources/Subs-Auth.php
Modified : /trunk/Sources/Subs-BoardIndex.php
Modified : /trunk/Sources/Subs-Boards.php
Modified : /trunk/Sources/Subs-Calendar.php
Modified : /trunk/Sources/Subs-Categories.php
Modified : /trunk/Sources/Subs-Charset.php
Modified : /trunk/Sources/Subs-Editor.php
Modified : /trunk/Sources/Subs-Graphics.php
Modified : /trunk/Sources/Subs-Login.php
Modified : /trunk/Sources/Subs-Membergroups.php
Modified : /trunk/Sources/Subs-Members.php
Modified : /trunk/Sources/Subs-MembersOnline.php
Modified : /trunk/Sources/Subs-Menu.php
Modified : /trunk/Sources/Subs-MessageIndex.php
Modified : /trunk/Sources/Subs-OpenID.php
Modified : /trunk/Sources/Subs-Package.php
Modified : /trunk/Sources/Subs-Post.php
Modified : /trunk/Sources/Subs-PrettyUrls.php
Modified : /trunk/Sources/Subs-Recent.php
Modified : /trunk/Sources/Subs.php
Modified : /trunk/Sources/Subscriptions-PayPal.php
Modified : /trunk/Sources/Suggest.php
Modified : /trunk/Sources/Themes.php
Modified : /trunk/Sources/Unread.php
Modified : /trunk/Sources/Unreadreplies.php
Modified : /trunk/Sources/ViewQuery.php
Modified : /trunk/Sources/ViewSMFile.php
Modified : /trunk/Sources/Who.php
Modified : /trunk/Sources/Xmlhttp.php
Modified : /trunk/Themes/default/Admin.template.php
Modified : /trunk/Themes/default/Announce.template.php
Modified : /trunk/Themes/default/Calendar.template.php
Modified : /trunk/Themes/default/ManageNews.template.php
Modified : /trunk/Themes/default/ManageSearch.template.php
Modified : /trunk/Themes/default/Packages.template.php
Modified : /trunk/index.php
Modified : /trunk/other/install.php
Modified : /trunk/other/tools/create_backup.php
Modified : /trunk/other/tools/repair.php
Modified : /trunk/other/tools/repair_settings.php
Modified : /trunk/other/tools/restore_backup.php
Modified : /trunk/other/tools/smf_api.php
Modified : /trunk/other/tools/smfinfo.php
Modified : /trunk/other/unittest/tests/Class-UnitTest.php
Modified : /trunk/other/unittest/tests/Class-UnitTest_parsesmileys.php
Modified : /trunk/other/upgrade.php
Modified : /trunk/subscriptions.php

(Oh, and there is a change to Login.php to kick registered users back to the main page since we shouldn't really show the login page to non-guests.)
When we unite against a common enemy that attacks our ethos, it nurtures group solidarity. Trolls are sensational, yes, but we keep everyone honest. | Game Memorial

Nao

  • Dadman with a boy
  • Posts: 16,082
Re: New revs
« Reply #412, on December 4th, 2010, 11:02 AM »
rev 340

* Many script.js changes. Dropped is_ie4, is_ie5 and other deprecated browser vars (testing for if (is_ie4) is going to return false, whether they're declared or not, so let's not waste time initializing them...), used more logical ways to determine version numbers (Opera 9.5+ and IE versions), used jQuery in many places to save up to 3KB of script code. Turned addLoadEvent into a jQuery alias. (script.js)
! Fixed the following bugs in inline JS postponing: double ob_sessrewrite calls, events not getting compiled at runtime (used function() instead of new Function()), exotic templates generating errors (xml, etc), and self-closing tags breaking validation after being modified. Also used a static instead of a global var to store duplicate events. (QueryString.php)
* helpFrame was no longer working due to variable name optimizations. Renamed it to helf and optimized related code. BTW this Help template is ridiculously short now, as well as a couple other templates... Maybe we should integrate them into another file... (Help.template.php, Register.template.php, script.js)
* As inline events no longer require to have entities instead of <, >, & etc, converted all of the existing events to use clean code. (Groups.php, TEMPLATES: ManageBans, ManageMaintenance, ManageMembergroups, ManageSearch, MessageIndex, ModerationCenter, Packages, Search)
* Turned <div class="smalltext"> descriptions in admin zones, to use <dfn> (definition term), which validates when inside <dt> tags. (index.css, ManageBans.template.php, up to 214 more changes to come...)
* Minor details. (Errors.english.php, Errors.french.php, ManageMaintenance.french.php, Profile.template.php)

It's not yet out... But I've written the changelog already, so here it is :P
Obviously it would be out already if it didn't collide with the latest revs, ah ah... I can feel the fun already.
:edit: Not a single collision, actually. :wow:
:edit: :edit: Done!
Re: New revs
« Reply #413, on December 4th, 2010, 01:56 PM »
rev 341

* 172 more <div class="smalltext"> replacements to <dfn>. Should be done now... (ManageSettings.php, index.css, TEMPLATES: ManageBoards, ManageMembergroups, ManageNews, ManagePaid, ManageScheduledTasks, ManageSearch, ManageSmileys, ModerationCenter, Packages, PersonalMessage, Profile, Register, SendTopic, Themes, LANGUAGES: Admin, ManageSettings, Search)
* Spacinazi and valinazi (small issues that broke validation :P). (Errors.template.php, Profile.template.php, Themes.template.php)
Posted: December 4th, 2010, 01:28 PM

rev 342

* Some optimizations in parse_bbc(). Not all, though. Yeah, I know, I could have used === instead of ==... Stop bothering me now, will you? (Subs.php)
Re: New revs
« Reply #414, on December 4th, 2010, 04:17 PM »
rev 343

* Mass renaming 'westring' class to 'westr'. (About 60 files.)
Posted: December 4th, 2010, 04:17 PM

rev 344

- Oops! Test code. (index.template.php)
Re: New revs
« Reply #415, on December 4th, 2010, 07:30 PM »
rev 345

* More jQuery fun. (script.js, suggest.js, topic.js)
! Fixed addLoadEvent no longer accepting strings as parameter, e.g. auto-suggest init. (script.js)
Re: New revs
« Reply #416, on December 5th, 2010, 12:31 AM »
rev 346

* Turned Ajax functions into jQuery $.ajax() calls. Seems to work on everything I tested (auto-suggest, topic pages.) (script.js, suggest.js)

This is a 'big' part even though it doesn't show. Maybe we don't want to do this conversion right now... Still, it can't hurt to at least *try*. It saves nearly an extra kilobyte off the script file... And a mere 160 bytes from the minified, gzipped file.

Arantor

  • As powerful as possible, as complex as necessary.
  • Posts: 14,278
Re: New revs
« Reply #417, on December 5th, 2010, 04:16 PM »
Revision: 347
Author: arantor
Date: 15:15:57, 05 December 2010
Message:
! Updated to r10296
 - expanded support for size types in size bbc (install.sql)
 - caching board parents information (Load.php)
 - OpenID fix (Subs-OpenID.php)
 - moving action spamming checks earlier in workflow (Login2.php, SendTopic.php)
 - some servers send $_SERVER['HTTPS'] in different ways (ManageServer.php)
 - comment fixes (Errors.php, ManagePosts.php, Subs-Menu.php)
 - make sure cache is cleared when boards are altered (Subs-Boards.php)
 - make sure cache-clearing also invalidates cache in case files weren't removed (Subs.php)
 - minor layout tweak (admin.css)
 - remove signature padding for IE6 and IE7 (ie6.css, ie7.css)
 - language cleanups including a missing error message (Admin, Errors, Help, index, Profile)
 - Fix for additional space in post template (Post.template.php)
 - Formatting change in profile template for requesting a group membership (Profile.template.php)
 - Change of reserved words to use change in admin CSS (additional by me: dropping of name attribute for HTML5) (Register.template.php)
----
Modified : /trunk/Sources/Errors.php
Modified : /trunk/Sources/Load.php
Modified : /trunk/Sources/Login2.php
Modified : /trunk/Sources/ManagePosts.php
Modified : /trunk/Sources/ManageServer.php
Modified : /trunk/Sources/SendTopic.php
Modified : /trunk/Sources/Subs-Boards.php
Modified : /trunk/Sources/Subs-Menu.php
Modified : /trunk/Sources/Subs-OpenID.php
Modified : /trunk/Sources/Subs.php
Modified : /trunk/Themes/default/Post.template.php
Modified : /trunk/Themes/default/Profile.template.php
Modified : /trunk/Themes/default/Register.template.php
Modified : /trunk/Themes/default/css/admin.css
Modified : /trunk/Themes/default/css/ie6.css
Modified : /trunk/Themes/default/css/ie7.css
Modified : /trunk/Themes/default/languages/Admin.english.php
Modified : /trunk/Themes/default/languages/Errors.english.php
Modified : /trunk/Themes/default/languages/Help.english.php
Modified : /trunk/Themes/default/languages/Profile.english.php
Modified : /trunk/Themes/default/languages/index.english.php
Modified : /trunk/other/install.sql



(Changes from RC4 public to r10296)

Nao

  • Dadman with a boy
  • Posts: 16,082
Re: New revs
« Reply #418, on December 5th, 2010, 07:38 PM »
rev 348

! Auto-suggest search could generate errors in the log. (Suggest.php)
* Updated French translation. (Admin, Errors, Help, index, Profile)
Re: New revs
« Reply #419, on December 5th, 2010, 08:31 PM »
rev 349

- Removed support for bbcode tags: glow (out of fashion), shadow (meh), move (epileptic FTW), and acronym (deprecated in HTML5, use abbr instead. Yes I know, I could have just made an alias for that one...) (install.sql, Subs.php, Post.english.php, Post.french.php, Admin.french.php)
- Removed corresponding icons (glow, shadow and move) from the sprite. (Class-Editor.php, bbc/sprite.png)
! Fixed a couple of issues in the bbcode table's default contents. (install.sql)

I couldn't determine whether <acronym> was really deprecated in HTML5[1] (most websites say yes, but the w3schools site, which is run by the w3c IIRC, doesn't mention it), but I figured it wouldn't matter anyway.
We need to (1) make that "things to do in the converter" topic, (2) mention that we should update posts to delete these tags.
Posted: December 5th, 2010, 08:19 PM

rev 350

* <tt> is deprecated in HTML5. Replacing HTML contents for the tag. (install.sql)
 1. :edit: Seems really likely...
Plugin revs »