New revs
Plugin revs »

Nao

  • Dadman with a boy
  • Posts: 16,082
Re: New revs
« Reply #345, on November 18th, 2010, 04:33 PM »
You should do your checks quickly, because I'll probably be moving the theme to HTML5 ASAP, meaning you'll have meaningless code to check in addition to proper code... It's best to first check proper code, and then just skim quickly through the meaningless HTML5 upgrade.

(BTW: XHTML5, right? I'm not interested in changing the /> stuff anyway... I learned to like them.)
Posted: November 18th, 2010, 04:17 PM
Quote from Nao/Gilles on November 18th, 2010, 04:17 PM
skim quickly through
Skim over or scan through... I'm always bad with prepositions.

Arantor

  • As powerful as possible, as complex as necessary.
  • Posts: 14,278
Re: New revs
« Reply #346, on November 18th, 2010, 04:36 PM »
Makes no odds to me, I still look through commit by commit as I always do.

As for X/HTML, I actually have no preference - whatever works is fine with me. Browsers interpret it fairly well these days.
When we unite against a common enemy that attacks our ethos, it nurtures group solidarity. Trolls are sensational, yes, but we keep everyone honest. | Game Memorial

Nao

  • Dadman with a boy
  • Posts: 16,082
Re: New revs
« Reply #347, on November 18th, 2010, 05:11 PM »
rev 263

* Moved storeCaret() from editor.js to PHP, as it's too short to bother waiting for editor.js to finish loading... (Class-Editor.php, editor.js)
* Replaced existing onclick hacks with a new trick that is cleaner but requires moving templates to HTML5. We would have had to do it at one point anyway... (Class-Editor.php, Display.template.php, script.js, index.template.php, Poll.template.php, Post.template.php)
* Spacinazi. (PrettyUrls-Filters.php)
Re: New revs
« Reply #348, on November 18th, 2010, 05:48 PM »
rev 264

* Wedge is now officially using HTML5. (index.template.php)
* Fixed footer indentation. (Class-Editor.php, Display.template.php, index.template.php)
+ Added placeholder function for manipulating external links. @todo: Fix domain name detection, or remove the function. (script.js)
! HTML5 compatibility in Footnotes. (Subs.php)
! Horrible typo. (script.js)

live627

  • Should five per cent appear too small / Be thankful I don't take it all / 'Cause I'm the taxman, yeah I'm the taxman
  • Posts: 1,670
Re: New revs
« Reply #349, on November 18th, 2010, 10:48 PM »
Quote from Nao/Gilles on November 18th, 2010, 02:32 PM
Quote from Nao/Gilles on November 18th, 2010, 07:30 AM
Oh yeah eheh.
Pete! Please send feedback on my code, ideas and implentations! :^^;:
Any reason why you're blatantly ignoring me...?

I could use some of your hindsight, really.
Know that I'm still offering my help  - that is, if you are wanting someone other than Pete to join the fray :)
A confident man keeps quiet.whereas a frightened man keeps talking, hiding his fear.

MultiformeIngegno

  • Posts: 1,337

Arantor

  • As powerful as possible, as complex as necessary.
  • Posts: 14,278
Re: New revs
« Reply #351, on November 19th, 2010, 03:12 AM »
OK, back to business. I've taken too long out working on this paid project, I need time to recover!

So... reviewed all the changes (holy crap, there's been a lot of commits in the last 9 days), nothing huge is jumping out at me, I did fix a change in the code docs though, SMF_HOOK_SETTINGS vs WEDGE_HOOK_SETTINGS. Also, now we're listing JS files and there seems to be changes to the list of included stylesheets if I'm not mistaken (bearing in mind loadTemplate can load stylesheets), we probably should fix up the debug info in ViewQuery.php.

I'm looking at building the new DB class first though.



Revision: 265
Author: arantor
Date: 01:20:29, 19 November 2010
Message:
! Minor doc fix (Load.php)
----
Modified : /trunk/Sources/Load.php

Posted: November 19th, 2010, 02:23 AM

Revision: 266
Author: arantor
Date: 02:11:21, 19 November 2010
Message:
! Remove legacy case-sensitivity parameter from DB processes (Subs-Database.php, LogInOut.php, Subs-Auth.php, Subs-Post.php)
----
Modified : /trunk/Sources/LogInOut.php
Modified : /trunk/Sources/Subs-Auth.php
Modified : /trunk/Sources/Subs-Database.php
Modified : /trunk/Sources/Subs-Post.php

Posted: November 19th, 2010, 03:11 AM

Revision: 267
Author: arantor
Date: 02:12:34, 19 November 2010
Message:
! More legacy parameters not used in the DB subsystem. (Subs-Database.php)
----
Modified : /trunk/Sources/Subs-Database.php

Nao

  • Dadman with a boy
  • Posts: 16,082
Re: New revs
« Reply #352, on November 19th, 2010, 11:21 AM »
Aeva Media rev 12 (<-- since it'll soon be merged with Wedge)

! Adding proper UTF8 handling in htmlspecialchars when editing custom fields, showing RSS feeds, errors and item titles. Also when showing SMG code (is that useful, really?) (Aeva-Admin.php, Aeva-Foxy.php, Aeva-Media.php, Aeva-Subs-Vital.php, Aeva-Subs.php)
- Removed Noisen copyright from auto-embedder code. This is ONLY for AeMe2 and Wedge! (Aeva-Embed.php)
+ Added an extra field to Exif data... Not that it's of any interest. Should really update that Exif library at some point. (Aeva-Exif.php)
* More improvements to visual details. (am.css, am.js)
Re: New revs
« Reply #353, on November 19th, 2010, 04:41 PM »
rev 268

* Remove registered hooks that no longer exist. (e.g. file was deleted after uninstalling an add-on.) Hopefully this is the right thing to do... (Load.php, Subs.php)
* Continuing HTML5 conversion, introducing cellspacing and cellpadding replacement classes. (Subs.php, ViewQuery.php, Calendar.template.php, index.css, GenericList.template.php, Memberlist.template.php, Register.template.php, Reports.template.php, Stats.template.php)
* Moved more JS inline code to the footer. (Post.template.php, Stats.template.php)
* Indenazi. (Calendar.template.php, Post.template.php, Register.template.php, Stats.template.php)
! For an unknown reason, HTML5 doesn't play well with the quick icon selector's padding on hover. (script.js)
Re: New revs
« Reply #354, on November 20th, 2010, 09:25 AM »
rev 269

* Converted two more files. (Calendar.template.php, Post.template.php)
* Started work on PM template -- need to move inline scripts to the footer. (PersonalMessage.template.php)
+ Added workaround for IE6 table borders and HTML5 tags. (ie6.css, index.template.php)
- Started deleting type="text/javascript" references. Thanks HTML5! (Class-Editor.php)
* Replaced context-type meta tag with meta charset. Thanks HTML5! (index.template.php)
! Calendar design was broken. (index.css)
! HTML5 validation no longer allows numeric entities in the C1 range, so turned … into &hellip; (Admin.french.php, ManageMaintenance.french.php, Post.english.php, Post.french.php)
! SMF bug: error message in Post template was shown with two <dt>'s rather than a <dt><dd> pair. (Post.template.php)
! SMF bug: File-type inputs don't accept a size parameter. (Post.template.php)
Re: New revs
« Reply #355, on November 20th, 2010, 09:45 AM »
rev 270

! data-on* trick didn't work on anything else than data-onclick. (script.js)

"Oops! Infinite loop."
Was due to a last minute change in variable names and I didn't change it everywhere... As a result, my thread was running at 100% because I had a tab set on a page with this code running. Uh. Opera is very powerful, but it could be a little helpful and offer me to warn me when a script is in an infinite loop... Even IE does... Because it seriously impaired my work yesterday.
Re: New revs
« Reply #356, on November 20th, 2010, 04:41 PM »
rev 271

* A few more data-on* conversions and JS fixes. (Groups.php, ManageAttachments.php, ManageBans.php, ManageCalendar.php, ManageErrors.php, ManageMail.php, ManageMembergroups.php, ManageMembers.php, ManageSearchEngines.php, ManageServer.php, ManageSmileys.php, Modlog.php, Profile-Modify.php, Subs-Package.php, Subs.php, Calendar.template.php, GenericMenu.template.php, index.template.php, ManageMaintenance.template.php, MessageIndex.template.php)
* The VERY boring, extremely DULL, but totally PRICELESS JavaScriptEscape mega-update. All occurrences of confirm() now sport a proper JSE call that prevents broken scripts. Thank you for that superb bug, SMF, and you can keep the change. (Groups.php, ManageAttachments.php, ManageBans.php, ManageBoards.php, ManageMail.php, ManageMembers.php, ManagePaid.php, ManageSearchEngines.php, ManageSmileys.php, ModerationCenter.php, TEMPLATES: Admin, Calendar, Display, ManageAttachments, ManageBans, ManageBoards, ManageMaintenance, ManageMembergroups, ManageNews, ManageSearch, ManageSmileys, MessageIndex, ModerationCenter, MoveTopic, Packages, PersonalMessage, Post, Profile, Recent, Search, Themes, LANGUAGES: Admin, index, ManageBoards, ManageMail, ManageMaintenance, ManageMembers, ManagePaid, ManageSettings, ManageSmileys, ModerationCenter, Packages, PersonalMessage, Search, Themes)
* Commenazi. (Subscriptions-PayPal.php)
Re: New revs
« Reply #357, on November 20th, 2010, 05:12 PM »
rev 272

! Fixed PIE bug that prevented it from being called from the header. (PIE.htc)
- Deleted two unused language strings. Unless I'm wrong?! (ManagePermissions.english.php, ManagePermissions.french.php)
* French version was using a misleading translation for "template" in the Themes file. (Themes.french.php)
* Some extra fixes to the JavaScriptEscape mega-update. (I'm not gonna list all of the files again!)

I think I'm done for JSE... Finished with alert() and confirm(), at least.
There are plenty more occurrences of the "use/don't use entities" comment in language files, that we REALLY need to look into. Either they're already gone (i.e. entry was deleted from Curve, but not from the language files), or they're for e-mails (in which case we can't do much except make an EmailEscape function), or they shouldn't be here.

MultiformeIngegno

  • Posts: 1,337
Re: New revs
« Reply #358, on November 20th, 2010, 05:37 PM »
Wow! Awesome work!

Nao

  • Dadman with a boy
  • Posts: 16,082
Re: New revs
« Reply #359, on November 21st, 2010, 12:42 AM »
Thanks :)
I'm not finished, unfortunately... I just took a break after I finished the JSE portions (I'm also trying not to overwhelm Pete with code to verify...)
I still have to finish the data-* implementation, *and* convert all templates... Most notably drop all of the old params (align, valign, cellspacing, cellpadding, type...), and... I don't remember the rest, I'm too tired. Good night!

rev 273

! Implemented a quick hack to fix menus not working in IE6 since rev 260. I have no idea why this fixes it, but it does, so let's shoot first and ask questions later. (index.template.php)
* Indenazi. (BoardIndex.php)
Posted: November 21st, 2010, 12:24 AM

rev 274

- Dropped XHTML5 specification for now, because it needs to be served with an unrealistic MIME type. Just plain HTML5 is fine enough. @todo: determine whether existing application/xhtml+xml support should be removed, and remove support for strict doctypes as well, since HTML5 only has one doctype anyway. (index.template.php)
* Changed XHTML to HTML5 in the footer. (index.template.php, index.english.php, index.french.php)
Plugin revs »