New revs
Plugin revs »

Nao

  • Dadman with a boy
  • Posts: 16,082
Re: New revs
« Reply #330, on November 15th, 2010, 11:20 AM »
rev 258

* Moved CSS cache folder to the theme folder's root. (Subs.php)
* Replaced Wedge logo with a simpler one. (wedgelogo.png)
+ Added a help description for the styling selector. (ManageBoards language files)
* Spacinazi is adding a useless space, for once. It's just to make large hierarchies readable in Opera... (ManageBoards.template.php)
Re: New revs
« Reply #331, on November 15th, 2010, 03:16 PM »
rev 259

+ Added hooks for copyright management ('place_credit'), and Pretty URL manipulation ('determine_location'). (Credits.php, QueryString.php)
- Removed the "orignal" txt strng, as it was emty in the fist plce. (Who.englsh.php, Who.frnch.pp)
Re: New revs
« Reply #332, on November 16th, 2010, 11:30 PM »
rev 260

+ Added support for compressed JS files, just like CSS files but with different syntax. (.htaccess, Load.php, ManageServer.php, Help language, ManageSettings language)
* Moved all Display and Editor javascript to the footer, including some inline code that was in the header. (Class-Editor.php, Display.template.php)
+ Added wedge_add_css and wedge_add_js functions to make life easier. (Load.php, Subs.php)
+ Added a short copyright notice in the HTML source code, to have a signature left when people will remove the onscreen credits. (index.template.php)
! Fixed mixup between default theme and current theme when looking for CSS folders. (Subs.php)
! Started adding missing semicolons that would make the JS minifier fail. (editor.js, script.js)
@ JS minifier is a work in progress. Can't account for all lazy Javascript coders putting some strange code in... (Subs.php)

live627

  • Should five per cent appear too small / Be thankful I don't take it all / 'Cause I'm the taxman, yeah I'm the taxman
  • Posts: 1,670
Re: New revs
« Reply #333, on November 16th, 2010, 11:50 PM »
I always wondered why some JS lacked a semicolon appended to the line.. It certainly works to go the PHP way and use a semicolon EVERYWHERE (and easier too!)
A confident man keeps quiet.whereas a frightened man keeps talking, hiding his fear.

Nao

  • Dadman with a boy
  • Posts: 16,082
Re: New revs
« Reply #334, on November 17th, 2010, 11:48 AM »
Absolutely.
I'm tempted to add them everywhere (in prototype definitions) and then force users to use them as well, by failing to compile their JS if they don't.
Re: New revs
« Reply #335, on November 17th, 2010, 07:23 PM »
Okay, I'm committing, hopefully you can look into my code changes and my remarks in the changelog....

rev 261

! Trying to add support for .jgz and .cgz for Safari, but even if just using uncompressed .css, it doesn't seem to work on Safari 5.0.2... Needs some further research! (.htaccess, Subs.php)
* Moved the rest of the common Javascript to the bottom of the page. IE6 pawa. (index.template.php)
+ Started replacing onclick events with a neat trick I devised, to prevent UI clicks before the scripts are actually loaded. (Okay, I'm proud of myself, so what. Go away. I'm the only reading these changelogs anyway.) (Display.template.php, script.js)
! SMF bug: <span id="top_subject"> was missing, causing quick edit to fail on first topic posts. They don't want me as beta tester so I'll just let them find out by themselves. Ah ah. (Display.template.php)
* The user menu didn't return specific values, so return false anyway, so save a few bytes in the Display template. (topic.js, Display.template.php)
! User menu failed when clicking a guest account. (topic.js)
! Syntax error. (RemoveTopic.php)
! Whatever you put into onclick, it's *already* in Javascript... No need to specify it is! (Post.template.php, Display.template.php)
* Spacinazi on addPollOption. Why is that function duplicated anyway?! Should be changed... (Poll.template.php, Post.template.php)
Re: New revs
« Reply #336, on November 17th, 2010, 09:58 PM »
rev 262

! It would be a shame to break w3c validation just for this... Changed the lang trick to use comments instead. So, basically, move your onclick code, unmodified, to a comment immediately after the target element, and add a clickme class to that element. (Display.template.php, index.template.php, script.js)
- Removed a few nbsp's from Javascript confirm boxes. (index.french.php)
+ Finished French translation of the new Security language file. Hopefully... (Security.french.php)

Tested the comments trick successfully on Opera 9.62 (I figured it'd be more representative than v10.6x), Safari 5.0.2 (which BTW now seems to accept my CGZ files... Don't ask me), and IE8. It should be a tad slower than the lang version, but only because it retrieves firstChild and then possibly nextSibling.

live627

  • Should five per cent appear too small / Be thankful I don't take it all / 'Cause I'm the taxman, yeah I'm the taxman
  • Posts: 1,670
Re: New revs
« Reply #337, on November 17th, 2010, 11:28 PM »
Quote from Nao/Gilles on November 17th, 2010, 07:23 PM
! SMF bug: <span id="top_subject"> was missing, causing quick edit to fail on first topic posts. They don't want me as beta tester so I'll just let them find out by themselves. Ah ah. (Display.template.php)
grep -nHIi -- top_subject (in directory: /var/www/smf_dev/Themes/default)
Help.template.php:663:               <span id="top_subject">', $txt['manual_topic_heading'], '</span>
Search completed with 1 match.

Need I say more? :P

Nao

  • Dadman with a boy
  • Posts: 16,082
Re: New revs
« Reply #338, on November 18th, 2010, 12:08 AM »
Yes you do...

It stayed in the Help template, yes (the one which we removed from Wedge), but it's only an example page, it's not the proper Display page.
Just compare RC3 to RC4's Display template. The top_subject went away ;)
They can remove it if they want... But then they should remove any code that manipulates it!

live627

  • Should five per cent appear too small / Be thankful I don't take it all / 'Cause I'm the taxman, yeah I'm the taxman
  • Posts: 1,670
Re: New revs
« Reply #339, on November 18th, 2010, 01:06 AM »
So in other words they removed code but not completely... heh, so typical of them. <PRV>

Nao

  • Dadman with a boy
  • Posts: 16,082
Re: New revs
« Reply #340, on November 18th, 2010, 07:30 AM »
Oh yeah eheh.
Pete! Please send feedback on my code, ideas and implentations! :^^;:
Re: New revs
« Reply #341, on November 18th, 2010, 02:32 PM »
Quote from Nao/Gilles on November 18th, 2010, 07:30 AM
Oh yeah eheh.
Pete! Please send feedback on my code, ideas and implentations! :^^;:
Any reason why you're blatantly ignoring me...?

I could use some of your hindsight, really.

Arantor

  • As powerful as possible, as complex as necessary.
  • Posts: 14,278
Re: New revs
« Reply #342, on November 18th, 2010, 02:59 PM »
I'm not ignoring you - I really just haven't had time to keep up with everything :(
When we unite against a common enemy that attacks our ethos, it nurtures group solidarity. Trolls are sensational, yes, but we keep everyone honest. | Game Memorial

Nao

  • Dadman with a boy
  • Posts: 16,082
Re: New revs
« Reply #343, on November 18th, 2010, 03:26 PM »
Sorry, bit tired here. Already 24 hours spent on making sure I can move all JS code to the bottom...
I said that because you've been here a lot today, and you didn't answer my questions... :P

Arantor

  • As powerful as possible, as complex as necessary.
  • Posts: 14,278
Re: New revs
« Reply #344, on November 18th, 2010, 03:28 PM »
Wouldn't call it 'a lot' - I'm still reading everything, but it's hard to get everything straight. First thing I'll be doing when I get back from town will be reading through the last few commits, and then back through the discussions on the JS stuff.
Plugin revs »