New revs
Plugin revs »

Nao

  • Dadman with a boy
  • Posts: 16,082
Re: New revs
« Reply #315, on November 9th, 2010, 07:39 PM »
Gotta go, no time to check my commit thoroughly... Please have a quick look!

rev 247
* Generate non-gzipped cached files for user agents that don't support gzipping. (Subs.php)
- I'm a big fan of Grandia and Terranigma myself, and it hurts to delete that Easter egg, but I'd rather not waste cycles in a regularly called function, thank you. (Spellcheck.php)

Arantor

  • As powerful as possible, as complex as necessary.
  • Posts: 14,278
Re: New revs
« Reply #316, on November 9th, 2010, 10:33 PM »
Revision: 248
Author: arantor
Date: 21:32:53, 09 November 2010
Message:
- Remove getLastPost() which does not seem to be have been called anywhere in the source (even in RC3 or RC4) (Recent.php)
----
Modified : /trunk/Sources/Recent.php
When we unite against a common enemy that attacks our ethos, it nurtures group solidarity. Trolls are sensational, yes, but we keep everyone honest. | Game Memorial

Nao

  • Dadman with a boy
  • Posts: 16,082
Re: New revs
« Reply #317, on November 9th, 2010, 11:42 PM »
Actually, getLastPost() was already in the code as of SMF 1.0 beta 4 (!), and never used, even at the time.
My *guess*, is that it was written for modder convenience.
But honestly -- that kind of undocumented helper function isn't gonna help anyone. Because anyone with half a brain would write the function themselves instead of spending an hour trying to find an hypothetical function that does what they want.

Arantor

  • As powerful as possible, as complex as necessary.
  • Posts: 14,278
Re: New revs
« Reply #318, on November 10th, 2010, 02:11 AM »
:o That's what I call a WTF then.
Posted: November 9th, 2010, 11:48 PM

Revision: 249
Author: arantor
Date: 00:20:10, 10 November 2010
Message:
! More of the reshuffle, splitting Recent.php up... including breaking the one function into two files for unread/unreadreplies, I don't think I broke anything with it though it definitely could be harmonised by finding common code and making a Subs-Unread.php file (index.php, Recent.php, Unread.php, Unreadreplies.php)
----
Modified : /trunk/Sources/Recent.php
Added : /trunk/Sources/Unread.php
Added : /trunk/Sources/Unreadreplies.php
Modified : /trunk/index.php

Posted: November 10th, 2010, 01:20 AM

Revision: 250
Author: arantor
Date: 01:04:17, 10 November 2010
Message:
! Harmonsied some function names with filenames/actions: Download became Dlattach, Admin.php's AdminMain became Admin (Dlattach.php, Admin.php, index.php)
! More of the cleanup (Post.php, JSModify.php, index.php)
+ Some actions now identify they should not be logged through defining WEDGE_NO_LOG (index.php, Dlattach.php, SMStats.php, VerificationCode.php, ViewQuery.php, ViewSMFile.php)
----
Modified : /trunk/Sources/Admin.php
Added : /trunk/Sources/Dlattach.php (Copy from path: /trunk/Sources/Download.php, Revision, 247)
Deleted : /trunk/Sources/Download.php
Added : /trunk/Sources/JSModify.php
Modified : /trunk/Sources/Post.php
Modified : /trunk/Sources/SMStats.php
Modified : /trunk/Sources/VerificationCode.php
Modified : /trunk/Sources/ViewQuery.php
Modified : /trunk/Sources/ViewSMFile.php
Modified : /trunk/index.php

Nao

  • Dadman with a boy
  • Posts: 16,082
Re: New revs
« Reply #319, on November 10th, 2010, 08:11 AM »
Yeah, a WTF indeed...
Thanks for finding that kind of WTF, btw. I'm lagging in terms of codebase knowledge, and because you're moving everything around, it's not going to be better soon eheh.

Arantor

  • As powerful as possible, as complex as necessary.
  • Posts: 14,278
Re: New revs
« Reply #320, on November 10th, 2010, 12:32 PM »
That's one of the benefits of going through and breaking the files up, you get to find where the function dependencies are.

Nao

  • Dadman with a boy
  • Posts: 16,082
Re: New revs
« Reply #321, on November 10th, 2010, 03:06 PM »
Sure is!
Re: New revs
« Reply #322, on November 10th, 2010, 04:01 PM »
Was unrelated until now, but since this will probably all find its way into Wedge... Here's the Aeva Media latest rev changelog, eheh :)

rev 11

+ Added transparency flag to pictures, and functions to determine transparency. (db_aeva.php, Aeva-Gallery.php, Aeva-Gallery2.php, Aeva-Subs.php, Aeva.template.php)
* Changed album page layout to show only thumbnails and titles, and hide the rest, which will instead appear in a popup when you hover over the thumbnail or title. (Aeva-Subs.php, am.css)
* Instead of just kilobytes, show filesize in bytes, kilobytes or megabytes in item pages. (Aeva-Gallery.php, Aeva.template.php)
+ Added a function to hide/show popups in IE6. (Aeva-Subs.php, am.js)
! Fixed error when deleting a comment. (Aeva-Gallery.php)
! Fixed animated GIFs shown at incorrect sizes when using ImageMagick. (Aeva-Media.php)
Re: New revs
« Reply #323, on November 10th, 2010, 08:25 PM »
rev 251

! $modSettings['pretty_enable'] didn't actually exist, so it screwed up a lot of Pretty URLs code... (ManageBoards.php, QueryString.php, ManageBoards.template.php)
! Fixed some styling. (ManageServer.php, ManageSettings.php, index.css)
! Foolishly trying to make all browsers like each other when showing popups. Sob. (script.js)
+ Added placeholder about a "Wedge license"... Need to setup an URL and actually put something there. (script.js)
Re: New revs
« Reply #324, on November 12th, 2010, 05:40 PM »
rev 252

! In case guests can post to topics, make sure they return to the topic after they posted. (install.sql)
* Renaming hook-related functions and variables. Integration functions become call/add/remove_hook for simplicity reasons. Hooks are renamed from $modSettings['integrate_something'] to $modSettings['hooks']['something'], and are now proper arrays. Finally, SMF_INTEGRATION_SETTINGS is renamed to WEDGE_HOOK_SETTINGS. So what? (index.php, Activate.php, Admin.php, Class-Editor.php, Errors.php, Load.php, LogInOut.php, ManageMembers.php, Profile-Actions.php, Profile-Modify.php, Profile.php, Register.php, Reminder.php, Security.php, Subs-Auth.php, Subs-Members.php, Subs-Post.php, Subs.php, Who.php, Display and MessageIndex templates)
* Made sure that the error message can be tampered with by the output_error hook. Otherwise, it's relatively useless. (Errors.php)
* Given that the outgoing_email hook has permission to tamper with e-mail data, personal_message and create_topic hooks should be able to play around with their data, too. Same with $data in the change_member_data hook in updateMemberData. (Subs.php, Subs-Post.php)

Arantor

  • As powerful as possible, as complex as necessary.
  • Posts: 14,278
Re: New revs
« Reply #325, on November 12th, 2010, 05:46 PM »
Regarding the last change, I haven't looked yet, but I seem to recall that outgoing_email occurs before the email is sent, but the PM and create topic hooks happen after the PM is sent/topic is created...?

* Arantor will review in a minute, just trying to dry off after going out in the rain to get fixings for dinner...

Nao

  • Dadman with a boy
  • Posts: 16,082
Re: New revs
« Reply #326, on November 12th, 2010, 05:55 PM »
Hmm yeah I didn't notice that but if you're saying so it's probably right!
I made a mistake anyway when I complained about reset_pass, I think that it's never passed as a ref...
Re: New revs
« Reply #327, on November 13th, 2010, 04:42 PM »
rev 253

* Renaming Wedge 1.0 Alpha to SMF 2.0 RC4 (Wedge 0.1), for as long as the BSD licensing is not official. (index.php)
! Clearly separated temporary from permanent hooks. (Load.php, Subs.php)
* The reqWin function will now open an iframe instead of a popup window. It's less aggressive and it's cooler. Also, it now properly positions it. (Help.template.php, script.js)

PS: reqWin was tested under Opera, not other browsers though... It may not work elsewhere. I'm quite happy with the current results, although we may want to go Ajax on this, so that we can add cool animations and show/hide on hover...
Re: New revs
« Reply #328, on November 14th, 2010, 08:54 PM »
rev 254

* Renamed "Wedge Default theme" to just "Wedge"... If we call our main theme "Wedge", people will understand that it's the default theme, right? Right? (Install.english.php, Install.french.php)
! Fixed a XML bug reported by live627. Thanks! (Subs.php)
* Reworked the theme/styling selector to better emphasize the overall hierarchy. (ManageBoards.template.php, admin.css)
Re: New revs
« Reply #329, on November 14th, 2010, 10:40 PM »
rev 255

* Renamed "package" to "add-on", "package-info" to "addon-info", "paquet" (French) to "extension", "modification" to "code add-on", etc. (tools/package/modifications/*, PackageGet.php, Packages.php, Subs-Package.php, language files in English and French: Admin, Errors, Help, index, Install, ManagePermissions, ManageSettings, Packages, Who)

Just to be clear... I only renamed these where the user has interaction with them. Internally, I didn't rename anything, because there are 2500+ occurrences of "package", and it's not ALWAYS related to actual add-ons...
If you want to do it, Pete, feel free, but our efforts should be focus on more important things.
Still, I'd like to see /Packages/ renamed to /Addons/. Would be nice.
BTW, I used "Extension" for French. It looks cool.
Posted: November 14th, 2010, 09:48 PM

rev 256

* A few more renames I forgot. (Admin.*.php, Help.*.php, ManageSettings.english.php, Packages.*.php, Who.french.php)

(I just hope I didn't rename anything that shouldn't have been.)
Posted: November 14th, 2010, 09:57 PM

rev 257

* Found better entities for representing theme hierarchy. I was dying to commit that. (ManageBoards.template.php)
Plugin revs »