New revs
Plugin revs »

Nao

  • Dadman with a boy
  • Posts: 16,082
Re: New revs
« Reply #300, on November 5th, 2010, 09:14 AM »
rev 239

@ The big "theme stylings" initial commit!
@ todo: remove support CSS variants to avoid confusion? Make sure caching is solid (has flush option, fixes folder rights, etc.) Maybe separate theme entries from styling entries with Javascript in ManageBoards. Allow choosing a styling for non-board pages, too! (via $modSettings)
+ Added support for stylings and added two sample stylings. (install.sql, Class-Editor.php, Load.php, ManageBoards.php, Subs.php, Subs-Boards.php, css/index.css, index.template.php, ManageBoards.template.php, css/cache, css/Green/*, css/Nix/*)
+ Added support for gzipped CSS files. (.htaccess)
+ Store current user agent in $context['browser']['agent'] for later use. (Load.php)
* More SMF svn fixes. This will be my last batch, since SMF no longer want us to be able to stick to their codebase. (Class-Editor.php, Load.php)
! Fixed undefined error. (ManageAttachments.php)
! Pretty URLs really need some fixin'... (QueryString.php, Subs-Boards.php)
* Merged mergeposts.gif button into quickbuttons.png sprite file. (css/index.css)
* Spacinazi. (Load.php, Subs.php, Themes.php)

PS: forgot to mention Subs.php being modified by the styling feature in the svn changelog. Adding it here...

Arantor

  • As powerful as possible, as complex as necessary.
  • Posts: 14,278
Re: New revs
« Reply #301, on November 5th, 2010, 09:57 AM »
Some kind of separation is needed since the idea is to detect which file to run by looking for a file with the same name as the action, and I don't really want to have to give it rules like not firing on Load/QueryString/Manage*/Subs-*/etc
When we unite against a common enemy that attacks our ethos, it nurtures group solidarity. Trolls are sensational, yes, but we keep everyone honest. | Game Memorial

Nao

  • Dadman with a boy
  • Posts: 16,082
Re: New revs
« Reply #302, on November 5th, 2010, 12:17 PM »
The more we do to fix sMF, the more we realize we have to do if we are to follow our instincts. <sigh>

Arantor

  • As powerful as possible, as complex as necessary.
  • Posts: 14,278
Re: New revs
« Reply #303, on November 5th, 2010, 12:20 PM »
Of course, the corollary: the more we follow our instincts, the further we get from SMF's lock-down mentality.

Nao

  • Dadman with a boy
  • Posts: 16,082
Re: New revs
« Reply #304, on November 5th, 2010, 06:43 PM »
rev 240
! A misplaced "}" broke board identification if Pretty URLs were disabled. (QueryString.php)
! Couldn't disable Pretty URLs once enabled. (ManageSettings.php, Admin.template.php)
Re: New revs
« Reply #305, on November 5th, 2010, 07:14 PM »
rev 241
! Don't show the Pretty URLs area if you're editing a board with Pretty URLs disabled... (ManageBoards.php, ManageBoards.template.php)
! Could possibly keep using Pretty URLs even if it was disabled in the admin. (QueryString.php)

PS: leave rev 242 to me, it's one of my lucky numbers :P

Arantor

  • As powerful as possible, as complex as necessary.
  • Posts: 14,278
Re: New revs
« Reply #306, on November 5th, 2010, 09:27 PM »
Go for rev 242 :) I haven't started the changes yet due to other stuff going on.

Nao

  • Dadman with a boy
  • Posts: 16,082
Re: New revs
« Reply #307, on November 5th, 2010, 09:34 PM »
It's a scam!

rev 242
* Replaced » with a graphic arrow in the linktree. It sucks and may not work outside of Opera, but I wanted to have rev 242. Mwahaha. Okay, I'll take my pills. (index.css, index.template.php)
+ Placeholder for theme styling in themes table. (install.sql)

Seriously, this 242 isn't linked to 42 or anything... It's just that it was the length in kilobytes of the scrolltext I wrote for a music compilation back in 1990... It was the world record and I think it never was broken. Unfortunately that screen never found itself featured in a demo disk AFAIK... But I got to show it off in a few coding parties, including the legendary STNICCC. Ah ah, good times. Too bad I've lost said demo!

Also up to post #1500 at the same time, eh eh.

Arantor

  • As powerful as possible, as complex as necessary.
  • Posts: 14,278
Re: New revs
« Reply #308, on November 6th, 2010, 01:25 AM »
Chrome no like the gzipped CSS file :( Just comes up without any styles at all (though ?board=1 works now, haha)
Posted: November 6th, 2010, 12:02 AM

Revision: 243
Author: arantor
Date: 00:12:33, 06 November 2010
Message:
! First batch of conversions of splitting some actions into their own files (index.php, Admin.php, MessageIndex.php, Post.php, Register.php, SplitTopics.php, Who.php, Activate.php, CoppaForm.php, Credits.php, QuickMod.php, QuoteFast.php)
----
Added : /trunk/Sources/Activate.php
Modified : /trunk/Sources/Admin.php
Added : /trunk/Sources/CoppaForm.php
Added : /trunk/Sources/Credits.php
Modified : /trunk/Sources/MessageIndex.php
Modified : /trunk/Sources/Post.php
Added : /trunk/Sources/QuickMod.php
Added : /trunk/Sources/QuoteFast.php
Modified : /trunk/Sources/Register.php
Modified : /trunk/Sources/SplitTopics.php
Modified : /trunk/Sources/Who.php
Modified : /trunk/index.php

Nao

  • Dadman with a boy
  • Posts: 16,082
Re: New revs
« Reply #309, on November 6th, 2010, 07:25 AM »Last edited on November 6th, 2010, 07:33 AM by Nao/Gilles
Quote from Arantor on November 6th, 2010, 01:25 AM
Chrome no like the gzipped CSS file :(
It should... I tested it in Chrome (stable), too. Are you sure you enabled the .htaccess file? It has an updated rule.
In any case, I'll add a setting to the db to enable it or not -- and it'll be disabled by default, just like PHP gzipping. I just postponed it because it requires adding an $helptxt or something, and I hate writing docs. (Because I have to do it twice... Once in French, once in English.)
Quote
! First batch of conversions of splitting some actions into their own files (index.php, Admin.php, MessageIndex.php, Post.php, Register.php, SplitTopics.php, Who.php, Activate.php, CoppaForm.php, Credits.php, QuickMod.php, QuoteFast.php)
Oh oh! I'll have a look!

Arantor

  • As powerful as possible, as complex as necessary.
  • Posts: 14,278
Re: New revs
« Reply #310, on November 6th, 2010, 08:26 PM »
In Chrome beta it just ignored it. I did see the .htaccess file (and it should be being copied with the installation) but I'll double check.

The first batch is simply moving some functions around and making some files - there's little in the way of dependencies there, unlike so many other things :(

Nao

  • Dadman with a boy
  • Posts: 16,082
Re: New revs
« Reply #311, on November 7th, 2010, 05:42 PM »
rev 244

* Changed default DB table prefix to wedge_, to make sure Wedge can be installed next to a vanilla SMF install. (install.php)
! php_value/php_flag aren't supported in CGI PHP. (.htaccess)
* Minor details. (index.css, Admin.french.php)

Arantor

  • As powerful as possible, as complex as necessary.
  • Posts: 14,278
Re: New revs
« Reply #312, on November 9th, 2010, 06:10 PM »
Revision: 245
Author: arantor
Date: 16:59:29, 09 November 2010
Message:
! More of the function/action rearranging (Admin.php, Post.php, Post2.php, Printpage.php, Register.php, SMStats.php, Spellcheck.php, Stats.php, Subs-Editor.php, Subs-Post.php, Subs-Sound.php, Suggest.php, VerificationCode.php, ViewSMFile.php)
----
Modified : /trunk/Sources/Admin.php
Modified : /trunk/Sources/Post.php
Added : /trunk/Sources/Post2.php
Modified : /trunk/Sources/Printpage.php
Modified : /trunk/Sources/Register.php
Added : /trunk/Sources/SMStats.php
Added : /trunk/Sources/Spellcheck.php
Modified : /trunk/Sources/Stats.php
Modified : /trunk/Sources/Subs-Editor.php
Modified : /trunk/Sources/Subs-Post.php
Modified : /trunk/Sources/Subs-Sound.php
Added : /trunk/Sources/Suggest.php
Added : /trunk/Sources/VerificationCode.php
Added : /trunk/Sources/ViewSMFile.php
Modified : /trunk/index.php

(And index.php got modified too, of course. I'm getting closer to where I want to be with this. Not there yet though.)

Nao

  • Dadman with a boy
  • Posts: 16,082
Re: New revs
« Reply #313, on November 9th, 2010, 06:58 PM »
I was wondering... Wasn't the point of these changes, putting the files into a \Sources\Admin folder?
Or do you prefer to have plenty of files in one place, and not have to go through several folders when updating some code?


rev 246

+ Added setting to enable CSS compression. Disabled by default. (ManageServer.php, Subs.php, Help language, ManageSettings language)
* Updated footer copyright to the new URLs, and disabled copyright check because, why bother. (Subs.php, index language)

Arantor

  • As powerful as possible, as complex as necessary.
  • Posts: 14,278
Re: New revs
« Reply #314, on November 9th, 2010, 06:59 PM »
I'm just splitting them up into the relevant actions first, is a bit easier that way to rearrange later.
Plugin revs »