New revs
Plugin revs »

Nao

  • Dadman with a boy
  • Posts: 16,082
Re: New revs
« Reply #285, on October 26th, 2010, 10:09 AM »
rev 233
! Fixed undefined error in merge admin. (ManagePosts.php)
* Optimized index.css for size. "0.5em" becomes ".5em", "padding: 1px 3px 2px 3px" becomes "padding: 1px 3px 2px", things like that... Inspired by a CSS minifier. (index.css)
* Reverted hover color on main menu's top-level entries, to match the admin menu color. Too many different colors can be confusing... (index.css)
* Updated to SMF rev 10246.
  ! Fix for windows check (ManageServer.php)
@ Also in latest SMF revs: RC4 version updates, and smfinfo.php was updated to a new version... It doesn't work very well, though, failing notably at showing the current version, uh. Should probably remove that file from the svn entirely...
Quote from Arantor on October 25th, 2010, 08:03 PM
Haven't seen the code but protected membergroups isn't (if it's what I think it is) as big a feature as it might have been; group 1 was already protected, i.e. can't add a user to it, can't remove it from a user, unless you are in that group yourself.
I don't know, it adds plenty of code and it's slightly obscure... Well, at least on first look.
Sinan asked for beta testers to look into the addition. I'm afraid I can't bother...
Quote
Hang on, didn't we add the censoring being based off admin_forum ages ago? Hell, I know I argued that with K@ weeks ago on the beta board.
I don't know... I couldn't even find the word 'censor' in the diff patch (?!), and the changelog doesn't specify which file was changed... (Good job!)
Quote
Everything else seems reasonably uneventful, but it sounds like WYSIWTF might even launch in RC4 as being only marginally buggy as opposed to thoroughly broken.
clean_cache('data') might be worth mentioning, though...
But maybe we'll add more cache types later. CSS? Hmm...
Re: New revs
« Reply #286, on October 26th, 2010, 12:29 PM »
rev 234
* resize-handle.gif is a horribly wrong version... Seriously, 800+ bytes for that? Also reworked the 'picture' to suggest enlargement. (resize-handle.gif)
* Repositioned sprites so that the empty space is at the bottom right. (bbc/sprite.png)
+ Did I actually forget to commit edit.gif in the smiley list...? Maybe this should be a BBC button instead, though... (edit.gif)
! Fixed wrong resizer bar width on IE browsers. (editor_ie.css)

Arantor

  • As powerful as possible, as complex as necessary.
  • Posts: 14,278
Re: New revs
« Reply #287, on October 26th, 2010, 04:29 PM »
Going back to the censoring, I seem to recall it's in either Admin or ManagePosts, where the permission is changed from moderate_board to admin_board.

For cache cleaning, there's a bunch of different things, primarily data_ and lang_ that get cached but I think there are more in the bowels of the system.
When we unite against a common enemy that attacks our ethos, it nurtures group solidarity. Trolls are sensational, yes, but we keep everyone honest. | Game Memorial

Nao

  • Dadman with a boy
  • Posts: 16,082
Re: New revs
« Reply #288, on October 26th, 2010, 06:10 PM »
Code: [Select]
'posts' => array('ModifyPostSettings', 'admin_forum'),
'bbc' => array('ModifyBBCSettings', 'admin_forum'),
'censor' => array('SetCensor', 'moderate_forum'),
'topics' => array('ModifyTopicSettings', 'admin_forum'),

This has been in both Wedge and SMF for at least the last month... I really don't see any changes in SMF RC4 in that respect!

Arantor

  • As powerful as possible, as complex as necessary.
  • Posts: 14,278
Re: New revs
« Reply #289, on October 26th, 2010, 07:10 PM »
Is that Admin.php or ManagePosts.php?

Nao

  • Dadman with a boy
  • Posts: 16,082
Re: New revs
« Reply #290, on October 26th, 2010, 07:17 PM »
ManagePosts... The code that redirects to the respective tabs at the beginning.

Arantor

  • As powerful as possible, as complex as necessary.
  • Posts: 14,278
Re: New revs
« Reply #291, on October 26th, 2010, 07:25 PM »
Well, there's an entry in the Admin menu, and IIRC there's another entry at the start of ManagePosts, but I can't remember off hand which is actually needed to be changed - if in doubt both should be set to admin_forum.

Nao

  • Dadman with a boy
  • Posts: 16,082
Re: New revs
« Reply #292, on October 26th, 2010, 08:31 PM »Last edited on October 26th, 2010, 08:39 PM by Nao/Gilles
All righty, in Admin.php:

Code: [Select]
'postsettings' => array(
'label' => $txt['manageposts'],
'file' => 'ManagePosts.php',
'function' => 'ManagePostSettings',
'permission' => array('admin_forum'),
'icon' => 'posts.gif',
'subsections' => array(
'posts' => array($txt['manageposts_settings']),
'bbc' => array($txt['manageposts_bbc_settings']),
'censor' => array($txt['admin_censored_words']),
'topics' => array($txt['manageposts_topic_settings']),
'merge' => array($txt['manageposts_merge']),
),
),

So, apparently one needs to have admin_forum to access all of these tabs...
Which means ManagePosts is buggy in that respect.

:edit:

http://dev.simplemachines.org/mantis/view.php?id=4520

Arantor

  • As powerful as possible, as complex as necessary.
  • Posts: 14,278
Re: New revs
« Reply #293, on October 26th, 2010, 09:14 PM »
Wouldn't that imply that ManagePosts doesn't even need to be checking at all? (Or indeed, any of the other files within the admin area)

This isn't a trivial thing to change, because it's either being checked twice and Admin.php holds all the keys to the kingdom (and everywhere else can drop the secondary checks) - or Admin.php simply checks it for the menu and each file is still responsible for its own permissions (much as SMF 1 used to do)

Nao

  • Dadman with a boy
  • Posts: 16,082
Re: New revs
« Reply #294, on October 26th, 2010, 09:36 PM »
Yeah, I was wondering the same... Maybe the report will clear this up.

rev 235
! Fixed htaccess by making sure mod_headers is enabled before we try to rewrite headers. (.htaccess)
! Forgot to apply group_type to membergroups table at install time. (install_2-0.sql)
+ Added support for the following pretty URLs: /topic_id/topic_name/page_number/, /year/month/day/, /cat/category_name/, /tag/tag_name/, and /board_page/ (QueryString.php)
Re: New revs
« Reply #295, on October 26th, 2010, 10:09 PM »
rev 236
* Updated to SMF rev 10247.
  ! A safer handling of the database last error and generally writing Settings.php [Bug 4222]

--> Mainly it moves db_show_error to Errors.php... I updated the docs, hopefully it's okay.
Now db_fatal_error() is 100% an alias. Norv forgot to remove the $sourcedir global, I finished that.
There's a @todo in there. Yeah, the function could be removed, but... mods, maybe?

Arantor

  • As powerful as possible, as complex as necessary.
  • Posts: 14,278
Re: New revs
« Reply #296, on October 26th, 2010, 10:12 PM »
I don't know any mods that modified that (not even mine), since really any errors should be funnelled through fatal_*_error or trigger_error if you're doing something funky. No need to worry about such changes affecting mods :)

Nao

  • Dadman with a boy
  • Posts: 16,082
Re: New revs
« Reply #297, on October 27th, 2010, 12:07 AM »
rev 237
- Deleted db_fatal_error(), as it was no longer used. (index.php, Errors.php, Load.php, Subs-Database.php)

I double-checked, and there was no such "or db_fatal_error()" occurrences in the code, even though that's mentioned in the SMF source files...

Arantor

  • As powerful as possible, as complex as necessary.
  • Posts: 14,278
Re: New revs
« Reply #298, on October 27th, 2010, 12:27 AM »
It may well have been like that once upon a time.

It would be worth forcing the conditions that would otherwise cause it to trigger that error (certain DB connectivity issues) just to prove it doesn't abort inappropriately.

Nao

  • Dadman with a boy
  • Posts: 16,082
Re: New revs
« Reply #299, on November 2nd, 2010, 01:13 PM »
I figured I should commit whatever I have that isn't related to CSS variants... It'll be easier for me in the longer term because I don't know when I'll be ready to commit.

rev 238

* Renamed install and upgrade scripts to drop the version number, as Wedge is 1.0, not 2.0. (install.php, install.sql, upgrade.php, upgrade.sql)
- Removed most of the credits. Technically, these names have nothing to do with our project... (Who.php, Who.template.php)
* Updated to SMF svn 10260. There are still a couple of revs to catch up with...
  ! Last minute: boards incorrectly retrieved (Subs-Boards.php, Load.php) (NB: Load.php not done yet.)
  ! Last minute: an incorrect warning (Profile-Actions.php)
  ! Last minute: adding SMF favicon. (favicon.ico)
  * Validation errors due to a typo in themes list (Themes template) [Bug 4505]
  ! On some versions of Opera the cursor wasn't displayed in WYSIWYG editor (thanks TE) [Bug 4521]
  ! Clean the entire cache on the disk, if any, during scheduled maintenance (ScheduledTasks.php)
  ! Small addition to clean_cache() documentation (Subs.php)
  ! Manage Posts area should only check for admin_forum permission. (ManagePosts.php) [Bug 4520]
  * Undefined index in Subs.php for Core theme (Display template)
Plugin revs »