New revs
Plugin revs »

Arantor

  • As powerful as possible, as complex as necessary.
  • Posts: 14,278
Re: New revs
« Reply #270, on October 17th, 2010, 11:33 PM »
Nah, there was $_POST['ID_ADMIN'] or something similar IIRC in the PersonalMessage files.
When we unite against a common enemy that attacks our ethos, it nurtures group solidarity. Trolls are sensational, yes, but we keep everyone honest. | Game Memorial

Nao

  • Dadman with a boy
  • Posts: 16,082
Re: Editor JS
« Reply #271, on October 18th, 2010, 05:19 PM »Last edited on October 18th, 2010, 07:39 PM by Nao/Gilles
rev 220, 221, 222: http://wedge.org/?msg=249861

rev 223
- Removed validate_unicode__recursive entirely. (QueryString.php, Subs.php)
* Updated to SMF rev 10187. All of the changes are DB related, and most of them were already done in Wedge. (changelog.txt, upgrade.php, DbExtra.php, DbPackages.php, DbSearch.php)
  ! UTF8 fixes. Thank you, Nao! (Subs.php, Subs-Post.php) [Bug 4498]
  ! One more slight change, in supported versions. (install, upgrade, convert scripts)
  ! Now MySQL versions support ENGINE, so simplify some things. (several files)
  ! Escaping potential identifiers used as column names (DbExtra-mysql.php, DbExtra-postgresql.php) [Bug 4261]

Arantor

  • As powerful as possible, as complex as necessary.
  • Posts: 14,278
Re: Editor JS
« Reply #272, on October 18th, 2010, 07:23 PM »
Revision: 224
Author: arantor
Date: 18:21:43, 18 October 2010
Message:
+ Bad Behavior tests now part of the core (sorry for all the language strings, note also that not every BB test is included). Still needs a log viewer to be implemented, though.
----
Modified : /trunk/Sources/QueryString.php
Modified : /trunk/Sources/Security.php
Modified : /trunk/Sources/Subs.php
Modified : /trunk/Themes/default/Errors.template.php
Added : /trunk/Themes/default/languages/Security.english.php
Modified : /trunk/index.php
Modified : /trunk/other/install_2-0.sql


Just to clarify; every intrusion attempt/bad hit is logged with enough details to be able to see what the issue is, and the error specifically encourages the recipient to ask the admin quoting the 'incident number' which is the id in the table. Sorry for the size of the commit but I wanted to get it all in one go.

Nao

  • Dadman with a boy
  • Posts: 16,082
Re: New revs
« Reply #273, on October 18th, 2010, 09:16 PM »
Oh my... An awful lot of code! Must have been painful to implement... Question time on the related topic!

Arantor

  • As powerful as possible, as complex as necessary.
  • Posts: 14,278
Re: New revs
« Reply #274, on October 18th, 2010, 10:06 PM »
It's still smaller than the original WTF-laden code :P
Posted: October 18th, 2010, 09:18 PM

Revision: 225
Author: arantor
Date: 21:05:57, 18 October 2010
Message:
! Fixed version of CIDR compare function. (Subs.php)
----
Modified : /trunk/Sources/Subs.php

Nao

  • Dadman with a boy
  • Posts: 16,082
Re: New revs
« Reply #275, on October 22nd, 2010, 11:06 AM »
rev 226 -- a.k.a. biggest one evah.
(And probably buggiest, too.)

* Updated to SMF rev 10205. Check out the changelog. (changelog.txt, index.php, Admin.php, Class-Editor.php, Load.php, ManagePaid.php, Profile.php, Subs-Boards.php, Subs.php, Who.php, install.css, Display.template.php, ManagePaid.template.php, MessageIndex.template.php, ManagePaid language, Who language, editor.js, script.js)

@ !!! Need to change $user_info['url'] etc. (index.php, Load.php)

@ !!! Added avatar and image caching, but mod_header is required, so leaving it commented out for now. (.htaccess)

+ Added support for merging double posts. Most of the magic happens in SplitTopics. (index.php, Admin.php, Display.php, ManagePosts.php, SplitTopics.php, Subs-Post.php, index.css, Display.template.php, Admin language, Errors language, index language, ManageSettings language, mergeposts.gif)

+ Added support for URL trimming. (ManagePosts.php, Subs.php, Admin language)

+ Added partial Pretty URLs feature. QueryString.php is awfully hardcoded and a WIP. Support for finding topics by name should be deleted or improved. (index.php, .htaccess, install_2-0.sql, readme_*.html, Admin.php, Display.php, Load.php, ManageBoards.php, ManageErrors.php, ManageSettings.php, PrettyUrls-Filters.php, QueryString.php, RemoveTopic.php, SplitTopics.php, Subs-Boards.php, Subs-PrettyUrls.php, Subs.php, SSI.php, Admin.template.php, admin.css, index.template.php, ManageBoards.template.php, Admin language)

- Removed queryless URL feature. (.htaccess, readme_*.html, repair_settings.php, smfinfo.php, ManageSettings.php, News.php, QueryString.php, Subs.php, Help language, ManageSettings language)

- Removed parameters in db_insert_id function. (install.php, Display.php, ManageBans.php, ManagePermissions.php, Poll.php, Post.php, Profile-Actions.php, Profile-Modify.php, RemoveTopic.php, RepairBoards.php, Security.php, SendTopic.php, SplitTopics.php, Subs-Boards.php, Subs-Calendar.php, Subs-Categories.php, Subs-Database.php, Subs-Graphics.php, Subs-Members.php, Subs-Post.php, Subs.php)

+ Added in boards table the preliminary structure for many upcoming features: per-board allowed and banned members, board owners, board type (should probably be called internally "board_type" rather than "wedge_type"), custom style, show title, per-board stats, per-board language. (install_2-0.sql)

+ Added more preliminary support for board owners. (Load.php:571+)

+ Added more preliminary support for per-board allowed and banned members. Need to implement a limit + group_concat, or just disregard multiple contradictory entries in the board_members table and rewrite code at line 714. (Load.php:576+)

+ Added very preliminary support for board privacy. (Load.php:633)

+ Added automatic creation date within the boards table. This could be useful in the future. (install_2-0.sql)

! Some default settings were applied to guests when they should have been applied to members instead. (install_2-0.sql)

* Changed some defaults at install time: week starting day (previously Sunday, now Monday), return to post, save PMs, display quick mod checkboxes, quick reply on and closed by default, view newest PMs first, remove inbox label when applying PM label, and show Today and Yesterday in dates. (install_2-0.sql)

* Increased post box size and board description box size. (Class-Editor.php, ManageBoards.template.php)

@ !!! bareimg placeholder. (Class-Editor.php)

@ !!! placeholders for {query_see_topic} (topic privacy) and a friend subselect override, which may or may not be rewritten later. (Subs-Database.php)

@ !!! placeholder for Ignore Topics. (Admin language)

+ Added support for align parameters in img tags. (Class-Editor.php)

* Don't fix url tags into a more developed version, there's no point in that using more space in the database. (Class-Editor.php)

* Disallow bots from accessing the Post template. Is this a good idea? (Display.php)

* If not on a forum, blog posters can't remove their own topics if not a moderator. Is that logical? I don't know. You tell me. I probably had a good reason for that. (RemoveTopic.php)

* Show bots in green italics in Who's Online. Noisen style. (Who.php)

+ Show board URLs next to topic links in Who's Online. Noisen style, too. (Who.php)

+ Added support for the 'more' BBC tag, which allows blog posts (upcoming feature) to be trimmed in the homepage, and shown in full in the dedicated post page. (Subs.php)

* Moved "Add Poll" button to the Topic Moderation strip, as currently there can only be one poll per topic and it changes their nature. (Display.template.php)

! Accidentally double-clicking a user name in topic pages when using the user menu could select said name. (Display.template.php)

! Unreverted a spacing commit I made for SMF that they reverted because they're bad people. I have your names, I'll tell your moms. (Display.template.php)

- This ":" in the Last Edit area has always annoyed me. (Display.template.php)

- Deleted a few remaining GD warnings from the language files. Please note that there are more GD-related tests that can be safely removed in plenty of places now. (Admin language)

! Fixed various errors in the French version. Also discovered the horror that is the EmailTemplates French translation. Oh, my... I'm nearly tempted to revert it back to English to save French users the agony of going through these emails. (EmailTemplates, Help, Login, Post, Profile)

+ Added French version of the Security language file. About half of it is translated for now... (Security.french.php)

* Spacinazi. (SplitTopics.php, MessageIndex.template.php)
Re: New revs
« Reply #276, on October 22nd, 2010, 08:39 PM »
rev 227

- Removed a couple of GD warning leftovers. (ManageAttachments.php, Register.php)
* Having some fun with subtle fade-in effects in non-IE6/7/8 browsers... (index.css, script.js)

Pete, can you have a look at the menu effect? I tested in Chrome, Opera 11 and IE6/8. Doesn't work in IE but doesn't break anything, either. I like the effect, but I'm a bit concerned that it could make it a bit TOO stylish at this point... You know, the more goodies you add, the less they stand out?

Arantor

  • As powerful as possible, as complex as necessary.
  • Posts: 14,278
Re: New revs
« Reply #277, on October 22nd, 2010, 08:48 PM »
I just ran through clean install - haven't checked any of the changes in either revs 226 or 227 but wanted to look at this quickly for you.

Installer has a much wider right margin than left now for some reason but more importantly:
Quote
Line #1603: You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near '{db_prefix}pretty_urls_cache (
url_id varchar(255) NOT NULL,
replacement v' at line 1
Should be {$db_prefix} in the install script IIRC

:edit: So I fixed that in the installer, and get the following just on the last step (the 'do you want to delete the install files' one)
Quote
Notice: Undefined index: pretty_enable_cache in C:\Dev\public_html\smf_test\wedge\Sources\Subs.php on line 160

Notice: Undefined index: pretty in C:\Dev\public_html\smf_test\wedge\Sources\Subs-PrettyUrls.php on line 218

Notice: Undefined index: db_count in C:\Dev\public_html\smf_test\wedge\Sources\Subs-PrettyUrls.php on line 218

Going back to the original point, the fade-in looks nice, and I think I'm right in saying you moved the menus to left-align under the icon rather than the text? It's subtle and understated - I'd leave it as is personally.

Merging is broken - Admin > Posts > Merging gives:
Quote
Fatal error: Call to undefined function prepareDBSettingContext() in C:\Dev\public_html\smf_test\wedge\Sources\ManagePosts.php on line 421
Need to make sure ManageServer.php is included in the function.

Nao

  • Dadman with a boy
  • Posts: 16,082
Re: New revs
« Reply #278, on October 22nd, 2010, 09:04 PM »
Quote from Arantor on October 22nd, 2010, 08:48 PM
I just ran through clean install - haven't checked any of the changes in either revs 226 or 227 but wanted to look at this quickly for you.
Thanks.
Quote
Installer has a much wider right margin than left now for some reason
That's probably because of the body { width: 90% } that the SMF team added very recently at the top of install.css. I left it as is but suspect it would only bring problems. Okay, I just launched the installer and -- wow -- it looks good with my css, eheh :) I removed width: 90% and replaced it with padding-top: 20px; looks better.
Quote
Should be {$db_prefix} in the install script IIRC
Indeed, sorry about that. Fixed. Whoever commits it first :P
Quote
Notice: Undefined index: pretty_enable_cache in C:\Dev\public_html\smf_test\wedge\Sources\Subs.php on line 160

Notice: Undefined index: pretty in C:\Dev\public_html\smf_test\wedge\Sources\Subs-PrettyUrls.php on line 218

Notice: Undefined index: db_count in C:\Dev\public_html\smf_test\wedge\Sources\Subs-PrettyUrls.php on line 218
Hmm... That probably means this requires initializing PURL first. (In the admin.)
I guess I'll have to do it in the installer, or something...
Quote
Going back to the original point, the fade-in looks nice, and I think I'm right in saying you moved the menus to left-align under the icon rather than the text? It's subtle and understated - I'd leave it as is personally.
Hmm, actually it's been like that since the day I added the icons. I used a padding trick to achieve that effect. It's totally different from the trick in use at wedgeforum.com, because this time I figured out how to do it in CSS rather than with tables :P
Quote
Merging is broken - Admin > Posts > Merging gives:
Quote
Fatal error: Call to undefined function prepareDBSettingContext() in C:\Dev\public_html\smf_test\wedge\Sources\ManagePosts.php on line 421
Hmm yeah I didn't test the admin area, only the actual merging (which is enabled by default apparently...)
Quote
Need to make sure ManageServer.php is included in the function.
Yup. Thanks for the feedback.
Re: New revs
« Reply #279, on October 22nd, 2010, 09:33 PM »
rev 228
! Fixed broken installer. (install_2-0.sql)
! Fixed PrettyURLs warnings. (Subs.php, Subs-PrettyUrls.php)
* Improved installer styling. (install.css)
* catbg class wasn't using the same color as cat_bar. (index.css)
! Fixed double post merging admin area. (ManagePosts.php, Admin languages, ManageSettings languages)

Thanks Pete!
Re: New revs
« Reply #280, on October 23rd, 2010, 10:46 PM »
rev 229
* Put 31 of the BBC button images into a single sprite. Yay! (Class-Editor.php, editor.js, index.css)
+ Added Spoiler tag. (Subs.php, index.css, bbc/sprite.png, index language, Post language)
Re: New revs
« Reply #281, on October 24th, 2010, 01:10 AM »
rev 230
* Improved settings styling in admin area by separating setting titles from setting descriptions. (index.css)
* Spacinazi -- today, we remove all double spaces except from comments. (Plenty of files. Ouch.)
! Javascript error in admin error log when using the French version. Why isn't JavaScriptEscape used everywhere, eh? (Errors.template.php)
Re: New revs
« Reply #282, on October 24th, 2010, 09:50 PM »
rev 231
- Deleted unused "database filename" feature from SQLite leftovers. (install.php, Install files)
* Updated all files to reflect the change to the SMF 2.0 RC4 codebase.
* Spacinazi. (index.template.php)
* Updated to SMF rev 10242. At this point, isn't the data parameter in clean_cache('data') redundant? What else is left to delete, anyway?
  ! Reverting 10207 for Subs.php. Should be included only if it can be properly tested.
  ! Fixed webkit unexpected behavior when setting font styles (thank you Nibogo!) (editor.js) [Bug 4511]
  ! Allow nested [size] tags - we do allow them anyway, just not in all combinations (Subs.php)
  ! censor area should only be available to admins - reported by more, including KinG-InFeT.
  ! Package servers URLs and names properly cleaned for all circumstances - reported by KinG-InFeT.
  & Adapt a language string to the changes in SMF meta keywords. (Help.english.php) [Bug 4515]
  & Notify about PostgreSQL of older and newer versions not supported in the same database. (install language file) [Bug 4214]
  ! Language files are no longer cached. (Load.php, ManageMaintenance.php, ManageServer.php, Subs.php, Themes.php)
  & Remove the note about caching from all language files. (many files)
  ! Load English version of language files as a fallback for missing language strings. (Load.php) [Bug 2743]
  * Added a new group type, protected, for too powerful groups to be managed only by true admins. (Groups.php, ManageMembergroups.php, Profile-Modify.php, Subs-Membergroups.php, ManageMembergroups template, Profile template) [Bug 3528]
  & Added the new group type language string for the change above. (ManageMembers language file) [Bug 3528]
  ! Make sure Administrator group type is set to protected on install and upgrade. (install_2-0_*.sql, upgrade_2-0_*.sql)
  ! Making sure eol-style is on all files on other directory as well. (might have been missed) (/other files)
  ! Making sure eol-style is set on all our converters as well. (/other/converters ASCII files)

Well... Looks like the dev team got to work, eh!
I'm surprised they added such a feature as "protected membergroups"... It demanded a lot of code updates. Hopefully it isn't buggy...
Also, all of the files are updated because RC3 had to be changed to RC4.
Re: New revs
« Reply #283, on October 24th, 2010, 11:52 PM »
rev 232
* Replaced all reqWin(this.href) calls with reqWin(this), to make calls shorter and allow positioning the popup window next to the clicked link. (Plenty of files, script.js)

Arantor

  • As powerful as possible, as complex as necessary.
  • Posts: 14,278
Re: New revs
« Reply #284, on October 25th, 2010, 08:03 PM »
Haven't seen the code but protected membergroups isn't (if it's what I think it is) as big a feature as it might have been; group 1 was already protected, i.e. can't add a user to it, can't remove it from a user, unless you are in that group yourself.

Hang on, didn't we add the censoring being based off admin_forum ages ago? Hell, I know I argued that with K@ weeks ago on the beta board.

Everything else seems reasonably uneventful, but it sounds like WYSIWTF might even launch in RC4 as being only marginally buggy as opposed to thoroughly broken.
Plugin revs »