New revs
Plugin revs »

Arantor

  • As powerful as possible, as complex as necessary.
  • Posts: 14,278
Re: New revs
« Reply #165, on September 27th, 2010, 01:30 AM »
Revision: 155
Author: arantor
Date: 23:00:41, 26 September 2010
Message:
! Fixed up outstanding issue with smiley set (install_2-0.sql, Install.english.php)
- Removed remaining topic icon fluff (I think I got it all)
 - Class determination function (Subs.php)
 - Display in the topic view (Display.php, Display.template.php)
 - Fix for alignment of author/title without icon (index.css)
 - Cleaning up topic class in message index (MessageIndex.php, MessageIndex.template.php)
 - And unread/replies (Recent.php, Recent.template.php)
 - And search (Search.php)
 - And the admin panel (ManagePosts.php)
 - And all language strings (FixLanguage.php, Admin.english.php, Help.english.php, index.english.php)
 - And pruning the images that are no longer used (lots, there's still a couple actually used, but 45 gone bye-bye)
----
Modified : /trunk/Sources/Display.php
Modified : /trunk/Sources/FixLanguage.php
Modified : /trunk/Sources/ManagePosts.php
Modified : /trunk/Sources/MessageIndex.php
Modified : /trunk/Sources/Recent.php
Modified : /trunk/Sources/Search.php
Modified : /trunk/Sources/Subs.php
Modified : /trunk/Themes/default/Display.template.php
Modified : /trunk/Themes/default/MessageIndex.template.php
Modified : /trunk/Themes/default/Recent.template.php
Modified : /trunk/Themes/default/css/index.css
Deleted : /trunk/Themes/default/images/topic/hot_poll.gif
Deleted : /trunk/Themes/default/images/topic/hot_poll_locked.gif
Deleted : /trunk/Themes/default/images/topic/hot_poll_locked_sticky.gif
Deleted : /trunk/Themes/default/images/topic/hot_poll_sticky.gif
Deleted : /trunk/Themes/default/images/topic/hot_post.gif
Deleted : /trunk/Themes/default/images/topic/hot_post_locked.gif
Deleted : /trunk/Themes/default/images/topic/hot_post_locked_sticky.gif
Deleted : /trunk/Themes/default/images/topic/hot_post_sticky.gif
Deleted : /trunk/Themes/default/images/topic/my_hot_poll.gif
Deleted : /trunk/Themes/default/images/topic/my_hot_poll_locked.gif
Deleted : /trunk/Themes/default/images/topic/my_hot_poll_locked_sticky.gif
Deleted : /trunk/Themes/default/images/topic/my_hot_poll_sticky.gif
Deleted : /trunk/Themes/default/images/topic/my_hot_post.gif
Deleted : /trunk/Themes/default/images/topic/my_hot_post_locked.gif
Deleted : /trunk/Themes/default/images/topic/my_hot_post_locked_sticky.gif
Deleted : /trunk/Themes/default/images/topic/my_hot_post_sticky.gif
Deleted : /trunk/Themes/default/images/topic/my_normal_poll.gif
Deleted : /trunk/Themes/default/images/topic/my_normal_poll_locked.gif
Deleted : /trunk/Themes/default/images/topic/my_normal_poll_locked_sticky.gif
Deleted : /trunk/Themes/default/images/topic/my_normal_poll_sticky.gif
Deleted : /trunk/Themes/default/images/topic/my_normal_post_locked.gif
Deleted : /trunk/Themes/default/images/topic/my_normal_post_locked_sticky.gif
Deleted : /trunk/Themes/default/images/topic/my_normal_post_sticky.gif
Deleted : /trunk/Themes/default/images/topic/my_veryhot_poll.gif
Deleted : /trunk/Themes/default/images/topic/my_veryhot_poll_locked.gif
Deleted : /trunk/Themes/default/images/topic/my_veryhot_poll_locked_sticky.gif
Deleted : /trunk/Themes/default/images/topic/my_veryhot_poll_sticky.gif
Deleted : /trunk/Themes/default/images/topic/my_veryhot_post.gif
Deleted : /trunk/Themes/default/images/topic/my_veryhot_post_locked.gif
Deleted : /trunk/Themes/default/images/topic/my_veryhot_post_locked_sticky.gif
Deleted : /trunk/Themes/default/images/topic/my_veryhot_post_sticky.gif
Deleted : /trunk/Themes/default/images/topic/normal_poll_locked_sticky.gif
Deleted : /trunk/Themes/default/images/topic/normal_poll_sticky.gif
Deleted : /trunk/Themes/default/images/topic/normal_post.gif
Deleted : /trunk/Themes/default/images/topic/normal_post_locked.gif
Deleted : /trunk/Themes/default/images/topic/normal_post_locked_sticky.gif
Deleted : /trunk/Themes/default/images/topic/normal_post_sticky.gif
Deleted : /trunk/Themes/default/images/topic/veryhot_poll.gif
Deleted : /trunk/Themes/default/images/topic/veryhot_poll_locked.gif
Deleted : /trunk/Themes/default/images/topic/veryhot_poll_locked_sticky.gif
Deleted : /trunk/Themes/default/images/topic/veryhot_poll_sticky.gif
Deleted : /trunk/Themes/default/images/topic/veryhot_post.gif
Deleted : /trunk/Themes/default/images/topic/veryhot_post_locked.gif
Deleted : /trunk/Themes/default/images/topic/veryhot_post_locked_sticky.gif
Deleted : /trunk/Themes/default/images/topic/veryhot_post_sticky.gif
Modified : /trunk/Themes/default/languages/Admin.english.php
Modified : /trunk/Themes/default/languages/Help.english.php
Modified : /trunk/Themes/default/languages/Install.english.php
Modified : /trunk/Themes/default/languages/index.english.php
Modified : /trunk/other/install_2-0.sql


Yeah, this was an exciting commit ;)
Posted: September 27th, 2010, 12:01 AM

Revision: 156
Author: arantor
Date: 23:06:56, 26 September 2010
Message:
! Converted outstanding .icon1 and .icon2 to .icon (index.css, MessageIndex.template.php, Recent.template.php)
----
Modified : /trunk/Themes/default/MessageIndex.template.php
Modified : /trunk/Themes/default/Recent.template.php
Modified : /trunk/Themes/default/css/index.css

Posted: September 27th, 2010, 12:07 AM

Revision: 157
Author: arantor
Date: 00:27:57, 27 September 2010
Message:
! Misc typo fixes (smfinfo.php, Subs.php)
+ Error counter log (index.php, Errors.php, ManageErrors.php, Subs.php)
----
Modified : /trunk/Sources/Errors.php
Modified : /trunk/Sources/ManageErrors.php
Modified : /trunk/Sources/Subs.php
Modified : /trunk/index.php
Modified : /trunk/other/tools/smfinfo.php


In case it's not clear what's going on (and it is a little convoluted, if I'm honest) - the logic behind it is that if an error occurs during execution, it adds to a counter, then if there were errors during runtime, save that in $modSettings at the end of runtime. It's far lighter to do that than it is to query it (or query then cache it) every page load, and really if we're honest, the idea is to encourage admins to resolve errors sooner rather than later.
When we unite against a common enemy that attacks our ethos, it nurtures group solidarity. Trolls are sensational, yes, but we keep everyone honest. | Game Memorial

Nao

  • Dadman with a boy
  • Posts: 16,082
Re: New revs
« Reply #166, on September 27th, 2010, 09:48 AM »
rev 158
- Deleted remaining hotTopic vars from install script. (install_2-0.sql)
! Fixed padding issues in main menu. (index.css, ie6.css)

Not much, but I'm quite happy with the main menu now. ;)
Re: New revs
« Reply #167, on September 27th, 2010, 11:32 AM »
rev 159
- Deleted some theme compatibility leftovers. Again: Wedge is not compatible with SMF 1.x themes. Use SMF 2.x if you need compatibility. (detailed-version.js, Load.php, Compat.template.php)
- Deleted $settings['separate_sticky_lock'] from index template, as the feature was deleted from Wedge and if it's not supported in the default theme, external themes should deal with it by themselves. (index.template.php)
- Deleted $settings['doctype'], which isn't used in Curve. I don't think it should cause any incompatibilities with future HTML5 themes... (Or use XHTML5, heck.) (index.template.php)
- Deleted leftovers from older themes in language files. (index.english.php)
* Various subtle CSS improvements. (index.css, MessageIndex.template.php, Recent.template.php)
* Spacinazi. (ManageErrors.php, Subs.php, MessageIndex.template.php, Recent.template.php)

(May require a bit of double-checking... I *hope* my logic for separate_sticky_lock is good, because otherwise it means I don't have a damn idea of how themes are supposed to work :P

Arantor

  • As powerful as possible, as complex as necessary.
  • Posts: 14,278
Re: New revs
« Reply #168, on September 27th, 2010, 10:16 PM »
Revision: 160
Author: arantor
Date: 19:30:42, 27 September 2010
Message:
+ If the character before a smiley is a space, don't add another space (tested on IE8, Chrome 6) (editor.js)
----
Modified : /trunk/Themes/default/scripts/editor.js


I'll take a look at revs 158 and 159 shortly, I just wanted to fix that outstanding issue because it was bugging me. Looking at the code in replacetext from whence I borrowed, IE 6 (and 7?) may not support the change, but IE 8 and Chrome do, and since it's labelled in replacetext as 'Mozilla', I'm assuming FF does, though I haven't tested.
Posted: September 27th, 2010, 08:32 PM

Revision: 161
Author: arantor
Date: 20:51:55, 27 September 2010
Message:
+ Code documentation (ManageRegistration.php)
----
Modified : /trunk/Sources/ManageRegistration.php

Posted: September 27th, 2010, 09:52 PM

Revision: 162
Author: arantor
Date: 21:15:53, 27 September 2010
Message:
! Removal of more legacy stuff (template upgrading from YaBBSE/SMF1 templates) (upgrade.php, Themes.php)
----
Modified : /trunk/Sources/Themes.php
Modified : /trunk/other/upgrade.php

Nao

  • Dadman with a boy
  • Posts: 16,082
Re: New revs
« Reply #169, on September 27th, 2010, 10:36 PM »
Quote from Arantor on September 27th, 2010, 10:16 PM
+ If the character before a smiley is a space, don't add another space (tested on IE8, Chrome 6) (editor.js)
I have a feeling of déjà-vu... Is it normal? I wanted to do this at some point... Did I suggest it? Did you? Or did someone on the SMF bug tracker, maybe? Nah, I don't think so, I remember once thinking about this while not in front of my PC... Was dying to try implementing that, but forgot afterwards...
Quote
! Removal of more legacy stuff (template upgrading from YaBBSE/SMF1 templates) (upgrade.php, Themes.php)
Yay! I thought we hardly had anything left to strip at that point...... ;)

Arantor

  • As powerful as possible, as complex as necessary.
  • Posts: 14,278
Re: New revs
« Reply #170, on September 27th, 2010, 10:47 PM »
You suggested it - http://tracker.wedge.org/?sa=ticket;ticket=41

It seems to be incomplete however with IE 8 behaving incorrectly under some circumstances (yay?)
Quote
Yay! I thought we hardly had anything left to strip at that point......
Yeah... mostly it is, I just looked over Themes.php to see what fun there would be to document it, and found those functions. Since they didn't have upper case first letters, they wouldn't be called as action handlers... so went looking ;)

Nao

  • Dadman with a boy
  • Posts: 16,082
Re: New revs
« Reply #171, on September 27th, 2010, 10:52 PM »
Quote from Arantor on September 27th, 2010, 10:47 PM
Phew......!!! I really felt bad about that déjà-vu! :lol:
Quote
It seems to be incomplete however with IE 8 behaving incorrectly under some circumstances (yay?)
IE8 is bitchy with the post editor. Recently Ante committed a fix suggested by whomever I don't remember, which basically replaced the min-width;max-width with a normal width, and added a very high number of cols to the textarea (a hack to make it work.)
Quote
Yeah... mostly it is, I just looked over Themes.php to see what fun there would be to document it, and found those functions. Since they didn't have upper case first letters, they wouldn't be called as action handlers... so went looking ;)
I like it when you do these things.

...

No, it's nothing sexual. For crying out loud.

Arantor

  • As powerful as possible, as complex as necessary.
  • Posts: 14,278
Re: New revs
« Reply #172, on September 27th, 2010, 10:56 PM »
I saw that hack, I'm still not convinced it would actually work entirely as intended either.
Quote
For crying out loud.
Probably not the best line to say to a Meat Loaf fan...


Meat Loaf - For Crying Out Loud

"For crying out loud, you know I love you...."
Re: New revs
« Reply #173, on September 28th, 2010, 03:20 AM »
Revision: 163
Author: arantor
Date: 02:19:54, 28 September 2010
Message:
! Moved IP icon and made it tooltip of image (Display.template.php)
+ Made viewing own/any IP address a permission, and ensured it is managed in all the appropriate places (Display.php, ManageMembers.php, ManageMembers.template.php, ManagePermissions.php, ManagePermissions.english.php, Modlog.php, Profile-View.php, Who.php)
- Removed old help tooltip for admin IP viewing (Help.english.php)
----
Modified : /trunk/Sources/Display.php
Modified : /trunk/Sources/ManageMembers.php
Modified : /trunk/Sources/ManagePermissions.php
Modified : /trunk/Sources/Modlog.php
Modified : /trunk/Sources/Profile-View.php
Modified : /trunk/Sources/Who.php
Modified : /trunk/Themes/default/Display.template.php
Modified : /trunk/Themes/default/ManageMembers.template.php
Modified : /trunk/Themes/default/languages/Help.english.php
Modified : /trunk/Themes/default/languages/ManagePermissions.english.php

Nao

  • Dadman with a boy
  • Posts: 16,082
Re: New revs
« Reply #174, on September 28th, 2010, 09:38 AM »
rev 164
* Replaced apache_request_headers() emulation code with a shorter, faster version. (QueryString.php)
! Fixed validation error. (Search.template.php)

(The validation error is also in SMF2, AFAIK. Also, my fix is technically all right, but logically wrong. I'll rewrite it in the next commit, sorry.)
Posted: September 28th, 2010, 09:15 AM

BTW, nice catch on ManageMembers... Fixing the 'cols' into 'columns'. Another SMF2 stock bug...!
Posted: September 28th, 2010, 09:29 AM

$helptxt['see_member_ip'] should be updated (or deleted) to reflect the changes... Don't you think?
Posted: September 28th, 2010, 09:36 AM

$txt['permissionname_view_ip_address'] = 'View IP addresses in the main forum';
(And a couple other occurrences)

'Main forum' and 'forum' disturb me a bit, because profiles are not part of a 'main forum' per se, and we'll be adding support for blogs, which are definitely not forums.
Maybe 'front-end', 'outside the admin area' or something like that..?
Posted: September 28th, 2010, 09:38 AM

Is the view own IP permission set by default? I don't think it is?

Arantor

  • As powerful as possible, as complex as necessary.
  • Posts: 14,278
Re: New revs
« Reply #175, on September 28th, 2010, 09:41 AM »
Quote
$helptxt['see_member_ip'] should be updated (or deleted) to reflect the changes... Don't you think?
Probably, yes, but I didn't know how to word it, short of having it look up the groups.
Quote
'Main forum' and 'forum' disturb me a bit, because profiles are not part of a 'main forum' per se, and we'll be adding support for blogs, which are definitely not forums.
Yeah, I took the code directly from my old mod on the subject, and I'm not one for writing nice meaningful permission names...
Quote
Is the view own IP permission set by default? I don't think it is?
No, it isn't. I wasn't sure where to pitch the defaults (since logically, restrict probably needs view-ip-any), so left them all out (not just from the installer, but the default levels that are specified in ManagePermissions)

Nao

  • Dadman with a boy
  • Posts: 16,082
Re: New revs
« Reply #176, on September 28th, 2010, 09:48 AM »
Quote from Arantor on September 28th, 2010, 09:41 AM
Quote
$helptxt['see_member_ip'] should be updated (or deleted) to reflect the changes... Don't you think?
Probably, yes, but I didn't know how to word it, short of having it look up the groups.
Yeah that's a bit complicated... You should make it more generic. "Visible only to those who have permission to do so", or something like that...
Quote
Yeah, I took the code directly from my old mod on the subject, and I'm not one for writing nice meaningful permission names...
Lazy ass :P
Still -- valid request but it could probably be done site-wide when we implement non-forum code later...
Quote
No, it isn't. I wasn't sure where to pitch the defaults (since logically, restrict probably needs view-ip-any), so left them all out (not just from the installer, but the default levels that are specified in ManagePermissions)
Dunno what's best.

$txt['logged'] is no longer used in the Display template -- only in Modlog. Maybe it should be removed...?
Posted: September 28th, 2010, 09:45 AM

Searching for members by IP: it's disabled if you don't have the perms... But is it disabled in the actual search? I can edit a page and deleted "disabled" with Opera, in real time by editing the source (or in any modern browser by using a debugger tool), then if it's not disabled in the php file it's a security hole... I guess :)

Arantor

  • As powerful as possible, as complex as necessary.
  • Posts: 14,278
Re: New revs
« Reply #177, on September 28th, 2010, 09:50 AM »
Quote
Yeah that's a bit complicated... You should make it more generic. "Visible only to those who have permission to do so", or something like that...
Works for me.
Quote
Lazy ass
Still -- valid request but it could probably be done site-wide when we implement non-forum code later...
The only original code I committed last night was moving the icon :P as well as spacing fixes. But yeah, the language strings could be improved.
Quote
Dunno what's best.
Yup. This is why I just left it... but after sleeping on it, the easiest way to fix it is to align it with the ban list permission; those who have access to the ban list can see any IP, those who don't, can see their own - oh, and it probably should be barred from being given to guests.
Quote
$txt['logged'] is no longer used in the Display template -- only in Modlog. Maybe it should be removed...?
It could be moved to the modlog lang file?
Quote
Searching for members by IP: it's disabled if you don't have the perms... But is it disabled in the actual search? I can edit a page and deleted "disabled" with Opera, in real time by editing the source (or in any modern browser by using a debugger tool), then if it's not disabled in the php file it's a security hole... I guess
Yes it is. Something I didn't remember in the original mod...

Nao

  • Dadman with a boy
  • Posts: 16,082
Re: New revs
« Reply #178, on September 28th, 2010, 09:50 AM »
rev 165
- Removed a YaBBSE leftover. (upgrade.php)
! New IP text was missing LI tags. (Display.template.php)
! Fixed quick moderation checkboxes logic. (Search.template.php, Recent.template.php)

Done with the proof-reading :)
Re: New revs
« Reply #179, on September 28th, 2010, 09:54 AM »
Quote from Arantor on September 28th, 2010, 09:50 AM
Quote
Yeah that's a bit complicated... You should make it more generic. "Visible only to those who have permission to do so", or something like that...
Works for me.
Then I'll let you rephrase it :P
I'm just not comfortable enough with the English (NOT Scottish!) language.
Quote
Yup. This is why I just left it... but after sleeping on it, the easiest way to fix it is to align it with the ban list permission; those who have access to the ban list can see any IP, those who don't, can see their own - oh, and it probably should be barred from being given to guests.
Well... That's a good idea. I'd go with it.
Quote
It could be moved to the modlog lang file?
Or that, yes. :)
Quote
[quoet]
Pwned! Didn't use insertQuoteFast :P
Quote
Yes it is. Something I didn't remember in the original mod...
You mean the original mod had the hole? ;)
(Ah yes, I just checked, the fix is in it, indeed. Good thing we're both checking the code, always a failsafe for when we're lazy :))

I should stop posting so many smileys...
Plugin revs »