New revs
Plugin revs »

Nao

  • Dadman with a boy
  • Posts: 16,082
Re: New revs
« Reply #150, on September 24th, 2010, 07:43 PM »
Feeling a bit down... Not even css work can help here.

rev 141
* Changed menu hover color. If you can spot a difference, you're holy. (index.css)
* Reworked quotes, so that they don't look half as ugly. (index.css)
* Added a subtle border around cat_bar and title_bar, to make them a bit livelier. (index.css)
* Modified the admin/profile sidebar, because it's one of the ugliest Curve designs ever. Really. I hate cat_bar, but putting them as separators between plain white backgrounds is evil. (index.css, GenericMenu.template.php)
! Don't show the editor's name if it's the same as the original poster's. THE controversial commit to SMF. I'm defying the gods of reversal, because I'm craaaaazy. (BoardIndex.template.php)

Arantor

  • As powerful as possible, as complex as necessary.
  • Posts: 14,278
Re: New revs
« Reply #151, on September 24th, 2010, 07:52 PM »
Quote
Don't show the editor's name if it's the same as the original poster's. THE controversial commit to SMF. I'm defying the gods of reversal, because I'm craaaaazy. (BoardIndex.template.php)
Awesome, thank you :)
Quote
Changed menu hover color. If you can spot a difference, you're holy.
Do you see the light?!

Jesus H. Christ, I see the light! The band, Elwood, the band!

(Actually no, I haven't looked yet, but if you're saying that, odds are I wouldn't be able to tell the difference)
When we unite against a common enemy that attacks our ethos, it nurtures group solidarity. Trolls are sensational, yes, but we keep everyone honest. | Game Memorial

Nao

  • Dadman with a boy
  • Posts: 16,082
Re: New revs
« Reply #152, on September 24th, 2010, 08:30 PM »
rev 142
- Deleted the quotefast compatibility code for IE5. (Load.php, Post.php, Post.english.php, Post.template.php, topic.js)
! quotefast was called in a couple of places with a never used 'pb' var (it's an actual SMF bug, BTW, when used along with the 'xml' var.) (Post.template.php, topic.js)
* previewPost() should always assume that Ajax is available. (Post.template.php)

So, you're into my last modified fix? I thought you weren't :P Trying to cheer me up I'm sure :lol:
Oh, that BB scene was priceless. I never cared to watch the movie until a couple of months ago. What a treat!

Arantor

  • As powerful as possible, as complex as necessary.
  • Posts: 14,278
Re: New revs
« Reply #153, on September 24th, 2010, 11:36 PM »
Quote
So, you're into my last modified fix? I thought you weren't
I don't recall ever discussing it but the idea makes a lot of sense :)
Quote
Oh, that BB scene was priceless.
The whole film's pretty good. Note the cameo from Steven Spielburg (himself) as the tax assessor guy right at the end.

Nao

  • Dadman with a boy
  • Posts: 16,082
Re: New revs
« Reply #155, on September 25th, 2010, 12:45 PM »Last edited on September 25th, 2010, 07:46 PM by Nao/Gilles
rev 143
+ Added support for rounded corners for IE 6, 7 and 8, through ie-css3.htc (the only solution that worked for me), and only for wrc and roundframe classes (to save on performance). (ie6.css, ie7.css, ie8.css, ie-css3.htc, index.template.php)
! Forgot to add grad40.png gradient file. Really?
- Deleted roadmap.txt and todo.txt files (early SMF1 stuff.)
* Spacinazi. (GenericMenu.template.php, Packages.template.php)
Re: New revs
« Reply #156, on September 25th, 2010, 07:46 PM »
rev 144
* Renamed ie-css3.htc to css3.htc, fixed a couple of crashers in the code[1], and deleted all code related to box-shadow and text-shadow, as we won't be using it. (css3.htc)
* Found a better fix for wrc class not behaving correctly: it simply needed to have layout. Uh. Replaced width: 100% with zoom: 1, so it can be applied to all of its variations. (ie6.css)
+ Added a PNG fix script for IE6 emulation of transparent PNGs and correct background repeat. Believe me, it's a miracle that this thing works. (pngfix.js, index.template.php)
- Deleted ie8.css because it's only two lines, and added them to the index template.
* Moved body styling to a new wrapper, so that the body background can be properly redrawn in IE6. (index.template.php, index.css)
 1. First time in my life I'm fixing a .htc file... Fortunately it's just more JS :p
Re: New revs
« Reply #157, on September 25th, 2010, 08:08 PM »
'kay, what's with the dozens of topics updated all of a sudden? :^^;:

rev 145
- Deleted upgrade_1-0.sql and upgrade_1-1.sql, as we're not going to support upgrading from SMF 1.x anyway. (upgrade.php)
- Deleted ability to upgrade from YaBBSE. Did you know it was still in there?! (upgrade.php, Install.english.php)
- Deleted one of the smiley sets, because I have a problem with its name right now. :P
! Fixed a misplaced menu in the admin area in RTL mode. Although it might break sidebars... We'll see about that later. (rtl.css)

MultiformeIngegno

  • Posts: 1,337
Re: New revs
« Reply #158, on September 25th, 2010, 08:41 PM »
Quote from Nao/Gilles on September 25th, 2010, 07:46 PM
+ Added a PNG fix script for IE6 emulation of transparent PNGs and correct background repeat. Believe me, it's a miracle that this thing works. (pngfix.js, index.template.php)
Doesn't this affect performances? :blush:

Nao

  • Dadman with a boy
  • Posts: 16,082
Re: New revs
« Reply #159, on September 25th, 2010, 08:44 PM »
Nope... That's why I said it was a miracle.

MultiformeIngegno

  • Posts: 1,337

Nao

  • Dadman with a boy
  • Posts: 16,082
Re: New revs
« Reply #161, on September 25th, 2010, 09:36 PM »
rev 146
* Put submenu entries on the same line as their LI containers, to make menus a little bit less overwhelming when viewing the HTML source. (GenericMenu.template.php, index.template.php)
+ Added index.php protection to xkcd avatar folder.
* Updated to SMF rev 10141.
  * Minor typos and glitches
  ! The check on package server URL for http:// prefix failed.
  ! Incorrect parameter given for checkImageContents() on avatar uploads.
  ! Members with moderate_forum permission can no longer access Manage Posts admin area.
  * All new replies added via JavaScript were marked as ignored.
  * Fixed secret question page, and overflow error in admin menus.
  ! Tables should be created with SMF's charset and collation
  ! Installing as UTF8 should make all tables UTF8 <-- that's Pete's fix :)

Arantor

  • As powerful as possible, as complex as necessary.
  • Posts: 14,278
Re: New revs
« Reply #162, on September 26th, 2010, 06:03 PM »
Revision: 147
Author: arantor
Date: 05:03:01, 26 September 2010
Message:
+ First part of the naughty bot prevention code (plenty more to come though)
----
Modified : /trunk/Sources/QueryString.php
Modified : /trunk/Sources/Subs.php
Modified : /trunk/index.php


This adds the whitelisting stuff. Note the use of a constant; this is for use later throughout in a way that can't be tampered with.
Posted: September 26th, 2010, 06:04 AM

Revision: 148
Author: arantor
Date: 14:04:47, 26 September 2010
Message:
! Fix user menu inability to relate to message id (use %msg% in the URL for menu items) (Display.php, topic.js)
----
Modified : /trunk/Sources/Display.php
Modified : /trunk/Themes/default/scripts/topic.js

Posted: September 26th, 2010, 03:05 PM

Revision: 149
Author: arantor
Date: 15:00:07, 26 September 2010
Message:
! Remove 'send email' from user menu, added 'report to moderator' (Display.php)
- Removed unnecessary passing of current topic page into the send-report code, it wasn't being used for anything (Display.php, Display.template.php, SendTopic.php, SendTopic.template.php)
----
Modified : /trunk/Sources/Display.php
Modified : /trunk/Sources/SendTopic.php
Modified : /trunk/Themes/default/Display.template.php
Modified : /trunk/Themes/default/SendTopic.template.php

Posted: September 26th, 2010, 04:00 PM

Revision: 150
Author: arantor
Date: 16:32:57, 26 September 2010
Message:
! Removed topic class icon column from message index, unread/replies page (MessageIndex.template.php, Recent.template.php)
! Added icon to the subject area (MessageIndex.template.php, Recent.template.php, index.css, 4 new images)
----
Modified : /trunk/Themes/default/MessageIndex.template.php
Modified : /trunk/Themes/default/Recent.template.php
Modified : /trunk/Themes/default/css/index.css
Added : /trunk/Themes/default/images/icons/quick_lock_my.gif
Added : /trunk/Themes/default/images/icons/quick_my.gif
Added : /trunk/Themes/default/images/icons/quick_sticky_lock_my.gif
Added : /trunk/Themes/default/images/icons/quick_sticky_my.gif

Just a few notes.

1. icon1 class has not been removed. I don't *think* it's in use anywhere else.
2. Had to add 4 new images since the lock/stick/both icon in the subject column is a background image. Still, we can if we choose, proceed to ditch some of the images in the topic folder now.
3. I haven't touched the message index footer yet, not sure what to do with that exactly.
4. Topic class is currently still being determined both in the message index and in the topic itself (it's the icon in the top left corner of the topic). Since we're not using it in the message index, we can remove that (I'll do that later if you want, I was just concerned about getting it implemented as-is), but not sure about removing it from the topic yet. Makes little odds to me, I don't even notice it most (any?) of the time.
Posted: September 26th, 2010, 05:36 PM

Revision: 151
Author: arantor
Date: 17:03:07, 26 September 2010
Message:
+ Added new permissions for editing website and signature (independently of any other profile settings) (ManagePermissions.english.php, ManagePermissions.php)
+ Added enforcement of permissions (Profile-Modify.php)
+ Added permissions to edit own website/own signature to regular members and global moderators by default (install_2-0.sql)
----
Modified : /trunk/Sources/ManagePermissions.php
Modified : /trunk/Sources/Profile-Modify.php
Modified : /trunk/Themes/default/languages/ManagePermissions.english.php
Modified : /trunk/other/install_2-0.sql
Re: New revs
« Reply #163, on September 26th, 2010, 07:51 PM »
Revision: 152
Author: arantor
Date: 18:49:29, 26 September 2010
Message:
! Rearranging the order of Core Features - a feature whose title begins with A should be before something that begins with C. (ManageSettings.php)
----
Modified : /trunk/Sources/ManageSettings.php


...even if it was originally called 'Custom Profile Fields'... it's now called Advanced Profile Fields. And everything else is in... oh damn. I meant to move search engines too.
Posted: September 26th, 2010, 07:51 PM

Revision: 153
Author: arantor
Date: 18:51:41, 26 September 2010
Message:
! Also move search engines to be in the right alphabetic place (ManageSettings.php)
----
Modified : /trunk/Sources/ManageSettings.php

Nao

  • Dadman with a boy
  • Posts: 16,082
Re: New revs
« Reply #164, on September 26th, 2010, 08:27 PM »
As always, my revs aren't nearly as exciting as Pete's ;) But they must be done, too. And I'm here to do them, whether it rains or snows.

rev 154
+ Introduced #navi to contain the main menu and linktree areas and avoid breaking the menu under IE6 (don't ask.) (index.css, ie6.css, index.template.php)
- Deleted grad350.png, replacing header background with grad250.png because it's been reduced in height anyway. Doesn't look as good when folding it, but the header fold feature will probably be removed in the future anyway.
* Harmonized div.frame paddings, as they're confusing in their current state, and the trick was only useful in a vanilla Curve. (index.css)
! ie8.css was still being called by error. (index.template.php)
* Put linktree items on the same line as their LI parents, just like menu items. (index.template.php)
* Spacinazi. (QueryString.php, Subs.php)
* Saving a few bytes off JS files. (pngfix.js, css3.htc)
Plugin revs »