New revs
Plugin revs »

Nao

  • Dadman with a boy
  • Posts: 16,082
Re: New revs
« Reply #900, on July 26th, 2011, 12:13 AM »
rev 893
(7 files, 11kb)

* Cleaned up more DELETE FROM entries. Inspired by the latest commit. (ManagePermissions.php, ManageMedia2.php, Subs-Media.php, ScheduledTasks.php, Subs-Scheduled.php)

* French translation. Also, I believe our separator for floating point is a comma, not a period. (index.french.php)

* One-liner replacement for number_format. I'm sorry, I'm just like that. Please don't look at me that way. (Subs.php)
Re: New revs
« Reply #901, on July 27th, 2011, 10:44 AM »
rev 894
(13 files, 13kb)

* Modified error log's code previewer to show only 30 lines instead of 20[1] and use a monospaced font instead of the default. This ensures we get the entire preview without triggering a vertical scrollbar, improving usability. (ManageErrors.php, Errors.template.php, admin.css)

* Rename 'buddies' to 'contacts' in the English version, and other minor changes. To do: asymetrical contacts. (LANGUAGES: index, ManageSettings, Packages, PersonalMessage, Profile, Who, Wireless)

* Do not show "Age: N/A" in profiles if no age was specified. Just hide the line entirely. It's a waste of time, bandwidth and intelligence. (Profile.template.php)

! allow_no_censored should be tested through !empty(), as is often done. Not that it'll have any influence on a properly installed Wedge, but it's always been done this way with $modSettings, so we should harmonize it. Either add !empty() everywhere, or remove them everywhere. Considering updateSettings() is optimized for a systematical use of !empty(), it might also warrant a rewrite. (Profile.template.php)
 1. I meant '30 lines instead of 40'. Changelog error, sorry.
Re: New revs
« Reply #902, on July 28th, 2011, 01:08 AM »
rev 895
(8 files, 10kb)

! Whitespace trimmer in BBC parsing code was broken. (Subs-BBC.php)

* encodeURIComponent() has been supported as far back as IE 5.5, so there's no reason to use SMF's way of emulating it (string.php_tp8bit().php_urlencode()). (Packages.template.php, Post.template.php, editor.js, register.js, script.js, suggest.js, topic.js)

* php_strtr uses charAt when it could use [] instead. It's a bit faster, which is good in long loops. (script.js)

@ Note: there are two extra escape() calls in PM and Search templates, followed with unescapes. I'm letting them be for now because they're testing for %u in the URL, which only happens in escape()'d strings. I can probably just change the test to % alone... What do you think Pete? I haven't tested this.
Re: New revs
« Reply #903, on July 28th, 2011, 12:42 PM »
rev 896
(2 files, 9kb)

* Since php_strtr, php_strtolower and php_to8bit are only used in sha1.js, moved these functions to the correct file, saving 1.5kb (0.5kb gzipped) off the final cached file. If any mod wants to use them -- just include sha1.js in your stuff or copy the functions. I'm not forcing extra bandwidth use for logged in members. (script.js, sha1.js)

! The reason why charAt() is being used instead of [] is because IE6/IE7 don't support this. My bad, I thought they were decent browsers. Nah, just kidding, we all know they suck. Well, since php_strtr is only used in password encryption, it's not like it needed any optimization anyway. (sha1.js)

+ Added headers to the JS files. Well, at least we should start to do it. (script.js, sha1.js)
Re: New revs
« Reply #904, on July 29th, 2011, 12:58 AM »
rev 897 (a small one before going to bed...)
(4 files, 7kb)

* Replaced the very last escape/unescape calls with encodeURIComponent/decodeURIComponent. They're better suited for URL encoding. (PersonalMessage.template.php, Search.template.php)

* Removed {db_prefix}members:media and added {db_prefix}messages:id_parent. Both are unused, but id_parent can be used later for building a threaded view. (install.sql)

! If a timezone has no slash in it (such as 'UTC'), the timezone retrieval code will generate a warning. (ManageSettings.php)
Re: New revs
« Reply #905, on July 29th, 2011, 08:21 PM »
rev 898
(4 files, 7kb)

* More JavaScript function changes. Deleted php_addslashes (never used anywhere), moved easyReplace from script.js to post.js (it's only used by the smiley manager), turned _replaceEntities into an anonymous function (as it's only used by removeEntities). (post.js, script.js)

+ Added ability to call a regular popup window in reqWin, as opposed to an Ajax popup. (script.js)

! Fixed media button to call a popup window, as it's a two-step process and the second page wouldn't load in the Ajax popup. (Aeva-Gallery.php, editor.js)

@ Note: I wanted to use an iframe or something cooler than a popup window, but hey... Nobody ever complained about the AeMe popup in the first place, so why bother/waste time on this. As long as it works...
Re: New revs
« Reply #906, on August 1st, 2011, 01:56 PM »
rev 899
(11 files, 12kb)

* Upped the minimum PHP version to 5.2.3, so we can use the double_encode parameter on htmlspecialchars(). (install.php, readme_*.html, webinstall.php, upgrade.php, Class-String.php)

* Changed is_integer() to is_int() or a version that's approximately twice faster, (int) $number === $number. (smf_api.php, Class-String.php, Aeva-Subs-Vital.php)

* jQuerification of packman's file permission page. (Packages.template.php)

! Fixed folder icon alignment and padding in file permission page. (Packages.template.php)

@ NB: big commit today, so I'm splitting it in two. The next one will be there in a few.
Re: New revs
« Reply #907, on August 1st, 2011, 02:00 PM »
rev 900
(7 files, 14kb)

+ Added format_comma parameter to number_context(), allowing to disable comma formatting in specific cases. (Subs.php)

+ Optimized comma_format() to skip the (albeit very fast) number_format() call if the number is an integer (no decimal separator) and has less than 4 digits (no thousands separator). Performance is about 25% slower if the test fails, and 400% faster if it succeeds. (Subs.php)

! Searched PM messages didn't show the number of users in a replied PM, unlike other areas in Wedge. (PersonalMessage.php)

- Deleted wedge_checkReplied, as it was basically an early draft of number_context(). (PersonalMessage.php)

* Number of moderator reports now uses number_context(). (index.template.php, index.language.php)

* draftAutoPurge now uses number_context(), as originally intended. (PersonalMessage.template.php, Profile.template.php)

Arantor

  • As powerful as possible, as complex as necessary.
  • Posts: 14,278
Re: New revs
« Reply #908, on August 1st, 2011, 02:49 PM »
Revision: 901
Author: arantor
Date: 13:49:16, 01 August 2011
Message:
! First part of handling timezones from user perspective, there's no interface for it yet but it works from the database. (install.sql, Load.php, ManageSettings.php)

! The title derived from the current URL should not have a leading space. (install.php)
----
Modified : /trunk/Sources/Load.php
Modified : /trunk/Sources/ManageSettings.php
Modified : /trunk/other/install.php
Modified : /trunk/other/install.sql
Re: New revs
« Reply #909, on August 1st, 2011, 05:55 PM »
Revision: 902
Author: arantor
Date: 16:52:27, 01 August 2011
Message:
+ Provide the ability for people moving a topic to set how long the topic redirection notice stays in place for. (MoveTopic.php, MoveTopic.template.php, Subs-Scheduled.php, index.english.php)

! Miscellaneous layout bug in the move topic template, due to overwide dd forcing wrapping rather than floating. (sections.css)

! Miscellaneous bugs in the imperative scheduled system (Load.php, Subs-Scheduled.php)

! The recount-reports function is sometimes going to be run when permissions aren't loaded (namely during scheduled/imperative tasks), make sure the mod cache is loaded in that circumstance. (ModerationCenter.php)
----
Modified : /trunk/Sources/Load.php
Modified : /trunk/Sources/ModerationCenter.php
Modified : /trunk/Sources/MoveTopic.php
Modified : /trunk/Sources/Subs-Scheduled.php
Modified : /trunk/Themes/default/MoveTopic.template.php
Modified : /trunk/Themes/default/languages/index.english.php
Modified : /trunk/Themes/default/skins/sections.css



@ This isn't really finished, it's just at a convenient stopping place. The default is 1 day simply because it's at the top of the list, not because it's set that way - but that's actually an improvement in usability terms to the previous version IME. I haven't decided about allowing admins to set a default yet.

@ See also the discussion about dealing with redirections automatically; the way I solved it in the redirection topics mod I originally wrote was a separate table. Given the minimal approach I wanted to SMF modding at the time, this was the closest I could get, and it would only clean up once per day rather than actually as needed, so the individual table was useful then.
When we unite against a common enemy that attacks our ethos, it nurtures group solidarity. Trolls are sensational, yes, but we keep everyone honest. | Game Memorial

Nao

  • Dadman with a boy
  • Posts: 16,082
Re: New revs
« Reply #910, on August 1st, 2011, 10:13 PM »
rev 903
(9 files, 11kb)

* Don't show a submenu on mail settings (admin area) if the mail queue is disabled. (Admin.php)

! Fixed accidental revert from the last timezone commit. (ManageSettings.php)

* Changed 'Mail' label to 'Email Settings' in the Server & Maintenance admin menu. (Admin.language.php)

* I thought it would be amusing if the redirection topic strings actually used number_context()... (index.language.php, MoveTopic.template.php)

* Very minor fixes/changes. (ManageMedia.template.php, sections.css)

* French translation. (index.french.php)
Re: New revs
« Reply #911, on August 2nd, 2011, 01:02 PM »
rev 904
(6 files +2, 18kb)

* Changed wedge_type field name to board_type. At this point I'm unsure we'll keep the 'wedge' terminology for boards and blogs, so there's no point in adding more confusion. (install.sql, Load.php, RemoveTopic.php)

+ Re: my post 257238 at the forum, implementing 'before', 'after' and 'override' generic hooks for all template functions. The total overhead is no more than a millisecond per page. Needs more work. (Load.php)

! Resetting global locale scope to LC_TIME instead of LC_ALL, to avoid issues in the CSS parser. Although we could have fixed that directly in the parser, we're never far away from meeting more issues, so for now we'd rather remain compatible with the SMF method. (Load.php)

+ Added index.php dummy files for a couple of folders that missed them. (images/fields, images/theme)

! Typonazi. (Install.french.php)

Arantor

  • As powerful as possible, as complex as necessary.
  • Posts: 14,278
Re: New revs
« Reply #912, on August 4th, 2011, 03:05 AM »
Revision: 905
Author: arantor
Date: 02:04:48, 04 August 2011
Message:
! Removed several settings that irritate me in the admin panel:
- Current theme / Show BBC buttons in PM and Post Pages; you'd control this from the BBC and smileys areas instead. (Class-Editor.php, Settings.template.php, Admin.*.php)

- Go up/down buttons (on by default instead now) (ManageSettings.php, ManageSettings.*.php, Help.*.php, Display.template.php, MessageIndex.template.php)

- Show current position as text in linktree (I cannot seriously imagine anyone actually using this. It sort of defeats the point of a *link* tree.) (upgrade.php, Settings.template.php, Themes.*.php)

----
Modified : /trunk/Sources/Class-Editor.php
Modified : /trunk/Sources/ManageSettings.php
Modified : /trunk/Themes/default/Display.template.php
Modified : /trunk/Themes/default/MessageIndex.template.php
Modified : /trunk/Themes/default/Settings.template.php
Modified : /trunk/Themes/default/index.template.php
Modified : /trunk/Themes/default/languages/Admin.english.php
Modified : /trunk/Themes/default/languages/Admin.french.php
Modified : /trunk/Themes/default/languages/Help.english.php
Modified : /trunk/Themes/default/languages/Help.french.php
Modified : /trunk/Themes/default/languages/ManageSettings.english.php
Modified : /trunk/Themes/default/languages/ManageSettings.french.php
Modified : /trunk/Themes/default/languages/Themes.english.php
Modified : /trunk/Themes/default/languages/Themes.french.php
Modified : /trunk/other/upgrade.php

Nao

  • Dadman with a boy
  • Posts: 16,082
Re: New revs
« Reply #913, on August 4th, 2011, 03:09 PM »
rev 906
(10 files, 15kb)

+ Added ability to disable prev/next links in page index[1]. This is mostly useful in the message index. (MessageIndex.php, Subs.php)

! A couple of columns were wrongly colored in the admin member list. Also fixed comment typos and optimized styles/classes. (ManageMembers.php)

! Use $context['start'] instead of $_REQUEST['start'] in the message index. (MessageIndex.php)

- Deleted 'list_menu' and 'use_tabs' generic list features, as they're not used in Wedge. Or even in SMF, actually. (Subs-List.php, GenericList.template.php)

! Logic error in media admin JS, as well as a useless .each() call. (mediadmin.js)

- Removed another useless .each() call, this time for img.resized. (theme.js)

- Removed two unused footer classes and a useless ic_login. (index.css, index.rtl.css, sections.css)

+ Added a max-width for images. Should think of a better solution... (index.css)
 1. When calling the function, I mean. That is, it's internal to Wedge.
Re: New revs
« Reply #914, on August 5th, 2011, 05:39 PM »
rev 907
(7 files, 11kb) <-- much less than the time spent on it, comparatively :P

- Deleted stupid addLoadEvent() and rewrote the last couple of items that still used it to use better equivalents ($(window).load() and add_js). (install.php, upgrade.php, Subs.php, script.js, theme.js)

! When hovering out of a top-level menu entry with no submenus attached to it, it would remain highlighted for a second because the hover class was being removed from the wrong element. (script.js)

! Fixed one remaining occurrence of a wrong $.trim() implementation. (script.js)

* Simplified version retrieval at install time. (install.php)

* Changed the default minification process to Packer. I figure if modders can't make it work on a default install, they'll be more cautious about this whole semicolon issue, and I'd rather have to deal with modder issues than with user issues once they enable Packer. (install.sql)

- Removed outdated holidays from the calendar. (install.sql)

* Keep-alive timeout should be using a function name rather than a string. Same for the toggler object and menu_hide_me at one point. (script.js)

* Plenty of minor cleanup operations. (editor.js, script.js)
Plugin revs »