New revs
Plugin revs »

Nao

  • Dadman with a boy
  • Posts: 16,082
Re: New revs
« Reply #885, on July 20th, 2011, 01:03 AM »Last edited on July 20th, 2011, 08:51 PM by Nao/Gilles
rev 878
(3 files, ??kb)

* Reordered internal array for action menus, added a placeholder for link hover titles, and turned the 'click' member into 'custom', as it could be used for anything really. (Display.php, topic.js)

! mouseleave event didn't work correctly on user menus with the 'right-side' class applied to them. (topic.js)

* Even more hacking to prevent right-aligned user menus from animating the links inside them. Using float:right instead of text-align:right does the trick, although it also forces us to use the overflow:hidden clearfix, as well as some careful reordering. Gotta love CSS in those moments... (sections.css)

@ I still don't know if you guys like this all... I mean do you think it's better with or without the action menu?
Re: New revs
« Reply #886, on July 20th, 2011, 08:51 PM »
rev 879
(3 files, 14kb)

* Merged the two mini-menu objects (user, action) into a single one, saving about 1.2KB in the process. Gets a tad confusing though... Should try and make the two menus more similar internally. (topic.js)

* Moved profile icons to their own function. (Display.template.php)

* Minor display template changes. (Display.template.php)

! Selector inheritance bug in mini-menu. (sections.css)
Re: New revs
« Reply #887, on July 20th, 2011, 10:29 PM »
rev 880
(3 files, 12kb)

* Converted user menus to use the same object structure as action menus. Saves about 300 bytes in the topic.js file, but it's mostly for the slight benefit of readability. (Display.php, Display.template.php, topic.js)

! Minor jQuery error with opacity animation. (topic.js)

@ I think I'm done with these menus... Might just wanna add icons to the user menu, now.
Re: New revs
« Reply #888, on July 21st, 2011, 12:41 AM »
rev 881
(8 files, 14kb)

+ Added icons to the user menu. Uh. Actually, only one really... But at the least code skeleton is here. Also swapped class contents between list items and anchors in mini menus. (Display.php, Display.template.php, sections.css)

- Couldn't find the reason why there were non-semantic span tags inside mini-menu calls. So I removed them, because that's who I am. (TEMPLATES: Display, PersonalMessage, Post, Profile, Recent)

! Fixed icon positions in mini-menu. (topic.js)
Re: New revs
« Reply #889, on July 21st, 2011, 11:42 PM »
rev 882
(1 file, 7kb)

* More size optimizations for mini-menus (an extra 100 bytes saved.) (topic.js)

* Also made a few things clearer. Overall it should now be easier to write a fallback for non-JS by writing all of the code through PHP instead. (topic.js)
Re: New revs
« Reply #890, on July 22nd, 2011, 11:01 PM »
rev 883
(6 files, 10kb)

+ Added buttons for all of the currently available user menu items. Some are temp. Someone please find something worthy for them... And possibly move some of these icons to index.member.css -- at the very least, 'Send PM' and 'Add to buddies'! (Display.php, sections.css)

! Website links didn't work in user menu, because of extra quotes in them. (Display.php)

! $user_info['url'] was incorrectly set up in boards and topics when pretty URLs were used. As a result, the quick language change link would always redirect to the upper level. (Load.php)

* Spacinazi. (Profile-Modify.php)

! Member titles in user boxes used the title header styling, because of the ambiguous class name (li class="title"). (Display.template.php)

- Main forum header doesn't need a font size class to be set, as it's overridden in CSS anyway. (index.template.php)
Re: New revs
« Reply #891, on July 23rd, 2011, 11:01 AM »
rev 884
(4 files, 12kb)

+ Added $message['has_buttons'], which can be modified in the per-post hook ('display_post_done'). Allows you to add action menu buttons without too much of a hassle. Well, eventually at least... (Display.php, Display.template.php)

! User and action menus were incorrectly viewed as never empty on non-guest posts, and thus failing some tests for guests or users without any permissions. (Display.php)

* Moved buddy and PM buttons to the member CSS, saving some bandwidth for guests. (index.member.css, sections.css)
Re: New revs
« Reply #892, on July 23rd, 2011, 12:50 PM »
rev 885
(3 files, 5kb)

! SMF bug when handling admin membergroup. Thanks live627! (ManageMembergroups.php)

* Signatures didn't have enough breathing room at the bottom. (sections.css)

* Linktree array was being counted once, plus once for each linktree entry. Reduced this to only once overall. (index.template.php)
Re: New revs
« Reply #893, on July 23rd, 2011, 01:39 PM »
rev 886 -- aka the 'is_last' commit. Easy to revert, just in case...
(6 files, 8kb)

- Removed 'is_last' element from contextual tabs. They were only used in SMF 1.x themes, dropped in SMF 2.0, and these can be re-introduced easily through hooks. If anyone needs them, at least... (ManageBans.php, ManageErrors.php, ManageMembers.php, GenericMenu.template.php)

- Removed 'is_last' element from generic menus. They weren't used either in Wedge, and were pretty buggy. (1) $first_sa was tested for emptiness at a point where it could never be empty. (2) Current, first and last entries were set twice -- once during the main loop, and once after the loop was finished. (3) First and last entries in a submenu were swapped if in RTL mode. Since when does RTL include 'bottom to top'...? (Subs-Menu.php)

- Removed 'is_last' element from the main menu. Pretty much the same reason... Also fixes another SMF bug: $last_button ($last_item in Wedge) is set but never used, and is_last is unset in some situations but never reset elsewhere. (Subs.php)

! The Media tab in the main menu shouldn't show a submenu if it's only going to show a repeat of the top link... (Subs.php)
Re: New revs
« Reply #894, on July 23rd, 2011, 08:43 PM »
rev 887
(23 files +2-1, 50kb)

* Renamed reporttm action to report, as the word 'report' itself wasn't taken... Also added a temp Report button. (index.php, unit test, Display.php, Report.php, Subs.php, Display.template.php, SendTopic.template.php, Errors.language.php, index.english.php, Who.language.php, sections.css, report.png)

* Started renaming the warning system in the French translation. I was always bothered by its lack of coherence. "Report" is now "Avertir" instead of "Signaler", while "Issue warning" becomes "Sanctionner" instead of "Avertir". Also improved/fixed translation.
(Errors.french.php, Help.language.php, index.french.php, ManagePermissions.french.php, ManageSettings.french.php, ModerationCenter.language.php, Modlog.french.php, Profile.french.php, Reports.french.php)

* Renamed a couple of credit categories. (Who.language.php)

! The Remove button in the action menu was pretty broken. (Display.php)

! Rev 880 typo introduced a bug in the user menu regarding user vs post IDs. Blame copy & paste. (Display.php, Display.template.php)

! The IP icon had a help icon behind it. Fixed by renaming its class to helpc (for 'help cursor'). Also a shameless plug for multiple inheritance, ah ah. (Display.template.php, index.css, sections.css)
Re: New revs
« Reply #895, on July 23rd, 2011, 11:53 PM »
rev 888
(4 files, 8kb -- an appropriate size, dare I say.)

! Apparently, the Atom feed implementation was written around the time Atom 0.3 was out. Version 1.0 changes the modified tag to updated, and tagline to subtitle. Updated Wedge to use them. Also switched from summary tags to content tags, because as the name implies, summary should be for post extracts, not entire bodies. (Feed.php)

! Fixed RSS implementation bug: language should be specified in the language tag, rather than xml:lang (RSS is not proper XML so it doesn't officially understand that.) (Feed.php)

* Added a comment about the fact that pubDate for items is for RSS 0.93 and RSS 2.0, thus it renders the RSS 0.92 feed invalid. (Not that I'm not planning to remove it anyway...) (Feed.php)

* Top-level submenus are now horizontally aligned on their parent's label, rather than their icon. I guess it's something that could warrant a discussion, but apparently it's not a fascinating subject, so I'll just leave it at that. I probably should rewrite the menu code to make it simpler at this point. (script.js)

! Updated Trophy icon (used in the stats area) to fit in the same dimensions as the other icons on the page. Approximately, at least. (stats_posters.gif)

! Report button had too much padding on the right. (sections.css)

@ When will the bug fixing end? :P

Arantor

  • As powerful as possible, as complex as necessary.
  • Posts: 14,278
Re: New revs
« Reply #896, on July 25th, 2011, 04:22 PM »
Revision: 889
Author: arantor
Date: 15:21:08, 25 July 2011
Message:
! IP address unformatted if logged as a failed-admin-login-attempt where the IP address was in the body of the error. (Subs-Auth.php)

! Moving numeric formatting strings to the language files rather than a single global variable that was even wrong by default (1234.00 is not the format normally used in the US) (install.sql, Load.php, ManageSettings.php, Subs.php, Help+index+ManageSettings language files)

! Removing the ban log as part of removing the ban system generally (install.sql, repair.php, Admin.php, Class-DBPackages.php, ManageBans.php, ManageMaintenance.php, ManageSettings.php, ScheduledTasks.php, Security.php, Subs-Members.php, Admin language file)
----
Modified : /trunk/Sources/Admin.php
Modified : /trunk/Sources/Class-DBPackages.php
Modified : /trunk/Sources/Load.php
Modified : /trunk/Sources/ManageBans.php
Modified : /trunk/Sources/ManageMaintenance.php
Modified : /trunk/Sources/ManageSettings.php
Modified : /trunk/Sources/ScheduledTasks.php
Modified : /trunk/Sources/Security.php
Modified : /trunk/Sources/Subs-Auth.php
Modified : /trunk/Sources/Subs-Members.php
Modified : /trunk/Sources/Subs.php
Modified : /trunk/Themes/default/languages/Admin.english.php
Modified : /trunk/Themes/default/languages/Admin.french.php
Modified : /trunk/Themes/default/languages/Help.english.php
Modified : /trunk/Themes/default/languages/Help.french.php
Modified : /trunk/Themes/default/languages/ManageSettings.english.php
Modified : /trunk/Themes/default/languages/ManageSettings.french.php
Modified : /trunk/Themes/default/languages/index.english.php
Modified : /trunk/Themes/default/languages/index.french.php
Modified : /trunk/other/install.sql
Modified : /trunk/other/tools/repair.php


w00t one less table! More to disappear too, inevitably.
Re: New revs
« Reply #897, on July 25th, 2011, 05:29 PM »
Revision: 890
Author: arantor
Date: 16:29:09, 25 July 2011
Message:
! Improve how timezones are handled, namely: 1) Don't try forcing use of Etc/ legacy timezones that are actually confusing by nature anyway, but actually attempt to query for proper timezone instead of estimating, 2) ensure an actual timezone will be set even if we don't have one in the DB for any reason as a fallback, 3) improve the selector in the admin panel to limit to only the regions of interest. (install.php, Load.php, ManageSettings.php)
----
Modified : /trunk/Sources/Load.php
Modified : /trunk/Sources/ManageSettings.php
Modified : /trunk/other/install.php
When we unite against a common enemy that attacks our ethos, it nurtures group solidarity. Trolls are sensational, yes, but we keep everyone honest. | Game Memorial

Nao

  • Dadman with a boy
  • Posts: 16,082
Re: New revs
« Reply #898, on July 25th, 2011, 07:14 PM »
rev 891
(13 files, 20kb)

- Don't call JSE on mini-menu strings that won't be shown in the first place. (Display.php, Display.template.php)

* Harmonized string names for mini-menus and added descriptions to all of them. Removed all related strings that weren't used anywhere else. (Display.php, index.language.php, topic.js)

! Fixed Close button not showing up on zoomed items when double-clicking them (happened only if no further zoom level was available.) (zoomedia.js)

! The number of new PMs was being tested twice per page. Removed it from the menu array, and kept the one in the menu builder. (Subs.php)

* New PM indicator was ugly (red text on dark background), replaced it with the usual 'New' icon. (Subs.php, index.css)

* Replaced New icons with versions that don't show white pixels around them on dark backgrounds. Uh. (new.gif)

* IE details. They're still heavily broken. I don't care for now. (index.ie6.css, index.ie7.css)

- Removed .postarea { margin: 0 0 0 15em }, as it's useless in display:table mode. This will, as you guessed correctly, break IE6 and IE7 even more. And again: I don't care for now. I'll fix that when I feel like it. (sections.css)

Arantor

  • As powerful as possible, as complex as necessary.
  • Posts: 14,278
Re: New revs
« Reply #899, on July 25th, 2011, 09:29 PM »
Revision: 892
Author: arantor
Date: 20:27:35, 25 July 2011
Message:
! First use of the proposed number_context function to aid in i18n of language strings. I've applied it to the board index and message index for the number of posts, topics and redirections for each board, with an appropriate 'No topics' type string for 0, which just looks nicer to me. (Subs.php, BoardIndex.template.php, MessageIndex.template.php, index.english.php)
----
Modified : /trunk/Sources/Subs.php
Modified : /trunk/Themes/default/BoardIndex.template.php
Modified : /trunk/Themes/default/MessageIndex.template.php
Modified : /trunk/Themes/default/languages/index.english.php


Yup. I finally implemented this sucker. It is a touch more elaborate than my original - because it also calls on comma_format while it's at it, meaning the language string has to have a %s in the right place for the numbers. But there are examples of this now!!
Plugin revs »