New revs
Plugin revs »

Arantor

  • As powerful as possible, as complex as necessary.
  • Posts: 14,278
Re: New revs
« Reply #750, on April 25th, 2011, 05:08 PM »
Revision: 735
Author: arantor
Date: 16:08:07, 25 April 2011
Message:
! Sync to BB 2.1.13 (all to Security.php)
 ! Two new ranges that Google contains. (Which will reactivate once IPv6 support is complete.)
 ! The other change to BB in 2.1.13 was in how it exited tests after detecting a search engine; this does not appear to affect our implementation.

! Sync to SMF 10488
 ! r10474, r10476 Cleanup of Subs-Calendar actually using the values passed to functions rather than relying on $_REQUEST for them. (Subs-Calendar.php)
 ! r10478 Don't do anything with the view-query page if debug mode isn't enabled (regardless of being an admin or not) (ViewQuery.php)
 ! r10480 Spacinazi, minor template bug (Subs.php, Admin.template.php)
 ! r10481 When creating a new ban, tick the boxes by default (ManageBans.template.php)
 ! r10482 News link was incorrect in places. (I also took the liberty of putting the right URL in the comment in ManageNews.php, their's is wrong still) (Admin.php, ManageNews.php)
 ! r10483 A few id mentions in the URL at times needed to be removed for mod_security. Note that their patch doesn't bother to strip $_GET['id'] use from Themes.php while I did here. (Themes.php, script.js)
 ! r10485 Updated create_table function signature to 'ignore' by default, in line with what they've done. This will need to be fixed properly at some point though. (Class-DBPackages.php)
 ! r10486 Changes to Subs-Members for PostgreSQL's benefit, but we will be pulled up on using the old code otherwise unless we feel like rewriting this bit. Pointless change from our POV. (Subs-Members.php)
 ! r10487 bbc that's destined for package readme display should be preparsecode'd first. (Packages.php)
 ! r10488 Warning status was shown inappropriately at times (Display.php, PersonalMessage.php)

! Not synced
 ! r10473 Removing __ magic methods and certain types of call_user_func/_array from the DB backtrace; since we're using an actual class rather than a pseudo extended/overloaded class like SleePy was playing with, it should not affect us. In any case, our criteria in the backtrace is different (for good reason)
 ! r10475 MySQL 5.5 compatibility fixes for SMF 1.1.x.
 ! r10477 MySQL 5.5 compatibility fixes for upgrader from 1.0.
 ! r10479 ;id= removed from ManageAttachments.php (was already done)
 ! r10484 Scheduled tasks did not return with an image when an image was requested; we already implemented this, and did it more cleanly.
----
Modified : /trunk/Sources/Admin.php
Modified : /trunk/Sources/Class-DBPackages.php
Modified : /trunk/Sources/Display.php
Modified : /trunk/Sources/ManageNews.php
Modified : /trunk/Sources/Packages.php
Modified : /trunk/Sources/PersonalMessage.php
Modified : /trunk/Sources/Security.php
Modified : /trunk/Sources/Subs-Calendar.php
Modified : /trunk/Sources/Subs-Members.php
Modified : /trunk/Sources/Subs.php
Modified : /trunk/Sources/Themes.php
Modified : /trunk/Sources/ViewQuery.php
Modified : /trunk/Themes/default/Admin.template.php
Modified : /trunk/Themes/default/ManageBans.template.php
Modified : /trunk/Themes/default/scripts/script.js
When we unite against a common enemy that attacks our ethos, it nurtures group solidarity. Trolls are sensational, yes, but we keep everyone honest. | Game Memorial

Nao

  • Dadman with a boy
  • Posts: 16,082
Re: New revs
« Reply #751, on April 25th, 2011, 05:40 PM »
Please make sure the menu css changes work in your favorite browser! (Tested browser list is below.)

rev 736
(8 files, 10kb)

* Removed padding parameter from the main menu, and replaced it with a few CSS tweaks that should allow for it to work the same. Tested successfully in Opera 11.1, Firefox 3.6, Safari 5, Chrome 12, IE6, IE7 and IE8. I think. (Subs.php, index.template.php, index.css, index.ie6.css, index.ie7.css)
- Hover emulation in IE6 was slow. Removed emulation from form elements and the .css class to save time. (.css is never used once JavaScript is active anyway.) (ie6hover.js)
* Hey Nao, you know you can use jQuery in events, right? (Aeva-Foxy.php)
* Spacinazi. (Profile-View.php)
Re: New revs
« Reply #752, on April 26th, 2011, 02:25 AM »
rev 737
(5 files, 10kb)

! Fixed user menu not staying open[1]. Also restyled it a little, and added an opening animation. (topic.js, index.css)
! Fixed outdated fixes in IE6 menus. (index.ie6.css)
* Moved some JS from the Display template to topic.js, and a class to where it should be. (Display.template.php, topic.js, sections.css)
 1. Finally!!
Re: New revs
« Reply #753, on April 26th, 2011, 03:23 PM »
rev 738
(5 files, 11kb)

* Rewrote user menu to use as little JavaScript as possible in the HTML page. Everything we need is processed in topic.js, and strings are stored in a new object. Also removed current_user_menu global, as it wasn't needed. (Display.php, Display.template.php, topic.js)
* Improved user menu styling. (topic.js, index.css)
* Spacinazi. (Class-Editor.php)

(Pete, feel free to tell me what you think about the rewrite.)
Re: New revs
« Reply #754, on April 26th, 2011, 11:55 PM »
rev 739
(4 files, 6kb)

! Fixed undefined variables in various situations. (Buddy.php, Subs-Cache.php)
* Testing for getElementById? Seriously? (db_aeva.php)
* Made user menu code slightly clearer. (topic.js)
Re: New revs
« Reply #755, on April 27th, 2011, 10:24 AM »
rev 740 (useless markup commit.)
(5 files, 9kb)

* multiple attribute is valueless. (Admin.template.php, ManageMedia.template.php, Media.template.php)
* checked attribute is valueless. This was fixed long ago, but the latest SMF sync brought in a couple more. (ManageBans.template.php)
* <a name> is deprecated in favor of <a id>. Forgot to fix that when importing AeMe. (Media.template.php)
* Commenazi. (Class-CSS.php)
Re: New revs
« Reply #756, on April 27th, 2011, 11:55 AM »
rev 741 (useless rename commit.)
(38 files -3, 37kb)

* Renamed Javascript to JavaScript, for case nazis. I'm not one, but... Oh right, maybe I am. (Class-JSMin.php, Load.php, ManageMembers.php, ManageRegistration.php, Aeva-Embed.php, Spellcheck.php, Subs-Cache.php, Subs.php, Subscriptions-PayPal.php, aeva/readme.txt, TEMPLATES: Display, index, ManageBoards, ManagePaid, ManagePermissions, MessageIndex, Post, Profile, LANGUAGES: Help, ManageMedia, ManageScheduledTasks, ManageSettings, Media, PersonalMessage)
* Renamed use_lightbox to use_zoom, and other lightbox variables to zoom or zoomedia. I think most people are unfamiliar with what a lightbox is -- and zoomedia is more self-descript. (db_aeva.php, Aeva-Gallery.php, Aeva-Gallery2.php, Aeva-Subs-Vital.php, ManageMedia.php, Subs-Media.php, ManageMedia.english.php, ManageMedia.french.php, Media.english.php, Media.french.php, ManageMedia.template.php, Media.template.php)
- Removed Highslide JavaScript files and outlines folder. The hs folder will wait until I'm finished converting. (aeva/highslide*.js, aeva/hs/outlines)
Posted: April 27th, 2011, 11:32 AM

Note: if you have use_zoom problems when reloading, that's because you have to go to Admin > Media > Settings > Appearance, and enable (or disable) Zoomedia. The variable is supposedly always set in the DB so I won't bother to add empty() tests.
Re: New revs
« Reply #757, on April 27th, 2011, 11:59 AM »
rev 742 (useless color conversion commit.)
(48 files -1, 172kb)

* Converted all 32-bit PNGs in the aeva images folder to 32-color PNG-8s, moved originals to other/images. (other/images/aeva32, images/aeva/*.png)
! Undefined index error in media area. (Aeva-Subs-Vital.php)
- white-op85.png was never used in media area. (images/aeva/white-op85.png)
Re: New revs
« Reply #758, on April 27th, 2011, 07:09 PM »
rev 743 (useless function removal commit.)
(7 files, 9kb)

- Removed stylesheet parameter from loadTemplate(). Instead, use add_css_file('myfile', true) to load extra CSS. This was only ever used to load admin.css in Moderation and Package areas, so it's not a big loss. As a note, the fatal parameter isn't used either, so it could go just the same. (Admin.php, Load.php, ModerationCenter.php, PackageGet.php, Packages.php)
- Removed wedge_add_css just the same. Wedge is really better off with only the main CSS being cached in its own file. Contextual files need to be in their own files. Next step: merge wedge_cache_css with add_css_file. They're like twins! (Class-Editor.php, Subs-Cache.php)
Re: New revs
« Reply #759, on April 28th, 2011, 03:39 PM »
rev 744 (useless not-so-useless commit.)
(24 files, 52kb)

* Hopefully finished converting the Media template to validate HTML5. (Media.template.php, Media language, ManageMedia language)
- Removed debug mode for auto-embedding. It probably had a point back when it wasn't as efficient as it is nowadays... If your embedding is slow, just disable a bunch of sites. (Aeva-Embed.php, ManageMedia language, Media language)
! Renamed aeva_* variables to embed_* in everything related to auto-embedding. Hopefully should work. Also renamed $context['media_disable'] to $context['disable_media_tag']. (db_aeva.php, Aeva-Embed.php, ManageMedia.php, ManageMedia3.php, Subs-Media.php, ManageMedia language)
+ Added a .bbc_pre class to emulate <pre> mode in spans. Did some fixing on other occurrences of <pre>. (index.css, install.sql, Load.php, Subs-BBC.php)
- Removed support for pre_include hook. I don't think it's the 'right' way of doing it. Also removed WEDGE_HOOK_SETTINGS, since there's actually no point in providing support for a deprecated way of adding hooks... I must have been drunk when I did that in rev 252. (Load.php, Subs.php)
+ Added file parameter in add_hook(). You can now specify the required source file directly in that call. Skip the php extension and make sure it's a relative path based on the Sources folder. (Subs.php, Credits.php, ManageSettings.php)
! Fixed URL trimmer. It didn't actually work until now... (install.sql, Subs-BBC.php, ManagePosts.php, Admin language)
* Spacinazi. (db_aeva.php, Subs-Exif.php, captcha-ledicons_anim.php, Aeva-ModCP.php, Aeva-Subs-Vital.php)

@ Note: I renamed the aeva_ variables to fix issues with settings not being saved (they were expecting media_ vars so I changed everything to embed_). Maybe I should have simply told Wedge to expected aeva_ vars, but it's too late to change my mind now... Hopefully if there's any error in my change list, it'll be found soon enough. Or at least faster than it took me to realize trim_url wasn't working... :whistle:
Re: New revs
« Reply #760, on April 28th, 2011, 06:58 PM »
rev 745 (so useless I forgot to post it here)
(3 files, 8kb)

! Fixed a bug where after quick editing a post, you couldn't quick edit it again without either reloading the page or quick editing and cancelling another post. (topic.js)
! The hide_prefixes variables is a global, so it shouldn't be declared as local. (topic.js)
- Removed optimize section from topic.js, as I'm starting to dislike the systematic use of this feature on variable names. (topic.js)
* Tags can be in HTML5 format inside XML as long as they're inside CDATA tags... (Xml.template.php)
* The $xml variable in the CSS parser is misleading. It's not a XML document we're building, just some regular, arbitrary, crawlable HTML soup. Renamed it to $tree. (Class-CSS.php)
Re: New revs
« Reply #761, on April 28th, 2011, 10:39 PM »
rev 746 (useless IE fixin')
(2 files, 5kb)

! I don't remember why (or when) I did that, but I think it seemed important at the time. Reverted the 'nowrap' white-space rule to 'pre' for .bbc_code and .php_code, as it didn't work in IE7 and IE8. (index.css)
! IE8 screws up short messages with smileys. (index.ie8.css)

@ Note: I really don't remember... >_< The first occurrence of the change is when I changed the default styling from Wuthering to Warm... But apparently, Warm wasn't already stored in the SVN at that point. So it kinda comes out of nowhere... Please test a multi-line code tag in Firefox, Chrome and Safari if you're interested in making sure it keeps working...!
Re: New revs
« Reply #762, on April 29th, 2011, 12:34 AM »
rev 747 (useless iPhone commit)
(1 file +1, 6kb)

+ Added a (temp?) iPhone icon and made sure to use the icon by default when posting from an iPhone or iPod Touch. (Post2.php, images/post/iphone.gif)

Note: tested on the demo site...
Re: New revs
« Reply #763, on April 29th, 2011, 04:31 PM »
rev 748 (useless commit except for Pete and others here :P)
(2 files +1, 9kb)

+ Added hook for plugins to automatically modify $browser right after it's been built. (Load.php)
+ Added 'tablet' entry to browser detection. It only detects the iPad for now. Hi Pete! (Load.php)
+ Added a tablet entry to the list of wireless devices that get their own icon in posts. (Post2.php, images/post/tablet.gif)

Arantor

  • As powerful as possible, as complex as necessary.
  • Posts: 14,278
Re: New revs
« Reply #764, on April 30th, 2011, 01:25 AM »
Revision: 749
Author: arantor
Date: 00:25:07, 30 April 2011
Message:
! Sync to SMF 10497
 ! r10489 Setting base_theme_dir caused undefined index errors in manage languages area. (ManageServer.php) [Bug 4634]
 ! r10490 Personal message preview did not display post errors. (PersonalMessages.php) [Bug 4653]
 ! r10491-2 Custom language strings were not loaded when editing theme settings. (Themes.php) [Bug 4658]
 ! r10493 modify_modifications hook should be triggered earlier in the code. (ManageSettings.php) [Bug 4638]
 ! r10494-5 menu_items hook was triggered too late in the code. (Subs.php) [Bug 4637,4670]
 ! r10496 (adapted) Undefined index errors when there were not any recent posts. (BoardIndexInfoCenter.template.php) [Bug 4650]
 ! r10497 CAPTCHA settings were linked to the incorrect area in admin search results. (Admin.php) [Bug 4707]

I'm not entirely happy with the changes in r10494/5, as per my comments originally in bug 4637; I do not entirely agree that the menu items hooked items should be cached like this unless you guarantee to flush the cache at any point when you will removing add-ons, or you have add-ons that do funky dynamic buttons. (Any add-ons should really be paying attention. It isn't that hard, either. But I can see the flip side of why it's been done, too, that it does simplify and make consistent additive item behaviour. So I've committed it, after some internal deliberation. It will be interesting to see how this stands up for add-ons that actually do this; I suspect no-one's actually been using the hooks for this other than Fel (for PortaMX), Live (for EP) and myself (SimpleDesk) anyway. Won't get into the debate here over whether a system author should listen to the needs of those who modify the system or not.)
----
Modified : /trunk/Sources/Admin.php
Modified : /trunk/Sources/ManageServer.php
Modified : /trunk/Sources/ManageSettings.php
Modified : /trunk/Sources/PersonalMessage.php
Modified : /trunk/Sources/Subs.php
Modified : /trunk/Sources/Themes.php
Modified : /trunk/Themes/default/BoardIndexInfoCenter.template.php
Plugin revs »