New revs
Plugin revs »

Nao

  • Dadman with a boy
  • Posts: 16,082
Re: New revs
« Reply #570, on January 28th, 2011, 12:05 PM »
rev 537
(23 files, 78kb, mostly clean-up though)

+ The CSS parser now accepts variable names with a dash in them (they're supported in class names so why not vars?), and now limits the maximal filesize for data inclusion to 4KB, because it really shouldn't accept more, technically and ethically. (Class-CSS.php)
* Loaded all CSS files together before calling the CSS parser. This improves performance by about 20% here. (Subs.php)
- Removed a few unused strings in the Install language files, as well as many  's found in alert or confirm boxes. JavaScript doesn't like that. Also did minor tweaks. (LANGUAGE: Install, ManageBoards, ManageCalendar, ManageMaintenance, ManageSmileys, ModerationCenter, PersonalMessage, Profile, Search, Themes)
! Some of the new files were in CR-LF format. Okay, I've added to my to-do-list that I should quit all of my Notepad2 windows and change the default format to LF. It has to work at some point hasn't it? (guest.css, ie8.css, member.css, sections.css)
* Layout tweaks to the moderation report viewing page. (ModerationCenter.template.php)

Arantor

  • As powerful as possible, as complex as necessary.
  • Posts: 14,278
Re: New revs
« Reply #571, on January 28th, 2011, 12:18 PM »
Revision: 538
Author: arantor
Date: 11:17:30, 28 January 2011
Message:
! Updated bundled Bad Behaviour install to 2.1.10, involving:
 + Add less hackish proxy support (Admin.php, Admin.english.php, ManageServer.php, ManageSettings.english.php, Help.english.php, QueryString.php, Security.php)
 ! Test for Yahoo's bot should have been included before but was overlooked, but at least I translated that one into French, even my rusty language skills could do that! (Security.php, Security.english.php, Security.french.php)
 ! Rejigged the tests for Google, MSN and Yahoo to test the IP against the known netblocks first (again, originally part of BB anyway) (Security.php)
 ! Confirmed licence notes for BB as being LGPL 3.0 and included a good-faith note regarding our lack of inclusion of the GPL and LGPL licence files. (QueryString.php)
----
Modified : /trunk/Sources/Admin.php
Modified : /trunk/Sources/ManageServer.php
Modified : /trunk/Sources/QueryString.php
Modified : /trunk/Sources/Security.php
Modified : /trunk/Themes/default/languages/Admin.english.php
Modified : /trunk/Themes/default/languages/Help.english.php
Modified : /trunk/Themes/default/languages/ManageSettings.english.php
Modified : /trunk/Themes/default/languages/Security.english.php
Modified : /trunk/Themes/default/languages/Security.french.php
Modified : /trunk/other/install.sql


I implemented the UI back into the original admin panel for now simply because I'm still trying to figure out where everything needs to go, so reverted the (minor) changes in code to keep parity with SVN for now. All my real work's on paper at the moment...

There was also a bug fix in the code that BB had to have, but I'd already fixed around it anyway (the test for allowing external forms needed tweaking but I'd already tweaked it to work properly)
Re: New revs
« Reply #572, on January 28th, 2011, 02:05 PM »
Revision: 539
Author: arantor
Date: 13:04:38, 28 January 2011
Message:
! Create a recycling board by default on install. (install.sql, Install.english.php)
----
Modified : /trunk/Themes/default/languages/Install.english.php
Modified : /trunk/other/install.sql
When we unite against a common enemy that attacks our ethos, it nurtures group solidarity. Trolls are sensational, yes, but we keep everyone honest. | Game Memorial

Nao

  • Dadman with a boy
  • Posts: 16,082
Re: New revs
« Reply #573, on January 28th, 2011, 06:01 PM »
rev 540
(6 files, 15kb)

+ Added a slightly dirty, but still relatively fast and totally awesome[1] 'base' CSS property, where you can easily inherit an existing class or even an existing tag structure. If it turns out to be bug-free, we can safely remove the 'BasedOn' plugin. (Class-CSS.php)
* Replacing a preg_match with a strpos is always best. Especially, *especially* when you're calling it in a huge loop. (Class-CSS.php)
* We're not using getNodesByNodeName in other areas, so optimized it to fit our needs. @todo: determine whether the XML parser always returns uppercase tags, in which case we can do without the strtolower(). (Class-CSS.php)
* Started using base: and optimizing Warm. It's just an example but it works well as it is. (Warm/index.css, Warm/sections.css)
* Minor performance optimization. That silly PageSpeed plugin told me to. Ask him. (index.css)
* Renamed CSS cache classes to something more, err... memory-cacheable. (Class-CSS.php, Subs.php)
! Fixed wrong CSS nesting. (css/sections.css)
 1. I'm serious. Took me all afternoon to figure out how to implement that, and that was well worth it.
Re: New revs
« Reply #574, on January 28th, 2011, 06:40 PM »
(Pete, you forgot to post that one ;))

Revision: 536
Author: arantor
Date: 10:30:00, vendredi 28 janvier 2011
Message:
! Sync to SMF rev 10346
 * Incorrect fallback for pm receive options when buddy/ignore lists are disabled. (Profile.template.php) [Bug 4596]
 ! Upgrade did not update group types. (NB I did alter the change to use 'have not' instead of 'haven't' due to possible issues with the ' in the upgrade script. (upgrade.sql) [Bug 4577]
 ! Protected but visible group details could not be viewed by non-admins. (Groups.php) [Bug 4525]
 ! Search returned incorrect results for database users without create_temporary privilege. (Search2.php)
 ! Search may result in database errors for database users without create_temporary privilege. (Search2.php)
 & Copyright years update (index.english.php, index.french.php, install.php, upgrade.php)

Not applied:
 ! r10338 Removal of .new_win class definition (the one that was width: 400px, height: 400px) as it wasn't in our theme anyway.
 ! r10339 Fix for buffers trying to call arrays whose contents were not being trimmed; Nao already implemented more thorough trimming.
----
Modified : /trunk/Sources/Groups.php
Modified : /trunk/Sources/Search2.php
Modified : /trunk/Themes/default/Profile.template.php
Modified : /trunk/Themes/default/languages/index.english.php
Modified : /trunk/Themes/default/languages/index.french.php
Modified : /trunk/other/install.php
Modified : /trunk/other/upgrade.php
Modified : /trunk/other/upgrade.sql
Re: New revs
« Reply #575, on January 28th, 2011, 06:46 PM »
rev 541
(6 files, 10kb)

* French translation. Although, I have absolutely no idea what this is talking about. CIDR blocks for IP zone HTTP headers? Yeah sure, I'll call my lawyer and I'll get back to you. (Admin, Help, Install, ManageSettings)
* Thou shalt not commit XHTML, especially after all the time it took me to convert the damn templates back to dirty HTML :P (Profile.template.php)
Re: New revs
« Reply #576, on January 28th, 2011, 09:15 PM »
rev 542
(8 files, 17kb)

- Removed BasedOn plugin -- it's clearly inefficient compared to the new base: feature, and I shouldn't encourage its use. (Class-CSS.php, Subs.php)
* Moved OpenID graphics to guest.css (why did I forget that?), converted more rules to use base:, removed some styles that were never applied or duplicate. (index.css, sections.css)
Re: New revs
« Reply #577, on January 29th, 2011, 04:08 PM »
rev 543
(1 file, 8kb)

+ Color functions now accept percentage values. (Class-CSS.php)
! Fixed rgb_output() treating a=0 as having full opacity. Simplified the function. (Class-CSS.php)
+ Added channels() function to treat each RGBA channel separately. Example: channels(rgba(255, 128, 0, .5), -50, -50%, 255, -50%) should return rgba(205, 64, 255, .25). The alpha channel is not mandatory. It also works to change RGBA channels on HSLA colors, if you ever want to do that. (Class-CSS.php)
* Improved regex to be more restrictive with alpha declarations (it used to accept "0.5.1"). (Class-CSS.php)
Posted: January 29th, 2011, 02:58 PM

rev 544
(4 files, missed size, not much.)

! Fixed JavaScript error when the page counter allowed expanding to the right. (Subs.php)
! Fixed inverted background coordinates on a couple of icons. (sections.css, post.js)
* The Send PM page should use a cat instead of a title. (PersonalMessage.template.php)
Posted: January 29th, 2011, 03:46 PM

rev 545
(7 files, and AGAIN missed size and it's not much.)

+ Added a warning at install time if libxml is not activated. (install.php, readme_*.html, Install.english.php, Install.french.php)
* Does SMF2 *really* install on a server with 2.5MB of storage space, eh? I'd say at least 10MB... Let alone when Wedge gets AeMe as default... (readme_*.html)
* Saving 6 bytes of code. Don't worry, that's only because I tried adding some menu animations, wasn't too happy UI-wise, reverted and just kept the only worthy change. Uh. (script.js)
Re: New revs
« Reply #578, on January 30th, 2011, 12:21 AM »Last edited on January 30th, 2011, 12:47 AM by Nao/Gilles
rev 546
(12 files, 19kb)

! Rewrote HSL conversion to fix a few bugs, notably the hue being rounded incorrectly when the processed color was mainly red. (Class-CSS.php)
* .windowbg2 and .windowbg3 should always have inherited from .windowbg, from day one. The resulting files will be a few bytes larger because of newly added selectors, but it's for the better really. (index.css, admin.css, Nix/ie6.css, report.css, sections.css, wireless.css)
* Moved all PM-related CSS to the member-only CSS file, as it's very, very unlikely that you ever receive a PM if you're guest. If I were you, I wouldn't hold my breath waiting for that. (sections.css, member.css)
- Removed .lower_padding class (never used). (index.css)

Forgot to document: harmonized linktree with the bottom version. (padding, etc.) Added a temp background color to it.
Re: New revs
« Reply #579, on January 30th, 2011, 04:30 PM »
rev 547
(5 files, 11kb)

* Renamed $context['browser'] to a new $browser global, and referenced it into $context['browser']. Memory concerns I'd say. (Class-CSS.php, Load.php)
+ Added support for percentage values in rgb, rgba, hsl and hsla colors. (Class-CSS.php)
+ Added a workaround to get IE6/7/8 to support rgba, hsl and hsla colors. Oh yeah. (Class-CSS.php)
* Made sure that channels() gets 4 channels to play with, setting the rest to 0 if less are provided. (Class-CSS.php)
+ Added a $browser['is_ie8down'] variable in PHP and is_ie8down in JS, because it's likely to be useful for other users. (Load.php, Subs.php, Class-CSS.php, index.template.php, script.js)

(Nearly finished with my CSS parser, really... Still need to look into implementing a math parser.)
Re: New revs
« Reply #580, on January 30th, 2011, 05:25 PM »
rev 548
(2 files, 4kb)

! Selectors could be treated as base selectors by Wedge if their name included the one of an existing base selector. (Class-CSS.php)
* More CSS parsing use. I'm loving it. (Warm/index.css)
Re: New revs
« Reply #581, on January 31st, 2011, 12:38 PM »
rev 549
(4 files, 6kb)

* Renamed SI_* classes to CSS_*... Makes more sense in this context. (Class-CSS.php)
- Removed header from the 'more smileys' popup. If you clicked that link, you know what to do. (Class-Editor.php)
* Replaced the dynamic str_replace for debug data insertion, with a substr_replace which is faster in effect, and less error-prone. (QueryString.php)
! A misplaced preview linebreak was visible even when the preview wasn't. (Post.template.php)
Re: New revs
« Reply #582, on January 31st, 2011, 06:46 PM »
rev 550
(1 file, 5kb)

! Fixed a bug in the IE codepath: rgba and hsla colors weren't correctly transformed to rgb. Maybe I should start testing my code before committing it... Hmm... Wait, no that's too hard to do. (Class-CSS.php)
! Fixed (although it never generated any glitch?) a regex bug in the rule parser: a "+" was needlessly escaped, and worse, a "." should have been escaped. Plus, uppercase chars weren't taken into account, even though they should. (Class-CSS.php)
! Fixed a dirty bug where selectors were treated more than they should, resulting in long parsing times when using class inheritance. Maybe I should start tes... Look behind you, a three-headed monkey! (Class-CSS.php)
Re: New revs
« Reply #583, on January 31st, 2011, 09:37 PM »
rev 551
(3 files, 12kb)

+ Added a horrible, complicated and rather ugly hack called $alpha_matte. On the other hand, it allows using RGBA/HSLA colors without providing a fallback for IE 6/7/8. If you have a better idea, please share. (Class-CSS.php, Warm/index.css)
! Fixed named colors not working at all. Yes, I didn't test these either. So, did you see that three-headed monkey or not? (Class-CSS.php)
* Moved color extraction code to its own method. Not because it's cleaner, but because it allows me to call it again. (Class-CSS.php)
- Removed the buggy, and unused, server import function. (Class-CSS.php, Subs.php)
Posted: January 31st, 2011, 08:50 PM

rev 552
(2 files, 6kb)

* Updated ie6.css to remove the original rgba() hacks. Although... Can someone please tell me why it doesn't show backgrounds anymore? And why does the h4.hove work, but not the li.hove one? Eh? You don't care? You're mean. (Warm/ie6.css)
* Rewrote menu.gif handling to call it only once and save some space in the cached CSS file. (Warm/index.css)
Posted: January 31st, 2011, 09:20 PM

rev 553
(2 files, 5kb)

* Added ability to specify email and URL fields in Profile inputs, and changed a couple of these entries to force them. iPhone users will like me more for that. I need love. (Profile-Modify.php, Profile.template.php)
Re: New revs
« Reply #584, on January 31st, 2011, 11:30 PM »
rev 554
(5 files added, 1 deleted, 2 updated, 18kb)

* Renamed Nix styling to Wine (in keeping with the 'W' theme...), and tweaked the colors to be more inviting. Hips! (Wine/*, various files)

I *hope* you'll like it, Pete! I didn't change much, but I don't know how I could possibly make the catbar and titlebar brighter... :^^;: It would spoil the styling's name :P
I think I'll keep the 'Nix' name (or Nyx) for a REAL black theme ;)
Plugin revs »