New revs

Nao

  • Dadman with a boy
  • Posts: 16,082
Re: New revs
« Reply #540, on January 19th, 2011, 03:50 PM »
rev 501

- Remove media-specific query_see_* declarations, as they're in the (as yet uncommitted) media source files now. (Class-DB.php)
+ Added the Warm styling. Even though it's still a work in progress, there's really no reason to keep it away from the repository. (Warm/*)
! Fixed the Green styling. A bit. (Green/index.css)
Re: New revs
« Reply #541, on January 19th, 2011, 06:17 PM »
rev 502

- Removed all input_* classes, fixed many typos in that area, shortened checked/selected/disabled and basically used HTML5 goodness to simplify everything. button_* will come later. (68 files. Not gonna list them all!)
Re: New revs
« Reply #542, on January 19th, 2011, 09:55 PM »
rev 503

* Started work on button_submit conversions. Yes, I'm slower than earlier today. (install.php, SSI.php)
* Turned all string calls in setTimeout to proper function calls. Death to eval! (create_backup.php, repair*.php, restore_backup.php, upgrade.php, Load.php, TEMPLATES: Admin, Announce, ManageMaintenance, ManageNews, ManageSearch, Packages, Profile, Themes)

Thanks to w3fools for the tip on JS... I didn't even know it was possible and it pissed me off when I made the original reworking for jQuery. I never realized SMF used proper functions at some (rare) points.
Re: New revs
« Reply #543, on January 20th, 2011, 12:02 AM »
rev 504

+ Added a new button class, save, which should be semantically appropriate for a lot of areas, beginning with drafts. Also added spell class but it's unstyled for now. (Class-Editor.php, icons/save.png, Profile.template.php)
+ Styled search-type inputs. Dunno if it's a good idea to always show that icon in the header, though. (Admin.template.php, index.template.php, index.css)
! Inherited stylings didn't correctly reproduce the <we:> templates. (settings.xml)
* More abuse of the simpler, shorter HTML5 tag format. (index.template.php)
* More button conversions. And yes, I know, it still all looks ugly... And the Cancel button is broken, now. (index.css, Profile.template.php, Themes.template.php)
! The W3C Validator for HTML5 suddenly started giving errors on the JavaScript code in the debug footer, saying "invalid return". I'm sorry, man, but return false is totally justified here. Ah, well. Went back to SMF's way of doing it (javascript:void(0)). (Subs.php)
! Fixed an undefined offset error in the admin quick search. (Admin.php)
* Inpunazi. (install.sql)
Re: New revs
« Reply #544, on January 20th, 2011, 11:39 AM »
rev 505

* Added 'delete' and 'new' input buttons, converted some more button-heavy templates and resumed <we:> transforms. (Admin.template.php, ManageBoards.template.php, ManageMaintenance.template.php, index.css, add.png)
! Fixed the Cancel button and added a small 3D effect. Not as visible as in SMF, though. But they don't have icons in buttons. (index.css)
+ Added proper (temp?) hack for display:table in IE6 and IE7. May I say one word? "Ewwwwwwwwwwwwwwwww." (index.template.php)
* Made core feature boxes slightly larger. Even IE6 seems to accept 50% here, so why bother. (admin.css)
! Fixed a potential XML error when parsing CSS under IE. (Class-CSS.php)
! An input_* class had escaped me. Rats! (Display.php)
! Commenazi. (Subs.php)

Arantor

  • As powerful as possible, as complex as necessary.
  • Posts: 14,278
Re: New revs
« Reply #545, on January 20th, 2011, 12:34 PM »
Revision: 506
Author: arantor
Date: 11:32:46, 20 January 2011
Message:
! Move draft post settings into their own little menu (Admin.php, ManagePosts.php, Admin.english.php)
----
Modified : /trunk/Sources/Admin.php
Modified : /trunk/Sources/ManagePosts.php
Modified : /trunk/Themes/default/languages/Admin.english.php


I like the revision to the buttons - they're back to being as 3D-ish as they were before IMO, but the rounded corners are a nice touch.

The only search type input I see that's affected is the one in the admin panel, but that's not looking right anyway.
When we unite against a common enemy that attacks our ethos, it nurtures group solidarity. Trolls are sensational, yes, but we keep everyone honest. | Game Memorial

Nao

  • Dadman with a boy
  • Posts: 16,082
Re: New revs
« Reply #546, on January 20th, 2011, 05:06 PM »
rev 507

* Fixed form inside the h3 tag. The div will be fixed once we:cats are written to use something more flexible. Or whatever. (Admin.template.php, admin.css, rtl.css)
+ Added a white bevel inside buttons (only for modern browsers.) If you can spot the difference without zooming, you don't need glasses. It's only a test. (index.css, bevel.png)
! Safari and Chrome don't like CSS on search-type inputs. Thankfully, they provide a workaround for that... (webkit.css)
* Some more conversion work. (PersonalMessage.template.php)
* French translation. (Admin.french.php)

Arantor

  • As powerful as possible, as complex as necessary.
  • Posts: 14,278
Re: New revs
« Reply #547, on January 20th, 2011, 05:56 PM »
Revision: 508
Author: arantor
Date: 16:56:19, 20 January 2011
Message:
! Length parameter should have been in the truncate function (Class-String.php)
----
Modified : /trunk/Sources/Class-String.php

Nao

  • Dadman with a boy
  • Posts: 16,082
Re: New revs
« Reply #548, on January 21st, 2011, 04:29 PM »
rev 509

* Finished remodeling buttons in a way that I actually appreciate. Also added a workaround to see icons in IE -- they will have to be moved to the semantically more relevant ie*.css when the number of icons has stabilized. (index.css)
* Replaced button icons with a single sprite and provided an original copy (for modifications) and a copy processed through "pngquant -nofs 64" (to save bandwidth.) (buttons.png, buttons-32bit.png, add.png, cross.png, save.png, tick.png, index.css)
- Removed the original button background. Nothing that can't be replaced with a bevel (4 times smaller). IE? Screw IE. (submit_bg.png)
* Continuing we:cat transforms and button class additions. (Display.template.php, PersonalMessage.template.php)
Re: New revs
« Reply #549, on January 21st, 2011, 07:26 PM »
rev 510

+ Added very preliminary (and thankfully short) code to automatically switch between sidebar and jumbo footer depending on the window width. Jumbo footer isn't styled at all. (index.template.php)

(Just to get that out of my way... :P)
Re: New revs
« Reply #550, on January 22nd, 2011, 01:07 AM »
rev 511

* Started converting < br /> to < br> in the code logic. Well, hopefully it won't screw it up... (install.sql, Profile-Modify.php)
* Continuing work on simplifying self-closing tags, replacing button classes and transforming <we:cat>s. I don't even known why I'm doing all of these manually. (sphinx_config.php, create_backup.php, repair.php, Profile-Modify.php, Profile.template.php)
! Fixed png backgrounds in Nix for IE6. (Nix/ie6.css)
* Indenazi. (Profile.template.php)

Going to bed... Leaving you the very geeky rev 2^9 ;)
Re: New revs
« Reply #551, on January 22nd, 2011, 03:49 PM »
Okay, well apparently I'm getting 2^9 too :P Too many changes to leave them hanging. Don't worry, you can safely update your svn without checking everything, I double-checked all br and hr conversions.
Also forgot to mention that I added more <we:cat>s and button classes, as usual. (In Search)

rev 512

! The Search menu item shouldn't have submenu entries if simple search is disabled. (Subs.php)
* Turned < br /> into < br> on all template and language files. Also did it for < hr> and class'ed variations. I know, it's a bit scary when you're using to XHTML... But it saves a whooping 1.6kb of template code. What do you mean, "who cares?" (All templates but 8 (should make sure no XHTML templates are touched), most language files, spellcheck.js, settings.xml)
! Fixed a small issue with the dynamic sidebar in IE. Might be useful for other browsers, too. (index.css)
! Button icons were incorrectly positioned in simple search mode. (sections.css)
* Updated Warm styling to the recent template changes. (Warm/admin.css, Warm/index.css, Warm/webkit.css)
Posted: January 22nd, 2011, 02:28 PM

rev 513

! Fixed <we:cat> not being converted in the default styling. Oops, that's what happens when you never use it... (Load.php)
* Continuing we:cat, button_submit and self-closing tag conversions. Statistics: 729 self-closers, 268 cat_bars and 79 button_submits left to convert... And that's only in the templates. Someone help me please, I'm gonna drown. (TEMPLATES: Announce, Calendar, Errors, Login, Memberlist, MessageIndex, ModerationCenter, Themes, Who, sections.css)
* Moved #sidebar to a semantically more logical place in index.css, and added vertical-aligns, even though it should already be the default one. You never know. (index.css)
Re: New revs
« Reply #552, on January 22nd, 2011, 04:58 PM »
rev 514

- Removed a bunch of useless ' . ' (no need to concatenate two strings like that...) (repair_settings.php, Load.php, ManageSmileys.php, Packages.php, Search2.php, Subs.php, Themes.php, BoardIndexInfoCenter.template.php, Memberlist.template.php)
* Simplified a serious amount of hacks regarding \<\? and such, replaced br regexes with stronger ones, continued HTML5 conversions and the usual crap. (Admin.php, Class-Package.php, Load.php, ManageRegistration.php, Packages.php, PersonalMessage.php, Post.php, QuoteFast.php, Themes.php)
! Here's a funny regex. "Look for anything that isn't >. Then, look for something that isn't /, followed by >. But if there's no /, it's still okay." Can someone tell me why they're looking for / at all?! Just leaving out the "it's still okay" portion, because it makes sense to prevent the / at the end in script and style tags because they're not self-closing. (Class-Editor.php)
Re: New revs
« Reply #553, on January 22nd, 2011, 07:25 PM »
rev 515

* The commit that may make or break Wedge... Self-closing tag conversions for the entire Sources folder. Also converting button_submit classes and the usual rest. (Announce.php, Class-DB.php, CoppaForm.php, Display.php, Errors.php, Groups.php, Load.php, ManageAttachments.php, ManageBans.php, ManageCalendar.php, ManageErrors.php, ManageMail.php, ManageMembergroups.php, ManageMembers.php, ManageNews.php, ManagePaid.php, ManagePermissions.php, ManageRegistration.php, ManageSearchEngines.php, ManageServer.php, ManageSettings.php, ManageSmileys.php, MessageIndex.php, ModerationCenter.php, Modlog.php, Packages.php, PersonalMessage.php, Post2.php, Profile-View.php, Profile.php, QuoteFast.php, Reminder.php, RemoveTopic.php, Reports.php, Search2.php, Security.php, SplitTopics.php, Subs-Auth.php, Subs-BoardIndex.php, Subs-Menu.php, Subs-Package.php, Subs-Post.php, Subs-Recent.php, Subs.php, Subscriptions-PayPal.php, Unread.php, Unreadreplies.php, ViewQuery.php, Who.php)
Re: New revs
« Reply #554, on January 22nd, 2011, 10:23 PM »
rev 516

* Using non-xhtml version of nl2br (thanks Pete!) (install.php, restore_backup.php, upgrade.php, Class-DB.php, ManageMail.php, Packages.php, Subs.php, ViewQuery.php)
! Finished a regex conversion which I'd forgotten in the last rev. (Packages.php)
! Fixed an SMF bug with strong tags not being taken into account. (Themes.php)
+ Added left and right classes for img tags. Not used for now. (index.css)
* Self-closing tags. (install.php, restore_backup.php)