New revs
Plugin revs »

Arantor

  • As powerful as possible, as complex as necessary.
  • Posts: 14,278
Re: New revs
« Reply #525, on January 17th, 2011, 02:13 PM »
Revision: 484
Author: arantor
Date: 13:13:23, 17 January 2011
Message:
! Sync to SMF rev 10323
 ! Prevent wildcard-only censoring (ManagePosts.php)
 ! Converted passwords not recognised when using double MD5 hashing (Login2.php)
 ! Removed <b> tags that shouldn't be there (Reminder.php, PersonalMessage.template.php)
 & Wrong URL destination in 'birthday_email' help popup (Help.english.php)
 ! Extended maxlength for event titles, but see below (Calendar.template.php, Post.template.php)

!! Not applied:
 * revs 10317 and 10318 to Subs.php for the hook functions since they were previously rewritten anyway and the changes don't really apply now.
 * rev 10316 - the maxlength of event title's textbox was upped from 70 (Calendar) and 60 (Post) to 255 to match the expanded field size, except that the field is subject to htmlspecialchars which can mean cropped entities. I've moved both to 80 for us, and the fields are now correctly sized as 255 in the schema (I missed one of them before)
 * rev 10318's "pedantry" to index.css to move the definition of .new_win earlier in the file and make it fit stylistically with all the other CSS declarations.
----
Modified : /trunk/Sources/Class-Editor.php
Modified : /trunk/Sources/Login2.php
Modified : /trunk/Sources/ManagePosts.php
Modified : /trunk/Sources/Reminder.php
Modified : /trunk/Themes/default/Calendar.template.php
Modified : /trunk/Themes/default/PersonalMessage.template.php
Modified : /trunk/Themes/default/Post.template.php
Modified : /trunk/Themes/default/languages/Help.english.php
Modified : /trunk/other/install.sql
When we unite against a common enemy that attacks our ethos, it nurtures group solidarity. Trolls are sensational, yes, but we keep everyone honest. | Game Memorial

Nao

  • Dadman with a boy
  • Posts: 16,082
Re: New revs
« Reply #526, on January 17th, 2011, 03:37 PM »
(Sorry about the hiccups. Once again...)

rev 485

@ A few of the files will be in the next commit instead. (I've got a weird way of dealing with SVN conflicts.) (index.php, Display.template.php, Post.template.php)
* Renamed $actionArray to $action_list and turned it into a global (temporarily at least), to make it easier for Pretty URLs to differentiate between actions and board names. (index.php, QueryString.php)
! Fixed relative paths when caching CSS (they were broken after the cache was moved up to the root.) (Subs.php)
+ Added a function to automatically add browser prefixes to CSS3 extensions (currently border-radius, box-shadow and transition.) (Subs.php, index.css, Nix/index.css, rtl.css)
- Started removing input_* and button_* classes, which are only useful to IE6, and added fallbacks for a couple of these in IE6 (which will probably be removed in the end.) (ie6.css, ie7.css, rtl.css, sections.css, settings.xml)
* More type="email" and adding some required fields. Also cleaned up some code and started simplifying form elements. (TEMPLATES: Display, ManageBans, Post)
* Now we can safely remove cols attributes from textareas, right...? (ManageNews.template.php)

rev 486
* in_array stuff and spacinazi. Don't mind me. Again this conflict issue. (Class-Editor.php, Load.php)

rev 487
@ Committing the rest. (index.php, Display.template.php, Post.template.php)
* French translation. (Admin, Help, index)
Posted: January 17th, 2011, 03:22 PM

Forgot to document the fact that I fixed a IE6 bug in that width:100% on any child of #main_contents broke the page. Putting hasLayout on #main_contents fixed that.

Arantor

  • As powerful as possible, as complex as necessary.
  • Posts: 14,278
Re: New revs
« Reply #527, on January 18th, 2011, 11:24 AM »
Revision: 488
Author: arantor
Date: 10:24:12, 18 January 2011
Message:
! PM unread indicator shouldn't be set twice (Subs.php)
+ Ability to mark PMs as read (PersonalMessage.php, PersonalMessage.template.php)
----
Modified : /trunk/Sources/PersonalMessage.php
Modified : /trunk/Sources/Subs.php
Modified : /trunk/Themes/default/PersonalMessage.template.php

Nao

  • Dadman with a boy
  • Posts: 16,082
Re: New revs
« Reply #528, on January 18th, 2011, 02:54 PM »
rev 489

+ Added a CSS file parser that allows for plenty of nice things like nested selectors. (Class-CSS.php, Subs.php)
* Converted sections.css to use nested selectors; saved 2KB in the process. Started basic work on the index file. (index.css, sections.css)
* Now you can actually call your styling folder 'css', or whatever. (Subs.php)
* Spacinazi. (Class-Package.php)

Arantor

  • As powerful as possible, as complex as necessary.
  • Posts: 14,278
Re: New revs
« Reply #529, on January 18th, 2011, 04:25 PM »
Revision: 490
Author: arantor
Date: 15:24:41, 18 January 2011
Message:
! Sync to SMF 10336
 ! The value of checkbox custom fields were displayed incorrectly on topic display. (Load.php, ManageSettings.php)
 ! Paid subscriptions scheduled taks should be disabled when paid subscriptions feature is disabled. (ManageSettings.php, install.sql)
 & Unclear help strings for post unapproved replies and attachments permissions. (ManagePermissions.english.php)
 & Outdated information in calendar help string. (Help.english.php)
 ! The check for empty body on personal message body failed in some cases. (PersonalMessage.php)
 ! Calendar maximum year was not adjusted on forums upgraded from older versions. (Updated from 2016 to 2020 in installer) (install.sql)
 ! Member approvals did not take account deletion requests into account when registration method is not set to member approval. (ManageMembers.php, Subs.php)
 ! News items now get HTML encoded as they should be. (ManageNews.php, Admin.english.php)

!! Not applying:
 ! rev 10328: WAP template being called from Post.php; we don't have the WAP template any more thus the code does not apply to us.
 ! revs 10333-10335: SSI permissions have been fixed in SMF, by checking a new variable and if not found, booting back to the login page. Interesting approach, if a little blunt... anyway we already did our own. There is a change to side padding in SSI examples in 10334 but I figured we'd redo that anyway...
 ! rev 10336: They ripped out the manual and replaced it with suitable links to their wiki. We already entirely killed the manual section...
----
Modified : /trunk/Sources/Load.php
Modified : /trunk/Sources/ManageMembers.php
Modified : /trunk/Sources/ManageNews.php
Modified : /trunk/Sources/ManageSettings.php
Modified : /trunk/Sources/PersonalMessage.php
Modified : /trunk/Sources/Subs.php
Modified : /trunk/Themes/default/languages/Admin.english.php
Modified : /trunk/Themes/default/languages/Help.english.php
Modified : /trunk/Themes/default/languages/ManagePermissions.english.php
Modified : /trunk/other/install.sql


(This was ALL done by Sinan last night. Guy's a legend it seems.)

Nao

  • Dadman with a boy
  • Posts: 16,082
Re: New revs
« Reply #530, on January 18th, 2011, 05:47 PM »Last edited on January 19th, 2011, 09:13 AM by Nao/Gilles
Quote from Arantor on January 18th, 2011, 04:25 PM
! rev 10336: They ripped out the manual and replaced it with suitable links to their wiki. We already entirely killed the manual section...
What did they link to instead?
So, they're dropping their awful help section for good? They should have done that much earlier...
Quote
(This was ALL done by Sinan last night. Guy's a legend it seems.)
I'm not sure what you mean by that?
Sure, it's nice that someone in the dev team has woken up -- but what's been done here accounts for about 10 kilobytes at most... I think I've done more today, and I'd even venture into saying that my daily average is actually better than that... Not to mention yours.
Anyway! :^^;:

rev 491

+ Added $context['bottom_linktree']. If set to true, the linktree will also be shown at the bottom of the page. Probably a tiny bit more flexible than the SMF implementation...? (TEMPLATES: Display, MessageIndex, index)
* Pretty much finished converting index.css to use nested selectors; saved 1.2KB. (index.css, guest.css)
* CSS parser optimizations. (Subs.php, Class-CSS.php)
* French translation. (Admin, Help, ManagePermissions)

Arantor

  • As powerful as possible, as complex as necessary.
  • Posts: 14,278
Re: New revs
« Reply #531, on January 19th, 2011, 08:57 AM »
Revision: 492
Author: arantor
Date: 07:57:21, 19 January 2011
Message:
! Sync to SMF 10337
 ! Integrated output buffers can now use static functions in classes (Subs.php)
----
Modified : /trunk/Sources/Subs.php
Re: New revs
« Reply #532, on January 19th, 2011, 10:44 AM »
Revision: 493
Author: arantor
Date: 09:44:10, 19 January 2011
Message:
! Make auto suggest extensible through hooks, and make the registration check also check that a function is truly callable as opposed to merely existing (Suggest.php)
----
Modified : /trunk/Sources/Suggest.php

Nao

  • Dadman with a boy
  • Posts: 16,082
Re: New revs
« Reply #533, on January 19th, 2011, 12:01 PM »
rev 494

! Technically, trim() doesn't work on arrays. There was also one too many trim(). (Subs.php)
* Sometimes, I wake up and I want to micro-optimize a useless function. That's who I am. Genius has got its downsides. (post.js)

(Bigger one coming up.)

Arantor

  • As powerful as possible, as complex as necessary.
  • Posts: 14,278
Re: New revs
« Reply #534, on January 19th, 2011, 12:36 PM »
Revision: 495
Author: arantor
Date: 11:36:22, 19 January 2011
Message:
! Restructure the post template into smaller chunks. (Post.template.php)
----
Modified : /trunk/Themes/default/Post.template.php
Re: New revs
« Reply #535, on January 19th, 2011, 01:14 PM »
Revision: 496
Author: arantor
Date: 12:14:07, 19 January 2011
Message:
! Scheduled tasks (regular and imperative) threw errors in browsers since the content was being requested as an image and returned in text/html MIME type (ScheduledTasks.php, Subs-Scheduled.php)
! Little tidying up of actions (index.php, Announce.php, SendTopic.php, Reporttm.php)
----
Modified : /trunk/Sources/Announce.php
Added : /trunk/Sources/Reporttm.php
Modified : /trunk/Sources/ScheduledTasks.php
Modified : /trunk/Sources/SendTopic.php
Modified : /trunk/Sources/Subs-Scheduled.php
Modified : /trunk/index.php

Nao

  • Dadman with a boy
  • Posts: 16,082
Re: New revs
« Reply #536, on January 19th, 2011, 01:32 PM »
rev 497

! Images were loaded from the wrong relative URL. (sections.css)
* Moved all opening curly brackets to the end of the rule definitions in CSS files, where it wasn't already the case. Only for consistency. (editor.css, ie7.css, ie8.css, install.css, report.css, rtl.css, webkit.css, wireless.css)
* Finished converting css files to use nested selectors. (admin.css, ie6.css, ie7.css, ie8.css, install.css, Nix/index.css, rtl.css, wireless.css)
@ Currently using table layouts in the uncommitted Warm styling... Let's just say it feel very hackish. :(
@ Need to rewrite the installer to convert index.css and install.css before using them... :-/

I have a feeling that we'll reach rev 500 today... :)

Arantor

  • As powerful as possible, as complex as necessary.
  • Posts: 14,278
Re: New revs
« Reply #537, on January 19th, 2011, 01:35 PM »
Revision: 498
Author: arantor
Date: 12:34:42, 19 January 2011
Message:
! Instead of trying to cache individual news items, let's be smart and cache the entire, bbc-parsed news item list in a single hit, saving a call to parse_bbc for every news item nearly every page. (ManageNews.php, Subs.php)
----
Modified : /trunk/Sources/ManageNews.php
Modified : /trunk/Sources/Subs.php


Easily, I should think :)
Re: New revs
« Reply #538, on January 19th, 2011, 02:14 PM »
Revision: 499
Author: arantor
Date: 13:13:59, 19 January 2011
Message:
! Made constant variable injection (e.g. {db_prefix}, {query_see_board}) into query engine extensible without any modifications to Class-DB being required by modders. (Class-DB.php, Load.php)
----
Modified : /trunk/Sources/Class-DB.php
Modified : /trunk/Sources/Load.php

Nao

  • Dadman with a boy
  • Posts: 16,082
Re: New revs
« Reply #539, on January 19th, 2011, 02:45 PM »
rev 500

+ Added basic support for OK and Cancel icons in submit buttons. It's only an example... (index.css, cross.png, tick.png)
* Dropped float-based sidebar in favor of a display:table system. Seems to work much better but it feels too hackish, and doesn't support IE6/7 (for now.) (index.css, index.template.php)

Champagne !

(And given it took me half an hour to analyze your latest commits[1] and finish up this one, I was expecting this to be rev 505 or so :P)
 1. Great stuff, as always!
Plugin revs »