New revs
Plugin revs »

Nao

  • Dadman with a boy
  • Posts: 16,082
Re: New revs
« Reply #495, on January 6th, 2011, 11:48 AM »
rev 446

! A new file was in CRLF format. Bugger. (post.js)
* CAPTCHA translation. (ManageSettings.french.php)
! Fixed message margins in topic splitter, and converted code to jQuery. (SplitTopics.template.php)
Re: New revs
« Reply #496, on January 6th, 2011, 03:32 PM »
rev 447

! Fixed logic error when logging errors. Apart from the bad pun, I'm going to start cursing Pretty URLs. There has to be a better way to do that... (Errors.php, ManageErrors.php)
Posted: January 6th, 2011, 03:14 PM

rev 448

! Actually, rev 447 was wrong: it can be even worse. This is the proof. (Errors.php)
! Fixed error count in the main menu when meeting a 404 error. (QueryString.php)
! Two years into it, and I'm still fixing bad French text... (Admin.french.php, ManageMaintenance.french.php, Profile.french.php)

Arantor

  • As powerful as possible, as complex as necessary.
  • Posts: 14,278
Re: New revs
« Reply #497, on January 6th, 2011, 03:42 PM »
Revision: 449
Author: arantor
Date: 14:42:02, 06 January 2011
Message:
! Updated internal Bad Behaviour checks to match changes in BB 2.1.8
 - Due to a PHP bug, DNS lookups can fail and not report failure properly, so disabled those checks for the time being. (Subs.php)
 ! Two new spammer user-agents, update of existing user-agent to prevent some (rare) false positives (Security.php)
----
Modified : /trunk/Sources/Security.php
Modified : /trunk/Sources/Subs.php
When we unite against a common enemy that attacks our ethos, it nurtures group solidarity. Trolls are sensational, yes, but we keep everyone honest. | Game Memorial

Nao

  • Dadman with a boy
  • Posts: 16,082
Re: New revs
« Reply #498, on January 6th, 2011, 05:10 PM »
rev 450

! Gravatar e-mails were never shown after they were recorded. (Profile.template.php)
! hr's were pointlessly styled. Probably leftovers from old themes. (admin.css, TEMPLATES: Admin, ManageBoards, ManageNews, ManagePaid, Packages, Profile, SplitTopics, Themes)
* Moved the Wedge logo code over to CSS, to make it easier to hide it or remove it via stylings. (index.css, index.template.php)

Note: is ['avatar']['name'] the best place to retrieve the gravatar:// link? I'm not sure. It's also stored in another place...
Re: New revs
« Reply #499, on January 6th, 2011, 11:59 PM »
rev 451/452

! Fixed Javascript for CSS editor preview (it even had a leftover of pre-getXMLDocument era!), but it's pointless as right now it supports neither stylings, nor CSS caching. Anyone up for fixing that? Uh? Don't be so shy. (Themes.template.php)
! More jQuery fixin'. (Profile.template.php)
! Fixed IE6 margins for hr's. Untested. (ie6.css)
- Leftover debug code. (Themes.template.php)
Posted: January 6th, 2011, 10:44 PM

I can't believe I've been spending the last few hours debugging the css editor, when I never knew this thing existed before today.... :^^;:
It's not working, but at least I've made some progress.
BTW Pete, I think the 'default board language' setting doesn't work. I mean it works, but I've noticed it overrides my very own default language. (i.e. I forced a board to English and even though my language is set to French, it showed in English.)
Don't have time to work on checking that myself.

Arantor

  • As powerful as possible, as complex as necessary.
  • Posts: 14,278
Re: New revs
« Reply #500, on January 7th, 2011, 09:23 AM »
Revision: 453
Author: arantor
Date: 08:22:42, 07 January 2011
Message:
! Syntax error in registration screen JS (register.js)
! strftime issues dates with 0 prefixes, which upsets Javascript, so send the Unix epoch in milliseconds to build server time from instead (Profile-Modify.php, Register.php, Profile.template.php, Register.template.php, profile.js)
----
Modified : /trunk/Sources/Profile-Modify.php
Modified : /trunk/Sources/Register.php
Modified : /trunk/Themes/default/Profile.template.php
Modified : /trunk/Themes/default/Register.template.php
Modified : /trunk/Themes/default/scripts/profile.js
Modified : /trunk/Themes/default/scripts/register.js
Re: New revs
« Reply #501, on January 7th, 2011, 09:49 AM »
Revision: 454
Author: arantor
Date: 08:48:55, 07 January 2011
Message:
+ Add a hidden input box in all instances of the verification/CAPTCHA, which will be removed if Javascript is run, or at least hidden out the way, and if this box is submitted to the CAPTCHA receipt with content, kick it back. (Bots don't normally run JS, so won't remove it, but will typically populate it.) (Subs-Editor.php, GenericControls.template.php, index.english.php, index.css)
----
Modified : /trunk/Sources/Subs-Editor.php
Modified : /trunk/Themes/default/GenericControls.template.php
Modified : /trunk/Themes/default/css/index.css
Modified : /trunk/Themes/default/languages/index.english.php

Nao

  • Dadman with a boy
  • Posts: 16,082
Re: New revs
« Reply #502, on January 7th, 2011, 12:09 PM »
rev 455

+ Added support for stylings in the WYSIWYG CSS editor. (Themes.template.php)
+ Implemented a way to disable CSS caching and showing links directly for admins. Needed by the above. (QueryString.php, Subs.php)
+ Can you believe I actually forgot to implement replace-type stylings...? Unfortunately, this forces Wedge to load settings.xml for all nested stylings, but there's obviously no workaround for that. (Subs.php)
* Made CSS preview box a bit taller (from 300 to 400 pixels.) (Themes.template.php)
* More inline JS moved to the footer. (Profile.template.php)

BUG: if you browse your website from within the CSS preview iframe, it seems like the LAST component in the query string is ignored. i.e. ?action=pm with bring you to the board index, and ?action=pm;sa=send will show you the PM front page. I've been unable to find the reason for this. But frankly, this is better than nothing. Pete, let's say it bluntly, I spent hours on fixing this feature I never saw before, and I'm totally pissed off by the number of issues I had to fix. I can live with that one. If you want to look into it, please be my guest because I just won't do it.

NOTE: not yet actually committed. We both modified Subs.php (the joys of Subversion...), so it won't let me commit until I'm up to date. I'll look at your changes now, but while I'm at it: is there any point in showing a box and hiding it via JS? I mean, users with JS disabled will have a problem with it, *and* anyone writing a bot to pass through the Wedge CAPTCHA *will* notice that anyway and simply prevent the bot from filling it any other inputs... No?
Posted: January 7th, 2011, 12:02 PM

Also: your strftime stuff... What exactly does it do and fix? Is that a bug that happens everywhere?
Re: New revs
« Reply #503, on January 7th, 2011, 06:43 PM »
rev 456

! When using gravatars, pages would no longer validate. Thankfully, Gravatar.com seems to support ";" URL separators, so no need to wonder about turning ampersands into entities. (Subs.php)
* Split index.css into index.css, guest.css and sections.css to make it easier to browse through the main file (guest.css is just here as a test.) (guest.css, index.css, sections.css, Load.php)
* Micro-optimization. (Class-Editor.php)
* Spacinazi. Mainly removed useless tabs. (captcha-*.php, Class-DB.php, Class-GifAnimator.php, ManageMaintenance.php, PersonalMessage.php, Post.php, Profile-Actions.php, Profile-View.php, Subs-Editor.php, MessageIndex.template.php, post.js)
Re: New revs
« Reply #504, on January 8th, 2011, 06:57 PM »
rev 457

* Some windowbg/windowbg2 classes were missing their system wrc class. Reviewing all files to determine if they can be added. WIP. (upgrade.php, Class-Editor.php, Subs.php)
* Started work on reordering cat_bar's against title_bar's. (Admin.template.php, Packages.template.php)
! $reservedTables was incorrectly declared as $reservedTypes, causing a crash. (Class-DBPackages.php)
! Wrong smiley variable was put to the cache. (Class-Editor.php)
! Crash in list_getNumSmileys(). (ManageSmileys.php)
! Who thought it was funny to resize the title's text at the same time as the live news box? (admin.css)
* Moved Add-on link to the bottom of its menu entry. OCD stuff. (Subs.php)
* Used shorthands on a few long CSS declarations. (index.css)
- Some useless styles on legend tags. (admin.css)
! Security French language wasn't in UTF-8 mode, causing issues when showing text. (Security.french.php)
* Spacinazi. (Dlattach.php, Errors.php, ManageMaintenance.php, ManageServer.php, ManageSmileys.php, Memberlist.php, Profile-Modify.php, ScheduledTasks.php, SendTopic.php, SplitTopics.php, Subs-Calendar.php, Subs-Post.php, MessageIndex.template.php)

Note: popup in the error log is buggy. If you click a filename, it opens the source code in a 800+px high popup, even though it's requested as a 400px high popup.

Arantor

  • As powerful as possible, as complex as necessary.
  • Posts: 14,278
Re: New revs
« Reply #505, on January 9th, 2011, 04:59 PM »
Revision: 458
Author: arantor
Date: 15:59:07, 09 January 2011
Message:
! Fix the translatable captions in DB-based bbcode. (Subs.php)
----
Modified : /trunk/Sources/Subs.php

Nao

  • Dadman with a boy
  • Posts: 16,082
Re: New revs
« Reply #506, on January 10th, 2011, 04:29 PM »
rev 459

- Rewrote CSS hack for the WYSIWYG editor in IE to something that actually makes sense and takes 2 lines of code instead of 74. (Class-Editor.php, editor_ie.css, ie6.css, ie7.css, ie8.css, editor.js)
! A few popup windows were missing the UTF-8 attribute while $txt was being used in them. (Errors.php, ViewQuery.php, Errors.template.php)
! Validation error with IE6. (index.template.php)
* Keeping up with changing cat/title header logic where needed. (Admin.template.php)
* Avoid an error in reattribute posts feature, if JS is disabled. (ManageMaintenance.php)
* As always, \w is the winner when it comes to regular expressions. (Subs.php)
* More JS moved to the footer. (Errors.template.php, ManageNews.template.php)
* Minor changes. (QueryString.php, index.css, Post.template.php)
+ Added a smaller logo for use in the next styling. (minilogo.png) (not documented in the SVN, sorry.)

(Another one coming up...)
Posted: January 10th, 2011, 04:12 PM

rev 460

* Rewrote member maintenance area to use jQuery. Also fixed a few SMF UI bugs in that area. (ManageMaintenance.template.php)
* More JS code moved to the footer. (ManagePermissions.template.php)
! Code viewer in the error log was buggy. Fixed presentation with a dirty hack, I'm afraid. Compensated for the extra bytes by micro-optimizing strings in that function and using a jQuery hack found in its source code for cancelling event propagation. I'm clinically insane. (script.js)
! More French translation fixes. And I thought 2 months spent on that back in 2008 were enough... (Admin.french.php)
* Minor changes. (theme.js)
Re: New revs
« Reply #507, on January 11th, 2011, 12:32 AM »
rev 461

- Removed $settings['theme_version'], as it's a compatibility setting for SMF1/2. Will reimplement if ever needed... Probably not! (Subs-Menu.php, Subs.php, index.template.php)
- Removed other unused compatibility variables. (Subs.php)
* More jQuery conversions and, possibly, the final removal of inlined JS code. Yay! Only got AeMe code left to convert now... It'll come in time. (ManageMembergroups.template.php, ManageSearch.template.php, ManageSmileys.template.php, PersonalMessage.template.php, Register.template.php, Search.template.php)
@ The Membergroups stuff also had indentation bugs. And it used to be faster without jQuery. Ah, well. Can't have everything. (ManageMembergroups.template.php)
Posted: January 10th, 2011, 11:57 PM

rev 462

* The sweet taste of revenge. Or whatever. Just tweaked the search area to something a bit smarter. (Search.template.php)
Re: New revs
« Reply #508, on January 11th, 2011, 05:03 PM »
rev 463

* Slightly enlarged source code viewer in the error log. Since it can never be too large... (ManageErrors.php)
! Fixed undefined index error when viewing a subscription with no allowed groups. (Profile-Actions.php)
- Removed unneeded '-sections' from CSS file URLs. (Subs.php)
! Not sure why, but unlink() would sometimes fail on cache files, even if they're confirmed to exist. Stat cache anyone? (Subs.php)
* CSS editor font was too small. (Themes.template.php)
* More title/cat balancing. (Admin.template.php)
Posted: January 11th, 2011, 04:00 PM

rev 464

! Pages wouldn't validate if their title had an accent in it, because the charset was defined after the title. Silly... (index.template.php)
! Missing div broke validation. (Search.template.php)
Re: New revs
« Reply #509, on January 11th, 2011, 11:52 PM »
rev 465

+ Added support for cat bars as list headers. Dunno, it just felt like the only way to easily fix page logic... (ManageServer.php, Subs-List.php, GenericList.template.php)
! Fixed regression introduced in rev 440 that caused URLs to be incorrectly transformed when they had a page start value. (PrettyUrls-Filters.php)
* Micro-optimization for a preg_replace. Actually, this could be turned into a simple str_replace with a trick or two. Would probably be worth benchmarking. (QueryString.php, Subs.php)

(Sorry for the regression!)
Plugin revs »