New revs
Plugin revs »

Nao

  • Dadman with a boy
  • Posts: 16,082
Re: New revs
« Reply #375, on November 24th, 2010, 02:18 PM »
rev 289

- Reverted rev 287-288

rev 290

+ Added placeholder for a dynamic file cache suffix (*.js?suffix), in case we want to use it.
- Commented out the statistics sharing code. We're not SMF. (install.php, upgrade.php)
* More add_js/add_js_file. (Admin.template.php, Subs-Editor.php
- Deleted all copyright removal test code. We'll see to that later but we're certainly not selling the right to delete a copyright. You just need to ask nicely. (Credits.php, Subs.php, Admin.template.php, Who.template.php, Admin language, Errors language)
* Renamed some of the SMF stuff to Wedge and fixed scheduled task SM files to point to our website. (install.php, install.sql, upgrade.php, Install language, ScheduledTasks.php, Subs-Database.php, other/xml/*.js renamed to *.php)
Re: New revs
« Reply #376, on November 24th, 2010, 03:40 PM »
rev 291

* More SMF to Wedge changes. (Settings.php, Settings_bak.php, repair_settings.php, smfinfo.php,
+ Added an add_js_inline() to add JS code before the big scripts at the end. Right now it is an alias to add_js(). If used in enough cases, it will be made into a proper function. (QueryString.php, PersonalMessage.template.php)
* Optimized add_js() to justify using it even in loops. Modders are big boys, they don't need newlines to be added automatically for them. (QueryString.php)
* Continuing the add_js quest. (ManageMail.php, PersonalMessage.template.php)
Re: New revs
« Reply #377, on November 24th, 2010, 11:55 PM »Last edited on November 25th, 2010, 12:07 AM by Nao/Gilles
I can't believe I spent my entire day on this... So many bugs to fix!!

rev 292

@ 30 files done. Got 21 more templates to document before I can commit them... I'll do that tomorrow alright? Man's gotta sleep sometimes.
* More SMF to Wedge renaming. (current-version.php, detailed-version.php)
* More add_js conversion. (TEMPLATES: Admin, Announce, BoardIndex, GenericList)
! Fixed missing parenthesis. (ManageMail.php)
- $profile_fields['js_submit'] and ['js'] are never set in the first place. (Profile-Modify.php)
* Indenazi. (index.php, ManageMembers.php, ManageServer.php, ManageSmileys.php, Admin.template.php, Nix/index.css, ManageSettings.english.php, ManageSettings.french.php)
* Made submit buttons slightly rounded if CSS3 is available. Eh, why not. I'm bored. (index.css)
* Added some margin below fatal errors. Looks better for the Return link. (index.css)
* Changed stats page column internal widths to allow for more space on the left side. (index.css)
! Generic lists could sometimes set width to "100%px"... Yeah. (GenericList.template.php)
! addcslashes/JSE fixes. (Search.php, Search.template.php, ManageMembers.english.php, ManageMembers.french.php)
! Precedence logic issue in cascaded tables. (index.css)
! Cellspacing values weren't working, at least in Opera. (index.css)
! CSS wasn't applied correctly to reports. (report.css)
! SMF glitch: broken class. (ManageScheduledTasks.php)
! Validation error in custom profile fields page. (ManageSettings.php)
! French translation fixes. (index.french.php, Help.french.php, Reports.french.php)
! Alignment issues when opening a month via Ajax in stats page. (stats.js)
! Editor BBC button list was vertical (uh!) in IE6 and IE7 (ahah!) (ie6.css, ie7.css)
! Pete bug (evil grin): auto-suggester was broken. Restored a few lines but they probably would best be removed. (Suggest.php)
! Nao bug (annoyed grunt): removed an extra </div> from the admin settings template. (Admin.template.php)
! Admin area would print label tags linked to non-forms, causing HTML5 validation to break. Yeah I know, they're a PITA... (Admin.template.php)
Re: New revs
« Reply #378, on November 25th, 2010, 05:26 PM »Last edited on November 25th, 2010, 05:39 PM by Nao/Gilles
rev 293

! Two errors with SMF variables. (install.php, Install languages)
* Continuing the inline JS exodus. (TEMPLATES: Login, ManageAttachments/Bans/Boards/Calendar/Maintenance/ Membergroups/Members/News/Paid/Permissions, ModerationCenter, Packages, Post, Profile, Search, SplitTopics, Stats)
! SMF bug: Javascript error when editing the Local Moderator membergroup. (ManageMembergroups.template.php)
- Removed unused variables $context['profile_javascript'] and $context['profile_onsubmit_javascript']. BTW, the latter's implementation was buggy. (Profile.template.php)
+ Added description for membergroup color setting. (ManageMembergroups.template.php, ManageMembergroups language)
+ Added a label for duration radio boxes. UI FTW. (ManagePaid.template.php)
! isset($something) ? $something : $something has to be the funniest waste of space I've seen today. Four times. In the same file. (ManagePaid.template.php)
! Fixed validation broken due to [] in URLs. Too bored to look for other URLs manually... (PersonalMessage.template.php)
! SMF glitch: validation was broken in profiles due to a self-closed span. Whatever. (Profile.template.php)
* Started replacing <br /><span class="smalltext"> with <div class="smalltext">. Allows for setting some padding in the settings area to avoid getting long descriptions to touch the right side of the area. (TEMPLATES: ManageBans, ManagePaid, ManagePermissions, PersonalMessage, Profile)
! Fixed leap year handling. The problem won't occur before 2100, but we might as well be ready for the far future. That's what Wedge is. (Calendar.template.php, ManageCalendar.template.php)
! JSE fixes in various places, most notably all doAutoSubmit() functions. Maybe we should be putting this into a JS file...? (TEMPLATES: Admin, Announce, ManageAttachments, ManageMaintenance, ManageMembers, ManageNews, ManageSearch, Packages, Register, Search)
* Seriously, plenty more fixes that I couldn't both to log. Do you realize I spent an entire day just writing this changelog and checking it again and again? Is there someone reading me anyway? Hello? Mom is that you?
* Indenazi. (Reports.php)

I'm only halfway through it! I have just as many files left to commit. And I'm not even started on onclicks, lol...
Re: New revs
« Reply #379, on November 25th, 2010, 05:59 PM »
rev 294

+ Adding proper support for add_js_inline(). (Load.php, QueryString.php, index.template.php)
* Don't show debug info in help popups. Seriously, this was too silly. (Subs.php)
- Removing submit button's rounded corners until I figure out a way to properly disable the outline that shows up in Opera when clicking it. (index.css)
* Simplified init process for both objects in admin.js file. (admin.js)
* Give some padding to descriptions inside the settings area. At least some breathing space... (index.css)
+ Forgot to translate an entry to French. (Admin.french.php)
* Finished committing a few multi-file fixes that were mentioned in the previous commit: <span>'s to <div>'s, leap year fix and renamed functions. (ManageAttachments.php, ManageScheduledTasks.php, ManageServer.php, ManageSmileys.php, Profile-Modify.php, TEMPLATES: Calendar, Help, ManageCalendar, ManageSmileys, Post, Themes)

Phew... Here are are.
Many files, but less changes per file, thankfully, so it was way quicker to build this changelog.
One more commit coming up, with the last smalltext span fixes...
Re: New revs
« Reply #380, on November 25th, 2010, 06:09 PM »
rev 295

- Couple of useless classes. (index.css)
* Finished replacing <span>'s with <div>'s. Phew. One good thing done... (All other files in that rev. Honest.)

TAKING A BREAK! :P
Re: New revs
« Reply #381, on November 25th, 2010, 09:48 PM »
rev 296

* The manage smileys page had a very ugly link at the bottom. (ManageSmileys.php)
* More inline JS movement. (Admin.template.php, ManageSmileys.template.php, Packages.template.php, Reminder.template.php, Themes.template.php)
* Scheduled Tasks translation to French was inconsistent. (Admin, Help and ManageSettings language files)
* Fixed latest-*.php files to prevent them from sending errors to Wedge. Whatever... (xml/latest-*.php)
Re: New revs
« Reply #382, on November 25th, 2010, 11:02 PM »Last edited on November 26th, 2010, 12:23 AM by Nao/Gilles
rev 297

- Removed support for theme variants... We have stylings now, and they're easier to grasp for themers, hopefully. Better documented, too. Maybe it'll get me to finally enable choosing a styling for the forum theme (outside of boards)... And maybe customization for users, but honestly I'm not fond of that idea. (Load.php, Themes.php, BoardIndex.template.php, Themes language, MessageIndex.template.php, Themes.template.php)
* Continuing, and pretty much finishing, the inline JS migration. Every single script tag left means the data can safely be stored inside the JS and doesn't rely on externals. (ManageMembergroups.template.php, ManagePaid.template.php, Packages.template.php, Poll.template.php, Profile.template.php)
* Forgot to fix the leap year on one of the files. (ManagePaid.template.php)
Re: New revs
« Reply #383, on November 26th, 2010, 08:17 PM »
rev 298

+ Added ability to specify a default styling for the forum. (install.sql, Load.php, ManageBoards.php, Themes.php, ManageBoards.template.php, Themes.template.php)
* A few minor tweaks to Themes language files, hopefully for the better. (Themes.english.php, Themes.french.php)
@ To do: allow members to set their own styling preferences, too.
Re: New revs
« Reply #384, on November 26th, 2010, 11:10 PM »
rev 299

* At last, STYLINGS ARE F'ING DONE! Implemented user's ability to select different stylings by default. (install.sql, Load.php, Themes.php, Themes.template.php, Themes.english.php, Themes.french.php)
* Some tweaks in stylings and their settings file. (Nix/index.css, Nix/settings.xml, Green/settings.xml)
Re: New revs
« Reply #385, on November 26th, 2010, 11:20 PM »
rev 300

* Theme preview/use page was beginning to be a bit crowded. (Themes.template.php)
+ Added a quick "proof of concept" styling. Dunno if it's worth including it in the final file. (css/Green/Green again/*)
@ Okay, so what? I just wanted to have rev 300 done before going to bed... Sue me.

Arantor

  • As powerful as possible, as complex as necessary.
  • Posts: 14,278
Re: New revs
« Reply #386, on November 27th, 2010, 02:57 AM »
Holy cow, lots of things to review, will try and look at them tomorrow.
When we unite against a common enemy that attacks our ethos, it nurtures group solidarity. Trolls are sensational, yes, but we keep everyone honest. | Game Memorial

Nao

  • Dadman with a boy
  • Posts: 16,082
Re: New revs
« Reply #387, on November 27th, 2010, 04:34 PM »
rev 301

* Show link underlines in posts. I've always found it silly that SMF insisted on pretty much hiding links from posts. If anything, it encourages spamming. (index.css)
* Moved smf_mousePose over to editor.js (the only file that uses it), and renamed it to getMousePosition (more logical). (editor.js, script.js)
* Moved the IconList object from script.js to topic.js, as it's only used on topic pages. (script.js, topic.js)
- Removed setInnerHTML/getInnerHTML functions, as they're no longer required. At all. Yes. Also removed smfFooterHighlight because it's an old compat function. We don't care about that. (script.js)
Re: New revs
« Reply #388, on November 27th, 2010, 05:13 PM »
rev 302

- Purged everything evil out of theme_copyright. (Subs.php)
* Slight DOM traversing optimizations (on Pete's suggestion.) (ManageAttachments.template.php, ManageBans.template.php)

Arantor

  • As powerful as possible, as complex as necessary.
  • Posts: 14,278
Re: New revs
« Reply #389, on November 27th, 2010, 06:06 PM »
Revision: 303
Author: arantor
Date: 17:05:02, 27 November 2010
Message:
! func_get_args() can't be used as a parameter for a function prior to PHP 5.3.0 (QueryString.php)
----
Modified : /trunk/Sources/QueryString.php



It's a really quirky one, this, but func_get_args() relies on scope, and the scope model changed fairly heavily in 5.3.0 - to a more powerful one. It's to do with the point at which scope is resolved for the function whose arguments you're getting. Downside is that for < 5.3, you have to push it into a variable first.
Plugin revs »