New revs
Plugin revs »

Arantor

  • As powerful as possible, as complex as necessary.
  • Posts: 14,278
Re: New revs
« Reply #255, on October 15th, 2010, 10:26 AM »
Revision: 209
Author: arantor
Date: 08:49:41, 15 October 2010
Message:
! Added flag to the manage languages page (ManageServer.php)
! Clarified that the language name is clickable (ManageSettings.english.php)
----
Modified : /trunk/Sources/ManageServer.php
Modified : /trunk/Themes/default/languages/ManageSettings.english.php

Posted: October 15th, 2010, 09:50 AM

Revision: 210
Author: arantor
Date: 09:06:09, 15 October 2010
Message:
- Remove legacy GIF support (detailed-version.js, Class-Graphics.php, Subs-Graphics.php)
----
Deleted : /trunk/Sources/Class-Graphics.php
Modified : /trunk/Sources/Subs-Graphics.php
Modified : /trunk/other/xml/detailed-version.js

Posted: October 15th, 2010, 10:06 AM

Revision: 211
Author: arantor
Date: 09:26:06, 15 October 2010
Message:
! Attachments now have .ext extensions by default to ensure they are not treated as ASCII files accidentally. (Subs.php)
----
Modified : /trunk/Sources/Subs.php
When we unite against a common enemy that attacks our ethos, it nurtures group solidarity. Trolls are sensational, yes, but we keep everyone honest. | Game Memorial

Nao

  • Dadman with a boy
  • Posts: 16,082
Re: New revs
« Reply #256, on October 15th, 2010, 10:28 AM »
(Maybe I should do that .ext thing for AeMe as well...)

Arantor

  • As powerful as possible, as complex as necessary.
  • Posts: 14,278
Re: New revs
« Reply #257, on October 15th, 2010, 03:04 PM »
Revision: 212
Author: arantor
Date: 12:39:21, 15 October 2010
Message:
! Being bold.
 ! The info center is now its own template file. (BoardIndexInfoCenter.template.php)
 ! The board index and info center have been broken down into smaller subtemplates and called as a group. (BoardIndex.php, BoardIndex.template.php, BoardIndexInfoCenter.template.php)
----
Modified : /trunk/Sources/BoardIndex.php
Modified : /trunk/Themes/default/BoardIndex.template.php
Added : /trunk/Themes/default/BoardIndexInfoCenter.template.php

Posted: October 15th, 2010, 01:39 PM

I do sort of want to break up the board index and message index into a board listing template; the code used between the two is identical except for spacing only and the initial foreach.

If I break them off into a new function which accepts an array (by reference) of boards, then foreachs through that array, we can cut the size of the board and message indexes down, and have them share the board listing code.
Posted: October 15th, 2010, 01:41 PM

Revision: 213
Author: arantor
Date: 13:25:44, 15 October 2010
Message:
! More cleanup now we know GD2 must be available (Subs-Graphics.php)
----
Modified : /trunk/Sources/Subs-Graphics.php

Posted: October 15th, 2010, 02:26 PM

Revision: 214
Author: arantor
Date: 13:44:05, 15 October 2010
Message:
! Doc additions, cleanups (Help.php, Subs-Graphics.php)
----
Modified : /trunk/Sources/Help.php
Modified : /trunk/Sources/Subs-Graphics.php

Posted: October 15th, 2010, 02:44 PM

Revision: 215
Author: arantor
Date: 14:04:03, 15 October 2010
Message:
! Announcement sending now in its own files instead of bulking up the Post files (index.php, Post.php, Post.template.php, Announce.php, Announce.template.php)
----
Added : /trunk/Sources/Announce.php
Modified : /trunk/Sources/Post.php
Added : /trunk/Themes/default/Announce.template.php
Modified : /trunk/Themes/default/Post.template.php
Modified : /trunk/index.php

Nao

  • Dadman with a boy
  • Posts: 16,082
Re: New revs
« Reply #258, on October 15th, 2010, 04:56 PM »
rev 216
* Minor spacing, and French translation. (Post.php, Subs-Graphics.php, ManageSettings.french.php)

(Well, it just means I'm done reviewing your commits :P)

BTW, why call the new file BoardIndexInfoCenter.template.php, rather than just InfoCenter.template.php? I know it's only initialized in the board index, but still... It could be recycled, couldn't it?

(I'm all for removal of recycled code, BTW!)

Arantor

  • As powerful as possible, as complex as necessary.
  • Posts: 14,278
Re: New revs
« Reply #259, on October 15th, 2010, 04:58 PM »
I did think about that, but it's tied to BoardIndex.php right now, since BoardIndex() gets all the stats, birthdays, recent posts, calendar entries, online folks etc to make it work.

The only way we could reasonably separate it and make it stand alone like that would be to make a InfoCenter.php, with InfoCenter(), which could be called from BoardIndex.php (or, notionally, Subs-BoardIndex.php) to get the information. Thing is you could have this subsidiary function manage the changes to the template list, as well as loading the other template, meaning BoardIndex would be 99% just for the board index itself (which would be neat)

Nao

  • Dadman with a boy
  • Posts: 16,082
Re: New revs
« Reply #260, on October 16th, 2010, 11:46 AM »
rev 217
* Updated to SMF rev 10171, and hacked my own style into the changes. (changelog.txt, tools folder, ManagePaid.php, Profile-Modify.php, Profile-View.php, Subs.php, ie6.css, ie7.css, index.css, GenericMenu.template.php, Post.template.php, Profile.template.php, editor.js)
- Since we're not upgrading from SMF1, removed the dont_repeat_theme_core process in install/upgrade. Kept the equivalent smiley upgrade process for now, because we may need that code for the SMF2->Wedge converter. (install_2-0.sql, upgrade_2-0.sql)
* Improved visuals for the search highlight class. (index.css)
* Improved Wedge logo. Not perfect... But better. (wedgelogo.png)

I postponed work on <div class="content"> until I was done with SMF.
I'll get started today... Will probably commit in several batches because I doubt I'll be finished today.
Posted: October 16th, 2010, 11:44 AM
Quote from Arantor on October 15th, 2010, 04:58 PM
I did think about that, but it's tied to BoardIndex.php right now, since BoardIndex() gets all the stats, birthdays, recent posts, calendar entries, online folks etc to make it work.
We could simply add a comment in InfoCenter.template.php stating that this is called from within BoardIndex()... No?

Arantor

  • As powerful as possible, as complex as necessary.
  • Posts: 14,278
Re: New revs
« Reply #261, on October 16th, 2010, 12:08 PM »
I'm in the midst of polishing up the Bad Behavior implementation (for stopping bad bots and spammers) and won't commit until I'm all done because it's pretty intricate - also means I probably won't review those patches until I'm ready to commit.

Seems to me there's a lot of purely style tweaks when the dev time would be better spent fixing bugs.

Nao

  • Dadman with a boy
  • Posts: 16,082
Re: New revs
« Reply #262, on October 16th, 2010, 01:23 PM »
Looking at the logs, 99% of what Antechinus does is style tweaks and template fixes. That's basically all he's been doing since the beginning -- visual tweaks. I know I'm doing a lot of these too, as it's one of my favorite things to do, but I'm not that focused...!
Norv does the converter stuff (I ain't importing that, though.) and hasn't committed anything interesting the last 3 weeks. Same for SiNaN, pretty much.
Uh...

"content" is going at a good pace but I'm currently stuck on a styling dilemma with the Display template. I'm crazy enough to spend time trying to fix a single pixel.

Arantor

  • As powerful as possible, as complex as necessary.
  • Posts: 14,278
Re: New revs
« Reply #263, on October 16th, 2010, 03:46 PM »
Ahtalkanus is allegedly on the team as a designer and by his own admission is not a strong programmer.

Norv's had commit rights to the converters branch since even before I left the team, which I thought was somewhat awkward.

As for the display template, I've been trying to figure out how I want to split that up since I think it does need to be split up.

Nao

  • Dadman with a boy
  • Posts: 16,082
Re: New revs
« Reply #264, on October 16th, 2010, 06:19 PM »
Quote from Arantor on October 16th, 2010, 03:46 PM
Ahtalkanus is allegedly on the team as a designer and by his own admission is not a strong programmer.
That's to his credit then, but I'm not as fine with the team hiring non-devs to do dev work.
I mean, why didn't they just invite Bloc instead? He wrote Curve in the first place, he can fix it! Ante's main achievement on Curve was... What? Adding more markup?
Quote
As for the display template, I've been trying to figure out how I want to split that up since I think it does need to be split up.
Well, it does. At the very least, we should elaborate on how we implement templating for floating topics.

Arantor

  • As powerful as possible, as complex as necessary.
  • Posts: 14,278
Re: New revs
« Reply #265, on October 16th, 2010, 06:34 PM »
Note the reason Ahtalkanus has a Dev badge as opposed to a Core Dev badge, that's the principle difference. That, and that Dev rather than Core Dev was also TE's position for a long time as he looked after converters rather than the core.

Interestingly Bloc used to be on the dev team, with a Dev (rather than Core Dev) badge when he initially designed Curve.

Nao

  • Dadman with a boy
  • Posts: 16,082
Re: New revs
« Reply #266, on October 17th, 2010, 02:18 PM »
All right... Makes more sense when said this way.
Posted: October 16th, 2010, 07:09 PM
Quote from Nao/Gilles on October 16th, 2010, 01:23 PM
"content" is going at a good pace but I'm currently stuck on a styling dilemma with the Display template. I'm crazy enough to spend time trying to fix a single pixel.
Fixed dilemma yesterday. Didn't get to commit any batch. That's because it's moving at a faster pace than I expected... I just finished doing all instances :) Even had time to fix hundreds of indentation bugs, as well as a few other bugs. (http://dev.simplemachines.org/mantis/view.php?id=4505#bugnotes)
Will commit today, but I'll need to review all of my fixes first... (Ah ah, more fun. I'm so tired.)
Re: New revs
« Reply #267, on October 17th, 2010, 04:40 PM »
Revision: 218
Author: nao
Date: 16:37:00, dimanche 17 octobre 2010
Message:
* Introducing a new favicon and associated logo. (favicon.ico, wedgelogo.png)
! Uppercase $_POST is duh. (PersonalMessage.php, PersonalMessage.template.php)
! Fixed a Javascript exception when clicking an editor button under Opera. (script.js)
* Board lists in BoardIndex and MessageIndex weren't clearly targeted in index.css (BoardIndex.template.php, MessageIndex.template.php, index.css)
* Various spacinazi and minor fixes. (BoardIndexInfoCenter.template.php, GenericMenu.template.php, PersonalMessage.template.php)
! A user's list of posts should show the Delete/Quote/etc. buttons next to their title, rather than below the message, for consistency reasons. (Profile.template.php)
! Fixed two validation errors. (index.template.php)
- Deleted all .content occurrences, as they no longer were needed. Fixed dozens of indenting and spacing issues in the process. (ssi_examples.php, ie6.css, rtl.css, index.css, Templates: Admin, BoardIndex, Display, ManageAttachments / Bans / Boards / Calendar / Mail / Maintenance / Membergroups / Members / News / Paid / Permissions / ScheduledTasks / Search / Smileys, MessageIndex, Packages, PersonalMessage, Post, Profile, Recent, Register, Reports, Search, SendTopic, SplitTopics, Stats, Themes, Who)
----
Modified : /trunk/Sources/PersonalMessage.php
Modified : /trunk/Themes/default/Admin.template.php
Modified : /trunk/Themes/default/Announce.template.php
Modified : /trunk/Themes/default/BoardIndex.template.php
Modified : /trunk/Themes/default/BoardIndexInfoCenter.template.php
Modified : /trunk/Themes/default/Display.template.php
Modified : /trunk/Themes/default/GenericMenu.template.php
Modified : /trunk/Themes/default/ManageAttachments.template.php
Modified : /trunk/Themes/default/ManageBans.template.php
Modified : /trunk/Themes/default/ManageBoards.template.php
Modified : /trunk/Themes/default/ManageCalendar.template.php
Modified : /trunk/Themes/default/ManageMail.template.php
Modified : /trunk/Themes/default/ManageMaintenance.template.php
Modified : /trunk/Themes/default/ManageMembergroups.template.php
Modified : /trunk/Themes/default/ManageMembers.template.php
Modified : /trunk/Themes/default/ManageNews.template.php
Modified : /trunk/Themes/default/ManagePaid.template.php
Modified : /trunk/Themes/default/ManagePermissions.template.php
Modified : /trunk/Themes/default/ManageScheduledTasks.template.php
Modified : /trunk/Themes/default/ManageSearch.template.php
Modified : /trunk/Themes/default/ManageSmileys.template.php
Modified : /trunk/Themes/default/MessageIndex.template.php
Modified : /trunk/Themes/default/ModerationCenter.template.php
Modified : /trunk/Themes/default/MoveTopic.template.php
Modified : /trunk/Themes/default/Packages.template.php
Modified : /trunk/Themes/default/PersonalMessage.template.php
Modified : /trunk/Themes/default/Post.template.php
Modified : /trunk/Themes/default/Profile.template.php
Modified : /trunk/Themes/default/Recent.template.php
Modified : /trunk/Themes/default/Register.template.php
Modified : /trunk/Themes/default/Reports.template.php
Modified : /trunk/Themes/default/Search.template.php
Modified : /trunk/Themes/default/SendTopic.template.php
Modified : /trunk/Themes/default/SplitTopics.template.php
Modified : /trunk/Themes/default/Stats.template.php
Modified : /trunk/Themes/default/Themes.template.php
Modified : /trunk/Themes/default/Who.template.php
Modified : /trunk/Themes/default/css/admin.css
Modified : /trunk/Themes/default/css/ie6.css
Modified : /trunk/Themes/default/css/index.css
Modified : /trunk/Themes/default/css/rtl.css
Modified : /trunk/Themes/default/images/wedgelogo.png
Modified : /trunk/Themes/default/index.template.php
Modified : /trunk/Themes/default/scripts/script.js
Modified : /trunk/changelog.txt
Modified : /trunk/favicon.ico
Modified : /trunk/other/ssi_examples.php

FYI, this rev saved a total of 22.800 bytes (SVN included, so it's not exactly byte for byte.)
Not much, but still welcome...!
Re: New revs
« Reply #268, on October 17th, 2010, 08:20 PM »
rev 219
* Updated to SMF svn 10185 whatever needed to be updated. *sob* Second time I get my name in the changelog. Also updated French version.
  ! Oops, yet some more formatting cleanup! Nao in action :). And other pedantic stuff. (several files) [Bug 4505]
  * Moved CSS and JavaScript to top. (index template) [Bug 4468]
  ! Fixed an undefined variable in some cases (Subs.php) (Note from Nao: changed the code to avoid using an extra line.)
  ! Some actions were unnecessarily logged. (index.php) [Bug 4465]
  & Who's Online language strings were missing for some actions. (Who.php, Who language file) [Bug 4465]

live627

  • Should five per cent appear too small / Be thankful I don't take it all / 'Cause I'm the taxman, yeah I'm the taxman
  • Posts: 1,670
A confident man keeps quiet.whereas a frightened man keeps talking, hiding his fear.
Plugin revs »