New revs

Arantor

  • As powerful as possible, as complex as necessary.
  • Posts: 14,278
Re: New revs
« Reply #2160, on June 8th, 2013, 08:57 PM »
(6 files, 9KB)

Revision: 2160
Author: arantor
Date: 08 June 2013 19:56:19
Message:
! ext/mysql is officially deprecated. It had to happen sometime, I guess. So, let's use ext/mysqli. It's not so pretty in some places, and has a nicer API in others. At least it only has one function for persistent connections now. (wedge_api.php, install.php, Class-DB.php, ManageMedia.php, QueryString.php, Subs-Template.php)
----
Modified : /trunk/Sources/Class-DB.php
Modified : /trunk/Sources/QueryString.php
Modified : /trunk/Sources/Subs-Template.php
Modified : /trunk/Sources/media/ManageMedia.php
Modified : /trunk/other/tools/wedge_api.php
Modified : /trunk/root/install.php


@ I double checked all the function handling because of the joys of mysqli_* having some functions with a different parameter order. I think it all works now. :angel:
When we unite against a common enemy that attacks our ethos, it nurtures group solidarity. Trolls are sensational, yes, but we keep everyone honest. | Game Memorial

Nao

  • Dadman with a boy
  • Posts: 16,079
Re: New revs
« Reply #2161, on June 8th, 2013, 11:14 PM »Last edited on June 8th, 2013, 11:54 PM
rev 2161 -- To infinity... AND BEYOND!!!
(6 files, 8kb)

+ Added Infinite Scrolling feature to topics. Just keep rolling your mouse wheel until it starts loading the next page! There are still a few bugs, such as video embedding not always working in newly loaded posts, and quick moderation being broken. It's not enough to justify not committing this nice feature, I think. (QueryString.php, Subs-Template.php, index.template.php, script.js, topic.js)

* Defined a new constant, INFINITE, which is set if the page was loaded through infinite mode. I may remove it later, but for now, I think it could be helpful. (QueryString.php)

! In some rare situations (for instance, pages with embedded videos), Wedge could have empty script tags. Dealing with these. (Subs-Template.php)

* Grouping block calls from mini-skeletons in the debug log; seriously, this saves admins from having huge logs in topic pages, although it might be argued that it makes debugging (slightly) harder, but whatever. (Subs-Template.php)

* Translation. I'm late with the other files, I know... (ManageMail.french.php)

@ I can't believe I fully commented my JavaScript for infinite scrolling... What happened to me? ;)

:edit: Forgot to mention script.js (which was committed) -- it adds a check related to infinite scrolling, too.

Arantor

  • As powerful as possible, as complex as necessary.
  • Posts: 14,278
Re: New revs
« Reply #2162, on June 10th, 2013, 03:38 PM »
11 modified, 2 added, 12KB

Revision: 2162
Author: arantor
Date: 10 June 2013 14:37:58
Message:
! Profile area can now use static methods for actions. Thanks live! (Profile.php)

! Since the profile area can do this, notifications doesn't need the helper method. (Notifications.php)

! While we're on the subject, scheduled tasks need similar love (install.sql, ManageScheduledTasks.php, ScheduledTasks.php, Notifications.php, Notifications language files)

! OK, so I was wrong, a function not properly documented in the PHP manual does actually exist. (Class-DB.php)

! Additional styles for the new manage board code as well as the new button icons. @Nao, please feel free to move the change from index.css if you would prefer... I can't immediately name anywhere that input.modify might be useful outside the admin panel but that doesn't mean there isn't somewhere. Also feel free to adjust the yellow to a better blended tone or indeed any other colour you might have that isn't blue, just for the variety of colours, really. Made one change in the admin panel but there are a lot of modify links-which-aren't-buttons-but-semantically-should-be, bah. (index.css, mana.css, modify.png, permissions.png, Admin.template.php)
----
Modified : /trunk/Sources/Class-DB.php
Modified : /trunk/Sources/ManageScheduledTasks.php
Modified : /trunk/Sources/Notifications.php
Modified : /trunk/Sources/Profile.php
Modified : /trunk/Sources/ScheduledTasks.php
Modified : /trunk/Themes/default/Admin.template.php
Added : /trunk/Themes/default/images/buttons/modify.png
Added : /trunk/Themes/default/images/buttons/permissions.png
Modified : /trunk/Themes/default/languages/Notifications.english.php
Modified : /trunk/Themes/default/languages/Notifications.french.php
Modified : /trunk/Themes/default/skins/index.css
Modified : /trunk/Themes/default/skins/mana.css
Modified : /trunk/root/install.sql

Nao

  • Dadman with a boy
  • Posts: 16,079
Re: New revs
« Reply #2163, on June 11th, 2013, 11:22 PM »
rev 2163 -- Some boring maintenance...
(11 files +4-2, 16kb)

* Optimized the new buttons to PNG8, and made them raw-url; as permbutton isn't used anywhere (I suspect it's not as desired..?), it's even less important to embed it, while the modify button, per se, is only found in one place, so let's not clutter the index CSS with more bytes, I'd say... (other/images/buttons/*, images/buttons/*, index.css, mana.css)

* Since the admin area is less bandwidth-critical, I figured that it might not be a complete waste to add hover text over A/X/D radio buttons in the permissions area, clearly indicating what the button is for, without needing to resort to reading the header description again. I know, as I found myself wanting this. The result is about 5% larger, but once gzipped, is only about a hundred bytes larger. (ManagePermissions.template.php, ManagePermissions.language.php)

* URL cutter now uses the Safari 'codepath' for all browsers, as it's shorter, seems more solid and actually works everywhere I tested, so whatever. (index.css)

* Commenazi. (ManagePermissions.php)

* French translation. (Help, ManagePermissions, ManageSettings)

- Removed a now unused style from IE6/7. (extra.ie6.css, extra.ie7.css)
Re: New revs
« Reply #2164, on June 13th, 2013, 08:00 PM »
rev 2164 -- the return of flexbox, can you believe it..?
(5 files, 4kb)

+ Implemented a new technique of my own, CSS-only, flexbox-based, to emulate proper rowspans in Chrome. I'm only targeting this browser, because really, it's the only one that supports my technique, but other than that, it should be flawless. I know, I know, Chrome always has the cool toys... But other browsers should think of getting their stuff to work, shouldn't they..? (sections.css)

! Fixed CSS transitions to auto-prefix 'transform' values (like Wess does on the 'transform' rule itself), as it is still a requirement in Chrome, as odd as it sounds... This is so 2012! (Class-CSS.php)

! Don't run MessageIndex JS code on Display pages, it's a (small) waste of time. Also some commenazi, whatever. (topic.js)

! Fixed AJAX loading icon not, err... loading, in the Zoomedia code. (zoom.css)

* Tweaked disabled buttons in the admin area, as it wasn't easy to notice that they were actually disabled, eh... (mana.css)

Arantor

  • As powerful as possible, as complex as necessary.
  • Posts: 14,278
Re: New revs
« Reply #2165, on June 14th, 2013, 03:09 AM »
(2 files, 1KB)

Revision: 2165
Author: arantor
Date: 14 June 2013 02:09:11
Message:
! When saving a topic-move, the wrong variable was used to generate the notification leading to an incorrect message for non admins. (MoveTopic.php)

! Memberlist search wasn't updated to use the profile fields privacy changes, leading to a database error because of a field that isn't there any more. (Memberlist.php)
----
Modified : /trunk/Sources/Memberlist.php
Modified : /trunk/Sources/MoveTopic.php

Nao

  • Dadman with a boy
  • Posts: 16,079
Re: New revs
« Reply #2166, on June 14th, 2013, 09:33 PM »
rev 2166
(7 files +2, 28kb) (that big?!)

+ Added Dragooon's notification subscriptions code. I don't get what it does, and it's not working for me, but I need it in SVN so that we can fix it later... Also added French translation, fixed some HTML (self-closed tags aren't needed in HTML5, useless $scripturl, using w100 class instead of an inline style, etc.) fixed indentation (spaces used instead of tabs?!), woot. (install.sql, Class-NotifSubscriber.php, Class-NotifSubscription.php, ManagePlugins.php, Notifications.php, Profile.php, Notifications.template.php, Notifications.language.php)

* PHP 5.2.3+ supports is_callable('class::method') (or even the equivalent function_exists) instead of is_callable(array('class', 'method')), so I figured it's best to use the string format, as it's a bit faster to handle internally. (Profile.php)
Re: New revs
« Reply #2167, on June 15th, 2013, 07:27 PM »
rev 2167
(2 files +1, 8kb)

* Moved my 'more' code to the attic. This is the super-short function that creates a 'More' entry in the main menu, on the fly, and populates it with entries that would make the menu span two lines or more. Since we're unlikely to use it anytime soon, might as well commit it there... (attic/Unused-menuMore.js)

* Updated Dailymotion embed code to their iframe-based latest. (Subs-Aeva-Sites.php)

- Removed a couple of video sites (5min, CarPix TV, ClipShack) that are obviously long dead, or at least not reliable enough. Will do more when I have time... (Subs-Aeva-Sites.php)

! Typo in notification code. (Class-Notification.php)
Re: New revs
« Reply #2168, on June 17th, 2013, 12:32 PM »
rev 2168 -- the long-awaited Aeva update! What? No one cared? Okay, okay...
(2 files, 22kb)

! Fixed Aeva embedding to finally work... A year ago, I fixed a problem with URL tags being broken, and in the process I also broke the future embedding of any websites requiring a lookup to work. Added a short hack to completely bypass the need of a variable-length negative lookbehind. (Aeva-Embed.php)

@ I'm starting to think it would probably be better to turn Aeva into some kind of generic engine that allows for users to post embed code from a selection of websites, embed them as such, and just 'protect' them within an iframe.

- Reviewed all of the currently available embed sites, and removed all those that were dead, not responding, or at least no longer working in this setup, or whatever. (Subs-Aeva-Sites.php)

! Fixed Wat.tv embedding, and updated DotSub to actually show captions... Since it's pretty much the selling point of that site, right? (Subs-Aeva-Sites.php)

@ The list: Google Video (sic!), ClipLife, Clipser, Cold-Link, Dv.ouou, Excessif (ooh, that one hurts... Was a great site, added the embed code for myself...), ExposureRoom, Gloria, Glumbert, Grassroots, GrindTv, Guba, iJigg, Joost, JumpCut, MoFile, MotionBox, Mpora TV, Mp3tube, MSN Live (sic! YouTube really won the battle!), Multiply (I want to snag that domain name!), MyNet, MySoccerMedia, MyShows.cn, OnSmash (moved to YouTube hosting on another domain), Passionato (x2), PikNikTube, Putfile, RawVegas (YT hosting too), Revver, ScreenToaster, Seeqpod, ShareView, Sharkle, Slide (can you sell me that domain name, please..?), Space.tv.cctv.com, UOL VideoLog, UUME, vbox7, Vidiac, Vholdr, VidiLife, VSocial (x2), and Yahoo Video HK (they renamed to Yahoo! Screen, and I won't bother to look into this.)

@ Yes, that's nearly 50 dead video sites, accounting for the previous commit.

@ Have a nice trip, Pete!

Arantor

  • As powerful as possible, as complex as necessary.
  • Posts: 14,278
Re: New revs
« Reply #2169, on June 20th, 2013, 07:22 PM »
(1 file, 2KB)

Revision: 2169
Author: arantor
Date: 20 June 2013 18:22:08
Message:
! Debugging information and error information could sometimes be overwritten in the post-process of Who's Online, making it hard to identify bots at times. (Who.php)
----
Modified : /trunk/Sources/Who.php

Nao

  • Dadman with a boy
  • Posts: 16,079
Re: New revs
« Reply #2170, on June 26th, 2013, 11:08 PM »
rev 2170 -- committing whatever is committable in my local install, which is easier said than done right now, uh...
(6 files, 7kb)

* Refactored debug junk area at the bottom of all pages, for several reasons: I wanted it to be shorter (it's now on average 3 lines only), so that infinite scrolling works better for admins, and to be readable when queries were expanded, which wasn't the case until now, uh. (Subs-Template.php, Stats.language.php)

! Fixed potential wrong redirection when expanding/collapsing queries. (ViewQuery.php)

! Fixed plugin CSS caching. Thanks John! (Subs-Cache.php)

* Added another bot to BadBehavior. Per Arantor's suggestion. (Security.php)
Re: New revs
« Reply #2171, on July 3rd, 2013, 03:50 PM »
rev 2171 -- finally got around to cherry-picking this N-th large overhaul of the notifications system...
(12 files, 21kb)

* Large overhaul of the notification system. Notifier is no longer an abstract class, and it provides default actions for all methods. It assumes that your notification is about a forum post, so if you want to notify about a topic, a thought, a media item or whatever else, you'll have to override some of the methods, but it's better than having to override it constantly. (Class-Notifier.php, Notifications.php, notifiers/*, ...)

* Notification::issue parameters were changed; notifier name now comes first (it makes more sense to me), and it expects a string, rather than a notifier object, so just remove weNotif::getNotifier() calls, it's much simpler this way. Also changed order in NotifSubscription::issue, although I have yet to see this function used, so it doesn't matter... (Class-Notification.php, Class-NotifSubscription.php, Like.php, MoveTopic.php, QuickMod.php)

* Notification previews are now prepared entirely within the getPreview method, making it easier for notifier objects to override the default behavior in case the notification isn't related to a topic, or something more complicated is needed. (Class-Notifier.php, Notifications.php, notifiers/Likes.php)

* Notification periodical e-mails should now be in plain text, as desired. (Notifications.template.php)

* Commenazi. (Class-Notification.php, Class-Notifier.php)

! Fixed missing header. (notifiers/Move.php)
Re: New revs
« Reply #2172, on July 3rd, 2013, 03:56 PM »
rev 2172 -- trying to do smaller bits now, easier to deal with...
(2 files, 2kb)

! Semi-fixed a problem with IE10 Desktop Mode in Windows 8. Apparently, this stupid browser (perhaps helped by some external program) tends to drop $.post requests in that particular setup, so I simply ensured it doesn't generate an error when dealing with thoughts, but the only workaround, really, is to emulate IE9 mode, which I can't bring myself to force upon Wedge users, so... Well, whatever. Use Metro mode, or emulate IE9, I don't really care right now, and I'm certainly not going to rewrite all functions to use $.get instead, uh... (Ajax.php)

* Moved debug junk into the footer, rather than below it. I just think it looks best, so... I'm expecting all footers to have an unordered list in them, otherwise it'll break your themes. Okay..? (Subs-Template.php)
Re: New revs
« Reply #2173, on July 3rd, 2013, 04:05 PM »
rev 2173 -- don't fret, I don't have much committable material after that one...
(2 files, 2kb)

! Was still using the min-device-pixel-ratio media query, when I should have been using min-resolution instead, which is fully supported by Wedge... (As in, 'it provides a fallback for it.') Also, IE8 has never supported that particular query, so I'm updating the target browser list. (index.css)

* Mixing .hide classes compresses better than extending them. Should have noticed I wasn't doing the right thing, but... (index.css)

* Moved random_news block to the main content area, right before the linktree. I simply thought that the header was crowded enough as it was, and people would be less likely to notice the extra news block in these conditions. I was so very tempted to remove the feature entirely, but I respect Pete's work on overhauling it! (index.css, skeleton.xml)
Re: New revs
« Reply #2174, on July 8th, 2013, 12:04 AM »
rev 2174
(2 files, 1kb)

! Fixed notification issuing process (wrong method name), broken last week. (Class-Notification.php)

! Several fixes to likes, which were also broken by the same commit... Hmm, 'guess no one tested it..? (notifiers/Likes.php)