Wedge

I'll look at the new style when I'm finished with the attachments UI stuff I've been meaning to do (this ticket)

Revision: 174
Author: arantor
Date: 23:47:48, 01 October 2010
Message:
+ Updated attachment UI. Sort of broken in IE right now though :( (Post.php, Post.template.php, Post.english.php, editor.js)
- Removed cleanFileInput function as no longer necessary (script.js)
----
Modified : /trunk/Sources/Post.php
Modified : /trunk/Themes/default/Post.template.php
Modified : /trunk/Themes/default/languages/Post.english.php
Modified : /trunk/Themes/default/scripts/editor.js
Modified : /trunk/Themes/default/scripts/script.js


When I say it's broken in IE, the error condition isn't right. The <input type="file"> needs to be cleared in the event of an error, which is fine. Now, a type=file is read-only for security reasons but everyone except IE accepts an empty string to clear it.

IE however makes it fully read-only (I have no idea why, that seems pretty stupid to me, when just accepting empty string isn't a security risk), which leaves the only alternative to being removing and replacing the element. This requires adding in spans or divs around the file element that weren't there before (and managing all the sleight of hand required to make it work given all the other stuff going on), and additionally all of the replace methods end up dropping the event handling. Yay, good times.

It can be done, I just don't have the inclination right now to do so.


As for the new style; hmm. The not-quite-black seems too pale, so it's not as striking against the background as perhaps it might be. Looks good otherwise though :)

Nice stuff. Maybe the Remove button could be placed to the left, so that all buttons are aligned? Also, put some padding below the file selector? Something like 4 to 6px would be good...

I thought you were planning to use WebForms (or whatver it's called in HTML5). If it's behaving like Opera's implementation, it allows you to get a lot of information on a file before uploading it... Things like filesize!
I actually planned to use that in Aeva Media, but at the time, Opera was the only browser that supported WebForms, so I gave up. Now it could be possible here.

We could also use YUI Upload to select multiple files from the file selector :PHmm...Well.......... I would gladly help you, but I don't know if you heard, I'm just back from a 2-week vacation in Hell...... :evil:Thanks. It's really HORRIBLE trying to get the lowest common denominator, whatever it's called in English.
I always feel inspired when I hack into my own websites... But Wedge really is something else.

One of the things that annoy me the most is the 50KB css file... Considering that half of that is for special styles from specific pages, it would be nice to have an index.css and an index_extra.css, and then at the time of caching index.css, automatically concatenate both... Would allow me to focus on the main stylesheet file.

---

rev 175
* A couple more improvements to the cat_bar styling. (index.css)
* Spacinazi. (Post.template.php, captcha.js, Stats.template.php)

(I changed the catbar color to something... greener. Tell me if you think it's better?)

Well, AFAIK, doesn't YUI make use of things like Flash? Sure it's doable but I'd hate to make Flash an inherent dependency even for something just like uploading files.

I also wasn't aware that HTML5 contained anything that let you have access to anything useful like the file size, especially since the major browsers can't even agree what the value of a <input type="file"> should be - some browsers only return the basename of the file, some make the full path accessible.:P I just wanted to get it committed, didn't feel up to making it work properly seeing how I cut the number of changes vs the SimpleDesk implementation in half and only made it basically a UI change as opposed to UI+logic change that it so nearly was.It's the right term; trying to find that common theme for everyone is tricky.

rev 176
* More tweaks to the cat_bar style... I'm starting to like it. (index.css)
* Replaced the original Wedge logo with new mockup. SMF for real -- SMF for real men. Ah ah. And women, too. And dogs. And cats. And other minorities. (wedgelogo.png)

Just so that I don't spend a day without committing...  :niark:

Revision: 177
Author: arantor
Date: 14:35:55, 03 October 2010
Message:
+ Provide option for redirect boards opening in new window/tab
 + New column, redirect_newtab added to boards table (install_2-0.sql)
 + New admin option for setting it (ManageBoards.english.php, ManageBoards.php, ManageBoards.template.php, Subs-BoardIndex.php, Subs-Boards.php)
 + Displaying changes (BoardIndex.template.php, MessageIndex.template.php)
----
Modified : /trunk/Sources/ManageBoards.php
Modified : /trunk/Sources/Subs-BoardIndex.php
Modified : /trunk/Sources/Subs-Boards.php
Modified : /trunk/Themes/default/BoardIndex.template.php
Modified : /trunk/Themes/default/ManageBoards.template.php
Modified : /trunk/Themes/default/MessageIndex.template.php
Modified : /trunk/Themes/default/languages/ManageBoards.english.php
Modified : /trunk/other/install_2-0.sql


Revision: 178
Author: arantor
Date: 14:53:21, 03 October 2010
Message:
! Render the time in smaller font on WAP2 (cannot apply to iMode or WAP as neither supports variable height fonts) (Wireless.template.php)
----
Modified : /trunk/Themes/default/Wireless.template.php


Revision: 179
Author: arantor
Date: 17:30:12, 03 October 2010
Message:
! Convert opendir/readdir/closedir to scandir as appropriate (upgrade.php, ManageAttachments.php, ManagePaid.php, ManageSearch.php, PackageGet.php, Packages.php, Post.php, Subs-Package.php, Subs-Post.php, Subs.php)
----
Modified : /trunk/Sources/ManageAttachments.php
Modified : /trunk/Sources/ManagePaid.php
Modified : /trunk/Sources/ManageSearch.php
Modified : /trunk/Sources/PackageGet.php
Modified : /trunk/Sources/Packages.php
Modified : /trunk/Sources/Post.php
Modified : /trunk/Sources/Subs-Package.php
Modified : /trunk/Sources/Subs-Post.php
Modified : /trunk/Sources/Subs.php
Modified : /trunk/other/upgrade.php

You did the scandir stuff? I had assigned it to myself and thought of doing it this month ;)
Well, I guess it'll give me more time for other tasks, eheh.

Yeah, I did. Basically I knew my time would be fragmented today and so doing anything big probably wasn't worth the effort, so I figured I'd look at smaller stuff, and besides, it's more green on the tracker (and I like green) :)

Yeah that's exactly why I was planning to do it as well... My 'big project' is the theme redesign, and all of the philosophy changes that come with it (and you know it's a huge weight on my shoulders. I'm really no designer and I have trouble thinking ahead. Hence why I'm very happy to have Bloc here now :))
Although I wouldn't have called scandir a "smaller" thing, if only because it can't be replaced in an automated manner. (Deleting <div class="content"> won't be easy either. 750+ occurrences, none of them can be automated unless I give up the idea of having proper indentation... I still want to do it at some point, though.)

scandir was a smaller thing, since as you remarked yourself it was only used in a couple of dozen places; a quick search on opendir showed it wouldn't be a big thing to change - and as you can see from the changelog, it wasn't.


Revision: 180
Author: arantor
Date: 20:35:56, 03 October 2010
Message:
- Remove WAP, imode support (index.php, BoardIndex.php, Display.php, ManageBans.php, PersonalMessage.php, Profile.php, Subs-Auth.php, Subs.php, Wireless.template.php)
----
Modified : /trunk/Sources/BoardIndex.php
Modified : /trunk/Sources/Display.php
Modified : /trunk/Sources/ManageBans.php
Modified : /trunk/Sources/PersonalMessage.php
Modified : /trunk/Sources/Profile.php
Modified : /trunk/Sources/Subs-Auth.php
Modified : /trunk/Sources/Subs.php
Modified : /trunk/Themes/default/Wireless.template.php
Modified : /trunk/index.php

rev 181
* Changed redirect_newtab to a bool status -- why waste space on this? (install_2-0.sql)
* Spacinazi and typo killing. (upgrade.php, Class-Editor.php, Profile-Actions.php, Subs.php, GenericList.template.php, Post.template.php, script.js)
+ nobbc tag should be allowed in parse_bbc_inline. (Subs.php)
! A regex in preparsecode() didn't require a return value. Saves about a micro-millisecond of CPU time per day. Think of the trees. (Class-Editor.php)
- Replaced useless javascript:void(0) calls that could easily be replaced with a # as long as the associated onclick() event returns false. (ssi_examples.php, repair_settings.php, smfinfo.php, Subs.php, templates: Help, ManageMembergroups, ManageNews, ManagePermissions, Packages, PersonalMessage, Profile, Search, Themes)
* I believe all of those typeof=undefined and null tests in Javascript are useless and can simply be replaced with a if (var) test as long as var can't take a value of false. (script.js)

----> Pete, you may safely skip the changes in all files (they're minor and double-checked already), but I'd like you to have a look at my changes in script.js... I would hate having added a logic bug. I've tested on my side with Opera and it works. Maybe older IEs will choke on these though...

PS: nothing was committed in the last 3 days...? Wow. I think it's our record. We're going the SMF way ;)

Are you planning to change all the other things that are similarly bools in nature? There is not a single bool amongst SMF's tables, never has been, and in the case of older MySQL versions it is neither smaller, nor faster to do so.

Will take a look at script.js shortly.

I don't know... Should I?
Depends on whatever I find out, I guess...Thanksalot.