New revs
Plugin revs »

Nao

  • Dadman with a boy
  • Posts: 16,082
Re: New revs
« Reply #1860, on January 20th, 2013, 01:24 AM »
rev 1860 -- fixing bugs, and again, and again! Plenty this time.
(5 files, 3kb)

! Finished a fix that was started last October and that I thought was already done... Hopefully it'll work fine now. This is about Wess's mixin feature. Some complex classes destined to be used as mixins would be broken when including them through a 'mixin:' property, rather than the 'mixes' keyword. (Class-CSS.php)

! Switching to Wysiwyg mode could have unwanted effects on whitespace inside quotes. (Subs-BBC.php)

! Changing one's language in the profile would generate an error due to a last remaining $context['user']. (Profile-Modify.php)

! IE7 in Wuthering STILL wasn't working properly... This was because of Microsoft (who else?). For a reason I ignore, when I try to view the page in IE10 using IE7 mode, it still gives me 'IE10 standards mode', instead of IE7 standards mode. And it just so happens that the 'filter' property isn't recognized in IE10 standards mode... (Wuthering/extra.css)

* Modified un_htmlspecialchars() to use htmlspecialchars_decode() for simplicity. (Subs.php)
Re: New revs
« Reply #1861, on January 20th, 2013, 07:38 PM »
rev 1861 -- "a byte is a byte is a byte."
(3 files, 3kb)

+ Added two preg_replaces to the output buffer manager, that will remove the protocol and/or the domain name of any link that don't require it (i.e. they either share the same protocol as the current web page being viewed, or even its domain name.) It saves about 150 gzipped bytes on a regular full topic page (it all depends on the number of links), which is not much, but it also doesn't use more than a few milliseconds of CPU time, so it's a fair trade I'd say. Hasn't been 100% tested but should work. It can always be reversed later, or an admin setting can be set, too. Whatever. (Subs-Template.php)

! Fixed URL shortening when entities were found in them. This also saves an additional 5 gzipped bytes... Yeah, I know, it's boring innit? (script.js)

* Saved about 20 bytes in the editor by using php_unhtmlspecialchars() properly instead of a custom replacement, and removing a code block that did absolutely nothing. I'm annoyed by the useless var declarations in the spellcheck code by the way, but stripping them out actually adds 3 bytes. The joys of gzipping magic... (editor.js)

Arantor

  • As powerful as possible, as complex as necessary.
  • Posts: 14,278
Re: New revs
« Reply #1862, on January 21st, 2013, 01:34 AM »
(5 files, 2KB)

Revision: 1862
Author: arantor
Date: 21 January 2013 00:31:54
Message:
! Use group colours in the manage boards area. (ManageBoards.php)

! News fader items shouldn't be bold by default. The user can stick bold in it if they want, plus the theme can set it, but it shouldn't be forced in the template. (Boards.template.php)

! A few sprinkles of plugin repo bug fixes: session checking, delete actually works, missing image fixed, nothing huge but makes it easier to get on with other plugin related stuff in the meanwhile. (ManagePlugins.php, ManagePlugins.template.php, mana.css)
----
Modified : /trunk/Sources/ManageBoards.php
Modified : /trunk/Sources/ManagePlugins.php
Modified : /trunk/Themes/default/Boards.template.php
Modified : /trunk/Themes/default/ManagePlugins.template.php
Modified : /trunk/Themes/default/skins/mana.css
Re: New revs
« Reply #1863, on January 21st, 2013, 01:23 PM »
(6 files, 24KB)

Revision: 1863
Author: arantor
Date: 21 January 2013 12:22:11
Message:
! Bug in FTP clean-up when a connection wasn't possible. Not the cleanest, but the safest. (Class-FTP.php)

! Next stage of plugin uploading, getting and validating FTP details. Still WIP in every respect. (index.php, ManagePlugins.php, Subs-Plugins.php, ManagePlugins.template.php, ManagePlugins language file)
----
Modified : /trunk/Plugins/index.php
Modified : /trunk/Sources/Class-FTP.php
Modified : /trunk/Sources/ManagePlugins.php
Modified : /trunk/Sources/Subs-Plugins.php
Modified : /trunk/Themes/default/ManagePlugins.template.php
Modified : /trunk/Themes/default/languages/ManagePlugins.english.php
When we unite against a common enemy that attacks our ethos, it nurtures group solidarity. Trolls are sensational, yes, but we keep everyone honest. | Game Memorial

Nao

  • Dadman with a boy
  • Posts: 16,082
Re: New revs
« Reply #1864, on January 21st, 2013, 11:53 PM »
rev 1864 -- Wysiwyg gets some love!! Until Pete decides to ditch it :P
(18 files, 11kb)

+ Bringing proper Wysiwyg support for iOS and Android (stock and whatever), as long as they're not ancient versions. Only Firefox <3.5 and Opera Mini are not compatible. Also removed the fallback to contenteditable, because really, if you use a browser that's too old for that trick, you don't even know what 'Wysiwyg' means. You probably don't even know that you can register on forums and post messages, not just read them. (Class-Editor.php, editor.js)

! Fixed smiley and link insertion regression in Wysiwyg mode, due to an oversight (I didn't immediately see that iMoveCursorBack could have a value of zero. If you're not following, don't worry, it's intentional.) (Class-Editor.php)

* Simplified Wysiwyg processing. If your browser doesn't support it, you won't get an error message -- Wedge will simply no longer show the switcher icon. Also, if BBC is disabled, Wysiwyg is now disabled directly from within the editor code, rather than external files. (Class-Editor.php, PersonalMessage.php, Post.php, editor.js, LANGUAGE: index, Post)

* Rewrote Wysiwyg CSS handling. Finally, clicking at the bottom of the pseudo-textarea will properly move the cursor to the end of the text! Things like that... Also shortened and simplified many variable names, for logic reasons (isWysiwyg and canWysiwyg come to mind) and better compression overall. (Class-Editor.php, editor-func.js, editor.js, post.js, topic.js)

* Simplified editor CSS. Most notably, I replaced the browser-based variable declarations with @if's. It isn't any faster or more efficient or whatever -- it's just easier to understand. Originally I mostly used these variables to show that they can be used not only as values, but also as property-value pairs. (editor.css, extra.ie6.css, extra.ie7.css, extra.ie8.css, index.member.css)

* Language! (index.french.php, Post.french.php, Errors.french.php)

* Some breathing space. (Post.template.php)

Arantor

  • As powerful as possible, as complex as necessary.
  • Posts: 14,278
Re: New revs
« Reply #1865, on January 22nd, 2013, 01:42 AM »
(2 files, 1KB)

Revision: 1865
Author: arantor
Date: 22 January 2013 00:41:19
Message:
! Only show the reorder pinned option when there's something to reorder. (MessageIndex.php)

! New method for FTP, to call for raw lists of information. (Class-FTP.php)
----
Modified : /trunk/Sources/Class-FTP.php
Modified : /trunk/Sources/MessageIndex.php
Re: New revs
« Reply #1866, on January 22nd, 2013, 05:59 AM »
(4 files, 12KB)

Revision: 1866
Author: arantor
Date: 22 January 2013 04:55:23
Message:
! Go up function for FTP. (Class-FTP.php)
! Some minor reorganisation and moving towards plugin uploads; there is a chunk of the code required to deactivate an existing plugin, delete it and prepare to upload a new one in its place. There is also sufficient code, in theory, to get through parsing and creating all the folders in the zip file,[1] but to quote Bachman Turner Overdrive, You Ain't Seen Nothin' Yet. (ManagePlugins.php, Subs-Plugins.php, ManagePlugins language file)
----
Modified : /trunk/Sources/Class-FTP.php
Modified : /trunk/Sources/ManagePlugins.php
Modified : /trunk/Sources/Subs-Plugins.php
Modified : /trunk/Themes/default/languages/ManagePlugins.english.php
 1. This is such an arse-pain because zip files don't enforce proper hierarchy. It's actually one long standing bug in SMF that certain zip file builders will leave out top level folders when preparing the file, e.g. it'll add /folder/file.txt but not create an entry for /folder/ as an actual folder entry in the directory header. Windows, I'm looking at you. So I have to manually parse every filename looking for folder names.
Re: New revs
« Reply #1867, on January 23rd, 2013, 12:49 AM »
(17 modified, 3 deleted, 5KB even though it's far more than a straight 5KB of changed code!)

Revision: 1867
Author: arantor
Date: 22 January 2013 23:47:45
Message:
! Removal of a lot of the old package server. There's some stuff relating to the file permissions and the downloading of plugins that might still be useful, but other than that, it can go. There may well be other legacy stuff that hasn't been excised yet, but that's mostly because this is a big and scary process and there's a lot of stuff with tendrils in the packman code. I did also take the liberty of hacking bits up in the old packman just while it's hanging around, so that I could remove other traces (e.g. converting lang string to normal inline strings so I could remove the actual language strings - any weirdness should be essentially ignored for now) (install.sql, Admin.php, ManageServer.php, PackageGet.php, Packages.php, Subs-Package.php, Packages.template.php, language files: Admin, Errors, Help, Modlog, Packages)
! Removed now legacy images. (package_ops.gif, package_installed.gif, package_old.gif)
----
Modified : /trunk/Sources/Admin.php
Modified : /trunk/Sources/ManageServer.php
Modified : /trunk/Sources/PackageGet.php
Modified : /trunk/Sources/Packages.php
Modified : /trunk/Sources/Subs-Package.php
Modified : /trunk/Themes/default/Packages.template.php
Deleted : /trunk/Themes/default/images/admin/package_ops.gif
Deleted : /trunk/Themes/default/images/icons/package_installed.gif
Deleted : /trunk/Themes/default/images/icons/package_old.gif
Modified : /trunk/Themes/default/languages/Admin.english.php
Modified : /trunk/Themes/default/languages/Admin.french.php
Modified : /trunk/Themes/default/languages/Errors.english.php
Modified : /trunk/Themes/default/languages/Errors.french.php
Modified : /trunk/Themes/default/languages/Help.english.php
Modified : /trunk/Themes/default/languages/Help.french.php
Modified : /trunk/Themes/default/languages/Modlog.english.php
Modified : /trunk/Themes/default/languages/Modlog.french.php
Modified : /trunk/Themes/default/languages/Packages.english.php
Modified : /trunk/Themes/default/languages/Packages.french.php
Modified : /trunk/root/install.sql

Nao

  • Dadman with a boy
  • Posts: 16,082
Re: New revs
« Reply #1868, on January 23rd, 2013, 12:33 PM »
rev 1868
(9 files, 6kb)

+ New linktree for Warm skin. This is located somewhere between the sobriety of Weaving and extravagance of Wuthering. Not 100% happy with it. I think that design is better suited to Weaving than Warm, but we're trying to keep Weaving simple. Suggestions welcome. (Warm/extra.css)

* Also decided to go for Open Sans font in Warm, instead of Tahoma. What do you know, it's a warmer font after all. Needs adjustments. (Warm/extra.css, Warm/skin.xml)

! Fixed a DOM validation error. (Search.template.php)

! Safari 5 doesn't seem to like text-indent. Found an alternative hack for it... If you find the reason why the original doesn't work, please contact me. (index.css)

* %1$s isn't a string that JavaScriptEscape needs to modify. :) (Boards.template.php)

* Cleaned up comments. (index.template.php, ManagePlugins.template.php, Warm/skin.xml)

* Gzinazi. That means I'm saving bytes. (Wuthering/extra.css)

* Translation. (ManagePlugins.french.php)
Re: New revs
« Reply #1869, on January 23rd, 2013, 03:05 PM »
rev 1869
(15 files, 21kb)

* Doing my share to help with the packman removal... So, removed log_packages-related code. Also silly comments. (readme_install.html, readme_update.html, readme_upgrade.html, sphinx_config.php, smfinfo.php, upgrade.php, upgrade.sql, install.sql, Class-DBPackages.php, PackageGet.php, Subs-Package.php, extra.rtl.css, mana.css)

+ Added Home language files and fixed Homepage to match what you're seeing on Wedge.org right now. This mostly allows me to keep the file out of its 'ignore' changelist, which is a bit confusing to me. (Home.template.php, Home.english.php, Home.french.php)
Re: New revs
« Reply #1870, on January 23rd, 2013, 03:25 PM »
rev 1870
(2 files, 2kb)

! Forgot to upload the Homepage in last commit. (Home.template.php)

* Tweaked Android icon to be less squarey and easier to see. It uses 5 more bytes... Bite me. (android.gif)
Re: New revs
« Reply #1871, on January 24th, 2013, 06:12 PM »
rev 1871
(7 files, 5kb)

! Wedge wasn't recording the OS name and version in CSS filenames, contrary to what it was supposed to do. This caused some issues, notably Safari for Windows stylesheets being shared with iPhone stylesheets... Not a good idea! (Subs-Cache.php)

! Fixed inconsistent padding around linktree elements. This was due to a classic: whitespace between them... Reminds me that it's best to remove whitespace when possible. It saves bytes in the end, and avoids silly issues like this one. Well, at least when an element is likely to have its display type changed to block or inline-block or inline depending on the skin... (index.template.php, Warm/extra.css)

! Various fixes for Warm, mostly due to Open Sans Bold not looking really good. It's best to just focus on using Open Sans in its regular weight... (Warm/extra.css)

- Removing Optima from fallback fonts -- it looks ugly in iOS. Also removing PT Sans from all stylesheets: I should tell you that I'd installed the font manually on my PC and I can't expect people to be happy with a design I'm not seeing (i.e. the fallback font I'm never seeing.) (common.css, Wine/common.css, Wine/extra.css)

* Home language file wasn't using UTF8. (Home.french.php)
Re: New revs
« Reply #1872, on January 24th, 2013, 10:57 PM »
rev 1872 - the Aeva Media fix commit. Keep 'em coming!
(3 files, 3kb)

! Fixed that annoying little bugger of a bug that prevented documents (including compressed files) from being marked as read just by visiting their item page in the Media gallery. I'm afraid this bug is also in Aeva Media for SMF (all versions), and I promised myself never to update it, so it's a bit of a... bugger, again. Well, I guess I'll have to do it at some point. I'm starting to wonder if people are aware that I don't read the AeMe topic at sm.org and that if they want to report bugs, they should do it on wedge.org...?! (Subs-Media.php)

! Marking the last Unseen Media page as seen would redirect you to an empty page, instead of the last available page of unseen items. (Aeva-Gallery2.php)

* I don't like h4 being bold either. I probably should unbold all header tags while I'm at it... (Warm/extra.css)

Arantor

  • As powerful as possible, as complex as necessary.
  • Posts: 14,278
Re: New revs
« Reply #1873, on January 24th, 2013, 11:28 PM »
(4 files, 8KB)

Revision: 1873
Author: arantor
Date: 24 January 2013 22:28:19
Message:
! Banned users could throw an error if they had made a post previously. (Display.template.php, index language file)

! More of the ban UI, it can now pull a ban in the DB into the editing form. Just saving to go, really. (ManageBans.php, ManageBans.template.php)
----
Modified : /trunk/Sources/ManageBans.php
Modified : /trunk/Themes/default/Display.template.php
Modified : /trunk/Themes/default/ManageBans.template.php
Modified : /trunk/Themes/default/languages/index.english.php

Nao

  • Dadman with a boy
  • Posts: 16,082
Re: New revs
« Reply #1874, on January 26th, 2013, 05:56 PM »
rev 1874 - iPad and JS lang fixes.
(5 files, 5kb)

! The language string integration for JS files was no longer working, not sure why... This relatively extensive rewrite of the feature should work. (Subs-Cache.php)

! iPads and Android tablets have a high enough resolution to handle any skin without going through the Wireless skin by default. So I'm removing them from the is_mobile test. Note that I could do a better job at searching for tablets... Right now it'll only find those Android tablets that follow Google's standards. (Class-System.php)

* iPads shouldn't go through the 'big font' path that is given to all iOS devices. (extra.ios.css)

! The gradient pseudo-rule in Wess wouldn't accept anything else than "top" and "left" as its third optional parameter, when it should have accepted any angles to "to left", etc... Fixed it to just mindlessly reproduce what you're putting in it. (Class-CSS.php)

* Translation. (index.french.php)
Plugin revs »