New revs
Plugin revs »

Nao

  • Dadman with a boy
  • Posts: 16,082
Re: New revs
« Reply #1755, on October 31st, 2012, 11:04 PM »
rev 1755
(5 files, 3kb)

! Undefined gender would appear as female in the user status box. (Display.template.php)

! Fixed moderators not getting the proper IP tracking link in the user mini-menus. (Display.php)

! Wess is a bit lazy when it comes to parenthesis matching in math() formulas. So, something like (math(...)) would fail. I hacked a half-arsed solution by offering the ability to surround the function in quotes to remove the ambiguity, i.e. ("math(...)"), so if you ever get a parsing error, just add the damn quotes. Sorry about that... (Class-CSS.php)

! Preventing overflows around generic button strips. Well -- it happens, so I'm simply extending .clearfix into the containers. (sections.css, Reports.template.php)
Re: New revs
« Reply #1756, on November 1st, 2012, 12:51 AM »
rev 1756 -- hopefully Private Alpha material!! :)
(7 files +2-4, 12kb)

* Now showing user status box instead of online button in PM user boxes. Wouldn't have been as easy without Wedge's skeleton system... :) (PersonalMessage.php, PersonalMessage.template.php)

* Many CSS tweaks.
  * Header font is now Segoe UI Light by default. What do you know. I just like it. To hell if it doesn't look great on older browsers. Use a nice one. (common.css)
  - Warm posts now use Tahoma by default, and Segoe UI in italic and bold modes (Tahoma only has the dull straight version). Also fixed padding above footer in responsive mode. (Warm/extra.css)
  - Removed unused ID from Wuthering, fixed popup alignment (due to the body being centered), fixed overflow issues. (Wuthering/extra.css)
  ! A few browser specific fixes. (Wine/extra.css)
  @ IE 6/7 are still broken in many areas... I think. They'll be fixed for the public alpha or something, I guess. Why do I no longer care these days..?

* Removed minilogo and minilogow (not used anywhere..?), replaced webelow and webelowine with wefoot1 and wefoot2 (slightly improved versions of the footer logos.) (images/*.png)

* Shortened PM popup code (in index template) by two bytes. Well, say() no longer needs an event object to be specified when you include a callback... (index.template.php)

* Tweaked index template to keep it from outputting wedge.org-specific data on non-worg websites. It's a hack, but you understand we're going to move that code over to a plugin anyway...? Eventually. Peeeete? Can you help? (index.template.php)
Re: New revs
« Reply #1757, on November 1st, 2012, 12:58 AM »
rev 1757
(2 files, 1kb)

! Last-minute typo. © 2012 Nao/Gilles. (index.template.php)

* Forgot to commit common.css. (common.css, obviously.)
Re: New revs
« Reply #1758, on November 1st, 2012, 01:25 AM »
rev 1758
(2 files, 1kb)

! Fixed ask() and say() not working correctly when providing just a callback function. (script.js)

! Doing an extra test on $_SERVER['REQUEST_URL']. It should NOT be needed... But I noticed an undefined index error in my log. Let's just say it's a free extra test anyway. (Subs-Template.php)
Re: New revs
« Reply #1759, on November 1st, 2012, 08:43 AM »
rev 1759
(1 file +11-10, 3kb)

* Moved all other/ files intended to be at the root, in a root/ folder. This should clear up some of the confusion... Hopefully. And help me release a private alpha in less than 20 minutes. (other/, root/*)

! Fixed linktree padding in Warm. (Warm/extra.css)

+ Initial changelog placeholder. (root/changelog.txt)
Re: New revs
« Reply #1760, on November 1st, 2012, 09:09 AM »
rev 1760
(1 file, 1kb)

! Fixed thought system getting broken when using the keyboard. Note to self: using a type=submit and a return false in its handler is critical to correct keyboard implementations. (script.js)

Arantor

  • As powerful as possible, as complex as necessary.
  • Posts: 14,278
Re: New revs
« Reply #1761, on November 2nd, 2012, 09:34 PM »
(4 files, 2KB)

Revision: 1761
Author: arantor
Date: 02 November 2012 20:33:18
Message:
! Certain things were inserted twice in the verification process, also there was an extra space. (GenericControls.template.php)

! Oops, stupid parameter missed from custom field creation. (ManageMemberOptions.php)

! Reserved names code was broken, mostly because I managed to remove the form variable back in r347. (ManageRegistration.php, Register.template.php)
----
Modified : /trunk/Sources/ManageMemberOptions.php
Modified : /trunk/Sources/ManageRegistration.php
Modified : /trunk/Themes/default/GenericControls.template.php
Modified : /trunk/Themes/default/Register.template.php
When we unite against a common enemy that attacks our ethos, it nurtures group solidarity. Trolls are sensational, yes, but we keep everyone honest. | Game Memorial

Nao

  • Dadman with a boy
  • Posts: 16,082
Re: New revs
« Reply #1762, on November 2nd, 2012, 09:38 PM »
rev 1762
(5 files -1, 4kb)

- Opera 12.10' latest RC finally fixed the selectionStart bug (http://my.opera.com/desktopteam/blog/2012/11/01/opera-12-10-rc1) I'd reported to them months ago. So the editor no longer requires my handy little workaround, and I can safely remove it. Although it means older versions will have the problem again, I'd rather not worry about these: most Opera users will usually stick to the latest version anyway. Power users, things like that. (editor.js)

! Fixed regression where member management wasn't correctly triggering moderation actions. (ManageMembers.php)

! ul.buttonlist was still not handled correctly. Needed an extra clearfix... Maybe it's a bit overkill though? (sections.css)

- Removed useless styling. (Wine/extra.css)

* Moved changelog from root/ to root (/) folder. I love it when I don't make sense... Anyway, the root/ folder is only meant for files that shouldn't overwrite root files on upgrade. Removed feature list because it's the SMF 1.1 version... We don't need that. (changelog.txt, features.txt)
Re: New revs
« Reply #1763, on November 3rd, 2012, 11:03 AM »
rev 1763
(5 files, 3kb)

! Fixed terrible layout in admin's member search form. Also removed empty values, I'm not sure what they were there for. (ManageMembers.template.php, mana.css)

! Fixed homepage thought buttons (Modify/Delete/Reply) not working correctly for non-admins. At the cost of 4 extra gzipped bytes, although the code is a bit shorter... Don't ask too much of that magical tool. (script.js)

* Won't get fooled again... If someone steps up and writes a custom error message when you try to register a new member with the same name as a membergroup (rather than an existing member). Well, I don't have time for that, so here's just the !! reminder comment... (Subs-Members.php)

! Actually, that extra space was simply misplaced, rather than unneeded. (GenericControls.template.php)
Re: New revs
« Reply #1764, on November 3rd, 2012, 04:20 PM »
rev 1764
(4 files, 5kb)

- Removed support for viewResults variable in polls, it was only for old SMF templates anyway. The variable is currently 'viewresults'. (Display.php)

! Fixed (again!) the viewresults button. In rev 1533, I fixed it to be hidden when actually showing results (a SMF bug). This time, I'm also ensuring that it doesn't show up at all if you don't have permission to view results in the first place (i.e. poll option is set to only show the results after voting.) Another SMF bug, if the devs over there want to fix it they can ask me for the modified line of code ;) (Display.php)

! Fixed guest showPosts when viewed by a guest. Because previously, Wedge would try to load the profile user info, fail, then load the current user info instead, then fail, and refuse to show anything. It's best to just skip most of the profile loading (including the menus) and instead focus on showing posts. Also, IIRC 'moderate_forum' as a permission implies access to all boards, so I'll be using that as a shortcut too. Maybe I should be using 'is_admin'..? (Display.php, Profile-View.php, Profile.php)

! Don't bother to show user status icons for guests... (Display.template.php)
Re: New revs
« Reply #1765, on November 3rd, 2012, 05:40 PM »
rev 1765
(7 files, 3kb)

! Fixed help popup z-index regarding objects below it. (index.css)

* Added group colors to membergroup list in admin permission page. The data was retrieved, I'm not sure why it wasn't shown in the first place... (ManagePermissions.template.php)

* Moved most of the output buffer reset code to its own function, clean_output(), which takes only one parameter to force (=true) disabling the ob_sessrewrite buffer. Mainly doing this to simplify things for modders. (Feed.php, Like.php, ManageMedia.php, Subs-Template.php, ViewRemote.php)

! Fixed media permission profile page's album list link. It was broken due to incorrect Ajax handling. (ManageMedia.php)

Arantor

  • As powerful as possible, as complex as necessary.
  • Posts: 14,278
Re: New revs
« Reply #1766, on November 3rd, 2012, 09:06 PM »
(6 files, 3KB)

Revision: 1766
Author: arantor
Date: 03 November 2012 20:05:50
Message:
! Temporary workaround for permissions bug as reported by Dr Deejay - anything that goes into ask/say can't have quotes in it. (ManagePermissions language file)

! Upgraded BB to 2.2.11. (Security.php)

! Add countdown for admin timeout. It's not exactly pretty but I'm happy with it for the moment. (Admin.php, Admin.template.php, Admin language file)
----
Modified : /trunk/Sources/Admin.php
Modified : /trunk/Sources/Security.php
Modified : /trunk/Themes/default/Admin.template.php
Modified : /trunk/Themes/default/languages/Admin.english.php
Modified : /trunk/Themes/default/languages/ManagePermissions.english.php
Modified : /trunk/Themes/default/languages/ManagePermissions.french.php

Nao

  • Dadman with a boy
  • Posts: 16,082
Re: New revs
« Reply #1767, on November 3rd, 2012, 10:55 PM »
rev 1767
(7 files, 2kb)

! The event delayer doesn't like seeing double quotes and > signs. Because I'm a nice boy, I decided to let Wedge ignore > inside event strings (assuming they're either embedded HTML or just a comparison), and allow JavaScriptEscape to additionally escape double quotes. Now, if I can find a volunteer to do a project-wide regex search on on[a-z]+="[^"]*\JavaScriptEscape, and manually add a true param after it, that would be swell... What? Why are you looking at me all of a sudden..? (Subs-Template.php, Subs.php, ManagePermissions.language.php, ManagePermissions.template.php)

! Fixed admin area sending errors when using Warm (due to the difference in layer names). (Warm/skin.xml)

* French translation. (Admin.french.php)

PS: just because I decided to go for this solution doesn't mean it's the 'right' one. Please feel free to disprove me. Or even revert me... No problem.

Arantor

  • As powerful as possible, as complex as necessary.
  • Posts: 14,278
Re: New revs
« Reply #1768, on November 5th, 2012, 01:27 AM »
(3 files, 1KB)

Revision: 1768
Author: arantor
Date: 05 November 2012 00:25:33
Message:
! The installer should initialise westr if it's going to load it - just in case. Most of the time, not a big deal. (install.php)

! glob() can return false instead of empty arrays sometimes. Check where this is important and skip the loops if it's empty. (Subs-Cache.php)

! Delete member PM rules when their account is deleted. (Subs-Members.php)
----
Modified : /trunk/Sources/Subs-Cache.php
Modified : /trunk/Sources/Subs-Members.php
Modified : /trunk/root/install.php
Re: New revs
« Reply #1769, on November 5th, 2012, 04:51 AM »
(5 files, 20KB)

Revision: 1769
Author: arantor
Date: 05 November 2012 03:49:40
Message:
! Some additional security for the manage boards code. It's not strictly necessary but better safe than sorry. (ManageBoards.php)

! Board group access was not revoked when groups were previously removed. (Subs-Membergroups.php)

! Should be possible to configure groups' access to boards from the groups configuration page - now uses the proper tables and everything. (ManageMembergroups.php, ManageMembergroups.template.php, ManageMembergroups language file)

@ Note that the groups/board configuration as it stands is not very pretty and while I've extended the queries to get categories, I have not yet made it display them. That's for next time. (But it'll be more spiffy when I get there.)
----
Modified : /trunk/Sources/ManageBoards.php
Modified : /trunk/Sources/ManageMembergroups.php
Modified : /trunk/Sources/Subs-Membergroups.php
Modified : /trunk/Themes/default/ManageMembergroups.template.php
Modified : /trunk/Themes/default/languages/ManageMembers.english.php
Plugin revs »